[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added a comment. In https://reviews.llvm.org/D52953#1268810, @MaskRay wrote: > And there is no reviewers set :) I don't know who to add. Repository: rL LLVM https://reviews.llvm.org/D52953 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

MaskRay added a comment. And there is no reviewers set :) Repository: rL LLVM https://reviews.llvm.org/D52953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

MaskRay added inline comments. Comment at: tools/lldb-mi/MICmdCmdGdbSet.cpp:447 +bool CMICmdCmdGdbSet::OptionFnBreakpoint( + const CMIUtilString::VecString_t ) { +bool bPending = false; clang-format Repository:

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added a comment. Gentle ping? Repository: rL LLVM https://reviews.llvm.org/D52953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53415: [lldbsuite, windows] Disable two tail call frames tests that fail on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: asmith, vsk. Herald added subscribers: lldb-commits, abidh. These tests fail on Windows because of known limitations (a.k.a. bugs) with the current implementation of GetFrameAtIndex Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D53412: [lldb] Fixed deadlock when SBProcess is Kill()ed and inspected

cameron314 created this revision. cameron314 added reviewers: zturner, clayborg. Herald added a subscriber: lldb-commits. This patch changes the order that mutexes are acquired in SBProcess such that the target API mutex is now always acquired before the public run lock mutex is acquired. This

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

Hey Vedant, I’ve attached the logs from Linux. Most of the tests now pass on Windows with the exception of TestSteppingOutWithArtificialFrames and TestTailCallFrameSBAPI. Both of these attempt to get a specific frame by calling GetFrameAtIndex which only works partially on Windows right now.

[Lldb-commits] [PATCH] D53402: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL344746: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView (authored by mgorny, committed by ). Herald added

[Lldb-commits] [lldb] r344746 - [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView

Author: mgorny Date: Thu Oct 18 08:39:22 2018 New Revision: 344746 URL: http://llvm.org/viewvc/llvm-project?rev=344746=rev Log: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView Differential Revision: https://reviews.llvm.org/D53402 Modified:

[Lldb-commits] [PATCH] D53331: [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344744: [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows (authored by stella.stamenova, committed

[Lldb-commits] [lldb] r344744 - [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows

Author: stella.stamenova Date: Thu Oct 18 08:30:31 2018 New Revision: 344744 URL: http://llvm.org/viewvc/llvm-project?rev=344744=rev Log: [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows Summary: They fail similarly to some of the other breakpoint tests on Windows, so I

[Lldb-commits] [PATCH] D53402: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView

zturner added a subscriber: mgorny. zturner added a comment. Lgtm Repository: rLLDB LLDB https://reviews.llvm.org/D53402 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D53402: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView

Lgtm On Thu, Oct 18, 2018 at 8:03 AM Michał Górny via Phabricator < revi...@reviews.llvm.org> wrote: > mgorny created this revision. > mgorny added a reviewer: zturner. > Herald added a subscriber: JDevlieghere. > > Repository: > rLLDB LLDB > > https://reviews.llvm.org/D53402 > > Files: >

[Lldb-commits] [PATCH] D53402: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView

mgorny created this revision. mgorny added a reviewer: zturner. Herald added a subscriber: JDevlieghere. Repository: rLLDB LLDB https://reviews.llvm.org/D53402 Files: source/Plugins/SymbolFile/NativePDB/CMakeLists.txt Index: source/Plugins/SymbolFile/NativePDB/CMakeLists.txt

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

aleksandr.urakov added a comment. In https://reviews.llvm.org/D53086#1267988, @labath wrote: > The thing that's not clear to me is: are you specifically interested in > unwinding from these kinds of functions **without debug info**? Because it > sounds to me like the info Zachary provided is

[Lldb-commits] [PATCH] D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

grimar updated this revision to Diff 170050. grimar added a comment. - Rebased, resolved conflicts. https://reviews.llvm.org/D53140 Files: lit/Breakpoint/Inputs/debug_rnglist_offset_pair.yaml lit/Breakpoint/debug_rnglist_offset_pair.test

[Lldb-commits] [PATCH] D53357: [Windows] Fix threads comparison on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL344729: [Windows] Fix threads comparison on Windows (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r344729 - [Windows] Fix threads comparison on Windows

Author: aleksandr.urakov Date: Thu Oct 18 00:52:56 2018 New Revision: 344729 URL: http://llvm.org/viewvc/llvm-project?rev=344729=rev Log: [Windows] Fix threads comparison on Windows Summary: This patch makes Windows threads to compare by a thread ID, not by a handle. It's because the same thread

[Lldb-commits] [PATCH] D53357: [Windows] Fix threads comparison on Windows

aleksandr.urakov added a comment. Thank you! Repository: rLLDB LLDB https://reviews.llvm.org/D53357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits