[Lldb-commits] [lldb] r346573 - Unbreak the linux bot from the previous commit. Fred needed to use

2018-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 9 16:25:45 2018 New Revision: 346573 URL: http://llvm.org/viewvc/llvm-project?rev=346573=rev Log: Unbreak the linux bot from the previous commit. Fred needed to use some of the macros from mach/exc_resource.h to decode EXC_RESOURCE, but that header doesn't exist

[Lldb-commits] [lldb] r346572 - Add extra diagnostics to test

2018-11-09 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Fri Nov 9 16:16:39 2018 New Revision: 346572 URL: http://llvm.org/viewvc/llvm-project?rev=346572=rev Log: Add extra diagnostics to test Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py Modified:

[Lldb-commits] [lldb] r346571 - Enable listening for EXC_RESOURCE events, and format mach

2018-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 9 16:14:14 2018 New Revision: 346571 URL: http://llvm.org/viewvc/llvm-project?rev=346571=rev Log: Enable listening for EXC_RESOURCE events, and format mach event as a thread stop reason if we receive one, using some macros to decode the payload. Patch

[Lldb-commits] [PATCH] D54352: [CMake] Explicit lldb_codesign function with application in debugserver and lldb-server

2018-11-09 Thread Chris Bieneman via Phabricator via lldb-commits
beanz added a comment. Why not just add entitlement support to ‘llvm_codesign’? Or feed through extra arguments? https://reviews.llvm.org/D54352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r346561 - Work with a gdb-remote target that doesn't handle the

2018-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 9 14:33:26 2018 New Revision: 346561 URL: http://llvm.org/viewvc/llvm-project?rev=346561=rev Log: Work with a gdb-remote target that doesn't handle the qWatchpointSupportInfo packet correctly. In GDBRemoteCommunicationClient::GetWatchpointSupportInfo, if the

[Lldb-commits] [PATCH] D54352: [CMake] Explicit lldb_codesign function with application in debugserver and lldb-server

2018-11-09 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added a comment. This would soon be used for other targets as well. llvm_codesign is here: https://reviews.llvm.org/D48797 Comment at: cmake/modules/AddLLDB.cmake:212 + set(pass_force "--force") +endif() + So far `--force` was used

[Lldb-commits] [PATCH] D54352: [CMake] Explicit lldb_codesign function with application in debugserver and lldb-server

2018-11-09 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. sgraenitz added reviewers: beanz, bogner, lanza, friss. Herald added a subscriber: mgorny. Add LLDB-specific utility function lldb_codesign. In contrast to llvm_codesign it must be invoked explicitly and allows to pass a target-specific entitlements file as well

[Lldb-commits] [PATCH] D54333: [CMake] Allow version overrides with -DLLDB_VERSION_MAJOR/MINOR/PATCH/SUFFIX

2018-11-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. nice! https://reviews.llvm.org/D54333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54333: [CMake] Allow version overrides with -DLLDB_VERSION_MAJOR/MINOR/PATCH/SUFFIX

2018-11-09 Thread Alex Langford via Phabricator via lldb-commits
xiaobai accepted this revision. xiaobai added a comment. Yep, this looks good to me. Thanks! :) https://reviews.llvm.org/D54333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54333: [CMake] Allow version overrides with -DLLDB_VERSION_MAJOR/MINOR/PATCH/SUFFIX

2018-11-09 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. Seems reasonable! https://reviews.llvm.org/D54333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r346553 - Remove llvm include from debugserver, change

2018-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 9 12:31:41 2018 New Revision: 346553 URL: http://llvm.org/viewvc/llvm-project?rev=346553=rev Log: Remove llvm include from debugserver, change LLVM_FALLTHROUGH's to [[clang::fallthrough]] - debugserver is only ever compiled on darwin systems with clang. Modified:

[Lldb-commits] [PATCH] D54335: [CMake] Fix: add_host_subdirectory source/Host/macosx

2018-11-09 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. sgraenitz added a reviewer: teemperor. Herald added a subscriber: mgorny. Typo introduced with https://reviews.llvm.org/D47929 https://reviews.llvm.org/D54335 Files: source/Host/CMakeLists.txt Index: source/Host/CMakeLists.txt

[Lldb-commits] [PATCH] D54333: [CMake] Allow version overrides with -DLLDB_VERSION_MAJOR/MINOR/PATCH/SUFFIX

2018-11-09 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. sgraenitz added reviewers: labath, xiaobai. Herald added a subscriber: mgorny. This follows the approach in Clang. If no overrides are given, LLDB_VERSION_* is inferred from LLVM_VERSION_*. This mimics the current behaviour (PACKAGE_VERSION itself is generated

[Lldb-commits] [lldb] r346527 - Add missing include

2018-11-09 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Fri Nov 9 09:58:05 2018 New Revision: 346527 URL: http://llvm.org/viewvc/llvm-project?rev=346527=rev Log: Add missing include Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp URL:

[Lldb-commits] [lldb] r346525 - Add missing include

2018-11-09 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Fri Nov 9 09:44:20 2018 New Revision: 346525 URL: http://llvm.org/viewvc/llvm-project?rev=346525=rev Log: Add missing include Modified: lldb/trunk/tools/debugserver/source/DNBRegisterInfo.cpp Modified: lldb/trunk/tools/debugserver/source/DNBRegisterInfo.cpp URL:

[Lldb-commits] [lldb] r346519 - Annotate switch with LLVM_FALLTHROUGH

2018-11-09 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Fri Nov 9 09:11:17 2018 New Revision: 346519 URL: http://llvm.org/viewvc/llvm-project?rev=346519=rev Log: Annotate switch with LLVM_FALLTHROUGH Modified: lldb/trunk/tools/debugserver/source/DNBRegisterInfo.cpp lldb/trunk/tools/debugserver/source/RNBRemote.cpp

Re: [Lldb-commits] [lldb] r346430 - Fix bug in PE/COFF plugin and ValueObjectVariable.

2018-11-09 Thread Zachary Turner via lldb-commits
The problem was actually in the native pdb plugin. I forgot to call ClangASTContext::SetHasExternalStorage with true on the enum decls when i created it, so it wasn't getting completed. I submitted a fix in r346517. On Thu, Nov 8, 2018 at 2:00 PM Greg Clayton wrote: > Another way to think

[Lldb-commits] [lldb] r346517 - [NativePDB] Fix completion of enum types.

2018-11-09 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Nov 9 09:08:26 2018 New Revision: 346517 URL: http://llvm.org/viewvc/llvm-project?rev=346517=rev Log: [NativePDB] Fix completion of enum types. This was originally submitted in a patch which fixed two unrelated bugs at the same time. This portion of the fix was

[Lldb-commits] [lldb] r346511 - [NativePDB] Add support for bitfield records.

2018-11-09 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Nov 9 08:29:19 2018 New Revision: 346511 URL: http://llvm.org/viewvc/llvm-project?rev=346511=rev Log: [NativePDB] Add support for bitfield records. Bitfields are represented as LF_MEMBER records whose TypeIndex points to an LF_BITFIELD record that describes the bit

Re: [Lldb-commits] [lldb] r346502 - revert rL346478

2018-11-09 Thread Davide Italiano via lldb-commits
OK, thanks. Please add an explanation next time you revert something. Best, -- Davide On Fri, Nov 9, 2018 at 8:10 AM Kadir Çetinkaya wrote: > > It was reverted in base repo, https://reviews.llvm.org/rL346500 > > On Fri, Nov 9, 2018 at 5:09 PM Davide Italiano wrote: >> >> On Fri, Nov 9, 2018 at

Re: [Lldb-commits] [lldb] r346502 - revert rL346478

2018-11-09 Thread Kadir Çetinkaya via lldb-commits
It was reverted in base repo, https://reviews.llvm.org/rL346500 On Fri, Nov 9, 2018 at 5:09 PM Davide Italiano wrote: > On Fri, Nov 9, 2018 at 7:20 AM Kadir Cetinkaya via lldb-commits > wrote: > > > > Author: kadircet > > Date: Fri Nov 9 07:18:02 2018 > > New Revision: 346502 > > > > URL:

Re: [Lldb-commits] [lldb] r346502 - revert rL346478

2018-11-09 Thread Davide Italiano via lldb-commits
On Fri, Nov 9, 2018 at 7:20 AM Kadir Cetinkaya via lldb-commits wrote: > > Author: kadircet > Date: Fri Nov 9 07:18:02 2018 > New Revision: 346502 > > URL: http://llvm.org/viewvc/llvm-project?rev=346502=rev > Log: > revert rL346478 > This message isn't explaining why you reverted. Ca you please

[Lldb-commits] [lldb] r346505 - Resubmit "Fix bug in PE/COFF plugin."

2018-11-09 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Nov 9 08:06:44 2018 New Revision: 346505 URL: http://llvm.org/viewvc/llvm-project?rev=346505=rev Log: Resubmit "Fix bug in PE/COFF plugin." The original commit was actually 2 unrelated bug fixes, but it turns out the second bug fix wasn't quite correct, so the entire

[Lldb-commits] [lldb] r346502 - revert rL346478

2018-11-09 Thread Kadir Cetinkaya via lldb-commits
Author: kadircet Date: Fri Nov 9 07:18:02 2018 New Revision: 346502 URL: http://llvm.org/viewvc/llvm-project?rev=346502=rev Log: revert rL346478 Summary: Reviewers: Subscribers: Modified: lldb/trunk/unittests/Host/FileSystemTest.cpp Modified: lldb/trunk/unittests/Host/FileSystemTest.cpp