[Lldb-commits] [lldb] r347283 - Skip TestTargetCreateDeps

2018-11-19 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Nov 19 17:18:49 2018 New Revision: 347283 URL: http://llvm.org/viewvc/llvm-project?rev=347283=rev Log: Skip TestTargetCreateDeps Skip this test because Windows deals differently with shared libraries. Modified:

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

2018-11-19 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. Can you post a short snippet of old help and new help output? Repository: rLLDB LLDB https://reviews.llvm.org/D54692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

2018-11-19 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM as long as the tests are all still passing :) https://reviews.llvm.org/D54731 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

2018-11-19 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: labath, stella.stamenova, davide, rnk, aprantl, friss. Herald added a subscriber: delcypher. Currently lit supports running shell commands through the use of the `RUN: ` prefix. This patch allows individual test suites to install their own

[Lldb-commits] [lldb] r347254 - Fix clang test suite on Windows by reverting part of r347216

2018-11-19 Thread Reid Kleckner via lldb-commits
Author: rnk Date: Mon Nov 19 11:36:28 2018 New Revision: 347254 URL: http://llvm.org/viewvc/llvm-project?rev=347254=rev Log: Fix clang test suite on Windows by reverting part of r347216 Otherwise, the clang analyzer tests fail on Windows when attempting to unpickle AnalyzerTest objects in the

[Lldb-commits] [PATCH] D54709: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang

2018-11-19 Thread Stella Stamenova via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL347243: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang (authored by stella.stamenova, committed

[Lldb-commits] [lldb] r347243 - [lldbsuite] Invoke sed on Windows to determine the cache dir for clang

2018-11-19 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon Nov 19 10:41:33 2018 New Revision: 347243 URL: http://llvm.org/viewvc/llvm-project?rev=347243=rev Log: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang Summary: In order to invoke sed on Windows, we need to quote the command correctly.

[Lldb-commits] [PATCH] D54709: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang

2018-11-19 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova created this revision. stella.stamenova added reviewers: aprantl, zturner. Herald added subscribers: lldb-commits, teemperor. In order to invoke sed on Windows, we need to quote the command correctly. Since we already have commands which do that, move the definitions at the

[Lldb-commits] [lldb] r347224 - [lit] On Windows, don't error if MSVC is not in PATH.

2018-11-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Nov 19 08:47:06 2018 New Revision: 347224 URL: http://llvm.org/viewvc/llvm-project?rev=347224=rev Log: [lit] On Windows, don't error if MSVC is not in PATH. We had some logic backwards, and as a result if MSVC was not found in PATH we would throw a string concatenation

[Lldb-commits] [lldb] r347223 - Remove non-ASCII characters at the beginning of file.

2018-11-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Nov 19 08:41:31 2018 New Revision: 347223 URL: http://llvm.org/viewvc/llvm-project?rev=347223=rev Log: Remove non-ASCII characters at the beginning of file. It's not clear how these ended up in the file, but this fixes it. Modified:

[Lldb-commits] [lldb] r347216 - Fix some issues with LLDB's lit configuration files.

2018-11-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Nov 19 07:12:34 2018 New Revision: 347216 URL: http://llvm.org/viewvc/llvm-project?rev=347216=rev Log: Fix some issues with LLDB's lit configuration files. Recently I tried to port LLDB's lit configuration files over to use a on the surface, but broke some cases that

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

2018-11-19 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347216: Fix some issues with LLDBs lit configuration files. (authored by zturner, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D54680: Don't use lldb -O in lit tests

2018-11-19 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347213: Dont use -O in lit tests. (authored by zturner, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54680?vs=174549=174609#toc

[Lldb-commits] [lldb] r347213 - Don't use -O in lit tests.

2018-11-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Nov 19 07:06:10 2018 New Revision: 347213 URL: http://llvm.org/viewvc/llvm-project?rev=347213=rev Log: Don't use -O in lit tests. Because of different shell quoting rules, and the fact that LLDB commands often contain spaces, -O is not portable for writing command

Re: [Lldb-commits] [lldb] r347125 - Just don't even attempt to invoke sed on Windows.

2018-11-19 Thread Pavel Labath via lldb-commits
On 17/11/2018 02:27, Adrian Prantl via lldb-commits wrote: Author: adrian Date: Fri Nov 16 17:27:47 2018 New Revision: 347125 URL: http://llvm.org/viewvc/llvm-project?rev=347125=rev Log: Just don't even attempt to invoke sed on Windows. Modified:

[Lldb-commits] [PATCH] D54617: [wip][Reproducers] Add file provider

2018-11-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D54617#1302376, @JDevlieghere wrote: > In https://reviews.llvm.org/D54617#1302366, @labath wrote: > > > I am confused by differing scopes of various objects that are interacting > > here. It seems you are implementing capture/replay as

[Lldb-commits] [PATCH] D54616: [Reproducers] Improve reproducer API and add unit tests.

2018-11-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: include/lldb/Utility/Reproducer.h:59-64 + void InitializeFileInfo(llvm::StringRef name, + llvm::ArrayRef files) { +m_info.name = name; +for (auto file : files) + m_info.files.push_back(file); + }

[Lldb-commits] [PATCH] D54682: [Driver] Extract option parsing and option processing.

2018-11-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. If by //"it would cause errors to no longer appear in the same order as specified by the user, but in an arbitrary order specified by the driver implementation"//, you mean that now for a command line like: $ new/lldb -S /tmp/sadg --file /tmp/qwr I get error: file

[Lldb-commits] [lldb] r347188 - Remove unused variable. NFC.

2018-11-19 Thread Benjamin Kramer via lldb-commits
Author: d0k Date: Mon Nov 19 02:59:12 2018 New Revision: 347188 URL: http://llvm.org/viewvc/llvm-project?rev=347188=rev Log: Remove unused variable. NFC. Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp URL:

[Lldb-commits] [PATCH] D54682: [Driver] Extract option parsing and option processing.

2018-11-19 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In https://reviews.llvm.org/D54682#1302448, @zturner wrote: > Lib option definitely does, as its entire purpose is to be powerful and > flexible enough to mimic arbitrary command line tools. I created https://reviews.llvm.org/D54692 to show what the driver would

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

2018-11-19 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: zturner. JDevlieghere added a project: LLDB. Herald added subscribers: jfb, mgorny. Alternative to https://reviews.llvm.org/D54682. Repository: rLLDB LLDB https://reviews.llvm.org/D54692 Files: tools/driver/CMakeLists.txt