[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

2018-12-30 Thread Robert O'Callahan via Phabricator via lldb-commits
rocallahan added a comment. I agree that ideally the linker would be able to do fine-grained GC of DWARF at the granularity of individual DIEs and other data items. However, implementing that would be a huge project. Currently AFAICT `lld` does very little DWARF processing. Wholesale DWARF

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

2018-12-30 Thread Robert O'Callahan via Phabricator via lldb-commits
rocallahan added a comment. Here are some results for the rusoto test in https://github.com/rust-lang/rust/issues/56068#issue-382175735: | LLD | Binary size in bytes | | LLD 6.0.1 | 43,791,192 | | LLD 8.0.0 1cfcf404f6b23943405bc3c5bb5940b10b914624

[Lldb-commits] [lldb] r350166 - [CommandInterpreter] Simplify PreprocessCommand. (NFCI)

2018-12-30 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Sun Dec 30 09:56:30 2018 New Revision: 350166 URL: http://llvm.org/viewvc/llvm-project?rev=350166=rev Log: [CommandInterpreter] Simplify PreprocessCommand. (NFCI) Simplify some code in PreprocessCommand. This change improves consistency, reduces the indentation and

Re: [Lldb-commits] [lldb] r350160 - [test] Remove flakiness decorator from TestObjCDynamicSBType

2018-12-30 Thread Davide Italiano via lldb-commits
No problem, thanks! On Sun, Dec 30, 2018 at 5:11 PM Jonas Devlieghere wrote: > > > > On Sun, Dec 30, 2018 at 05:33 Davide Italiano wrote: >> >> Nice, thanks! >> There is a typo in the commit message, I assume? > > > Correct, I made a typo in the PR and then mindlessly copied the name of the >

Re: [Lldb-commits] [lldb] r350160 - [test] Remove flakiness decorator from TestObjCDynamicSBType

2018-12-30 Thread Jonas Devlieghere via lldb-commits
On Sun, Dec 30, 2018 at 05:33 Davide Italiano wrote: > Nice, thanks! > There is a typo in the commit message, I assume? > Correct, I made a typo in the PR and then mindlessly copied the name of the test. > > > On Sun, Dec 30, 2018 at 7:13 AM Jonas Devlieghere via lldb-commits > wrote: > > > >

[Lldb-commits] [lldb] r350164 - [Type] Simplify operator!=. NFC.

2018-12-30 Thread Davide Italiano via lldb-commits
Author: davide Date: Sun Dec 30 07:08:51 2018 New Revision: 350164 URL: http://llvm.org/viewvc/llvm-project?rev=350164=rev Log: [Type] Simplify operator!=. NFC. Modified: lldb/trunk/source/Symbol/Type.cpp Modified: lldb/trunk/source/Symbol/Type.cpp URL:

[Lldb-commits] [lldb] r350163 - [TypeName] Simplify operator!=. NFCI.

2018-12-30 Thread Davide Italiano via lldb-commits
Author: davide Date: Sun Dec 30 07:07:25 2018 New Revision: 350163 URL: http://llvm.org/viewvc/llvm-project?rev=350163=rev Log: [TypeName] Simplify operator!=. NFCI. Modified: lldb/trunk/source/Symbol/Type.cpp Modified: lldb/trunk/source/Symbol/Type.cpp URL:

Re: [Lldb-commits] [lldb] r350160 - [test] Remove flakiness decorator from TestObjCDynamicSBType

2018-12-30 Thread Davide Italiano via lldb-commits
Nice, thanks! There is a typo in the commit message, I assume? On Sun, Dec 30, 2018 at 7:13 AM Jonas Devlieghere via lldb-commits wrote: > > Author: jdevlieghere > Date: Sat Dec 29 22:10:03 2018 > New Revision: 350160 > > URL: http://llvm.org/viewvc/llvm-project?rev=350160=rev > Log: > [test]