[Lldb-commits] [PATCH] D56425: [BreakpointList] Simplify/modernize BreakpointList (NFC)

vsk added a comment. Looks like a nice/reasonable cleanup, thanks! Based on the coverage report (https://teemperor.de/lldb-coverage/coverage/Users/vsk/src/llvm.org-lldbsan/llvm/tools/lldb/source/Breakpoint/BreakpointList.cpp.html#L217) and benchmarks

[Lldb-commits] [PATCH] D56425: [BreakpointList] Simplify/modernize BreakpointList (NFC)

JDevlieghere added a comment. I wonder if we should use a vector instead of a list here too. For small data sets a std::vector usually outperforms a std::list. I *think* the data-locality would outweigh the cost of copying the shared pointers. Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D56425: [BreakpointList] Simplify/modernize BreakpointList (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: davide. I was looking at the code in BreakpointList.cpp and found it deserved a quick cleanup. - Extract duplicate code - Use range-based for loop - Use early return in loops Repository: rLLDB LLDB

[Lldb-commits] [lldb] r350599 - [SymbolContext] Remove dead code

Author: jdevlieghere Date: Mon Jan 7 17:35:00 2019 New Revision: 350599 URL: http://llvm.org/viewvc/llvm-project?rev=350599=rev Log: [SymbolContext] Remove dead code Removes two methods from SymbolContextList that aren't referenced. Modified: lldb/trunk/include/lldb/Symbol/SymbolContext.h

[Lldb-commits] [PATCH] D56418: Change lldb-test to use ParseAllDebugSymbols instead of ParseDeclsForContext

zturner created this revision. zturner added reviewers: labath, clayborg, aleksandr.urakov, asmith, amccarth. Herald added subscribers: JDevlieghere, aprantl. `ParseDeclsForContext` was originally created to serve the very specific case where the context is a function block. It was never

[Lldb-commits] [lldb] r350576 - Clarify comment and variable names. (NFC)

Author: adrian Date: Mon Jan 7 15:02:28 2019 New Revision: 350576 URL: http://llvm.org/viewvc/llvm-project?rev=350576=rev Log: Clarify comment and variable names. (NFC) Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified:

[Lldb-commits] [lldb] r350575 - Rename DWARFDIE::GetDWOContext() -> GetDeclContext() (NFC)

Author: adrian Date: Mon Jan 7 14:47:17 2019 New Revision: 350575 URL: http://llvm.org/viewvc/llvm-project?rev=350575=rev Log: Rename DWARFDIE::GetDWOContext() -> GetDeclContext() (NFC) Despite the name, this function has nothing to do with the DWO format. Modified:

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

JDevlieghere added inline comments. Comment at: CMakeLists.txt:43 if(LLDB_INCLUDE_TESTS) + # FIXME: LLDB_TEST_CXX_COMPILER is unused. + # FIXME: In standalone builds LLVM_BINARY_DIR points to LLDB's build directory and not to LLVM's! Why is this unused? Are

[Lldb-commits] [PATCH] D56315: Add a verbose mode to "image dump line-table" and use it to write a .debug_line test

zturner accepted this revision. zturner added a comment. Ok, that makes sense. BTW, it would be nice if someone ever decided to make `llvm-mc` recognize more symbolic constants so we didn't have to use magic numbers everywhere. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56315/new/

[Lldb-commits] [lldb] r350570 - [lldb] Fix -Wstring-plus-int warning in POSIX-DYLD/AuxVector.cpp

Author: jgorbe Date: Mon Jan 7 13:04:12 2019 New Revision: 350570 URL: http://llvm.org/viewvc/llvm-project?rev=350570=rev Log: [lldb] Fix -Wstring-plus-int warning in POSIX-DYLD/AuxVector.cpp Modified: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp Modified:

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:44 + # FIXME: LLDB_TEST_CXX_COMPILER is unused. + # FIXME: In standalone builds LLVM_BINARY_DIR points to LLDB's build directory and not to LLVM's! + # FIXME:

[Lldb-commits] [lldb] r350559 - Split two sub-tests into separate top-level methods.

Author: adrian Date: Mon Jan 7 11:24:04 2019 New Revision: 350559 URL: http://llvm.org/viewvc/llvm-project?rev=350559=rev Log: Split two sub-tests into separate top-level methods. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py Modified:

[Lldb-commits] [lldb] r350557 - Refactor test, no changes expected.

Author: adrian Date: Mon Jan 7 11:19:34 2019 New Revision: 350557 URL: http://llvm.org/viewvc/llvm-project?rev=350557=rev Log: Refactor test, no changes expected. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/main.c Modified:

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:47 + # FIXME: With generator expressions we could simply query the output paths for each target, + # but for this LLDB_DOTEST_ARGS must always have a generator step.

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

sgraenitz created this revision. sgraenitz added reviewers: aprantl, JDevlieghere, labath, vsk. Herald added a subscriber: mgorny. Fix some issues in the code around D56399 : - remove outdated comments - streamline empty-string conditions - remove 2 uses of

[Lldb-commits] [PATCH] D56399: [CMake] Fix standalone builds: workaround the cxx target not getting imported yet (unlike clang target)

sgraenitz created this revision. sgraenitz added reviewers: aprantl, JDevlieghere. Herald added a subscriber: mgorny. Handle standalone builds separately and print a warning if we have no libcxx. https://reviews.llvm.org/D56399 Files: CMakeLists.txt Index: CMakeLists.txt

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

zturner added inline comments. Comment at: source/Host/common/File.cpp:606-607 #else long cur = ::lseek(m_descriptor, 0, SEEK_CUR); +SeekFromStart(offset); error = Write(buf, num_bytes); Be careful here. `pwrite` on posix is atomic, which means

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

zturner added inline comments. Comment at: source/Plugins/Platform/Windows/PlatformWindows.cpp:189-195 + else { +if (m_remote_platform_sp) + return m_remote_platform_sp->RunShellCommand( + command, working_dir, status_ptr, signo_ptr, command_output, timeout);

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

zturner added a comment. In D56232#1344652 , @labath wrote: > All of these functions seem identical to their PlatformPOSIX counterparts. Is > that right? And I seem to remember already seeing a lot of code duplication > between PlatformPOSIX and

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for building lldb-server on Windows

zturner added inline comments. Comment at: include/lldb/Host/windows/PosixApi.h:78-79 +#define WNOHANG 1 +#define WUNTRACED 2 + krytarowski wrote: > I think that these symbols should not be leaked here in the first place. In general we should avoid mocking

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB350546: Use the minidump exception record if present (authored by lemo, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56293/new/

[Lldb-commits] [lldb] r350546 - Use the minidump exception record if present

Author: lemo Date: Mon Jan 7 09:55:42 2019 New Revision: 350546 URL: http://llvm.org/viewvc/llvm-project?rev=350546=rev Log: Use the minidump exception record if present If the minidump contains a saved exception record use it automatically. Differential Revision:

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

lemo updated this revision to Diff 180515. lemo added a comment. Incorporating Pavel's suggestions (range-based loop, explicit type instead of auto) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56293/new/ https://reviews.llvm.org/D56293 Files:

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

zturner added inline comments. Comment at: source/Host/windows/PipeWindows.cpp:34-38 m_read = INVALID_HANDLE_VALUE; m_write = INVALID_HANDLE_VALUE; - m_read_fd = -1; - m_write_fd = -1; + m_read_fd = PipeWindows::kInvalidDescriptor; + m_write_fd =

[Lldb-commits] [lldb] r350543 - Fine-tune and document the barrier in TestQueues.

Author: adrian Date: Mon Jan 7 09:18:39 2019 New Revision: 350543 URL: http://llvm.org/viewvc/llvm-project?rev=350543=rev Log: Fine-tune and document the barrier in TestQueues. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/main.c Modified:

[Lldb-commits] [lldb] r350538 - [CMake] Fix standalone builds: make dependency to LLVM's `count` conditional

Author: stefan.graenitz Date: Mon Jan 7 08:43:04 2019 New Revision: 350538 URL: http://llvm.org/viewvc/llvm-project?rev=350538=rev Log: [CMake] Fix standalone builds: make dependency to LLVM's `count` conditional Summary: In standalone builds of LLDB we currently have no target `count` that

[Lldb-commits] [PATCH] D56389: [CMake] Fix standalone builds: make dependency to LLVM's `count` conditional

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB350538: [CMake] Fix standalone builds: make dependency to LLVMs `count` conditional (authored by stefan.graenitz, committed by ). Herald added a subscriber: abidh. Changed prior to commit:

[Lldb-commits] [lldb] r350537 - Simplify testcase by using lldbutil.run_to_source_breakpoint()

Author: adrian Date: Mon Jan 7 08:27:52 2019 New Revision: 350537 URL: http://llvm.org/viewvc/llvm-project?rev=350537=rev Log: Simplify testcase by using lldbutil.run_to_source_breakpoint() Modified:

[Lldb-commits] [PATCH] D56389: [CMake] Fix standalone builds: make dependency to LLVM's `count` conditional

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56389/new/ https://reviews.llvm.org/D56389 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D56389: [CMake] Fix standalone builds: make dependency to LLVM's `count` conditional

sgraenitz created this revision. sgraenitz added reviewers: davide, aprantl, JDevlieghere. Herald added a subscriber: mgorny. Herald added a reviewer: alexshap. In standalone builds of LLDB we currently have no target `count` that tests can depend on. This may be fixed in the future by exporting

[Lldb-commits] [lldb] r350511 - ObjectFileBreakpad: Implement sections

Author: labath Date: Mon Jan 7 03:14:08 2019 New Revision: 350511 URL: http://llvm.org/viewvc/llvm-project?rev=350511=rev Log: ObjectFileBreakpad: Implement sections Summary: This patch allows ObjectFileBreakpad to parse the contents of Breakpad files into sections. This sounds slightly odd at

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

This revision was automatically updated to reflect the committed changes. Closed by commit rL350511: ObjectFileBreakpad: Implement sections (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath accepted this revision. labath added a comment. Thank you for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/new/ https://reviews.llvm.org/D55434 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath removed a reviewer: labath. labath added a comment. Removing the self-accept (oops). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/new/ https://reviews.llvm.org/D55434 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D56174: ProcessLaunchInfo: remove Debugger reference

This revision was automatically updated to reflect the committed changes. Closed by commit rL350510: ProcessLaunchInfo: remove Debugger reference (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r350510 - ProcessLaunchInfo: remove Debugger reference

Author: labath Date: Mon Jan 7 02:59:57 2019 New Revision: 350510 URL: http://llvm.org/viewvc/llvm-project?rev=350510=rev Log: ProcessLaunchInfo: remove Debugger reference Summary: The Debuffer object was being used in "GetListenerForProcess" to provide a default listener object if one was not

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

On 04/01/2019 17:48, Zachary Turner wrote: For those kinds of cases, we could use obj2yaml and check in yaml right? Fwiw I tried to round-trip an exe through obj->yaml->obj recently and the resulting exe was incorrect but it was close, so I think there’s only some small fixes needed. I

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath requested changes to this revision. labath added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:1138 + // Double quote the string. + ::snprintf(arg_cstr, sizeof(arg_cstr),

Re: [Lldb-commits] [PATCH] D56315: Add a verbose mode to "image dump line-table" and use it to write a .debug_line test

On 04/01/2019 17:53, Zachary Turner wrote: It seems like this test could be made to work with non dwarf debug info by compiling a real source file. WDYT? Well.. I could write a test by compiling a real source, but it wouldn't be *this* test. The idea here was to validate the parsing of the