[Lldb-commits] [lldb] r356825 - [Reproducers] Fix GDB remote flakiness during replay

Author: jdevlieghere Date: Fri Mar 22 16:33:17 2019 New Revision: 356825 URL: http://llvm.org/viewvc/llvm-project?rev=356825=rev Log: [Reproducers] Fix GDB remote flakiness during replay This fixes the flakiness of the GDB remote reproducer during replay. It was caused by a combination sending

[Lldb-commits] [lldb] r356819 - [ScriptInterpreter] Remove a warning and reformat comments.

Author: davide Date: Fri Mar 22 15:38:49 2019 New Revision: 356819 URL: http://llvm.org/viewvc/llvm-project?rev=356819=rev Log: [ScriptInterpreter] Remove a warning and reformat comments. Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp Modified:

[Lldb-commits] [lldb] r356816 - [ScriptInterpreter] Make sure that PYTHONHOME is right.

Author: davide Date: Fri Mar 22 15:19:57 2019 New Revision: 356816 URL: http://llvm.org/viewvc/llvm-project?rev=356816=rev Log: [ScriptInterpreter] Make sure that PYTHONHOME is right. Summary: For the only version of Python actually supported on Darwin. Reviewers: jingham, friss,

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356816: [ScriptInterpreter] Make sure that PYTHONHOME is right. (authored by davide, committed by ). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

davide updated this revision to Diff 191958. davide added a comment. Adrian's feedback Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59719/new/ https://reviews.llvm.org/D59719 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

aprantl added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:181 +#else +#if defined(__APPLE__) && PY_MAJOR_VERSION == 2 +// For Darwin, the only Python version supported is the one shipped in the OS

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

davide created this revision. davide added reviewers: jingham, friss, JDevlieghere, aprantl, jasonmolenda. Herald added subscribers: llvm-commits, jdoerfert. Herald added a project: LLVM. For the only version of Python actually supported on Darwin. rdar://problem/40961425 Repository: rL LLVM

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

compnerd added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangHost.cpp:67 + relative_path.clear(); + llvm::sys::path::append(relative_path, "lib", "lldb", "clang"); + llvm::sys::path::append(clang_dir, relative_path); Does swift-lldb

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191946. teemperor marked 5 inline comments as done. teemperor added a comment. - Removed unused functions. - Fixed two comments that I missed to update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485

[Lldb-commits] [lldb] r356806 - Revert minidump changes

Author: jdevlieghere Date: Fri Mar 22 13:46:46 2019 New Revision: 356806 URL: http://llvm.org/viewvc/llvm-project?rev=356806=rev Log: Revert minidump changes This reverts the following two commits: Revert "Extend r356573 (minidump UUID handling) to cover elf build-ids too" Revert "Fix UUID

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

jingham added a comment. The behavior when verify is false seems a little weird to me. In that case you will just always get the $install_dir/lib/clang/$clang_version path. That's fairly different from the verify = true case. OTOH, I couldn't see anybody passing verify = false anywhere. Do

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

xiaobai created this revision. xiaobai added reviewers: aprantl, davide, compnerd, JDevlieghere, jingham. I'm adding this to reduce the difference between swift-lldb and llvm.org's lldb. https://reviews.llvm.org/D59708 Files: source/Plugins/ExpressionParser/Clang/ClangHost.cpp Index:

[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

nathawes updated this revision to Diff 191904. nathawes added a comment. Updated the test based on feedback from @aprantl and also to specifically check we don't see the output from the -o and -s commands. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59681/new/

[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

nathawes marked an inline comment as done. nathawes added inline comments. Comment at: lldb/lit/Driver/TestRepl.test:2 +# RUN: echo ':quit' | %lldb -x --repl -O 'expr 42' -S %S/Inputs/Print2.in -o 'expr something invalid' -s %s 2>&1 | FileCheck %s +# CHECK: warning: commands

[Lldb-commits] [PATCH] D59611: Move the rest of the section loading over to DWARFContext

labath added a comment. This broke the DWO flavours of some tests: lldb-Suite :: lang/c/const_variables/TestConstVariables.py lldb-Suite :: lang/c/local_variables/TestLocalVariables.py lldb-Suite :: lang/c/vla/TestVLA.py I believe the problem is that DWARFContext::LoadOrGetSection does

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added a comment. In D59485#1439570 , @martong wrote: > In D59485#1439390 , @teemperor wrote: > > > > Well, I still don't understand how LLDB synthesis the AST. > > > So you have a C++ module in a .pcm

[Lldb-commits] [lldb] r356773 - Revert "Move the rest of the sections over to DWARFContext."

Author: labath Date: Fri Mar 22 09:07:58 2019 New Revision: 356773 URL: http://llvm.org/viewvc/llvm-project?rev=356773=rev Log: Revert "Move the rest of the sections over to DWARFContext." This reverts commit r356682 because it breaks the DWO flavours of some tests: lldb-Suite ::

[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! LGTM with one tiny change to the test. Comment at: lldb/lit/Driver/TestRepl.test:2 +# RUN: echo ':quit' | %lldb -x --repl -O 'expr 42' -S %S/Inputs/Print2.in -o

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

martong added inline comments. Comment at: lldb/include/lldb/Symbol/StdModuleHandler.h:22 +/// process is setup to use C++ modules and has the 'std' module attached. +class StdModuleHandler { + clang::ASTImporter *m_importer = nullptr; I think it would worth to

[Lldb-commits] [PATCH] D59667: Regression test to ensure that we handling importing of anonymous enums correctly

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/cast_int_to_anonymous_enum/main.cpp:1 +#include + You can speed up compilation time of this test significantly by removing the printf and the include of cstdio.

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added a comment. In D59485#1439390 , @teemperor wrote: > > Well, I still don't understand how LLDB synthesis the AST. > > So you have a C++ module in a .pcm file. This means you could create an > > AST from that with ASTReader from it's

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:583 + // Returns a ImporterConstructor that constructs this class. + static ASTImporterOptionSpecificTestBase::ImporterConstructor + getConstructor() { balazske wrote: > Is it

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

MaskRay added a comment. @rocallahan I find that people are discussing a generic approach in D59553 Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/ https://reviews.llvm.org/D54747

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

This revision was automatically updated to reflect the committed changes. Closed by commit rL356753: [ObjectYAML] Add basic minidump generation support (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D59482?vs=191653=191879#toc Repository: rL LLVM

[Lldb-commits] [lldb] r356751 - Extend r356573 (minidump UUID handling) to cover elf build-ids too

Author: labath Date: Fri Mar 22 07:03:59 2019 New Revision: 356751 URL: http://llvm.org/viewvc/llvm-project?rev=356751=rev Log: Extend r356573 (minidump UUID handling) to cover elf build-ids too Breakpad (but not crashpad) will insert an empty (all-zero) build-id record for modules which do not

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

teemperor updated this revision to Diff 191876. teemperor added a comment. - Removed dump() that was left in there from some debugging. - Changed the second `Import` call I missed to `Import_New` - No longer ignoring the Errors in Expected when importing template arguments. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor added a comment. > Well, I still don't understand how LLDB synthesis the AST. > So you have a C++ module in a .pcm file. This means you could create an AST > from that with ASTReader from it's .clang_ast section, right? In that case > the AST should be complete with all type

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

balazske added inline comments. Comment at: lldb/source/Symbol/StdModuleHandler.cpp:245 +new_class_template->AddSpecialization(found_decl, InsertPos); +new_class_template->dumpColor(); +if (new_class_template->isOutOfLine()) This dump is not needed?

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191859. teemperor marked 4 inline comments as done. teemperor added a comment. - Addressed feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files: clang/include/clang/AST/ASTImporter.h

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added a comment. > @martong It's not related to lookup or anything like that, it's just that we > don't have enough information in our debug info AST to allow people to use > meta programming. The custom logic we have in LLDB looks into the std C++ > module to fill out these gaps in

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

balazske added inline comments. Comment at: lldb/source/Symbol/StdModuleHandler.cpp:220 +case TemplateArgument::Type: { + QualType our_type = m_importer.Import(arg.getAsType()); + imported_args.push_back(TemplateArgument(our_type)); teemperor

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7738 +Expected ASTImporter::ImportInternal(Decl *FromD) { + // Import the declaration. + ASTNodeImporter Importer(*this); Comment can be better: Import it using ASTNodeImporter.