[Lldb-commits] [lldb] r365593 - Revert accidental change to file

Author: asmith Date: Tue Jul 9 20:41:34 2019 New Revision: 365593 URL: http://llvm.org/viewvc/llvm-project?rev=365593=rev Log: Revert accidental change to file Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ELFHeader.cpp Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ELFHeader.cpp

[Lldb-commits] [lldb] r365592 - Try again to move common functionality from ProcessWindows into ProcessDebugger

Author: asmith Date: Tue Jul 9 20:34:57 2019 New Revision: 365592 URL: http://llvm.org/viewvc/llvm-project?rev=365592=rev Log: Try again to move common functionality from ProcessWindows into ProcessDebugger This reverts commit ed499a36b67cf46cbf66052cfe374c80a595f1c1 and addresses a problem

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This is adding a fair amount of complexity on something that just works fine on basically every platform but AIX. If AIX has issue with `psutil`, maybe the fix should be submitted to

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai added inline comments. Comment at: source/Target/ObjCLanguageRuntime.cpp:403 +CompilerType +ObjCLanguageRuntime::CalculateCompleteType(CompilerType base_type) { + CompilerType type_to_return; jingham wrote: > xiaobai wrote: > > clayborg wrote: > > > So

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai updated this revision to Diff 208841. xiaobai marked an inline comment as done. xiaobai added a comment. Switch to using llvm::Optional for the return type Rename method from CalculateCompleteType to GetRuntimeType CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64159/new/

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Raphael, great job! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64365/new/ https://reviews.llvm.org/D64365

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:194 +const uint32_t idx = ePropertyUseGPacket; +return m_collection_sp->GetPropertyAtIndexAsBoolean(nullptr, idx, true); + } Should we default to

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher added inline comments. Comment at: libcxx/utils/libcxx/util.py:256 """ -import psutil -try: -psutilProc = psutil.Process(pid) -# Handle the different psutil API versions +if platform.system() == 'AIX': +subprocess.call('kill

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 208838. guiandrade marked 3 inline comments as done. guiandrade added a comment. This rebases the change, rename *try_to_use_g_packet* to *use_g_packet*, defaults the setting to true, and modifies the condition of the read_all_registers_at_once bool in

[Lldb-commits] [PATCH] D64366: Add lldb type unit support to the release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL365568: Add lldb type unit support to the release notes (authored by labath, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64366/new/

[Lldb-commits] [PATCH] D64434: [lldb] Quick Fix: IRExecutionUnit check pointer before access it

This revision was automatically updated to reflect the committed changes. Closed by commit rL365567: [lldb] Quick Fix: IRExecutionUnit check pointer before access it (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r365567 - [lldb] Quick Fix: IRExecutionUnit check pointer before access it

Author: xiaobai Date: Tue Jul 9 15:24:54 2019 New Revision: 365567 URL: http://llvm.org/viewvc/llvm-project?rev=365567=rev Log: [lldb] Quick Fix: IRExecutionUnit check pointer before access it Summary: Move checking pointer code block before accessing the pointer This caused lldb to crash when

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

This revision was automatically updated to reflect the committed changes. Closed by commit rL365561: [lldb_test_suite] Fix lldb test suite targeting remote Android (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r365561 - [lldb_test_suite] Fix lldb test suite targeting remote Android

Author: xiaobai Date: Tue Jul 9 14:35:58 2019 New Revision: 365561 URL: http://llvm.org/viewvc/llvm-project?rev=365561=rev Log: [lldb_test_suite] Fix lldb test suite targeting remote Android Summary: Fixed `Android.rules` for running test suite on remote android - the build configuration is not

[Lldb-commits] [PATCH] D61778: [Docs] Replace SVN revisions with lldb versions

This revision was automatically updated to reflect the committed changes. Closed by commit rL365559: [Docs] Replace SVN revisions with lldb versions (authored by kastiglione, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r365559 - [Docs] Replace SVN revisions with lldb versions

Author: kastiglione Date: Tue Jul 9 14:21:45 2019 New Revision: 365559 URL: http://llvm.org/viewvc/llvm-project?rev=365559=rev Log: [Docs] Replace SVN revisions with lldb versions Summary: Replaces references to svn commits with the lldb version number those commits first appeared in.

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty updated this revision to Diff 208805. daltenty added a comment. - Use subprocess.call instead of importing it - Create killProcessAndChildrenIsSupported check and rewrite things to use it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D64444: Add Python 3.6 and 3.7 to the version list

amccarth added a comment. Be aware that Swig 3.0.12 has a compatibility problem with Python 3.7 that causes hundreds of LLDB tests to fail an assertion (at least on Windows). http://lists.llvm.org/pipermail/lldb-dev/2019-June/015086.html I don't think that should block the patch or whether it

[Lldb-commits] [PATCH] D64444: Add Python 3.6 and 3.7 to the version list

cbiesinger created this revision. cbiesinger added a reviewer: clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Python 3.6 and 3.7 have been released. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D6 Files:

[Lldb-commits] [PATCH] D64395: [CMake] Avoid libcxxabi dependency when building LLDB from the monorepo on macOS by default

sgraenitz abandoned this revision. sgraenitz added a comment. In D64395#1576738 , @ldionne wrote: > libc++ decides to build or not build `libc++.dylib`/`libc++.a` based on the > value of `LIBCXX_ENABLE_SHARED` and `LIBCXX_ENABLE_STATIC`, if that's your

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

cbiesinger added a comment. Ah, this works because Swig (?) adds compatibility macros to LLDBWrapPython: #define PyInt_Check(x) PyLong_Check(x) #define PyInt_AsLong(x) PyLong_AsLong(x) #define PyInt_FromLong(x) PyLong_FromLong(x) #define PyInt_FromSize_t(x) PyLong_FromSize_t(x) (etc)

[Lldb-commits] [PATCH] D64395: [CMake] Avoid libcxxabi dependency when building LLDB from the monorepo on macOS by default

ldionne added a comment. In D64395#1575999 , @sgraenitz wrote: > Thanks for taking a look. > > In D64395#1575967 , @ldionne wrote: > > > When is `LLDBConfig.cmake` used? > > > Very early in the LLDB config process:

[Lldb-commits] [PATCH] D64434: [lldb] Quick Fix: IRExecutionUnit check pointer before access it

kusmour created this revision. kusmour added reviewers: xiaobai, compnerd. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Move checking pointer code block before accessing the pointer This caused lldb to crash when testing on Android Repository: rLLDB LLDB

[Lldb-commits] [lldb] r365533 - [lldb, windows] Include WindowsError instead of ErrorHandling in ThreadLauncher

Author: stella.stamenova Date: Tue Jul 9 11:41:31 2019 New Revision: 365533 URL: http://llvm.org/viewvc/llvm-project?rev=365533=rev Log: [lldb, windows] Include WindowsError instead of ErrorHandling in ThreadLauncher ErrorHandling.h does not include WindowsError.h which is needed for

[Lldb-commits] [lldb] r365527 - [lldb-suite] Skip TestMachCore on Windows

Author: stella.stamenova Date: Tue Jul 9 11:18:02 2019 New Revision: 365527 URL: http://llvm.org/viewvc/llvm-project?rev=365527=rev Log: [lldb-suite] Skip TestMachCore on Windows This test was originally marked as expected failure on Windows, but it is timing out instead of outright failing

[Lldb-commits] [lldb] r365526 - [lldb, windows] Update two more locations that use LaunchThread to the new function signature

Author: stella.stamenova Date: Tue Jul 9 11:10:36 2019 New Revision: 365526 URL: http://llvm.org/viewvc/llvm-project?rev=365526=rev Log: [lldb, windows] Update two more locations that use LaunchThread to the new function signature Modified:

[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64397/new/ https://reviews.llvm.org/D64397

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I like the idea a lot and the implementation looks alright. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64408/new/

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:223 +// Returns true if this is the last token we get from the lexer. +exit = lex.LexFromRawLexer(token); + Can we write this as

[Lldb-commits] [PATCH] D64399: [CMake] Distribution builds for LLDB standalone

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64399/new/ https://reviews.llvm.org/D64399

[Lldb-commits] [PATCH] D64399: [CMake] Distribution builds for LLDB standalone

sgraenitz updated this revision to Diff 208695. sgraenitz added a comment. Add `include(LLVMDistributionSupport)` which went into the wrong patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64399/new/ https://reviews.llvm.org/D64399 Files:

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

labath added a comment. I'm not very familiar with the details here, but this approach seems reasonable to me... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64408/new/ https://reviews.llvm.org/D64408

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

sgraenitz added a comment. Usage example that should work in conjunction with D64397 and D64399 : $ cd path/to/lldb-deps-relwithdebinfo $ cmake -GNinja -C/path/to/llvm-project/lldb/cmake/caches/Apple-lldb-base.cmake \

[Lldb-commits] [PATCH] D64395: [CMake] Avoid libcxxabi dependency when building LLDB from the monorepo on macOS by default

sgraenitz added a comment. Thanks for taking a look. In D64395#1575967 , @ldionne wrote: > When is `LLDBConfig.cmake` used? Very early in the LLDB config process: https://github.com/llvm/llvm-project/blob/e0a3ee79c5ff/lldb/CMakeLists.txt#L15 Globally,

[Lldb-commits] [PATCH] D64395: [CMake] Avoid libcxxabi dependency when building LLDB from the monorepo on macOS by default

ldionne added a comment. When is `LLDBConfig.cmake` used? I'm trying to understand when the `LIBCXX_ENABLE_SHARED=OFF` setting will come into play. Will it influence whether `libc++.dylib` is built in the monorepo whenever you also happen to build LLDB? Comment at:

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

MaskRay added a comment. In D64398#1575713 , @devnexen wrote: > By the way quick question, I did not commit since quite a time, is it still > subversion ? Many people switched to the git monorepo github.com/llvm/llvm-project && `git llvm push` (I

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, compnerd, JDevlieghere, davide, labath, mgorny. Herald added a project: LLDB. There's a number of requirements for installing LLDB on macOS that are untypical for LLVM projects: use special install-prefix for LLDB.framework,

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen added a comment. By the way quick question, I did not commit since quite a time, is it still subversion ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/ https://reviews.llvm.org/D64398 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen updated this revision to Diff 208649. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/ https://reviews.llvm.org/D64398 Files: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.h Index:

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen marked an inline comment as done. devnexen added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:798 + if (!m_operation_thread) { + Status e("Start launch thread failed"); + error = e; MaskRay wrote: > See

[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

sgraenitz added a comment. This simplifies my proposal in D64399 , because I don't need it in `LLVM_DISTRIBUTION_COMPONENTS` and avoid dummy `install-distribution` and `install-distribution-stripped` targets. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D64399: [CMake] Distribution builds for LLDB standalone

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, mgorny, JDevlieghere, davide. Herald added a project: LLDB. Enable `distribution` and `install-distribution` targets in LLDB standalone and pre-populate the cache accordingly on macOS. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

MaskRay added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:798 + if (!m_operation_thread) { + Status e("Start launch thread failed"); + error = e; See D64163/r365226 Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen created this revision. devnexen added reviewers: mgorny, MaskRay. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, jfb, emaste. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D64398 Files:

[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

sgraenitz created this revision. sgraenitz added a reviewer: xiaobai. Herald added a subscriber: mgorny. Herald added a project: LLDB. The custom lldb-framework target was meant to encapsulate all build steps that LLDB.framework needs on top of the ordinaly liblldb. In the end all of it happens

[Lldb-commits] [PATCH] D64395: [CMake] Avoid libcxxabi dependency when building LLDB from the monorepo on macOS by default

sgraenitz added a comment. This is a no-op when used in conjunction with `lldb/cmake/cache/Apple-lldb-base.cmake`. Otherwise it touches the cache at configuration time, which typically causes ninja to re-run cmake before starting the build. I think it's acceptable, given that we do this in

[Lldb-commits] [PATCH] D64395: [CMake] Avoid libcxxabi dependency when building LLDB from the monorepo on macOS by default

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, davide. Herald added a subscriber: mgorny. Herald added a reviewer: EricWF. Herald added a project: LLDB. libc++abi became mandatory to link the libc++ binaries. LLDB only needs the build artifacts and not the linked

[Lldb-commits] [lldb] r365459 - [CMake] Polish a comment

Author: stefan.graenitz Date: Tue Jul 9 03:29:07 2019 New Revision: 365459 URL: http://llvm.org/viewvc/llvm-project?rev=365459=rev Log: [CMake] Polish a comment Modified: lldb/trunk/cmake/modules/LLDBFramework.cmake Modified: lldb/trunk/cmake/modules/LLDBFramework.cmake URL:

[Lldb-commits] [lldb] r365458 - [CMake] Don't initialize LLVM_INSTALL_TOOLCHAIN_ONLY in Apple-lldb-base cache

Author: stefan.graenitz Date: Tue Jul 9 03:29:00 2019 New Revision: 365458 URL: http://llvm.org/viewvc/llvm-project?rev=365458=rev Log: [CMake] Don't initialize LLVM_INSTALL_TOOLCHAIN_ONLY in Apple-lldb-base cache Modified: lldb/trunk/cmake/caches/Apple-lldb-base.cmake Modified:

[Lldb-commits] [lldb] r365457 - [CMake] Remove old lldb_setup_framework_rpaths_in_tool()

Author: stefan.graenitz Date: Tue Jul 9 03:28:53 2019 New Revision: 365457 URL: http://llvm.org/viewvc/llvm-project?rev=365457=rev Log: [CMake] Remove old lldb_setup_framework_rpaths_in_tool() Modified: lldb/trunk/cmake/modules/AddLLDB.cmake Modified: lldb/trunk/cmake/modules/AddLLDB.cmake