[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher added inline comments. Comment at: llvm/utils/lit/lit/LitConfig.py:81 +@property +def killProcessAndChildrenIsSupported(self): +""" Sorry to be pedantic but this (`LitConfig.killProcessAndChildrenIsSupported`) should be called

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty updated this revision to Diff 209409. daltenty added a comment. - Address review comments round 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64251/new/ https://reviews.llvm.org/D64251 Files: libcxx/utils/libcxx/util.py

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

This revision was automatically updated to reflect the committed changes. Closed by commit rL365853: [Expression] Move IRDynamicChecks to ClangExpressionParser (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r365853 - [Expression] Move IRDynamicChecks to ClangExpressionParser

Author: xiaobai Date: Thu Jul 11 17:58:02 2019 New Revision: 365853 URL: http://llvm.org/viewvc/llvm-project?rev=365853=rev Log: [Expression] Move IRDynamicChecks to ClangExpressionParser Summary: IRDynamicChecks in its current form is specific to Clang since it deals with the C language family.

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.

teemperor accepted this revision. teemperor added a comment. Closed by 365698 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64194/new/ https://reviews.llvm.org/D64194 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added a comment. In D64591#1581878 , @jingham wrote: > That would be cleaner. > > OTOH, the original reason for these checkers was to help people understand > crashes in their expressions more clearly. Supposedly, modern languages > "don't have

[Lldb-commits] [lldb] r365843 - [Target] Replace Plugin headers with non-plugin headers

Author: xiaobai Date: Thu Jul 11 16:45:35 2019 New Revision: 365843 URL: http://llvm.org/viewvc/llvm-project?rev=365843=rev Log: [Target] Replace Plugin headers with non-plugin headers Modified: lldb/trunk/source/Target/Target.cpp Modified: lldb/trunk/source/Target/Target.cpp URL:

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That would be cleaner. OTOH, the original reason for these checkers was to help people understand crashes in their expressions more clearly. Supposedly, modern languages "don't have

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added a comment. In D64591#1581820 , @jingham wrote: > Then the IRDynamicCheck part would go with LLVMUserExpression, and the > C-specific checks in Clang... Except IRDynamicChecks has special knowledge of the clang-specific instrumenters. I

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

jingham added a comment. Then the IRDynamicCheck part would go with LLVMUserExpression, and the C-specific checks in Clang... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64591/new/ https://reviews.llvm.org/D64591 ___ lldb-commits

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Okay... Provided we can come up with not too torturous ways to get the ObjC and Swift support out of generic-code, it seems okay to do this as a first step. I just don't want to end up in

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added a comment. In D64591#1581775 , @jingham wrote: > This is a little unclear to me. LLVMUserExpression is the class that > represents "anything that uses LLVM at its back end." Both the Swift & Clang > user expressions are instances of

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai added a comment. In D64599#1581718 , @jingham wrote: > Anyway, if you can make all the generic parts of lldb not depend on the > language specific - but still abstract - part of the plugin, that would be > fine. Then just LanguageRuntime.h

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

jingham added a comment. This is a little unclear to me. LLVMUserExpression is the class that represents "anything that uses LLVM at its back end." Both the Swift & Clang user expressions are instances of this. Running through IR and inserting little callouts is an LLVMUserExpression type

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

jingham added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:55 #include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h" +#include "Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h" xiaobai wrote: > labath

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

jingham added a comment. In D64599#1581620 , @labath wrote: > In D64599#1581598 , @jingham wrote: > > > My model for this was that there was a CPPLanguageRuntime.cpp that contains > > everything you can implement

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai marked an inline comment as done. xiaobai added a comment. In D64599#1581620 , @labath wrote: > In D64599#1581598 , @jingham wrote: > > > My model for this was that there was a CPPLanguageRuntime.cpp that

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai updated this revision to Diff 209351. xiaobai added a comment. Remove documentation boilerplate CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64591/new/ https://reviews.llvm.org/D64591 Files: include/lldb/Expression/DynamicCheckerFunctions.h

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

jingham added a comment. In D64599#1581604 , @labath wrote: > What is the indented relationship between CPPLanguage and CPPLanguageRuntime > plugins (and generally between any Language and its LanguageRuntime)? Right > now you're having the CPPLanguage

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

labath added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:55 #include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h" +#include "Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h" compnerd wrote: >

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

labath added a comment. In D64599#1581598 , @jingham wrote: > My model for this was that there was a CPPLanguageRuntime.cpp that contains > everything you can implement about the CPP runtime that is independent of any > particular implementation of the

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

compnerd added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:55 #include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h" +#include "Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h" xiaobai wrote: >

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

JDevlieghere added inline comments. Comment at: include/lldb/Expression/DynamicCheckerFunctions.h:19 + +/// \class DynamicCheckerFunctions DynamicCheckerFunctions.h +/// "lldb/Expression/DynamicCheckerFunctions.h" Encapsulates dynamic check xiaobai wrote: >

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:55 #include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h" +#include "Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h"

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

labath added a comment. What is the indented relationship between CPPLanguage and CPPLanguageRuntime plugins (and generally between any Language and its LanguageRuntime)? Right now you're having the CPPLanguage depend on the CPPLanguageRuntime plugin. There is no reverse dependency, so this

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. My model for this was that there was a CPPLanguageRuntime.cpp that contains everything you can implement about the CPP runtime that is independent of any particular implementation

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added inline comments. Comment at: include/lldb/Expression/DynamicCheckerFunctions.h:19 + +/// \class DynamicCheckerFunctions DynamicCheckerFunctions.h +/// "lldb/Expression/DynamicCheckerFunctions.h" Encapsulates dynamic check JDevlieghere wrote: > Can

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

JDevlieghere added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:55 #include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h" +#include "Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h" What's the benefit

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai updated this revision to Diff 209335. xiaobai added a comment. Reflow comment Remove newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64591/new/ https://reviews.llvm.org/D64591 Files: include/lldb/Expression/DynamicCheckerFunctions.h

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, jingham, compnerd, labath. Herald added a subscriber: mgorny. This seems better suited to be in a plugin. https://reviews.llvm.org/D64599 Files: include/lldb/Target/CPPLanguageRuntime.h

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

JDevlieghere added inline comments. Comment at: include/lldb/Expression/DynamicCheckerFunctions.h:19 + +/// \class DynamicCheckerFunctions DynamicCheckerFunctions.h +/// "lldb/Expression/DynamicCheckerFunctions.h" Encapsulates dynamic check Can we skip this

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

kusmour updated this revision to Diff 209325. kusmour edited the summary of this revision. kusmour added a comment. Herald added a subscriber: abidh. add more context to diff Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64583/new/

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

xiaobai added a comment. Can you add more context to this diff? I can't see the code surrounding the changes. You can get the whole context with something like `git show -U`. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64583/new/

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai created this revision. xiaobai added reviewers: compnerd, clayborg, jingham, JDevlieghere. Herald added a subscriber: mgorny. IRDynamicChecks in its current form is specific to Clang since it deals with the C language family. It is possible that we may want to instrument code generated

[Lldb-commits] [PATCH] D64535: Add convenience methods to convert LLDB to LLVM data structures.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365819: Add convenience methods to convert LLDB to LLVM data structures. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r365819 - Add convenience methods to convert LLDB to LLVM data structures.

Author: jdevlieghere Date: Thu Jul 11 13:26:53 2019 New Revision: 365819 URL: http://llvm.org/viewvc/llvm-project?rev=365819=rev Log: Add convenience methods to convert LLDB to LLVM data structures. This patch adds two convenience methods named GetAsLLVM to the LLDB counterparts of the DWARF

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

kusmour created this revision. kusmour added a reviewer: xiaobai. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. Delete the duplicate func `skipIfTargetAndroid` Fix the old one Repository: rLLDB LLDB https://reviews.llvm.org/D64583 Files:

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

This revision was automatically updated to reflect the committed changes. Closed by commit rL365813: [lldb] Make TestDeletedExecutable more reliable (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64545: [lldb] Don't use __FUNCTION__ as a file name

This revision was automatically updated to reflect the committed changes. Closed by commit rL365812: [lldb] Dont use __FUNCTION__ as a file name (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r365813 - [lldb] Make TestDeletedExecutable more reliable

Author: teemperor Date: Thu Jul 11 12:27:33 2019 New Revision: 365813 URL: http://llvm.org/viewvc/llvm-project?rev=365813=rev Log: [lldb] Make TestDeletedExecutable more reliable Summary: It seems that calling Popen can return to the caller before the started process has read all the needed

[Lldb-commits] [lldb] r365812 - [lldb] Don't use __FUNCTION__ as a file name

Author: teemperor Date: Thu Jul 11 12:26:55 2019 New Revision: 365812 URL: http://llvm.org/viewvc/llvm-project?rev=365812=rev Log: [lldb] Don't use __FUNCTION__ as a file name Summary: I saw while debugging that we call this file `ParseInternal`, which is not a very good name for our fake

[Lldb-commits] [PATCH] D64536: Adding inline comments to code view type records

nilanjana_basu marked 2 inline comments as done. nilanjana_basu added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeViewRecordIO.h:63 - Error mapInteger(TypeIndex ); + Error mapInteger(TypeIndex , const char* Comment = nullptr); rnk

[Lldb-commits] [PATCH] D64536: Adding inline comments to code view type records

nilanjana_basu updated this revision to Diff 209278. nilanjana_basu added a comment. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. String parameter passing is done using Twine instead of using C strings, as suggested in the review Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

teemperor updated this revision to Diff 209231. teemperor edited the summary of this revision. teemperor added a comment. - Timeout -> file synchronization. - Made the test process run longer just in case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64546/new/

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

labath added a comment. In D64546#1580618 , @friss wrote: > This might mitigate the issue, but timeouts like this are bound to fail in > some circumstances (machine load, ...). It's more work, but can we instead > have the inferior produce an observable

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

davide added a comment. Yeah, I'd rather have an explicit communication between debugger and debuggee. We tried to put sleeps in the code [for e.g. `lldb-mi` tests in the past] and they end up failing anyway sporadically, which makes a pain to track the problem down. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

friss added a comment. This might mitigate the issue, but timeouts like this are bound to fail in some circumstances (machine load, ...). It's more work, but can we instead have the inferior produce an observable side effect (eg, print some output) and synchronize on this? Repository:

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

This revision was automatically updated to reflect the committed changes. Closed by commit rL365761: [LLDB] Fix FreeBSD build. (authored by devnexen, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r365761 - [LLDB] Fix FreeBSD build.

Author: devnexen Date: Thu Jul 11 05:21:04 2019 New Revision: 365761 URL: http://llvm.org/viewvc/llvm-project?rev=365761=rev Log: [LLDB] Fix FreeBSD build. To align with the LaunchThread change. Reviewers: MaskRay, mgorny Reviewed By: MaskRay Differential Revision:

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I think the description should mention that this is to fix FreeBSD build after the LaunchThread interface change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/ https://reviews.llvm.org/D64398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org