[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

kusmour created this revision. kusmour added a reviewer: xiaobai. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This can help `lldb-vscode` handle launch commands associate with remote platform attach request have field `attachCommands` to handle attach specific commands

[Lldb-commits] [PATCH] D65362: [CMake] Move project() call to main CMake file

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. The main CMake file don't have a project() call. In this case, cmake will run a dummy project(Project ) at the very beginning. Even before cmake_minimum_required. And a series of compiler

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai updated this revision to Diff 212031. xiaobai added a comment. Address comments: - Use Expected - Did some formatting - Made error checking more explicit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65122/new/ https://reviews.llvm.org/D65122 Files:

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. (In fact I observe many patterns in this review like: enum { Foo = alignof(void*); } aligned_storage_t<1234, Foo> x; and then a bunch of casting to treat it as a char buffer; if it was just born as a char buffer you can remove both the casts and the enum hack:

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. In D65249#1603335 , @jfb wrote: > @rnk: how about I add a bit of code that wraps `aligned_storage` on all > platforms except MSVC (where I'd implement it as Billy suggests). That would > mean updating all the uses of

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

clayborg added a comment. Can we add a section for "Building LLDB with Xcode"? We had a shell script patch that was going to be checked in, not sure if it made it. But it did a two part thing where it built LLVM and clang and then generated an Xcode project. I would rather just produce the

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a comment. In D65249#1603278 , @BillyONeal wrote: > > @BillyONeal do you know if 19.11 has the aligned_storage issue on x86? > > aligned_storage is still capped at what the library can fake with unions. It > would be an ABI break to change it

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. > @BillyONeal do you know if 19.11 has the aligned_storage issue on x86? aligned_storage is still capped at what the library can fake with unions. It would be an ABI break to change it to use alignas, so things where the x86 stack temporarily breaks T's usual

[Lldb-commits] [PATCH] D65353: [lldb] Also include the array definition in Properties.inc

JDevlieghere created this revision. JDevlieghere added a reviewer: teemperor. Right now our Properties.inc only generates the initializer for the options list but not the array declaration boilerplate around it. As the array definition is identical for all arrays, we might as well also let the

[Lldb-commits] [PATCH] D65311: [dotest] Remove multiprocessing

jingham added a comment. This seems okay to me. I would also check with Jason. I don't know who coordinates running tests remotely - or even if they can run in parallel now. But that's the one bit I don't understand well enough to say yea or nay on. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r367153 - [CMake] Print the correct variables

Author: jdevlieghere Date: Fri Jul 26 13:58:10 2019 New Revision: 367153 URL: http://llvm.org/viewvc/llvm-project?rev=367153=rev Log: [CMake] Print the correct variables This didn't get updated after we decided to set PYTHON_MAJOR_VERSION and PYTHON_MINOR_VERSION in find_python_libs_windows,

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a subscriber: BillyONeal. jfb added a comment. In D65249#1603133 , @rnk wrote: > I still think this concern applies: > https://reviews.llvm.org/D64417#1576675 > > I'm not sure how to track down an 19.11 release to test if we can pass >

[Lldb-commits] [lldb] r367152 - [TableGen] Fix stale include paths

Author: jdevlieghere Date: Fri Jul 26 13:55:07 2019 New Revision: 367152 URL: http://llvm.org/viewvc/llvm-project?rev=367152=rev Log: [TableGen] Fix stale include paths This worked locally because the include files were not regenerated, but fails when performing a clean build. Modified:

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

rnk added a comment. I still think this concern applies: https://reviews.llvm.org/D64417#1576675 I'm not sure how to track down an 19.11 release to test if we can pass std::aligned_storage values through function calls on x86. We might be better off raising the minimum to 19.14, which is a

[Lldb-commits] [PATCH] D65331: [lldb] Also include the array definition in CommandOptions.inc

JDevlieghere added inline comments. Comment at: lldb/utils/TableGen/LLDBOptionDefEmitter.cpp:146 // We undefine the macro for the user like Clang's include files are doing it. + OS << "};\n"; OS << "#undef " << NeededMacro << "\n"; Let's move this before

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 1min

jankratochvil added a comment. In D65271#1602143 , @labath wrote: > I think I'd go for threading it in from VSCodeTestCaseBase. Maybe not as an > argument to `request_attach` and friends, but possibly as an argument to the > `DebugCommunication` object

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil updated this revision to Diff 211973. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65271/new/ https://reviews.llvm.org/D65271 Files: lldb/lit/lit-lldb-init.in lldb/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added a comment. I'm going to update this diff with what I changed to give y'all a better idea of what has been changed. I shoulda done that to begin with... :P In D65122#1602145 , @labath wrote: > In D65122#1602067

[Lldb-commits] [lldb] r367140 - [TableGen] Move core properties into a separate file (NFC)

Author: jdevlieghere Date: Fri Jul 26 11:14:12 2019 New Revision: 367140 URL: http://llvm.org/viewvc/llvm-project?rev=367140=rev Log: [TableGen] Move core properties into a separate file (NFC) With the plugins having their own tablgen file, it makes sense to split off the core properties as

[Lldb-commits] [lldb] r367139 - [TableGen] Move target properties into a separate file (NFC)

Author: jdevlieghere Date: Fri Jul 26 11:14:08 2019 New Revision: 367139 URL: http://llvm.org/viewvc/llvm-project?rev=367139=rev Log: [TableGen] Move target properties into a separate file (NFC) With the plugins having their own tablgen file, it makes sense to split off the target properties as

[Lldb-commits] [lldb] r367138 - [TableGen] Move interpreter properties into a separate file (NFC)

Author: jdevlieghere Date: Fri Jul 26 11:14:04 2019 New Revision: 367138 URL: http://llvm.org/viewvc/llvm-project?rev=367138=rev Log: [TableGen] Move interpreter properties into a separate file (NFC) With the plugins having their own tablgen file, it makes sense to split off the interpreter

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

amccarth added inline comments. Comment at: lldb/docs/resources/build.rst:94 +project, it generates the files needed by your build tool. The recommended +build tool for LLVM is Ninja. Please also read `Building LLVM with CMake +`_.

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

jingham added a comment. It seems to me part of the goal of Alex's efforts is to make it possible for a given lldb to have or not have support for any particular type system. In some future day they might even be live pluggable, so that which ones get loaded would be a user choice. In that

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:94 +project, it generates the files needed by your build tool. The recommended +build tool for LLVM is Ninja. Please also read `Building LLVM with CMake +`_.

[Lldb-commits] [PATCH] D65293: Document the fact that LLDB_LOG uses llvm::format_providers

This revision was automatically updated to reflect the committed changes. Closed by commit rL367132: Document that LLDB_LOG macros use the format_providers. (authored by jingham, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65293: Document the fact that LLDB_LOG uses llvm::format_providers

jingham added a comment. Yeah, I didn't want to bother with formatting in case there were suggestions on content. I checked in a version that's correctly truncated. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65293/new/ https://reviews.llvm.org/D65293

[Lldb-commits] [lldb] r367132 - Document that LLDB_LOG macros use the format_providers.

Author: jingham Date: Fri Jul 26 10:25:20 2019 New Revision: 367132 URL: http://llvm.org/viewvc/llvm-project?rev=367132=rev Log: Document that LLDB_LOG macros use the format_providers. Differential Revision: https://reviews.llvm.org/D65293 Modified: lldb/trunk/include/lldb/Utility/Log.h

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. In D65330#1602786 , @jryans wrote: > On http://releases.llvm.org/, for some recent versions like 8.0.0, the > "Documentation" column has separate versioned links for "llvm clang lld > clang-extra libc++ polly", but lldb

[Lldb-commits] [PATCH] D47384: Remove dependency from Host to clang

mclow.lists added inline comments. Herald added a project: LLVM. Comment at: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangHost.cpp:77 + const char *swift_clang_resource_dir = "usr/lib/swift/clang"; + auto parent = std::next(rev_it); + if (parent != r_end && *parent

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In D65330#1602779 , @sgraenitz wrote: > Where did you find the //sub-project list of versioned docs//? On http://releases.llvm.org/, for some recent versions like 8.0.0, the "Documentation" column has separate versioned links

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:94 +project, it generates the files needed by your build tool. The recommended +build tool for LLVM is Ninja. Please also read `Building LLVM with CMake +`_.

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. In D65330#1602756 , @jryans wrote: > Hmm, are there the LLDB docs archived per release? [...] LLDB doesn't seem to > appear in sub-project list of versioned docs Right, Clang docs are here:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

amccarth added a comment. Looks good. Thanks for doing these updates! Comment at: lldb/docs/resources/build.rst:85 +The LLVM project is migrating to a single monolithic respository for LLVM and +its subprojects. This is the recommended way to build LLDB. Checkout the

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans accepted this revision. jryans added a comment. In D65330#1602737 , @sgraenitz wrote: > I added a few links to LLVM documentation here and wondered what to do with > them, if this gets cherry-picked to `release/9.x`, e.g. >

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

amccarth added a comment. In D65230#1602370 , @labath wrote: > Thanks. > > BTW, I tried this on windows, and it didn't blow up in my face, I think it > should be relatively safe. I couldn't reproduce the problems that @amccarth > was experiencing, so I

Re: [Lldb-commits] [lldb] r366985 - LLGS: fix tracking execve on linux

Merged to release_90 in r367128. On Wed, Jul 24, 2019 at 11:37 PM Pavel Labath via lldb-commits wrote: > > Author: labath > Date: Wed Jul 24 23:38:33 2019 > New Revision: 366985 > > URL: http://llvm.org/viewvc/llvm-project?rev=366985=rev > Log: > LLGS: fix tracking execve on linux > > Summary: >

[Lldb-commits] [PATCH] D65331: [lldb] Also include the array definition in CommandOptions.inc

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65331/new/ https://reviews.llvm.org/D65331 ___

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In D65330#1602715 , @sgraenitz wrote: > Cool, patch `Diff 211951` has the change. Here's the difference in generated > output: > https://weliveindetail.github.io/blog/res/lldb-docs/resources/build.html > >

[Lldb-commits] [lldb] r367127 - [CMake] Fix find_python_libs_windows

Author: jdevlieghere Date: Fri Jul 26 09:32:49 2019 New Revision: 367127 URL: http://llvm.org/viewvc/llvm-project?rev=367127=rev Log: [CMake] Fix find_python_libs_windows Exporting PYTHON_INCLUDE_DIR to the Python scope somehow got lost in my last change. Add it back again. This should fix the

[Lldb-commits] [lldb] r367125 - [CMake] Print Python version on Windows

Author: jdevlieghere Date: Fri Jul 26 09:15:19 2019 New Revision: 367125 URL: http://llvm.org/viewvc/llvm-project?rev=367125=rev Log: [CMake] Print Python version on Windows Trying to figure out what's causing the Windows bot to fail. Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. >> Since //Visual Studio// is the only section in //Building LLDB with CMake >> and Other Generators// now, ... > > Yes, this sounds like a good plan. Cool, patch `Diff 211951` has the change. Here's the difference in generated output:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 211951. sgraenitz added a comment. Merge Visual Studio build instructions into `Common CMake options > Windows` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 211950. sgraenitz added a comment. Polishing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 Files: lldb/docs/resources/build.rst Index:

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

This revision was automatically updated to reflect the committed changes. Closed by commit rL367115: [CMake] Loosen Python version check and ignore patch version (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added a comment. Thanks, labath@ Could anyone please merge this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931 ___ lldb-commits mailing

[Lldb-commits] [lldb] r367115 - [CMake] Loosen Python version check and ignore patch version

Author: jdevlieghere Date: Fri Jul 26 07:26:33 2019 New Revision: 367115 URL: http://llvm.org/viewvc/llvm-project?rev=367115=rev Log: [CMake] Loosen Python version check and ignore patch version Some versions of macOS report a different patch version for the system provided interpreter and

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In D65330#1602583 , @sgraenitz wrote: > Since //Visual Studio// is the only section in //Building LLDB with CMake and > Other Generators// now, I would like to: > > - move it merge it with another one, preferably //Common CMake

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. Updated rendered HTML: http://weliveindetail.github.io/blog/res/lldb-docs/resources/build.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. Since //Visual Studio// is the only section in //Building LLDB with CMake and Other Generators// now, I would like to: - move it merge it with another one, preferably //Common CMake options > Windows// - rename //Building LLDB with CMake & Ninja// into //Building

[Lldb-commits] [lldb] r367110 - [lldb][NFC] Remove eDiagnosticOriginGo

Author: teemperor Date: Fri Jul 26 07:00:13 2019 New Revision: 367110 URL: http://llvm.org/viewvc/llvm-project?rev=367110=rev Log: [lldb][NFC] Remove eDiagnosticOriginGo This enum value is unused as we removed Go support. Modified: lldb/trunk/include/lldb/Expression/DiagnosticManager.h

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 211930. sgraenitz marked an inline comment as done. sgraenitz added a comment. Polish section `Standalone builds` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans accepted this revision. jryans added a comment. This revision is now accepted and ready to land. Great!  Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 211931. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Polish section `CMake caches` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 Files:

[Lldb-commits] [PATCH] D65331: [lldb] Also include the array definition in CommandOptions.inc

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. Right now our CommandOptions.inc only generates the initializer for the options list but not the array declaration boilerplate around it. As the

[Lldb-commits] [lldb] r367106 - DWARF: Improve type safety or range lists parsing

Author: labath Date: Fri Jul 26 06:15:28 2019 New Revision: 367106 URL: http://llvm.org/viewvc/llvm-project?rev=367106=rev Log: DWARF: Improve type safety or range lists parsing Delete the abstract GetOffset function, which is only defined for rnglists entries. Instead fix up entries which refer

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In general, this looks great overall! I added few comments on things that would be good to clarify. Comment at: lldb/docs/resources/build.rst:108 +subprojects to build in addition to LLVM. Read more about additional options in +the CMake Options

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 211922. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Add links to sections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 Files:

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

labath added a comment. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D65282#1602293 , @labath wrote: > In D65282#1602244 , @MaskRay wrote: > > > > Are you referring to the

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. View rendered HTML output here: http://weliveindetail.github.io/blog/res/lldb-docs/resources/build.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

teemperor added a comment. LGTM (beside the standalone build section which I have no experience with). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 ___

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, jingham, labath, stella.stamenova, teemperor, jryans, kastiglione. Herald added a project: LLDB. sgraenitz added a subscriber: friss. sgraenitz added reviewers: xiaobai, compnerd. The lldb build system made good progress

[Lldb-commits] [PATCH] D65329: SymbolVendor: Move locking into the Symbol Files

labath created this revision. labath added reviewers: clayborg, JDevlieghere, jingham. Herald added a subscriber: aprantl. Herald added a reviewer: jdoerfert. The last bit of functionality in SymbolVendor passthrough functions is the locking the module mutex. While it may be nice doing the

[Lldb-commits] [lldb] r367102 - [lldb] Don't dynamically allocate the posix option validator.

Author: teemperor Date: Fri Jul 26 04:46:21 2019 New Revision: 367102 URL: http://llvm.org/viewvc/llvm-project?rev=367102=rev Log: [lldb] Don't dynamically allocate the posix option validator. We dynamically allocate the option validator which means we can't mark this list of OptionDefinitions

[Lldb-commits] [PATCH] D65293: Document the fact that LLDB_LOG uses llvm::format_providers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is the best place to put that comment. Your lines are longer than 80 chars though. :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65293/new/

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

labath added a comment. Thanks. BTW, I tried this on windows, and it didn't blow up in my face, I think it should be relatively safe. I couldn't reproduce the problems that @amccarth was experiencing, so I don't know if it fixes that problem. It would be good to know whether it does, as we

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath updated this revision to Diff 211904. labath added a comment. Split the test into two CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65282/new/ https://reviews.llvm.org/D65282 Files: lit/Modules/ELF/PT_LOAD-overlap-PT_TLS.yaml lit/Modules/ELF/PT_TLS-overlap-PT_LOAD.yaml

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath marked 2 inline comments as done. labath added a comment. In D65282#1602244 , @MaskRay wrote: > > Are you referring to the "image lookup" command specifically, or is it a > > more general question about the internals of lldb too? > > Both:) This

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

MaskRay added inline comments. Comment at: lit/Modules/ELF/PT_LOAD-overlap-PT_TLS.yaml:62 +Flags: [ SHF_ALLOC, SHF_WRITE ] +Address: 0x1000 +AddressAlign:0x4 `.data = .tbss = 0x1010` is a more realistic scenario. Normally, a

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

MaskRay added a comment. > Are you referring to the "image lookup" command specifically, or is it a more > general question about the internals of lldb too? Both:) This patch doesn't change the `Address: a.o[0x1010] (a.o.PT_LOAD[0]..tdata + 0)` output so I was puzzled what this patch

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath updated this revision to Diff 211899. labath marked 3 inline comments as done. labath added a comment. - update according to review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65282/new/ https://reviews.llvm.org/D65282 Files:

[Lldb-commits] [lldb] r367095 - Fix some "control reaches end of non-void function" warnings

Author: labath Date: Fri Jul 26 02:38:23 2019 New Revision: 367095 URL: http://llvm.org/viewvc/llvm-project?rev=367095=rev Log: Fix some "control reaches end of non-void function" warnings Modified: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp Modified:

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath marked an inline comment as done. labath added a comment. > Do you mind explaining more how you'd like to improve file-address-based > lookups for PT_TLS? I don't have this fully thought through (I was hoping this would develop as use cases start showing up), but... Are you referring

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65230/new/ https://reviews.llvm.org/D65230 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r367090 - ObjectFileELF: Use llvm::JamCRC to refactor CRC32 computation

Author: maskray Date: Fri Jul 26 01:33:36 2019 New Revision: 367090 URL: http://llvm.org/viewvc/llvm-project?rev=367090=rev Log: ObjectFileELF: Use llvm::JamCRC to refactor CRC32 computation Reviewed By: labath Differential Revision: https://reviews.llvm.org/D65318 Modified:

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

labath added a comment. In D65122#1602067 , @JDevlieghere wrote: > In D65122#1602025 , @xiaobai wrote: > > > After going through this and modifying this patch, I can't help but wonder > > if `llvm::Optional`

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

labath added a comment. In D65271#1601717 , @jankratochvil wrote: > In D65271#1600829 , @labath wrote: > > > Why not unify now? It shouldn't be too hard to at least unify all the > > instances in dotest python

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

MaskRay added inline comments. Comment at: lit/Modules/ELF/PT_LOAD-overlap-PT_TLS.yaml:44 +# LOOKUP-LABEL: image lookup -a 0x1010 +# LOOKUP: Address: {{.*}}.PT_LOAD[0]..data + 16) + Do you mind explaining more how you'd like to improve file-address-based

[Lldb-commits] [PATCH] D65311: [dotest] Remove multiprocessing

labath added a comment. Woohoo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65311/new/ https://reviews.llvm.org/D65311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D65208: SymbolVendor: Move Symtab construction into the SymbolFile

This revision was automatically updated to reflect the committed changes. Closed by commit rL367086: SymbolVendor: Move Symtab construction into the SymbolFile (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [lldb] r367086 - SymbolVendor: Move Symtab construction into the SymbolFile

Author: labath Date: Fri Jul 26 00:03:28 2019 New Revision: 367086 URL: http://llvm.org/viewvc/llvm-project?rev=367086=rev Log: SymbolVendor: Move Symtab construction into the SymbolFile Summary: Instead of having SymbolVendor coordinate Symtab construction between Symbol and Object files, make

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

MaskRay added a comment. > It turns out this was too aggressive because thread-local sections typically will have file addresses which apear to overlap regular data/code. This does not cause a problem at runtime because thread-local sections are loaded into memory using special logic, but it can