[Lldb-commits] [lldb] r372064 - [test] Disable reproducer dump test on Windows

Author: jdevlieghere Date: Mon Sep 16 20:58:32 2019 New Revision: 372064 URL: http://llvm.org/viewvc/llvm-project?rev=372064=rev Log: [test] Disable reproducer dump test on Windows Modified: lldb/trunk/lit/Reproducer/TestDump.test Modified: lldb/trunk/lit/Reproducer/TestDump.test URL:

[Lldb-commits] [PATCH] D67644: [ScriptInterpreter] Initialize globals when loading a scripting module.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372060: [ScriptInterpreter] Initialize globals when loading a scripting module. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [lldb] r372060 - [ScriptInterpreter] Initialize globals when loading a scripting module.

Author: jdevlieghere Date: Mon Sep 16 20:55:58 2019 New Revision: 372060 URL: http://llvm.org/viewvc/llvm-project?rev=372060=rev Log: [ScriptInterpreter] Initialize globals when loading a scripting module. The LoadScriptingModule used by command script import wasn't initializing the LLDB global

[Lldb-commits] [PATCH] D67644: [ScriptInterpreter] Initialize globals when loading a scripting module.

MaskRay added inline comments. Comment at: lldb/lit/Commands/Inputs/frame.py:3 +print(lldb.frame) \ No newline at end of file No newline at end of file Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67644/new/

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220424. hhb added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index:

[Lldb-commits] [PATCH] D67644: [ScriptInterpreter] Initialize globals when loading a scripting module.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67644/new/ https://reviews.llvm.org/D67644 ___

[Lldb-commits] [PATCH] D67644: [ScriptInterpreter] Initialize globals when loading a scripting module.

JDevlieghere created this revision. JDevlieghere added reviewers: davide, jingham. JDevlieghere added a project: LLDB. Herald added a subscriber: teemperor. The `LoadScriptingModule` used by `command script import` wasn't initializing the LLDB global variables (things like `lldb.frame` and

[Lldb-commits] [lldb] r372057 - Revert "[lldb][NFC] Make ApplyObjcCastHack less scary"

Author: jingham Date: Mon Sep 16 17:44:48 2019 New Revision: 372057 URL: http://llvm.org/viewvc/llvm-project?rev=372057=rev Log: Revert "[lldb][NFC] Make ApplyObjcCastHack less scary" This reverts commit 21641a2f6dbac22653befd03496e0850537882ff. It was causing the following test failures:

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

JDevlieghere added a comment. In D67641#1671917 , @hhb wrote: > In D67641#1671881 , @JDevlieghere > wrote: > > > Can we match what `FindPythonInterp ` and `FindPythonLibs` does? > > > > mark_as_advanced( > >

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb added a comment. In D67641#1671881 , @JDevlieghere wrote: > Can we match what `FindPythonInterp ` and `FindPythonLibs` does? > > mark_as_advanced( > PYTHON_EXECUTABLE > PYTHON_DEBUG_LIBRARY > PYTHON_LIBRARY > PYTHON_INCLUDE_DIR >

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220410. hhb added a comment. Add mark_as_advanced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index:

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

JDevlieghere added a comment. Can we match what `FindPythonInterp ` and `FindPythonLibs` does? mark_as_advanced( PYTHON_EXECUTABLE PYTHON_DEBUG_LIBRARY PYTHON_LIBRARY PYTHON_INCLUDE_DIR ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r372052 - [test] Fail gracefully if the regex doesn't match

Author: jdevlieghere Date: Mon Sep 16 16:49:42 2019 New Revision: 372052 URL: http://llvm.org/viewvc/llvm-project?rev=372052=rev Log: [test] Fail gracefully if the regex doesn't match This test is failing on the Fedora bot (staging). Rather than failing with an IndexError, we should trigger an

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb added a reviewer: JDevlieghere. This way it can be overwritten when cross compiling. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67641 Files:

[Lldb-commits] [PATCH] D67583: Fix swig python package path

This revision was automatically updated to reflect the committed changes. Closed by commit rL372047: Fix swig python package path (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67636: [Reproducer] Implement dumping packets.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372046: [Reproducer] Implement dumping packets. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r372046 - [Reproducer] Implement dumping packets.

Author: jdevlieghere Date: Mon Sep 16 16:31:06 2019 New Revision: 372046 URL: http://llvm.org/viewvc/llvm-project?rev=372046=rev Log: [Reproducer] Implement dumping packets. This patch completes the dump functionality by adding support for dumping a reproducer's GDB remote packets. Differential

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added a comment. In D62931#1607800 , @labath wrote: > In D62931#1607221 , @guiandrade > wrote: > > > Oh, sorry about that. I was relying on `ninja check`, which runs okay for > > me. > > > > > ninja

[Lldb-commits] [lldb] r372044 - Fix warning: lambda capture 'temp_file_path' is not used

Author: jdevlieghere Date: Mon Sep 16 15:55:49 2019 New Revision: 372044 URL: http://llvm.org/viewvc/llvm-project?rev=372044=rev Log: Fix warning: lambda capture 'temp_file_path' is not used Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp Modified:

[Lldb-commits] [PATCH] D67583: Fix swig python package path

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D67636: [Reproducer] Implement dumping packets.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: LLDB. This adds support for dumping a reproducer's GDB remote packets. Repository: rLLDB LLDB https://reviews.llvm.org/D67636 Files: lldb/lit/Reproducer/TestDump.test

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220392. hhb added a comment. Use CMAKE_HOST_SYSTEM_NAME instead. Since the python script is run on host. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files:

[Lldb-commits] [lldb] r372028 - [NFC] Move dumping into GDBRemotePacket

Author: jdevlieghere Date: Mon Sep 16 13:02:57 2019 New Revision: 372028 URL: http://llvm.org/viewvc/llvm-project?rev=372028=rev Log: [NFC] Move dumping into GDBRemotePacket This moves the dumping logic from the GDBRemoteCommunicationHistory class into the GDBRemotePacket so that it can be

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. (setting this to 'request changes' that it leaves the review queue and goes back to mib) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r372018 - [lldb] Remove SetCount/ClearCount from Flags

Author: teemperor Date: Mon Sep 16 11:02:49 2019 New Revision: 372018 URL: http://llvm.org/viewvc/llvm-project?rev=372018=rev Log: [lldb] Remove SetCount/ClearCount from Flags Summary: These functions are only used in tests where we should test the actual flag values instead of counting all

[Lldb-commits] [PATCH] D67540: [lldb] Remove SetCount/ClearCount from Flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL372018: [lldb] Remove SetCount/ClearCount from Flags (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r372017 - [lldb][NFC] Make ApplyObjcCastHack less scary

Author: teemperor Date: Mon Sep 16 11:02:21 2019 New Revision: 372017 URL: http://llvm.org/viewvc/llvm-project?rev=372017=rev Log: [lldb][NFC] Make ApplyObjcCastHack less scary Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified:

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

clayborg added a comment. In D67390#1671463 , @kwk wrote: > @clayborg what address is it exactly to store here `std::map ContString> SymbolMapType;`? As an example > `dc_symbol.GetAddress().GetFileAddress()` is something that would work but as > soon as

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

clayborg added a comment. In D67390#1671463 , @kwk wrote: > @clayborg what address is it exactly to store here `std::map ContString> SymbolMapType;`? As an example > `dc_symbol.GetAddress().GetFileAddress()` is something that would work but as > soon as

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @clayborg what address is it exactly to store here `std::map SymbolMapType;`? As an example `dc_symbol.GetAddress().GetFileAddress()` is something that would work but as soon as we have minidebuginfo, then we might end having the same symbol coming from two different

[Lldb-commits] [PATCH] D67625: [lldb] [Process/gdb-remote] Fix defaulting signal to invalid in action list

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Fix processing of "C" packet with signal for the whole process to default signal value for action list to LLDB_INVALID_SIGNAL_NUMBER rather than 0. https://reviews.llvm.org/D67625 Files:

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

friss added a comment. In D67520#1670880 , @labath wrote: > This looks like a really useful feature. The code seems fine, but I am > wondering if we should really bail out when encountering a zero enumerator. > It is not uncommon to use a special

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

clayborg added inline comments. Comment at: lldb/source/API/SBCommandInterpreter.cpp:165-172 +SBCommandReturnObject sb_return; +std::swap(result, SBCommandReturnObject_ref(sb_return)); SBCommandInterpreter sb_interpreter(_interpreter); SBDebugger

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

clayborg added a comment. In D67390#1671128 , @kwk wrote: > In D67390#1671018 , @labath wrote: > > > In D67390#1667270 , @kwk wrote: > > > > > @labath how shall we go about

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

clayborg added a comment. In D67390#1671018 , @labath wrote: > In D67390#1667270 , @kwk wrote: > > > @labath how shall we go about this? We do have the situation that when you > > lookup a symbol you might find it

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. In D67390#1671018 , @labath wrote: > In D67390#1667270 , @kwk wrote: > > > @labath how shall we go about this? We do have the situation that when you > > lookup a symbol you might find it

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

labath added a comment. In D67390#1667270 , @kwk wrote: > @labath how shall we go about this? We do have the situation that when you > lookup a symbol you might find it twice if it is in `.dynsym` and in > `.symtab`. Shall I adjust the test expectation

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

labath added a reviewer: jingham. labath added a comment. + Jim for SB API. I ran into this quirk of SBCommandReturnObject a couple of weeks ago, and then ran away screaming. I agree that this approach isn't nice, but probably there isn't a nice approach to this at this point. One possibility

[Lldb-commits] [PATCH] D66654: 2/2: Process formatters in reverse-chronological order

labath accepted this revision. labath added a comment. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66654/new/ https://reviews.llvm.org/D66654 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

labath added a comment. Sorry for the delay, I was OOO. I haven't yet read through all of the discussion, but I wanted to plug into this part. In D67347#1669877 , @aleksandr.urakov wrote: > But there is one more reason that makes it very difficult to

[Lldb-commits] [lldb] r371962 - [test] Add -z separate-code to fix tests that ae sensitive to exact addresses after r371958

Author: maskray Date: Mon Sep 16 00:52:30 2019 New Revision: 371962 URL: http://llvm.org/viewvc/llvm-project?rev=371962=rev Log: [test] Add -z separate-code to fix tests that ae sensitive to exact addresses after r371958 Modified: lldb/trunk/lit/SymbolFile/DWARF/debug-types-address-ranges.s

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

labath added a comment. cool Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB Remote Packet into Utility. (NFC)

labath added a comment. *Maybe* this is fine for now, but I also don't like moving the gdb-remote reproducer stuff out of the gdb plugin. If you want an inspection command to access those (which sounds like a useful thing btw), then the right way to handle that would be to have some sort of an

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

MaskRay added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:9529 + // in `enum {A, B, ALL = A|B }` we visit ALL first. + std::stable_sort( + values.begin(), values.end(), [](const auto , const auto ) { You can simply sort by magnitude and

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

labath added a comment. This looks like a really useful feature. The code seems fine, but I am wondering if we should really bail out when encountering a zero enumerator. It is not uncommon to use a special enumerator to mean "none of the above". Lldb does that occasionally

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added inline comments. Comment at: lldb/lit/Modules/ELF/minidebuginfo-corrupt-xz.yaml:1 +# REQUIRES: system-linux, lzma + kwk wrote: > labath wrote: > > system-linux shouldn't be required here. One of the reasons I wanted to > > have these tests is that