[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb marked 3 inline comments as done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:244 + else() +set(LIBLLDB_SYMLINK_DEST "${liblldb_build_dir}/liblldb${CMAKE_SHARED_LIBRARY_SUFFIX}") + endif() tatyana-krasnukha wrote: > This command still

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224955. hhb added a comment. Oops fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224954. hhb added a comment. Fix the build for multi-config generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D68968: [android/process list] use arg0 as fallback for process name

wallace created this revision. wallace added reviewers: labath, clayborg, aadsm. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. In systems like android, there are cases in which a process name can correspond to a package name (e.g. com.test.app), which is not an

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 224949. wallace added a comment. Herald added a subscriber: jfb. address comments Btw, @labath, could you point me to a example of a full end to end test like the attach one you mention? I haven't been able to find it :( Repository: rG LLVM Github

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; labath wrote: >

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

This revision was automatically updated to reflect the committed changes. Closed by commit rGd04855f820c5: [lldb-server/android] Show more processes by relaxing some checks (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r374853 - [lldb-server/android] Show more processes by relaxing some checks

Author: wallace Date: Mon Oct 14 17:00:05 2019 New Revision: 374853 URL: http://llvm.org/viewvc/llvm-project?rev=374853=rev Log: [lldb-server/android] Show more processes by relaxing some checks By default `platform process list` only shows the processes of the current user that lldb-server can

[Lldb-commits] [lldb] r374852 - Revert "fix"

Author: wallace Date: Mon Oct 14 16:56:54 2019 New Revision: 374852 URL: http://llvm.org/viewvc/llvm-project?rev=374852=rev Log: Revert "fix" This reverts commit d8af64c9a0228301f6fd0e1c841e4abe0b6f4801. Modified: lldb/trunk/source/Host/linux/Host.cpp Modified:

[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added parent revisions: D68962: update ScriptInterpreterPython to use File, not FILE*, D68960: remove FILE* usage from SBStream.i. The SWIG

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

JDevlieghere added a comment. ping @sammccall CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham updated this revision to Diff 224929. jingham added a comment. Addressed Pavel's comments. I explicitly want the number of fixed arguments, so I changed the function name to GetNumFixedArguments. The docs say explicitly that you have to make the function take either three or four

[Lldb-commits] [PATCH] D68962: update ScriptInterpreterPython to use File, not FILE*

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. ScriptInterpreterPython needs to save and restore sys.stdout and friends when LLDB runs a python script. It currently does this using FILE*, which is not

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

shafik created this revision. shafik added reviewers: aprantl, teemperor. We add support for `DW_AT_export_symbols` to detect anonymous struct on top of the heuristics implemented in D66175 This should allow us to differentiate anonymous structs and unnamed

[Lldb-commits] [lldb] r374846 - fix

Author: wallace Date: Mon Oct 14 16:32:46 2019 New Revision: 374846 URL: http://llvm.org/viewvc/llvm-project?rev=374846=rev Log: fix Modified: lldb/trunk/source/Host/linux/Host.cpp Modified: lldb/trunk/source/Host/linux/Host.cpp URL:

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace updated this revision to Diff 224931. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index:

[Lldb-commits] [PATCH] D68960: remove FILE* usage from SBStream.i

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. This patch removes FILE* and replaces it with SBFile and FileSP the SWIG interface for `SBStream.i`. And this is the last one. With this change, nothing in

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

lawrence_danna updated this revision to Diff 224923. lawrence_danna added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68856/new/ https://reviews.llvm.org/D68856 Files:

[Lldb-commits] [PATCH] D68918: eliminate virtual methods from PythonDataObjects

lawrence_danna updated this revision to Diff 224924. lawrence_danna added a comment. rebased, and added in explicit default constructors for MSVC's sake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68918/new/ https://reviews.llvm.org/D68918

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna added a comment. @labath, how's this look now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68737/new/ https://reviews.llvm.org/D68737 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna updated this revision to Diff 224922. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68737/new/ https://reviews.llvm.org/D68737 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68918: eliminate virtual methods from PythonDataObjects

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:188-192 // PythonObject is implicitly convertible to PyObject *, which will call the // wrong overload. We

[Lldb-commits] [lldb] r374825 - build fix for SBInstruction.

Author: lawrence_danna Date: Mon Oct 14 14:51:02 2019 New Revision: 374825 URL: http://llvm.org/viewvc/llvm-project?rev=374825=rev Log: build fix for SBInstruction. oops! I cherry-picked rL374820 thinking it was completely independent of D68737, but it wasn't. It makes an incidental use of

[Lldb-commits] [PATCH] D68890: remove FILE* bindings from SBInstruction.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7a9115680e2: remove FILE* bindings from SBInstruction. (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68890/new/

[Lldb-commits] [lldb] r374820 - remove FILE* bindings from SBInstruction.

Author: lawrence_danna Date: Mon Oct 14 13:59:57 2019 New Revision: 374820 URL: http://llvm.org/viewvc/llvm-project?rev=374820=rev Log: remove FILE* bindings from SBInstruction. Summary: This patch replaces the FILE* python bindings for SBInstruction and SBInstructionList and replaces them with

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

This revision was automatically updated to reflect the committed changes. Closed by commit rG322f12afc367: remove FILE* usage from ReportEventState() and HandleProcessEvent() (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D68546?vs=224668=224895#toc

[Lldb-commits] [PATCH] D68853: uint32_t options -> File::OpenOptions options

This revision was automatically updated to reflect the committed changes. Closed by commit rG62c9fe4273e8: uint32_t options - File::OpenOptions options (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68853/new/

[Lldb-commits] [lldb] r374817 - uint32_t options -> File::OpenOptions options

Author: lawrence_danna Date: Mon Oct 14 13:15:34 2019 New Revision: 374817 URL: http://llvm.org/viewvc/llvm-project?rev=374817=rev Log: uint32_t options -> File::OpenOptions options Summary: This patch re-types everywhere that passes a File::OpenOptions as a uint32_t so it actually uses

[Lldb-commits] [lldb] r374816 - remove FILE* usage from ReportEventState() and HandleProcessEvent()

Author: lawrence_danna Date: Mon Oct 14 13:15:28 2019 New Revision: 374816 URL: http://llvm.org/viewvc/llvm-project?rev=374816=rev Log: remove FILE* usage from ReportEventState() and HandleProcessEvent() Summary: This patch adds FileSP and SBFile versions of the API methods ReportEventState and

[Lldb-commits] [PATCH] D68951: Fix test breakage caused by r374424

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5768e3d0e88: Fix test breakage caused by r374424 (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68951/new/

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

tatyana-krasnukha added a comment. F10259577: D68858d.diff @hhb, please, take a look. Slightly changed your patch to make it work for Visual Studio. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/

[Lldb-commits] [lldb] r374803 - Fix test breakage caused by r374424

Author: lawrence_danna Date: Mon Oct 14 11:53:27 2019 New Revision: 374803 URL: http://llvm.org/viewvc/llvm-project?rev=374803=rev Log: Fix test breakage caused by r374424 Summary: The build directory name is based on the test method name, so having two test methods with the same name in the

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

lawrence_danna added a comment. In D68738#1708159 , @stella.stamenova wrote: > This is still failing on the Windows bot. Please fix it ASAP or revert it. fix here https://reviews.llvm.org/D68951 Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D68951: Fix test breakage caused by r374424

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath, stella.stamenova. Herald added a project: LLDB. The build directory name is based on the test method name, so having two test methods with the same name in the same test file is a problem,

Re: [Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

Sorry, I'm OOO now. I'll take a look tomorrow, thanks for catching that! On Mon, 14 Oct 2019, 19:20 Stella Stamenova via Phabricator, < revi...@reviews.llvm.org> wrote: > stella.stamenova added a comment. > > In D67347#1706405 , > @stella.stamenova wrote:

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

bruno accepted this revision. bruno added a comment. This approach looks overall much better! Unless @sammccall has any extra comments, it LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 ___

[Lldb-commits] [PATCH] D68868: Fix build under musl

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Given that the `FILE` struct lives in `stdio.h` this makes sense. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68868/new/

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

lawrence_danna added a comment. In D68738#1708159 , @stella.stamenova wrote: > This is still failing on the Windows bot. Please fix it ASAP or revert it. Sorry,i didn’t see this. I’ll fix it today Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

stella.stamenova added a comment. This is still failing on the Windows bot. Please fix it ASAP or revert it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68738/new/ https://reviews.llvm.org/D68738

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

stella.stamenova added a comment. In D67347#1706405 , @stella.stamenova wrote: > It looks like this changed fixed at least one of the XFAILed tests on Windows: > > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9751 > > So now the test

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk added a comment. In D68943#1708068 , @MaskRay wrote: > This is not correct. A lot of yaml2obj tests fail with: > > > yaml2obj: error: unknown section referenced: '.symtab' by YAML section > > '.rela.text' @MaskRay I'm so sorry. You're absolutely

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

teemperor added a comment. So, are there any concerns about this (beside the typo which I'll fix pre-commit) and Shafik's request for documentation (which will be another NFC commit)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68130/new/ https://reviews.llvm.org/D68130

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

MaskRay added a comment. This is not correct. A lot of yaml2obj tests fail with: > yaml2obj: error: unknown section referenced: '.symtab' by YAML section > '.rela.text' The problem is that .symtab can be the sh_link field of relocation sections, .llvm_addrsig, and some sections that may be

[Lldb-commits] [PATCH] D68939: [LLDB] [PECOFF] Use a "pc" vendor name in aarch64 triples

mstorsjo added a comment. Removing line 928 in ArchSpec.cpp or changing it to unknown doesn't seem to help though, so apparently there's something else forcing a pc vendor as well, somewhere. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68939/new/

[Lldb-commits] [PATCH] D68868: Fix build under musl

teemperor added a reviewer: JDevlieghere. teemperor added a comment. (Adding Jonas because reproducers) Btw, you can just upload a diff to phabricator (e.g. the output you get with `git diff -U > fix-build.patch` when using the monorepo ) and that's

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

labath added a comment. Thanks. I think this is great. @grimar, do you have any more comments? Comment at: llvm/lib/ObjectYAML/MinidumpYAML.cpp:377-383 + // TODO: We could provide a reasonable default for ThreadContext by searching + // the Thread stream for a thread with

[Lldb-commits] [lldb] r374583 - make ConstString allocate memory in non-tiny chunks

Author: llunak Date: Fri Oct 11 12:34:39 2019 New Revision: 374583 URL: http://llvm.org/viewvc/llvm-project?rev=374583=rev Log: make ConstString allocate memory in non-tiny chunks BumpPtrAllocator allocates in 4KiB chunks, which with any larger project is going to result in a large number of

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet updated this revision to Diff 224857. JosephTremoulet marked 2 inline comments as done. JosephTremoulet added a comment. - Move test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68657/new/ https://reviews.llvm.org/D68657 Files:

[Lldb-commits] [lldb] r374776 - minidump: Use yaml for memory info tests

Author: labath Date: Mon Oct 14 07:16:39 2019 New Revision: 374776 URL: http://llvm.org/viewvc/llvm-project?rev=374776=rev Log: minidump: Use yaml for memory info tests Also, delete some minidump binary files that are no longer used in any test. Removed:

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

labath added inline comments. Comment at: llvm/unittests/ObjectYAML/MinidumpYAMLTest.cpp:310-316 + ASSERT_FALSE(ExpectedFile); + auto Unhandled = + handleErrors(ExpectedFile.takeError(), [](const StringError ) { +EXPECT_EQ(static_cast(std::errc::invalid_argument),

[Lldb-commits] [PATCH] D68939: [LLDB] [PECOFF] Use a "pc" vendor name in aarch64 triples

mstorsjo added a comment. In D68939#1708020 , @labath wrote: > In D68939#1707998 , @mstorsjo wrote: > > > In D68939#1707985 , @labath wrote: > > > > > Would you say that

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet marked 4 inline comments as done. JosephTremoulet added inline comments. Comment at: llvm/lib/ObjectYAML/MinidumpYAML.cpp:377-383 + // TODO: We could provide a reasonable default for ThreadContext by searching + // the Thread stream for a thread with the given

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath marked an inline comment as done. labath added inline comments. Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:291-295 + EntryIterator Absolute = + getAbsoluteLocations( + SectionedAddress{BaseAddr, SectionedAddress::UndefSection}, +

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224852. kwk added a comment. - moved test files over to llvm subtree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 Files:

[Lldb-commits] [PATCH] D68939: [LLDB] [PECOFF] Use a "pc" vendor name in aarch64 triples

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D68939#1707998 , @mstorsjo wrote: > In D68939#1707985 , @labath wrote: > > > Would you say that "pc" is a

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet updated this revision to Diff 224853. JosephTremoulet added a comment. - Remove TODO, lit-ify negative test and tighten check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68657/new/ https://reviews.llvm.org/D68657 Files:

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk marked an inline comment as done. kwk added a comment. Moved `yaml2obj` tests under llvm subtree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 ___

[Lldb-commits] [PATCH] D68939: [LLDB] [PECOFF] Use a "pc" vendor name in aarch64 triples

mstorsjo added a comment. In D68939#1707985 , @labath wrote: > Would you say that "pc" is a reasonable value for the "vendor" field for the > win+aarch64 combo? I am asking because I don't have a clue about that, and > given that this platform is being

[Lldb-commits] [PATCH] D68939: [LLDB] [PECOFF] Use a "pc" vendor name in aarch64 triples

labath added a comment. Would you say that "pc" is a reasonable value for the "vendor" field for the win+aarch64 combo? I am asking because I don't have a clue about that, and given that this platform is being brought up right now, changing this now would be way easier than doing it later.

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk planned changes to this revision. kwk added a comment. Move tests over to `llvm/llvm/test/ObjectYAML/ELF/`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

labath added reviewers: grimar, MaskRay, jhenderson. labath added a comment. +llvm yaml2obj folks. Thank you for creating this diff. Please see comments inline. Comment at: lldb/test/Shell/ObjectFile/ELF/no-symtab-generated.yaml:1 +# In this test we don't explicitly define a

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk marked an inline comment as done. kwk added inline comments. Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:379-380 // being a single SHT_SYMTAB section are upheld. - std::vector Symbols; + Optional> Symbols; std::vector DynamicSymbols; };

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224839. kwk added a comment. - restore formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 Files: lldb/test/Shell/ObjectFile/ELF/minidebuginfo-corrupt-xz.yaml

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk created this revision. kwk added a reviewer: labath. Herald added subscribers: llvm-commits, lldb-commits, MaskRay, hiraditya, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added projects: LLDB, LLVM. kwk updated this revision to Diff

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224838. kwk added a comment. - Silence FileCheck in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 Files:

[Lldb-commits] [lldb] r374769 - DWARFExpression: Fix/add support for (v4) debug_loc base address selection entries

Author: labath Date: Mon Oct 14 05:49:06 2019 New Revision: 374769 URL: http://llvm.org/viewvc/llvm-project?rev=374769=rev Log: DWARFExpression: Fix/add support for (v4) debug_loc base address selection entries The DWARFExpression is parsing the location lists in about five places. Of those,

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 register contexts

mstorsjo added a comment. In D67954#1707791 , @labath wrote: > Hard to say off-hand, but the first thing I'd check is whether the > information about loaded modules and their addresses is making its way into > lldb. You can use the "image list" command

[Lldb-commits] [PATCH] D68939: [LLDB] [PECOFF] Use a "pc" vendor name in aarch64 triples

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, aleksandr.urakov. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. This matches all other architectures listed in the same file. This fixes debugging aarch64 executables with

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 register contexts

mstorsjo added a comment. In D67954#1707791 , @labath wrote: > Thank you _very_ much for those tests. +@mgorny, in case he has any comments > on those. > > In D67954#1707292 , @mstorsjo wrote: > > > The tests pass

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

labath added inline comments. Comment at: llvm/lib/ObjectYAML/MinidumpYAML.cpp:394 + mapOptionalHex(IO, "Exception Address", Exception.ExceptionAddress, 0); + IO.mapOptional("Number Parameters", Exception.NumberParameters, + support::ulittle32_t(0u));

[Lldb-commits] [PATCH] D68918: eliminate virtual methods from PythonDataObjects

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, this definitely looks better. Ideally, I'd like to get rid of the `Reset` functions altogether, and just ensure we already create/return fully valid objects (probably via factory

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 register contexts

labath accepted this revision. labath added a reviewer: mgorny. labath added a comment. This revision is now accepted and ready to land. Thank you _very_ much for those tests. +@mgorny, in case he has any comments on those. In D67954#1707292 , @mstorsjo

[Lldb-commits] [PATCH] D68910: use LLVM_LIBDIR_SUFFIX for python lib path

labath added a reviewer: hhb. labath added a subscriber: hhb. labath added a comment. As @mgorny said, I'm afraid the solution is not going to be as simple as attaching LLVM_LIBDIR_SUFFIX to the lib path. There is some ongoing work to refactor/fix the way python paths are handled, but

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py:31 +# which is not necessarily the order on the screen.) +self.child.timeout = 2 +self.child.send("s") # step

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

labath added subscribers: lawrence_danna, labath. labath added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; In light of varargs

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D68546#1706424 , @lawrence_danna wrote: > Ok I'll just update it to go though `StreamFile` internally and leave the > decision of whether a

[Lldb-commits] [PATCH] D68853: uint32_t options -> File::OpenOptions options

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/common/File.cpp:42 -static const char *GetStreamOpenModeFromOptions(uint32_t options) { +static Expected

[Lldb-commits] [PATCH] D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users

labath added a comment. In D68662#1706316 , @wallace wrote: > will update the previous diff There's no need to do that now. It's just a thing to keep in mind for the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68874: [lldb] Fix offset intersection bug between MPX and AVX registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for doing this, and especially thank you for writing the test. For posterity: more discussion on this patch and the problem it solves can be found in https://reviews.llvm.org/D62931.