Re: [Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

I'm switching the default for at least the weekend via 60ab30ebce833c87bd4776f67cd9a82fe162ef9c / https://reviews.llvm.org/rG60ab30ebce83 so the bots aren't failing because of this, we can all look into this next week. I think the best solution is to get lldb to fall back to p/P if g/G are

[Lldb-commits] [lldb] 60ab30e - Temporarily change the default for use-g-packet-for-reading to false,

Author: Jason Molenda Date: 2019-11-08T18:21:57-08:00 New Revision: 60ab30ebce833c87bd4776f67cd9a82fe162ef9c URL: https://github.com/llvm/llvm-project/commit/60ab30ebce833c87bd4776f67cd9a82fe162ef9c DIFF: https://github.com/llvm/llvm-project/commit/60ab30ebce833c87bd4776f67cd9a82fe162ef9c.diff

Re: [Lldb-commits] [lldb] 2bbc4fd - Add a testcase for .dSYM path remapping dictionaries.

This is failing on GreenDragon, so I've reverted it. Can you please have a look on Monday? On Fri, Nov 8, 2019 at 2:07 PM Adrian Prantl via lldb-commits wrote: > > > Author: Adrian Prantl > Date: 2019-11-08T14:07:35-08:00 > New Revision: 2bbc4fdd8fa0ed58d610ab6260cb664c7cfef204 > > URL: >

[Lldb-commits] [lldb] 441a785 - Revert "Add a testcase for .dSYM path remapping dictionaries."

Author: Jonas Devlieghere Date: 2019-11-08T18:16:44-08:00 New Revision: 441a78533e61cfffb3fd59e2c169ca7ff7b286dc URL: https://github.com/llvm/llvm-project/commit/441a78533e61cfffb3fd59e2c169ca7ff7b286dc DIFF:

Re: [Lldb-commits] [lldb] 0877dd1 - [Driver] Force llvm to install its handlers before lldb's

> On Nov 8, 2019, at 1:17 AM, Pavel Labath wrote: > > On 08/11/2019 01:33, via lldb-commits wrote: >> Hey JF, Pavel, >> We're still seeing crashes due to SIGPIPE on some lldb bots. This workaround >> in the lldb driver is insufficient, because liblldb.dylib may install its >> own a fresh set

[Lldb-commits] [PATCH] D70037: Fix a regression in macOS-style path remapping.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Sorry for breaking this functionality & thank you for fixing it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70037/new/ https://reviews.llvm.org/D70037

[Lldb-commits] [PATCH] D70037: Fix a regression in macOS-style path remapping.

aprantl created this revision. aprantl added reviewers: JDevlieghere, labath, jasonmolenda. When we switched to the LLVM .debug_line parser, the .dSYM-style path remapping logic stopped working for relative paths because of how RemapSourceFile silently fails for relative paths. This patch both

Re: [Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

Hm, a follow-on problem is that there's some bug between debugserver and lldb with the g/G packets which is causing bot failures on macos systems. lldb has never used g/G before (if p/P was available) because debugserver seeds all of the GPR values with the stop packet (? aka Tnn) or with the

Re: [Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

Hey Jason, Sorry, I think I ended up accidentally dropping the verification in the final version ( https://github.com/llvm/llvm-project/blob/b1b70f6761266c3eecaf8bd71529eaf51994207b/lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp#L307). I had implemented

Re: [Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

A heads-up - lldb is failing to detect the case where the remote gdb RSP stub does not support the 'g' packet. I found this while doing some bare board debugging; g fails and doesn't fall back to fetching register values individually. I wrote a test TestNoGPacketSupported.py to show this

[Lldb-commits] [lldb] 1478f36 - Test case to verify that lldb falls back to p/P if g is unsupported

Author: Jason Molenda Date: 2019-11-08T15:57:54-08:00 New Revision: 1478f36f27cfe06c5da75ef11fab2d409f2beafe URL: https://github.com/llvm/llvm-project/commit/1478f36f27cfe06c5da75ef11fab2d409f2beafe DIFF: https://github.com/llvm/llvm-project/commit/1478f36f27cfe06c5da75ef11fab2d409f2beafe.diff

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

jingham added a comment. Why not have the FindFunctions lambda take a FunctionSP? It would be easy to get the Function name out of the function in the lambda, and that would make the function more general (and also match what the Foreach does... CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik added a comment. @aprantl you will want to take a second look at this, I did some major refactoring. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69913/new/ https://reviews.llvm.org/D69913 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik updated this revision to Diff 228533. shafik marked 6 inline comments as done. shafik added a comment. After updating branch the stepping test started failing. It was failing because the __invoke case was subtly broken in this patch. Fixing that case opened up a lot of refactoring

[Lldb-commits] [lldb] 2bbc4fd - Add a testcase for .dSYM path remapping dictionaries.

Author: Adrian Prantl Date: 2019-11-08T14:07:35-08:00 New Revision: 2bbc4fdd8fa0ed58d610ab6260cb664c7cfef204 URL: https://github.com/llvm/llvm-project/commit/2bbc4fdd8fa0ed58d610ab6260cb664c7cfef204 DIFF: https://github.com/llvm/llvm-project/commit/2bbc4fdd8fa0ed58d610ab6260cb664c7cfef204.diff

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:334 thread->SetStoppedByTrace(); SetState(StateType::eStateStopped, true); I presume that in this code path we land into a scenario that: 1.

[Lldb-commits] [PATCH] D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads

krytarowski added a comment. How does it deal with `security.models.extensions.user_set_dbregs`? If there is a handled error than it's fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70023/new/ https://reviews.llvm.org/D70023 ___

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:241 case TRAP_BRKPT: -for (const auto : m_threads) { - static_cast(*thread).SetStoppedByBreakpoint(); - FixupBreakpointPCAsNeeded(static_cast(*thread)); +

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Multithread support

mgorny abandoned this revision. mgorny added a comment. I'm going to upload a new series shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64647/new/ https://reviews.llvm.org/D64647 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Fix handling concurrent watchpoint events so that they are reported correctly in LLDB. If multiple watchpoints are hit concurrently, the NetBSD kernel reports them as series of SIGTRAPs with a thread specified, and the

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

mgorny created this revision. mgorny added reviewers: labath, krytarowski. mgorny added a child revision: D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads. Implement major improvements to multithreaded program support. Notably, support tracking new and exited threads,

[Lldb-commits] [PATCH] D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads

mgorny created this revision. mgorny added reviewers: labath, krytarowski. mgorny added a parent revision: D70022: [lldb] [Process/NetBSD] Improve threading support. NetBSD ptrace interface does not populate watchpoints to newly-created threads. Solve this via copying the watchpoints from the

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

smeenai added a comment. In D69931#1739063 , @beanz wrote: > It is a bit gross that Python does an @rpath install name, that is generally > against convention. I can see adding an option to add rpaths to liblldb > making sense. I certainly agree LLDB

[Lldb-commits] [PATCH] D70002: [lldb] Make Target* a Target& in CommandObjectExpression::DoExecute REPL logic

jingham added a comment. As long as target.GetREPL (..., true) returns a sensible error for the Dummy target, this is fine. Actually having the dummy target run the REPL seems like a bad idea, since that's a pretty heavy-weight activity and the dummy target is supposed to be just for priming

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

beanz added a comment. It is a bit gross that Python does an @rpath install name, that is generally against convention. I can see adding an option to add rpaths to liblldb making sense. I certainly agree LLDB shouldn't be in the business of packaging transitive dependencies. In a broader

[Lldb-commits] [lldb] 8204d9f - Properly propagate is_variadic.

Author: Adrian Prantl Date: 2019-11-08T09:53:51-08:00 New Revision: 8204d9ff7ef59bbec9137a5b6679718d03b9cb1b URL: https://github.com/llvm/llvm-project/commit/8204d9ff7ef59bbec9137a5b6679718d03b9cb1b DIFF: https://github.com/llvm/llvm-project/commit/8204d9ff7ef59bbec9137a5b6679718d03b9cb1b.diff

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm added a comment. That should work fine yeah. It should be a matter of adding `"@loader_path/../../../"` to the rpath. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69931/new/ https://reviews.llvm.org/D69931

[Lldb-commits] [lldb] 4d0e07f - [lldb] Make Asan/SIP workaround work for Python 3

Author: Jonas Devlieghere Date: 2019-11-08T09:19:56-08:00 New Revision: 4d0e07f7862b832fb49a466feb8046770ea5b792 URL: https://github.com/llvm/llvm-project/commit/4d0e07f7862b832fb49a466feb8046770ea5b792 DIFF:

[Lldb-commits] [lldb] 6b44a41 - [lldb] Prevent Asan/SIP workaround from affecting Python in /usr/local/bin

Author: Jonas Devlieghere Date: 2019-11-08T09:08:27-08:00 New Revision: 6b44a41fefc7a62a5024c64fb7453f5ee93f3bb6 URL: https://github.com/llvm/llvm-project/commit/6b44a41fefc7a62a5024c64fb7453f5ee93f3bb6 DIFF:

[Lldb-commits] [lldb] 454acae - Adapt LLDB to clang API change in ObjCMethodDecl::create().

Author: Adrian Prantl Date: 2019-11-08T08:59:22-08:00 New Revision: 454acae97ca4ad25cac582afe66c616ad46e4dd1 URL: https://github.com/llvm/llvm-project/commit/454acae97ca4ad25cac582afe66c616ad46e4dd1 DIFF: https://github.com/llvm/llvm-project/commit/454acae97ca4ad25cac582afe66c616ad46e4dd1.diff

[Lldb-commits] [lldb] cdc38c9 - [lldb] Skip parts of TestCallOverriddenMethod.py on Linux

Author: Raphael Isemann Date: 2019-11-08T15:55:02+01:00 New Revision: cdc38c93fa22f0bee1bd7b84a27c32abb4a3aba8 URL: https://github.com/llvm/llvm-project/commit/cdc38c93fa22f0bee1bd7b84a27c32abb4a3aba8 DIFF:

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. Hi Jan, This change has introduced a regression in 32bit arm linux testsuite with around 60 new test failures. Here are list of tests which are failing with this change. Mostly tests are

[Lldb-commits] [PATCH] D70002: [lldb] Make Target* a Target& in CommandObjectExpression::DoExecute REPL logic

teemperor created this revision. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D70002 Files: lldb/source/Commands/CommandObjectExpression.cpp Index: lldb/source/Commands/CommandObjectExpression.cpp

[Lldb-commits] [PATCH] D70002: [lldb] Make Target* a Target& in CommandObjectExpression::DoExecute REPL logic

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1bac4d1dae: [lldb] Make Target* a Target in CommandObjectExpression::DoExecute REPL logic (authored by teemperor).

[Lldb-commits] [lldb] 5a1bac4 - [lldb] Make Target* a Target& in CommandObjectExpression::DoExecute REPL logic

Author: Raphael Isemann Date: 2019-11-08T12:28:49+01:00 New Revision: 5a1bac4d1daee2bcbf13365a8254a26d242d8c46 URL: https://github.com/llvm/llvm-project/commit/5a1bac4d1daee2bcbf13365a8254a26d242d8c46 DIFF:

[Lldb-commits] [PATCH] D70001: [lldb][NFC] Refactor some IsClangType checks in ClangASTContext

teemperor created this revision. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. All type in these functions need be valid and Clang types, so we might as well replace these checks with IsClangType. Also lets IsClangType explicitly check for

[Lldb-commits] [PATCH] D70001: [lldb][NFC] Refactor some IsClangType checks in ClangASTContext

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG79b3cce7f143: [lldb][NFC] Refactor some IsClangType checks in ClangASTContext (authored by teemperor). Repository: rG

[Lldb-commits] [lldb] 79b3cce - [lldb][NFC] Refactor some IsClangType checks in ClangASTContext

Author: Raphael Isemann Date: 2019-11-08T12:03:28+01:00 New Revision: 79b3cce7f143ebcbc57a3c4599cbd7a1541a742b URL: https://github.com/llvm/llvm-project/commit/79b3cce7f143ebcbc57a3c4599cbd7a1541a742b DIFF:

Re: [Lldb-commits] [lldb] 0877dd1 - [Driver] Force llvm to install its handlers before lldb's

On 08/11/2019 01:33, via lldb-commits wrote: Hey JF, Pavel, We're still seeing crashes due to SIGPIPE on some lldb bots. This workaround in the lldb driver is insufficient, because liblldb.dylib may install its own a fresh set of llvm signal handlers (the `NumRegisteredSignals` global is not

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

labath added a reviewer: beanz. labath added a subscriber: beanz. labath added a comment. In D69931#1738097 , @smeenai wrote: > I agree on not getting into the business of installing Python ourselves, but > there's also the rpath issue. The Windows case