[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

JDevlieghere updated this revision to Diff 230353. JDevlieghere added a comment. Fix description for `one-line-on-crash` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70514/new/ https://reviews.llvm.org/D70514 Files: lldb/docs/CMakeLists.txt lldb/docs/conf.py lldb/docs/lldb.1

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

jingham added inline comments. Comment at: lldb/docs/man/lldb.rst:80 + When in batch mode, tells the debugger to source this file of lldb commands if the target crashes. + +.. option:: --one-line This is probably wrong in the lldb help too - copy paste most

[Lldb-commits] [PATCH] D70517: [lldb][DataFormatters] Support pretty printing std::string when built with -funsigned-char.

merge_guards_bot added a comment. Build result: pass - 60200 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

JDevlieghere updated this revision to Diff 230349. JDevlieghere added a comment. Update configuration file section. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70514/new/ https://reviews.llvm.org/D70514 Files: lldb/docs/CMakeLists.txt lldb/docs/conf.py

[Lldb-commits] [PATCH] D70517: [lldb][DataFormatters] Support pretty printing std::string when built with -funsigned-char.

rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere, shafik. Herald added subscribers: lldb-commits, christof. Herald added a project: LLDB. When built w/ `-funsigned-char`, `std::string` becomes equivalent to `std::basic_string`, causing these formatters to not

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

jingham added inline comments. Comment at: lldb/docs/man/lldb.rst:306 +started) will be read. + +SEE ALSO This isn't quite right. The actual rule is: If the lldb library is loaded into an executable called Foo, lldb will first look for ~/.lldbinit-Foo, and if

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

JDevlieghere updated this revision to Diff 230346. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Address Adrian's comments. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70514/new/ https://reviews.llvm.org/D70514 Files:

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Very nice! Comment at: lldb/docs/man/lldb.rst:16 + +:program:`lldb` is the command line interface for the LLDB debugger library. +:program:`lldb` can debug C, C++,

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

JDevlieghere updated this revision to Diff 230341. JDevlieghere added a comment. Fix inconsistent newlines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70514/new/ https://reviews.llvm.org/D70514 Files: lldb/docs/CMakeLists.txt lldb/docs/conf.py lldb/docs/lldb.1

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mgorny, aprantl, ted. Herald added a subscriber: abidh. Herald added a project: LLDB. JDevlieghere added a comment. Here's what the output looks like: https://reviews.llvm.org/P8170 $ ninja docs-lldb-man [1/1]

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

JDevlieghere added a comment. Here's what the output looks like: https://reviews.llvm.org/P8170 $ ninja docs-lldb-man [1/1] Generating man Sphinx documentation for lldb into "/Volumes/Jonas/llvm/build-ra/tools/lldb/docs/man" $ nroff -man

[Lldb-commits] [lldb] 25f33d8 - [Reproducer] Limit signals to macro define sin

Author: Jonas Devlieghere Date: 2019-11-20T14:28:37-08:00 New Revision: 25f33d8318a39673fea798b24faf68154c03fdc1 URL: https://github.com/llvm/llvm-project/commit/25f33d8318a39673fea798b24faf68154c03fdc1 DIFF:

[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

This revision was automatically updated to reflect the committed changes. Closed by commit rGf24ed3a05198: Handle the case where the g packet doesnt get all regs. lldb would silently… (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D70417?vs=230129=230334#toc

[Lldb-commits] [lldb] f24ed3a - Handle the case where the 'g' packet doesn't get all regs.

Author: Jason Molenda Date: 2019-11-20T14:15:08-08:00 New Revision: f24ed3a05198003ef2c76ead91019561a45d26b5 URL: https://github.com/llvm/llvm-project/commit/f24ed3a05198003ef2c76ead91019561a45d26b5 DIFF: https://github.com/llvm/llvm-project/commit/f24ed3a05198003ef2c76ead91019561a45d26b5.diff

[Lldb-commits] [lldb] b033745 - [Driver] Fix missing space in lldb --help output.

Author: Jonas Devlieghere Date: 2019-11-20T13:49:22-08:00 New Revision: b03374584d6878e1fe06868a1cc03c28cc547e88 URL: https://github.com/llvm/llvm-project/commit/b03374584d6878e1fe06868a1cc03c28cc547e88 DIFF:

[Lldb-commits] [lldb] 0ebb780 - [Docs] Fix Sphinx warning (treated as error)

Author: Jonas Devlieghere Date: 2019-11-20T13:49:22-08:00 New Revision: 0ebb7803e6ae4919c1c782cafecaec237664efe3 URL: https://github.com/llvm/llvm-project/commit/0ebb7803e6ae4919c1c782cafecaec237664efe3 DIFF:

[Lldb-commits] [lldb] c8dfe90 - [Reproducer] Generate LLDB reproducer on crash

Author: Jonas Devlieghere Date: 2019-11-20T13:14:16-08:00 New Revision: c8dfe907299e16aeb17175cb0896c17043fc7c81 URL: https://github.com/llvm/llvm-project/commit/c8dfe907299e16aeb17175cb0896c17043fc7c81 DIFF:

[Lldb-commits] [PATCH] D70474: [Reproducer] Generate LLDB reproducer on crash

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc8dfe907299e: [Reproducer] Generate LLDB reproducer on crash (authored by JDevlieghere). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

davide accepted this revision. davide added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/D70393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] af331cb - [debugserver] Set arch based on TARGET_TRIPLE

Author: Vedant Kumar Date: 2019-11-20T12:12:47-08:00 New Revision: af331cbe14e8376c696441bb4c26a68be733b884 URL: https://github.com/llvm/llvm-project/commit/af331cbe14e8376c696441bb4c26a68be733b884 DIFF: https://github.com/llvm/llvm-project/commit/af331cbe14e8376c696441bb4c26a68be733b884.diff

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

davide added a comment. commit 6f4398d1b9950d48ead91b2b550792f2bbe4778e (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Nov 20 12:27:26 2019 -0800 [lldb] Fix NSURL data formatter truncation issue Remove hardcoded string prefix length

[Lldb-commits] [PATCH] D70474: [Reproducer] Generate LLDB reproducer on crash

vsk added a comment. This looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70474/new/ https://reviews.llvm.org/D70474 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

amccarth updated this revision to Diff 230303. amccarth marked an inline comment as done. amccarth added a comment. Reverted unintended change caught by reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70458/new/ https://reviews.llvm.org/D70458 Files:

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

amccarth marked 2 inline comments as done. amccarth added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4059 if (!module_spec.GetFileSpec() && !module_spec.GetPlatformFileSpec()) - module_spec.GetFileSpec().GetFilename() =

[Lldb-commits] [PATCH] D70474: [Reproducer] Generate LLDB reproducer on crash

JDevlieghere updated this revision to Diff 230288. JDevlieghere added a comment. Update the tests with uppercase signal names CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70474/new/ https://reviews.llvm.org/D70474 Files: lldb/include/lldb/API/SBReproducer.h

[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

jasonmolenda marked an inline comment as done. jasonmolenda added a comment. Thanks for looking this over Pavel. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:215 +struct RegisterInfo *reginfo =

[Lldb-commits] [PATCH] D70474: [Reproducer] Generate LLDB reproducer on crash

JDevlieghere updated this revision to Diff 230286. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70474/new/ https://reviews.llvm.org/D70474 Files:

[Lldb-commits] [PATCH] D70415: Complete complete types early when importing types from Clang module DWARF.

aprantl added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70415/new/ https://reviews.llvm.org/D70415 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] c502bae - [lldb][NFC] Simplify ClangASTContext::GetBasicTypes

Author: Raphael Isemann Date: 2019-11-20T12:47:14+01:00 New Revision: c502bae52410c83947e5ad7184dff810083afe75 URL: https://github.com/llvm/llvm-project/commit/c502bae52410c83947e5ad7184dff810083afe75 DIFF:

Re: [Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

On Wed, 20 Nov 2019 11:57:46 +0100, Omair Javaid wrote: > I am running Arm and AArch64 tests on docker containers running Ubuntu > Xenial. Could you run it outside of the docker if the problem still happens? Could you suggests which variant should I try? There are many:

[Lldb-commits] [lldb] 51ad025 - [lldb][NFC] Move searching for $__lldb_objc_class into its own function

Author: Raphael Isemann Date: 2019-11-20T16:10:24+01:00 New Revision: 51ad025ff313804674b4fb01f56f7b83e3ecc5e3 URL: https://github.com/llvm/llvm-project/commit/51ad025ff313804674b4fb01f56f7b83e3ecc5e3 DIFF:

[Lldb-commits] [lldb] 54b86b0 - [lldb][NFC] Remove unused ClangASTContext::GetUnknownAnyType

Author: Raphael Isemann Date: 2019-11-20T13:07:43+01:00 New Revision: 54b86b010bf52ae3f1c5499e38dc8ea52e17a9f2 URL: https://github.com/llvm/llvm-project/commit/54b86b010bf52ae3f1c5499e38dc8ea52e17a9f2 DIFF:

[Lldb-commits] [lldb] c34478f - [lldb][NFC] Move ClangExpressionDeclMap's persistent decl search into its own function

Author: Raphael Isemann Date: 2019-11-20T14:17:35+01:00 New Revision: c34478f5f6c7ef1ae8fb3605fbdec0634d543fed URL: https://github.com/llvm/llvm-project/commit/c34478f5f6c7ef1ae8fb3605fbdec0634d543fed DIFF:

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya updated this revision to Diff 230251. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/D70393 Files: lldb/source/Plugins/Language/ObjC/Cocoa.cpp Index: lldb/source/Plugins/Language/ObjC/Cocoa.cpp

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya updated this revision to Diff 230248. poya added a comment. Remove helper function Hardcode quote character to " with assert to catch future changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/D70393 Files:

[Lldb-commits] [lldb] 02e9113 - [lldb][NFC] Remove ClangASTContext::FieldIsBitfield overload

Author: Raphael Isemann Date: 2019-11-20T12:15:25+01:00 New Revision: 02e9113665602ca3a4b987a78db7147a648766d1 URL: https://github.com/llvm/llvm-project/commit/02e9113665602ca3a4b987a78db7147a648766d1 DIFF:

[Lldb-commits] [lldb] e7cc833 - [lldb][NFC] Move searching for $__lldb_class into its own function in ClangExpressionDeclMap

Author: Raphael Isemann Date: 2019-11-20T15:12:31+01:00 New Revision: e7cc833ddafdca10be4ef1322ab96ffee774045b URL: https://github.com/llvm/llvm-project/commit/e7cc833ddafdca10be4ef1322ab96ffee774045b DIFF:

[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good to me Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:215-220 +if (reginfo->byte_offset + reginfo->byte_size +

Re: [Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

I am running Arm and AArch64 tests on docker containers running Ubuntu Xenial. Underlying hardware is Thunder X1 or D05 machines. On Tue, 19 Nov 2019, 3:31 pm Jan Kratochvil via Phabricator, < revi...@reviews.llvm.org> wrote: > jankratochvil added a comment. > > @omjavaid I guess it depends on

[Lldb-commits] [PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1f95a6e077: Reland [clang] Remove the DIFlagArgumentNotModified debug info flag (authored by djtodoro). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D70474: [Reproducer] Generate LLDB reproducer on crash

labath added a comment. I think this looks pretty good. This is going to do a _lot_ of work in the signal handler, which may or may not work. However, at the point when this code gets invoked, we're already in undefined behavior territory anyway, so we might as well give it a shot. The dumping

[Lldb-commits] [lldb] ce1f95a - Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag"

Author: Djordje Todorovic Date: 2019-11-20T10:08:07+01:00 New Revision: ce1f95a6e077693f93d8869245f911aff3eb7e4c URL: https://github.com/llvm/llvm-project/commit/ce1f95a6e077693f93d8869245f911aff3eb7e4c DIFF:

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4059 if (!module_spec.GetFileSpec() && !module_spec.GetPlatformFileSpec()) - module_spec.GetFileSpec().GetFilename() = symbol_fspec.GetFilename(); +