[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

omjavaid updated this revision to Diff 232501. omjavaid added a comment. Hi I have updated this patch after incorporating previous suggestions like moving InvalidateAllRegisters declaration to NativeRegisterContextLinux and also relocated calls to InvalidateAllRegisters from NativeProcessLinux

[Lldb-commits] [lldb] 51ce067 - [lldb] NFC: less nesting in SearchFilter.cpp

Author: Konrad Kleine Date: 2019-12-06T08:38:33+01:00 New Revision: 51ce067a442ee6381527b12d113f51906b0245a8 URL: https://github.com/llvm/llvm-project/commit/51ce067a442ee6381527b12d113f51906b0245a8 DIFF: https://github.com/llvm/llvm-project/commit/51ce067a442ee6381527b12d113f51906b0245a8.diff

[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

kwk requested review of this revision. kwk marked 2 inline comments as done. kwk added a comment. Addressed all review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71022/new/ https://reviews.llvm.org/D71022

[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

kwk updated this revision to Diff 232494. kwk added a comment. - Review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71022/new/ https://reviews.llvm.org/D71022 Files: lldb/source/Core/SearchFilter.cpp Index:

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere added a comment. This patch is still missing a test and could use another pass over the `PacketRecorder` and `ProcessGDBRemoteProvider` to eliminate code duplication with `DataRecorder` and the `CommandProvider` on which they're based respectively. I wasn't able to get around to

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: abidh. Herald added a project: LLDB. When running the test suite with always capture on, a handful of tests are failing because they have multiple targets and therefore multiple GDB remote

[Lldb-commits] [PATCH] D71099: [lldb][test] Handle .categories lookup for inline tests.

merge_guards_bot added a comment. Build result: pass - 60539 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[Lldb-commits] [PATCH] D71099: [lldb][test] Handle .categories lookup for inline tests.

rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When creating a test with `lldbinline.MakeInlineTest()`, the reported `inspect.getfile(test.__class__)` is `lldbtest.pyc`, meaning any

[Lldb-commits] [lldb] 0d236d8 - [lldb] Update hardcoded Makefile.rules inclusions.

Author: Jordan Rupprecht Date: 2019-12-05T15:50:03-08:00 New Revision: 0d236d8b4f8aecc258e26ad53755a39d9b76032e URL: https://github.com/llvm/llvm-project/commit/0d236d8b4f8aecc258e26ad53755a39d9b76032e DIFF:

[Lldb-commits] [PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

rupprecht added a comment. In D70622#1771601 , @rupprecht wrote: > In D70622#1765674 , @JDevlieghere > wrote: > > > No objections to moving the test. Jordan, let me know if you're up for it, > > otherwise I'm

[Lldb-commits] [PATCH] D70883: [vscode.py] Make read_packet only return None when EOF

aadsm abandoned this revision. aadsm added a comment. Fair enough, I haven't seen evidence of this (haven't searched for it) but I imagine IDEs need to ignore this as well otherwise they just barf if they're expecting `Content-Length` and a wild print appears. The notion of stdout of

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

clayborg accepted this revision. clayborg added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71003/new/ https://reviews.llvm.org/D71003 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

rupprecht added a comment. In D70622#1765674 , @JDevlieghere wrote: > No objections to moving the test. Jordan, let me know if you're up for it, > otherwise I'm happy to take care of it. I tried moving it today. The rabbit hole goes deep :D The test

[Lldb-commits] [PATCH] D70992: Replacing to use of ul suffix in GetMaxU64Bitfield since it not guarenteed to be 64 bit

This revision was automatically updated to reflect the committed changes. Closed by commit rGfffd70291e12: [LLDB] Replacing use of ul suffix in GetMaxU64Bitfield since it not guarenteed… (authored by shafik). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D71052: [lldb][NFC] Move Address and AddressRange functions out of Stream and let them take raw_ostream

This revision was automatically updated to reflect the committed changes. Closed by commit rG1462f5a4c138: [lldb][NFC] Move Address and AddressRange functions out of Stream and let them… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1462f5a - [lldb][NFC] Move Address and AddressRange functions out of Stream and let them take raw_ostream

Author: Raphael Isemann Date: 2019-12-05T14:41:33+01:00 New Revision: 1462f5a4c138bb20f38a579a29d12ab4e5fb6191 URL: https://github.com/llvm/llvm-project/commit/1462f5a4c138bb20f38a579a29d12ab4e5fb6191 DIFF:

[Lldb-commits] [PATCH] D71052: [lldb][NFC] Move Address and AddressRange functions out of Stream and let them take raw_ostream

teemperor updated this revision to Diff 232322. teemperor marked an inline comment as done. teemperor added a comment. - Moved to format_hex. - Removed a now failing part of StreamTest that tested printing an address on a 160 bit system (which LLDB doesn't support yet). CHANGES SINCE LAST

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

labath added inline comments. Comment at: lldb/include/lldb/Expression/DWARFExpression.h:260 - bool GetLocation(lldb::addr_t func_load_addr, lldb::addr_t pc, - lldb::offset_t , lldb::offset_t ); + void RelocateLowHighPC(lldb::addr_t load_function_start,

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

labath updated this revision to Diff 232319. labath marked 10 inline comments as done. labath added a comment. - "inline" RelocateLowHighPC - add some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71003/new/

[Lldb-commits] [PATCH] D71056: [lldb] Add a test for how we lazily create Clang AST nodes

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. One of the ways we try to make LLDB faster is by only creating the Clang declarations (and loading the associated types) when we

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

labath added inline comments. Comment at: lldb/CMakeLists.txt:114 + COMMAND ${CMAKE_COMMAND} -E make_directory ${ARG_DEST_DIR}) +foreach(src_file ${ARG_FILES}) + if(ARG_DEST_FILE_NAME) tatyana-krasnukha wrote: > This is quite off-topic, but it

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

labath added inline comments. Comment at: lldb/source/Symbol/ObjectFile.cpp:480-486 + size_t ret = data.SetData(m_data, offset, length); + // DataExtractor::SetData copies the address byte size from m_data, but + // m_data's address byte size is only set from sizeof(void*),

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

tatyana-krasnukha added inline comments. Comment at: lldb/CMakeLists.txt:114 + COMMAND ${CMAKE_COMMAND} -E make_directory ${ARG_DEST_DIR}) +foreach(src_file ${ARG_FILES}) + if(ARG_DEST_FILE_NAME) This is quite off-topic, but it would be great if

[Lldb-commits] [PATCH] D71021: [lldb/DWARF] Switch to llvm debug_rnglists parser

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5767e284bea: [lldb/DWARF] Switch to llvm debug_rnglists parser (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71021/new/

[Lldb-commits] [lldb] f5767e2 - [lldb/DWARF] Switch to llvm debug_rnglists parser

Author: Pavel Labath Date: 2019-12-05T13:02:03+01:00 New Revision: f5767e284beaff4e5eb35f0f64270a070b47f6d3 URL: https://github.com/llvm/llvm-project/commit/f5767e284beaff4e5eb35f0f64270a070b47f6d3 DIFF: https://github.com/llvm/llvm-project/commit/f5767e284beaff4e5eb35f0f64270a070b47f6d3.diff

[Lldb-commits] [PATCH] D71052: [lldb][NFC] Move Address and AddressRange functions out of Stream and let them take raw_ostream

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Let's ship it. Comment at: lldb/source/Utility/Stream.cpp:88 + std::string f = "{0}0x{2,0+" + size + ":x-}{3}"; + s << llvm::formatv(f.c_str(), prefix, addr_size * 2,

[Lldb-commits] [PATCH] D70721: [lldb/cpluspluslanguage] Add constructor substitutor

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rGc16f0b18c13e: [lldb/cpluspluslanguage] Add constructor substitutor (authored by labath). Changed prior to commit:

[Lldb-commits] [PATCH] D70721: [lldb/cpluspluslanguage] Add constructor substitutor

labath marked 3 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:352 + void appendUnchangedInput() { +Result += llvm::StringRef(Written, this->First - Written); +Written = this->First;

[Lldb-commits] [lldb] c16f0b1 - [lldb/cpluspluslanguage] Add constructor substitutor

Author: Pavel Labath Date: 2019-12-05T12:44:51+01:00 New Revision: c16f0b18c13e88fedaa510bc2442bb693a6230c8 URL: https://github.com/llvm/llvm-project/commit/c16f0b18c13e88fedaa510bc2442bb693a6230c8 DIFF: https://github.com/llvm/llvm-project/commit/c16f0b18c13e88fedaa510bc2442bb693a6230c8.diff

[Lldb-commits] [PATCH] D71052: [lldb][NFC] Move Address and AddressRange functions out of Stream and let them take raw_ostream

teemperor updated this revision to Diff 232301. teemperor retitled this revision from "[lldb][NFC] Move Address and AddressRange functions out of Stream into namespace and let them take raw_ostream" to "[lldb][NFC] Move Address and AddressRange functions out of Stream and let them take

[Lldb-commits] [PATCH] D71052: [lldb][NFC] Move Address and AddressRange functions out of Stream and let them take raw_ostream

teemperor marked 2 inline comments as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/import-std-module/vector-basic/TestBasicVector.py:23-53 -self.expect("expr (size_t)a.size()", substrs=['(size_t) $0 = 3']) -

[Lldb-commits] [PATCH] D70954: [lldb] Don't put compile unit name into the support file list and support DWARF5 line tables

This revision was automatically updated to reflect the committed changes. Closed by commit rG57f8a998ceaf: [lldb] Dont put compile unit name into the support file list and support… (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 57f8a99 - [lldb] Don't put compile unit name into the support file list and support DWARF5 line tables

Author: Pavel Labath Date: 2019-12-05T11:37:18+01:00 New Revision: 57f8a998ceaf36e021878e8810bb57a00452c07d URL: https://github.com/llvm/llvm-project/commit/57f8a998ceaf36e021878e8810bb57a00452c07d DIFF: https://github.com/llvm/llvm-project/commit/57f8a998ceaf36e021878e8810bb57a00452c07d.diff

[Lldb-commits] [PATCH] D71052: [lldb][NFC] Move Address and AddressRange functions out of Stream into namespace and let them take raw_ostream

labath added a comment. All our namespace names are `snake_case`, so this new namespace should be too. Though, honestly, I don't think this needs to be a namespace -- I'd probably just make the function names a bit more descriptive... Maybe DumpAddress/DumpAddressRange, to match the existing

[Lldb-commits] [PATCH] D71052: [lldb][NFC] Move Address and AddressRange functions out of Stream into namespace and let them take raw_ostream

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Yet another step on the long road towards getting rid of lldb's Stream class. We probably should just make this some kind of member of

[Lldb-commits] [lldb] 4b4ede4 - Reland "[LiveDebugValues] Introduce entry values of unmodified params"

Author: Djordje Todorovic Date: 2019-12-05T11:10:49+01:00 New Revision: 4b4ede440a2ad51b150cb913775eee76189aac38 URL: https://github.com/llvm/llvm-project/commit/4b4ede440a2ad51b150cb913775eee76189aac38 DIFF:

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b8185bb1b45: Avoid triple corruption while merging core info (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70155/new/

[Lldb-commits] [lldb] 8b8185b - Avoid triple corruption while merging core info

Author: Muhammad Omair Javaid Date: 2019-12-05T13:10:04+05:00 New Revision: 8b8185bb1b456e0ccf7b1ed1f00bc646853ab004 URL: https://github.com/llvm/llvm-project/commit/8b8185bb1b456e0ccf7b1ed1f00bc646853ab004 DIFF: