[Lldb-commits] [lldb] f5114f4 - [lldb/Reproducer] Disable test on Windows to unblock the bot.

2019-12-06 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2019-12-06T16:17:31-08:00 New Revision: f5114f4d575e7a901d41277997d0c10074aa1a4e URL: https://github.com/llvm/llvm-project/commit/f5114f4d575e7a901d41277997d0c10074aa1a4e DIFF:

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

2019-12-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Why don't we move the `lldbsuite` as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71151/new/ https://reviews.llvm.org/D71151 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

2019-12-06 Thread pre-merge checks [bot] via Phabricator via lldb-commits
merge_guards_bot added a comment. Build result: pass - 60563 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

2019-12-06 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, jfb, arphaman, atanasyan, mgrang, jrtc27, christof, kbarton, krytarowski, arichardson, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a reviewer: jfb.

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

2019-12-06 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This creates a separate LLDB_TEST_SRC var to match the existing LLDB_TEST var. LLDB_TEST points to the test framework, LLDB_TEST_SRC points to

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

2019-12-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 232653. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Address CR feedback. - Introduce `AbstractRecorder` to reuse code between the `PacketRecorder` and the `DataRecorder`. - Move GDB related reproducer code into

[Lldb-commits] [PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

2019-12-06 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht abandoned this revision. rupprecht added a comment. Officially abandoning this rG0d236d8b4f8aecc258e26ad53755a39d9b76032e - fixes makefiles when separated from `Makefile.rules`

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

2019-12-06 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb6f9d7b8fb2e: Cleanup and speedup NativeRegisterContextLinux_arm64 (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D69371?vs=232501=232586#toc

[Lldb-commits] [lldb] b6f9d7b - Cleanup and speedup NativeRegisterContextLinux_arm64

2019-12-06 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2019-12-06T22:18:57+05:00 New Revision: b6f9d7b8fb2eb6b78ac93ebd5ea4e36c04469285 URL: https://github.com/llvm/llvm-project/commit/b6f9d7b8fb2eb6b78ac93ebd5ea4e36c04469285 DIFF:

[Lldb-commits] [PATCH] D71099: [lldb][test] Handle .categories lookup for inline tests.

2019-12-06 Thread Jordan Rupprecht via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG03a242bd41ee: [lldb][test] Handle .categories lookup for inline tests. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71099/new/

[Lldb-commits] [lldb] 03a242b - [lldb][test] Handle .categories lookup for inline tests.

2019-12-06 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2019-12-06T08:36:23-08:00 New Revision: 03a242bd41ee49e17f8da96af9787d13e7ea2b93 URL: https://github.com/llvm/llvm-project/commit/03a242bd41ee49e17f8da96af9787d13e7ea2b93 DIFF:

[Lldb-commits] [PATCH] D71108: [LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing headers

2019-12-06 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo created this revision. mstorsjo added reviewers: labath, clayborg. Herald added a project: LLDB. If not set, the address byte size was implied to be the one of the host process. This allows reverting the functional change from 31087b2ae9154, since now PECOFF does the same as ELF and

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

2019-12-06 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment. In D70840#1767611 , @mstorsjo wrote: > In D70840#1767049 , @labath wrote: > > > In D70840#1767028 , @mstorsjo > > wrote: > > > > > In

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

2019-12-06 Thread Anton Kolesov via Phabricator via lldb-commits
anton.kolesov updated this revision to Diff 232512. anton.kolesov retitled this revision from "[lldb-vscode] Ensure that target matches the executable file" to "[lldb] Set executable module when adding modules to the Target". anton.kolesov edited the summary of this revision. anton.kolesov added

[Lldb-commits] [lldb] fc39b94 - [lldb][NFC] Move [SU]Int64ValueIsValidForByteSize to RegisterValue

2019-12-06 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2019-12-06T11:16:39+01:00 New Revision: fc39b94849c89843aebb210c5d9be9c48e2b43a6 URL: https://github.com/llvm/llvm-project/commit/fc39b94849c89843aebb210c5d9be9c48e2b43a6 DIFF:

[Lldb-commits] [lldb] f69f923 - [lldb/DWARF] Fix DW_AT_addr_base & DW_AT_low_pc interaction

2019-12-06 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2019-12-06T10:33:13+01:00 New Revision: f69f92344adaada1f8f3cfcd711037227432b062 URL: https://github.com/llvm/llvm-project/commit/f69f92344adaada1f8f3cfcd711037227432b062 DIFF: https://github.com/llvm/llvm-project/commit/f69f92344adaada1f8f3cfcd711037227432b062.diff

[Lldb-commits] [lldb] b6e2cf3 - [lldb][NFC] Remove ability to pass a custom printf format to DataExtractor::PutToLog

2019-12-06 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2019-12-06T10:27:45+01:00 New Revision: b6e2cf3270dab43dbc6ffad4695c5c14789bc5e5 URL: https://github.com/llvm/llvm-project/commit/b6e2cf3270dab43dbc6ffad4695c5c14789bc5e5 DIFF:

[Lldb-commits] [lldb] 5ee8e67 - [lldb/DWARF] Fix DW_AT_rnglists_base handling for dwo files

2019-12-06 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2019-12-06T10:26:52+01:00 New Revision: 5ee8e673135891072789f0f9bf14a5d82f0f8e01 URL: https://github.com/llvm/llvm-project/commit/5ee8e673135891072789f0f9bf14a5d82f0f8e01 DIFF: https://github.com/llvm/llvm-project/commit/5ee8e673135891072789f0f9bf14a5d82f0f8e01.diff

[Lldb-commits] [lldb] 777d1f7 - [lldb] Migrate VMRange::Dump to raw_ostream

2019-12-06 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2019-12-06T10:19:20+01:00 New Revision: 777d1f7272b52cbe372e7234a7247b189e416062 URL: https://github.com/llvm/llvm-project/commit/777d1f7272b52cbe372e7234a7247b189e416062 DIFF:

[Lldb-commits] [PATCH] D70722: [lldb/IRExecutionUnit] Stop searching based on demangled names

2019-12-06 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0d2472ff6f60: [lldb/IRExecutionUnit] Stop searching based on demangled names (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70722/new/

[Lldb-commits] [lldb] 0d2472f - [lldb/IRExecutionUnit] Stop searching based on demangled names

2019-12-06 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2019-12-06T10:17:49+01:00 New Revision: 0d2472ff6f604af842059d9a0098db274515a2d3 URL: https://github.com/llvm/llvm-project/commit/0d2472ff6f604af842059d9a0098db274515a2d3 DIFF: https://github.com/llvm/llvm-project/commit/0d2472ff6f604af842059d9a0098db274515a2d3.diff

[Lldb-commits] [lldb] 6e1f317 - [lldb/DWARF] Remove DWARFDebugRangesBase abstract class

2019-12-06 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2019-12-06T10:15:46+01:00 New Revision: 6e1f3170e061b16c9096a769508f0a6d7eb95b9c URL: https://github.com/llvm/llvm-project/commit/6e1f3170e061b16c9096a769508f0a6d7eb95b9c DIFF: https://github.com/llvm/llvm-project/commit/6e1f3170e061b16c9096a769508f0a6d7eb95b9c.diff

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

2019-12-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h:32 + // Invalidates cached values in register context data structures + virtual void InvalidateAllRegisters(){}; + no semicolon here CHANGES SINCE LAST

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

2019-12-06 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this looks good now. Thanks for your patience. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69371/new/ https://reviews.llvm.org/D69371

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

2019-12-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Looks pretty straight-forward, but I am still not happy about how more and more of ProcessGDBRemote is infiltrating its way into the Utility module. I think that the reproducer code specific to gdb-remote should live next to the code it's capturing, and

[Lldb-commits] [lldb] 4dac97e - [lldb][NFC] Migrate FileSpec::Dump to raw_ostream

2019-12-06 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2019-12-06T09:40:42+01:00 New Revision: 4dac97eb1e6563750e682e482e68f29ac076a4f7 URL: https://github.com/llvm/llvm-project/commit/4dac97eb1e6563750e682e482e68f29ac076a4f7 DIFF:

[Lldb-commits] [PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

2019-12-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thanks for looking into this, Jordan. I'm not sure how hard it is, but I think it would be nice to not have the actual tests intermingled with the test framework stuff. (Also, another reason for moving the tests is that the symlink trick will just not work on windows.)

[Lldb-commits] [PATCH] D70883: [vscode.py] Make read_packet only return None when EOF

2019-12-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D70883#1771686 , @aadsm wrote: > Fair enough, I haven't seen evidence of this (haven't searched for it) but I > imagine IDEs need to ignore this as well otherwise they just barf if they're > expecting `Content-Length` and a