[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71237/new/ https://reviews.llvm.org/D71237 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

mib updated this revision to Diff 233473. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71237/new/ https://reviews.llvm.org/D71237 Files: lldb/docs/use/formatting.rst lldb/include/lldb/Core/FormatEntity.h lldb/source/Core/FormatEntity.cpp lldb/test/Shell/Settings/Inputs/main.cpp

[Lldb-commits] [PATCH] D71380: [lldb/CMake] Rename LLDB_DISABLE_LIBEDIT to LLDB_ENABLE_LIBEDIT

JDevlieghere created this revision. JDevlieghere added reviewers: labath, xiaobai, mgorny. Herald added subscribers: abidh, krytarowski. Herald added a project: LLDB. JDevlieghere added a parent revision: D71377: [lldb/CMake] Rename LLDB_DISABLE_CURSES to LLDB_ENABLE_CURSES. This matches the

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg added a comment. Current output. F11025690: image.png F11025692: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg updated this revision to Diff 233470. mossberg added a comment. Output return address in logging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/ https://reviews.llvm.org/D71372 Files: lldb/source/Target/ThreadPlanStepOut.cpp

[Lldb-commits] [PATCH] D71379: lldbutil: Forward ASan launch info to test inferiors

vsk created this revision. vsk added reviewers: davide, jingham. vsk edited the summary of this revision. This allows an unsanitized test process which loads a sanitized DSO (the motivating example is a Swift runtime dylib) to launch on Darwin. rdar://57290132 https://reviews.llvm.org/D71379

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

jingham added a comment. Please do print out the return address in the log. That will be helpful. The LLDB_LOG* macros check the log for you. They are convenient if the thing you are going to log happen in one step. If you need to do some more logic when gathering up the log message and

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg updated this revision to Diff 233466. mossberg added a comment. Remove lingering Section.h include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/ https://reviews.llvm.org/D71372 Files: lldb/source/Target/ThreadPlanStepOut.cpp

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

mib updated this revision to Diff 233465. mib added a comment. Run clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71237/new/ https://reviews.llvm.org/D71237 Files: lldb/docs/use/formatting.rst lldb/include/lldb/Core/FormatEntity.h lldb/source/Core/FormatEntity.cpp

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

mib updated this revision to Diff 233464. mib added a comment. Simplifying the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71237/new/ https://reviews.llvm.org/D71237 Files: lldb/docs/use/formatting.rst

[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

shafik created this revision. shafik added reviewers: martong, teemperor. Herald added a subscriber: rnkovacs. This fix was motivated by a crashes in expression parsing during code generation in which we had a `RecordDecl` that had incomplete `FieldDecl`. During code generation when computing

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

mib updated this revision to Diff 233463. mib marked 5 inline comments as done. mib added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71237/new/ https://reviews.llvm.org/D71237 Files: lldb/docs/use/formatting.rst

[Lldb-commits] [PATCH] D71377: [lldb/CMake] Rename LLDB_DISABLE_CURSES to LLDB_ENABLE_CURSES

JDevlieghere updated this revision to Diff 233456. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71377/new/ https://reviews.llvm.org/D71377 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/docs/resources/build.rst lldb/include/lldb/Host/Config.h.cmake

[Lldb-commits] [PATCH] D71377: [lldb/CMake] Rename LLDB_DISABLE_CURSES to LLDB_ENABLE_CURSES

JDevlieghere created this revision. JDevlieghere added reviewers: labath, xiaobai, mgorny. Herald added a subscriber: abidh. Herald added a project: LLDB. JDevlieghere updated this revision to Diff 233456. This matches the naming scheme used by LLVM. https://reviews.llvm.org/D71377 Files:

[Lldb-commits] [PATCH] D71376: [lldb][dotest] Add `#include ` to libc++ detection

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60743 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[Lldb-commits] [lldb] ff82315 - [lldb/CMake] Simplify linking against curses

Author: Jonas Devlieghere Date: 2019-12-11T14:36:32-08:00 New Revision: ff82315d4ec0fc96a8c581e1c9252a15bc0adaf3 URL: https://github.com/llvm/llvm-project/commit/ff82315d4ec0fc96a8c581e1c9252a15bc0adaf3 DIFF:

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:859 +p = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True) +

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg added a comment. Something I noticed while updating the patch was that the `GetLoadedAddressPermissions` call would succeed, even if passed an address that is obviously not mapped. In my test case I placed an int 0x22 where the return address would be, expecting the validation to fail

[Lldb-commits] [lldb] bf68bcb - [lldb/Host] Use Host/Config.h for LibXML2 instead of a global define

Author: Jonas Devlieghere Date: 2019-12-11T14:13:41-08:00 New Revision: bf68bcb920ffdac5da8b82cd06535cec5dc5a56b URL: https://github.com/llvm/llvm-project/commit/bf68bcb920ffdac5da8b82cd06535cec5dc5a56b DIFF:

[Lldb-commits] [PATCH] D71376: [lldb][dotest] Add `#include ` to libc++ detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG786b6db8e6fd: [lldb][dotest] Add `#include algorithm` to libc++ detection (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71376/new/

[Lldb-commits] [PATCH] D71376: [lldb][dotest] Add `#include ` to libc++ detection

rupprecht created this revision. rupprecht added a reviewer: echristo. Herald added a reviewer: EricWF. Herald added subscribers: lldb-commits, ldionne. Herald added a project: LLDB. echristo accepted this revision. This revision is now accepted and ready to land. Speculative fix after

[Lldb-commits] [lldb] 786b6db - [lldb][dotest] Add `#include ` to libc++ detection

Author: Jordan Rupprecht Date: 2019-12-11T14:06:14-08:00 New Revision: 786b6db8e6fd87fb82f2ad3e94e20c5c9cf9c4e4 URL: https://github.com/llvm/llvm-project/commit/786b6db8e6fd87fb82f2ad3e94e20c5c9cf9c4e4 DIFF:

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

JDevlieghere added inline comments. Comment at: lldb/source/Core/FormatEntity.cpp:1763 + return false; +else { + s.PutCString(name); No else after return Comment at: lldb/source/Core/FormatEntity.cpp:1768 +Block

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg added a comment. Here are a few screenshots of what the bug looks like: Memory corruption leading to a "crash": F11025392: image.png Silent memory corruption: F11025394: lldbbug.png Repository: rG LLVM Github

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG34ef51b5f979: [lldb][dotest] Improve libc++ detection (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71319/new/

[Lldb-commits] [lldb] 34ef51b - [lldb][dotest] Improve libc++ detection

Author: Jordan Rupprecht Date: 2019-12-11T13:38:05-08:00 New Revision: 34ef51b5f97933ba12d857d2da8b0d7c133320ce URL: https://github.com/llvm/llvm-project/commit/34ef51b5f97933ba12d857d2da8b0d7c133320ce DIFF:

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg marked 2 inline comments as done. mossberg added inline comments. Comment at: lldb/source/Target/ThreadPlanStepOut.cpp:127-129 +if (!return_address_section) { + LLDB_LOGF(log, "Return address had no section."); + return; clayborg wrote: >

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg updated this revision to Diff 233442. mossberg added a comment. Updated to get permissions information from the Process rather than the Section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/ https://reviews.llvm.org/D71372

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

aprantl added a comment. In D71310#1780219 , @jingham wrote: > Would you mind adding a mention on the Projects page? This was a neat idea > and realistically if it just sits in git, in a few months no one will > remember it's there. Done.

[Lldb-commits] [lldb] 0ca0fba - Add resurrecting Type Validators to projects.rst

Author: Adrian Prantl Date: 2019-12-11T13:30:05-08:00 New Revision: 0ca0fba94d48959a8c5d1e074c8242e46b263d59 URL: https://github.com/llvm/llvm-project/commit/0ca0fba94d48959a8c5d1e074c8242e46b263d59 DIFF: https://github.com/llvm/llvm-project/commit/0ca0fba94d48959a8c5d1e074c8242e46b263d59.diff

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Target/ThreadPlanStepOut.cpp:127-129 +if (!return_address_section) { + LLDB_LOGF(log, "Return address had no section."); +

[Lldb-commits] [lldb] 6d64162 - return-object-by-reference ("non trivial") xfail on arm64 in TestTrivialABI.py

Author: Jason Molenda Date: 2019-12-11T12:00:16-08:00 New Revision: 6d64162a2d0df2230faf02ff7ee677c448faf4af URL: https://github.com/llvm/llvm-project/commit/6d64162a2d0df2230faf02ff7ee677c448faf4af DIFF: https://github.com/llvm/llvm-project/commit/6d64162a2d0df2230faf02ff7ee677c448faf4af.diff

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg created this revision. mossberg added reviewers: labath, jingham. mossberg added a project: LLDB. Herald added a subscriber: lldb-commits. During the 'thread step-out' command, check that the memory we are about to place a breakpoint in is 1. at an Address with a valid Section and 2. in

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

jingham added a comment. Would you mind adding a mention on the Projects page? This was a neat idea and realistically if it just sits in git, in a few months no one will remember it's there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

xiaobai added a comment. In D71306#1779379 , @labath wrote: > In D71306#1778472 , @xiaobai wrote: > > > I personally prefer the third approach. To make sure I understand > > correctly, I'll write it in my own

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Did you test on swift? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71311/new/ https://reviews.llvm.org/D71311

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide added a comment. This is not a bad idea after all. Let me see if I can cook something reasonable without getting burned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71316/new/ https://reviews.llvm.org/D71316

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide added a comment. Ideally -- if we're able to make this a callback in the language plugins, we don't need this patch at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71316/new/ https://reviews.llvm.org/D71316

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

This revision was automatically updated to reflect the committed changes. Closed by commit rGee64dfd953f8: Remove TypeValidators (NFC in terms of the testsuite) (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D71310?vs=233209=233394#toc

[Lldb-commits] [lldb] ee64dfd - Remove TypeValidators (NFC in terms of the testsuite)

Author: Adrian Prantl Date: 2019-12-11T09:27:12-08:00 New Revision: ee64dfd953f89a9d3df3c13a28b1bce33f33f4cb URL: https://github.com/llvm/llvm-project/commit/ee64dfd953f89a9d3df3c13a28b1bce33f33f4cb DIFF: https://github.com/llvm/llvm-project/commit/ee64dfd953f89a9d3df3c13a28b1bce33f33f4cb.diff

[Lldb-commits] [PATCH] D71336: [lldb] Remove ClangASTMetrics

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. It is not clear to me we could use these in a test because I don't see a reason for the numbers to stay stable and therefore a useful measure.

[Lldb-commits] [lldb] 52c5342 - update TestThreadStepOut.py to expect correct source line on arm64.

Author: Jason Molenda Date: 2019-12-11T09:17:03-08:00 New Revision: 52c5342ebcc173b25c1644335cba7aef8ec73b92 URL: https://github.com/llvm/llvm-project/commit/52c5342ebcc173b25c1644335cba7aef8ec73b92 DIFF: https://github.com/llvm/llvm-project/commit/52c5342ebcc173b25c1644335cba7aef8ec73b92.diff

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

shafik added a comment. In D71306#1779379 , @labath wrote: > Besides lldb developers, another category we should consider are llvm (or > clang or lld, ...) developers who know nothing about lldb, but they ended up > building it because they specified

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That sounds like there is consensus. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71310/new/ https://reviews.llvm.org/D71310 ___

[Lldb-commits] [lldb] 24a4d27 - Don't run expect based tests remotely.

Author: Jason Molenda Date: 2019-12-11T08:29:18-08:00 New Revision: 24a4d27acd38d7d7e3c78a8ddf1410f046891b70 URL: https://github.com/llvm/llvm-project/commit/24a4d27acd38d7d7e3c78a8ddf1410f046891b70 DIFF: https://github.com/llvm/llvm-project/commit/24a4d27acd38d7d7e3c78a8ddf1410f046891b70.diff

Re: [Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

On 12/11/19 02:09 AM, Pavel Labath wrote: > > On 11/12/2019 00:51, Jason Molenda via lldb-commits wrote: > > That was my first inclination -- I don't see how it can work correctly on a > > remote setup, just like TestMultilineCompletion.py which I added the same > > skip to -- but I know

[Lldb-commits] [lldb] c7738cc - [lldb] Don't search the metadata map three times when retrieving metadata

Author: Raphael Isemann Date: 2019-12-11T15:08:10+01:00 New Revision: c7738cca7efda9d1a78569b69ba4ac735c0f2212 URL: https://github.com/llvm/llvm-project/commit/c7738cca7efda9d1a78569b69ba4ac735c0f2212 DIFF:

[Lldb-commits] [lldb] f95ef6a - [lldb][NFC] Remove dead metadata code in ClangASTSourceProxy

Author: Raphael Isemann Date: 2019-12-11T14:38:12+01:00 New Revision: f95ef6a548211ffa6723e4ec923d37359a3bb9e1 URL: https://github.com/llvm/llvm-project/commit/f95ef6a548211ffa6723e4ec923d37359a3bb9e1 DIFF:

[Lldb-commits] [lldb] 3bf8558 - [lldb][NFC] Remove ClangExternalASTSourceCommon::g_TotalSizeOfMetadata

Author: Raphael Isemann Date: 2019-12-11T14:05:43+01:00 New Revision: 3bf8558fbb2f3e9348bf1f5aafb64d8095ad6420 URL: https://github.com/llvm/llvm-project/commit/3bf8558fbb2f3e9348bf1f5aafb64d8095ad6420 DIFF:

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems ok. The reason these checks are written this way is because we used to have the xcode build which bypassed cmake and lit, so this was the only place to implement that centrally.

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

labath added a comment. It's true that external dependencies are a lot more critical for lldb than llvm. That might justify some deviation from it, but I would certainly try to minimize that. I am a big anti-fan of overwriting user-provided values, so I'd really try to avoid that method.

[Lldb-commits] [PATCH] D71336: [lldb] Remove ClangASTMetrics

teemperor created this revision. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Not once have I looked at these numbers in a log and considered them useful for anything. Also we should not

[Lldb-commits] [PATCH] D71299: [FormatManager] Add a unittest for GetCandidateLanguages()

teemperor added inline comments. Comment at: lldb/unittests/DataFormatter/FormatManagerTests.cpp:9-24 +#include "TestingSupport/TestUtilities.h" + +#include "lldb/Core/Mangled.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include

[Lldb-commits] [lldb] 987e732 - [lldb][NFC] Cleanup includes in FormatManagerTests.cpp

Author: Raphael Isemann Date: 2019-12-11T11:33:19+01:00 New Revision: 987e7323fb53f968d5878483610fcf2319cdde86 URL: https://github.com/llvm/llvm-project/commit/987e7323fb53f968d5878483610fcf2319cdde86 DIFF:

Re: [Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

On 11/12/2019 00:51, Jason Molenda via lldb-commits wrote: > That was my first inclination -- I don't see how it can work correctly on a > remote setup, just like TestMultilineCompletion.py which I added the same > skip to -- but I know people are doing remote linux testing for android and >

[Lldb-commits] [PATCH] D71268: [lldb/DWARF] Add support for DW_AT_loclists_base_FORM_loclistx

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rGc8b74ee264a9: [lldb/DWARF] Add support for DW_AT_loclists_baseDW_FORM_loclistx (authored by labath). Changed prior to commit:

[Lldb-commits] [lldb] c8b74ee - [lldb/DWARF] Add support for DW_AT_loclists_base_FORM_loclistx

Author: Pavel Labath Date: 2019-12-11T11:06:17+01:00 New Revision: c8b74ee264a943aad29fd0864c610ba5504f73a8 URL: https://github.com/llvm/llvm-project/commit/c8b74ee264a943aad29fd0864c610ba5504f73a8 DIFF: https://github.com/llvm/llvm-project/commit/c8b74ee264a943aad29fd0864c610ba5504f73a8.diff

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D71150#1778351 , @rupprecht wrote: > In D71150#1774575 , @labath wrote: > > > Hmm... given the lua thread

[Lldb-commits] [PATCH] D71299: [FormatManager] Add a unittest for GetCandidateLanguages()

labath added inline comments. Comment at: lldb/unittests/DataFormatter/FormatManagerTests.cpp:9-24 +#include "TestingSupport/TestUtilities.h" + +#include "lldb/Core/Mangled.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include

[Lldb-commits] [PATCH] D71268: [lldb/DWARF] Add support for DW_AT_loclists_base_FORM_loclistx

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:462 + uint64_t header_size = llvm::DWARFListTableHeader::getHeaderSize(DWARF32); + if (loclists_base >= header_size) { +

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1763639 , @labath wrote: > - I think we ought to have some kind of a utility function to hold the logic > for the `&~1` stuff. there is something like that in > Architecture::GetOpcodeLoadAddress. The Architecture