[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

paolosev updated this revision to Diff 234463. paolosev marked 2 inline comments as done. paolosev removed a project: LLVM. paolosev added a comment. Addressed first review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71575/new/ https://reviews.llvm.org/D71575 Files: lldb/

[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

paolosev marked 43 inline comments as done. paolosev added a comment. Thanks for all the comments! I am updating the code following your suggestions. Next step will be to split this into three distinct patches, as suggested by Pavel. Comment at: lldb/source/Plugins/DynamicLoa

[Lldb-commits] [PATCH] D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1202-1212 FILE *out = llvm::sys::RetryAfterSignal(nullptr, fopen, dev_null_path, "w"); - if (out) { -

[Lldb-commits] [PATCH] D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out

clayborg added a comment. minor nit and this is good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71633/new/ https://reviews.llvm.org/D71633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out

lanza created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The DAP is usually communicated over STDIN and STDOUT and thus lldb's Debugger instance printing and reading from these files can cause conflicts. However, if the DAP communication was set up to be

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, abidh, MaskRay, emaste. Herald added a reviewer: martong. Herald added a reviewer: espindola. Herald added a reviewer: shafik. Herald added a project: LLDB. teemperor added a co

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor added a comment. Herald added a subscriber: rnkovacs. I only converted like 40% of our tests to the new system as I first wanted to get some feedback before I do all the refactoring. Also I'm open to ideas how to name the member (currently I just use `subsystems` without the `m_` prefi

Re: [Lldb-commits] [PATCH] D71440: Extending step-over range past calls was causing deadlocks, fix that.

> On Dec 17, 2019, at 2:41 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > Thanks for the explanation (and for updating the test). This actually > explains why it sometimes seemed that I lose control over other threads while > stepping one of them. I'll be sure to

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

friss added a comment. In D69309#1787409 , @labath wrote: > In D69309#1787297 , @jarin wrote: > > > In D69309#1752738 , @friss wrote: > > > > > Basically, today the debug inf

[Lldb-commits] [lldb] 268f37d - [lldb][NFC] Use StringRef in CreateRecordType and CreateObjCClass

Author: Raphael Isemann Date: 2019-12-17T16:10:34+01:00 New Revision: 268f37df6e45c4b0603bd4d964483a0d84da44c1 URL: https://github.com/llvm/llvm-project/commit/268f37df6e45c4b0603bd4d964483a0d84da44c1 DIFF: https://github.com/llvm/llvm-project/commit/268f37df6e45c4b0603bd4d964483a0d84da44c1.dif

[Lldb-commits] [lldb] b852b3c - [lldb][NFC] Rename ClangASTImporter::InsertRecordDecl to SetRecordLayout and document it

Author: Raphael Isemann Date: 2019-12-17T15:56:07+01:00 New Revision: b852b3c982d2e8ad3f13c626b3e3655e5b3c399e URL: https://github.com/llvm/llvm-project/commit/b852b3c982d2e8ad3f13c626b3e3655e5b3c399e DIFF: https://github.com/llvm/llvm-project/commit/b852b3c982d2e8ad3f13c626b3e3655e5b3c399e.dif

[Lldb-commits] [PATCH] D71603: [lldb] Make ClangASTImporter::LayoutRecordType always return the same layout

teemperor created this revision. teemperor added a reviewer: shafik. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. teemperor removed reviewers: martong, a.sidorin. Herald added a reviewer: a.

[Lldb-commits] [lldb] 4aee81c - [lldb][NFC] Allow creating ClangExpressionDeclMap and ClangASTSource without a Target and add basic unit test

Author: Raphael Isemann Date: 2019-12-17T14:04:12+01:00 New Revision: 4aee81c4f73359230e358108bc428e3b0cc59566 URL: https://github.com/llvm/llvm-project/commit/4aee81c4f73359230e358108bc428e3b0cc59566 DIFF: https://github.com/llvm/llvm-project/commit/4aee81c4f73359230e358108bc428e3b0cc59566.dif

[Lldb-commits] [PATCH] D71562: [lldb] Remove modern-type-lookup

martong added a comment. > I'm curious what you think should happen to the clang-import-test. We could > either rewrite the tests as unit tests in the ASTImporterTest you guys are > already using or we move the necessary parts of the ExternalASTMerger into > the clang-import-test Raphael, I th

[Lldb-commits] [PATCH] D71562: [lldb] Remove modern-type-lookup

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGff0102b32cfe: [lldb] Remove modern-type-lookup (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D71562: [lldb] Remove modern-type-lookup

teemperor added a comment. I'm landing this now as I started the cleanup work for the current lookup code and the modern-type-lookup code is blocking that refactoring. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71562/new/ https://reviews.llvm.org/D71562

[Lldb-commits] [lldb] ff0102b - [lldb] Remove modern-type-lookup

Author: Raphael Isemann Date: 2019-12-17T12:24:31+01:00 New Revision: ff0102b32cfe506dfc16a86e38e70b0940697aa2 URL: https://github.com/llvm/llvm-project/commit/ff0102b32cfe506dfc16a86e38e70b0940697aa2 DIFF: https://github.com/llvm/llvm-project/commit/ff0102b32cfe506dfc16a86e38e70b0940697aa2.dif

[Lldb-commits] [PATCH] D71440: Extending step-over range past calls was causing deadlocks, fix that.

labath added a comment. Thanks for the explanation (and for updating the test). This actually explains why it sometimes seemed that I lose control over other threads while stepping one of them. I'll be sure to use the --run-mode argument next time. This seems fine given how the current stepping

[Lldb-commits] [lldb] d9ca412 - [lldb][NFC] Remove all unnecessary includes for ClangASTSourceCommon.h

Author: Raphael Isemann Date: 2019-12-17T11:21:11+01:00 New Revision: d9ca412a8a75ab64af33a9e95d1319c4dd2004d2 URL: https://github.com/llvm/llvm-project/commit/d9ca412a8a75ab64af33a9e95d1319c4dd2004d2 DIFF: https://github.com/llvm/llvm-project/commit/d9ca412a8a75ab64af33a9e95d1319c4dd2004d2.dif

[Lldb-commits] [lldb] dcd1432 - [lldb-vscode] Centrally skip debug info variants for vscode tests

Author: Pavel Labath Date: 2019-12-17T11:08:52+01:00 New Revision: dcd14324dced7d91aa8bf78a607055ca093b27bf URL: https://github.com/llvm/llvm-project/commit/dcd14324dced7d91aa8bf78a607055ca093b27bf DIFF: https://github.com/llvm/llvm-project/commit/dcd14324dced7d91aa8bf78a607055ca093b27bf.diff

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

jarin added a comment. In D69309#1787481 , @labath wrote: > In D69309#1787468 , @jarin wrote: > > > What Fred proposes makes a lot of sense to me, although the lookup of > > instantiations might be slow because the

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

labath added a comment. In D69309#1787468 , @jarin wrote: > What Fred proposes makes a lot of sense to me, although the lookup of > instantiations might be slow because there would be no accelerator for that > (but we could build one). Do we ever looku

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

jarin added a comment. In D69309#1787409 , @labath wrote: > In D69309#1787297 , @jarin wrote: > > > In D69309#1752738 , @friss wrote: > > > > > Basically, today the debug inf

[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

labath added a comment. I think this is pretty good for a first pass, but I would like to see this split up into (at least) three patches (one for each plugin). That way, we can properly focus on each plugin. For instance, I'm pretty sure that the object file and symbol vendor changes are fully

[Lldb-commits] [lldb] 6e1fe49 - [lldb][NFC] Remove implementation of GetOriginalDecl and just call GetDeclOrigin instead

Author: Raphael Isemann Date: 2019-12-17T10:42:09+01:00 New Revision: 6e1fe4966c402d17a253b38192cfd5e8b919ab8e URL: https://github.com/llvm/llvm-project/commit/6e1fe4966c402d17a253b38192cfd5e8b919ab8e DIFF: https://github.com/llvm/llvm-project/commit/6e1fe4966c402d17a253b38192cfd5e8b919ab8e.dif

[Lldb-commits] [PATCH] D71196: [lldb] Add support for calling objc_direct methods from LLDB's expression evaluator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5b54bbfaf19: [lldb] Add support for calling objc_direct methods from LLDB's expression… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] d5b54bb - [lldb] Add support for calling objc_direct methods from LLDB's expression evaluator.

Author: Raphael Isemann Date: 2019-12-17T10:28:40+01:00 New Revision: d5b54bbfaf19a8527ebf70fbf23cb8d2937f15ef URL: https://github.com/llvm/llvm-project/commit/d5b54bbfaf19a8527ebf70fbf23cb8d2937f15ef DIFF: https://github.com/llvm/llvm-project/commit/d5b54bbfaf19a8527ebf70fbf23cb8d2937f15ef.dif

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

labath added a comment. Thanks. I think we're getting closer, and I think we can start talking about a more direct way to test this behavior. This is now definitely, as Adrian called it, a DWARF peculiarity, and so an assembly file with hard-coded dwarf would be much better. Can you take a look

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

labath added a comment. In D69309#1787297 , @jarin wrote: > In D69309#1752738 , @friss wrote: > > > Basically, today the debug info will describe an entity named "Foo". > > The accelerator tables all reference this

[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

teemperor added a comment. I think this is really nice. I have some minor remarks here and there but otherwise this LGTM. Comment at: lldb/source/Plugins/DynamicLoader/WASM-DYLD/DynamicLoaderWasmDYLD.cpp:88 + + if ((module_sp = modules.FindFirstModule(module_spec))) { +U

[Lldb-commits] [lldb] ba6f25d - [lldb][NFC] Make clang-format happy by removing trailing space in ArchSpec.cpp

Author: Raphael Isemann Date: 2019-12-17T09:13:48+01:00 New Revision: ba6f25d7d3671f8ff1d072a43a292950dbbf899e URL: https://github.com/llvm/llvm-project/commit/ba6f25d7d3671f8ff1d072a43a292950dbbf899e DIFF: https://github.com/llvm/llvm-project/commit/ba6f25d7d3671f8ff1d072a43a292950dbbf899e.dif