[Lldb-commits] [lldb] 68cb7d8 - [lldb/Commands] Honor the scripting language passed (2/2)

Author: Jonas Devlieghere Date: 2019-12-21T22:32:13-08:00 New Revision: 68cb7d85423c19a61c5d6afbc8e004a345a28856 URL: https://github.com/llvm/llvm-project/commit/68cb7d85423c19a61c5d6afbc8e004a345a28856 DIFF:

[Lldb-commits] [lldb] ba0eb7b - [lldb/ScriptInterpreter] Fix stale/bogus error messages

Author: Jonas Devlieghere Date: 2019-12-21T22:33:02-08:00 New Revision: ba0eb7b66fd9dac7bf4883f70b65bded03a4b97a URL: https://github.com/llvm/llvm-project/commit/ba0eb7b66fd9dac7bf4883f70b65bded03a4b97a DIFF:

[Lldb-commits] [lldb] acdda13 - [lldb/Lua] Add missing boiler plate to ScriptInterpreter.

Author: Jonas Devlieghere Date: 2019-12-21T21:54:44-08:00 New Revision: acdda1344a0e1b45bd3ba7feb0e8cd398bee0179 URL: https://github.com/llvm/llvm-project/commit/acdda1344a0e1b45bd3ba7feb0e8cd398bee0179 DIFF:

[Lldb-commits] [lldb] 1ff01cf - [lldb/Commands] Use the default scripting langauge for BP functions

Author: Jonas Devlieghere Date: 2019-12-21T18:12:37-08:00 New Revision: 1ff01cfe3ea51f873ff91ed66e1b8157583c6aa1 URL: https://github.com/llvm/llvm-project/commit/1ff01cfe3ea51f873ff91ed66e1b8157583c6aa1 DIFF:

[Lldb-commits] [lldb] bbf70c0 - [lldb/Core] Support asking the debugger for a specific script interpreter

Author: Jonas Devlieghere Date: 2019-12-21T17:11:12-08:00 New Revision: bbf70c046789f4403a9c02fc5558708ef19073cf URL: https://github.com/llvm/llvm-project/commit/bbf70c046789f4403a9c02fc5558708ef19073cf DIFF:

[Lldb-commits] [lldb] 8983d69 - [lldb/Commands] Fix bogus enum entry and add Lua (NFC)

Author: Jonas Devlieghere Date: 2019-12-21T17:21:32-08:00 New Revision: 8983d69144d14d6477c377bb91e9c7224e32f753 URL: https://github.com/llvm/llvm-project/commit/8983d69144d14d6477c377bb91e9c7224e32f753 DIFF:

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere updated this revision to Diff 235033. JDevlieghere added a comment. Test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71801/new/ https://reviews.llvm.org/D71801 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath. Herald added a project: LLDB. The Python script interpreter makes the current debugger, target, process, thread and frame available to interactive scripting sessions through convenience variables. This patch does

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS AND UNIX

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lldb/source/API/CMakeLists.txt:124 + set(_install_rpath "\$ORIGIN/../lib${LLVM_LIBDIR_SUFFIX}" "\$ORIGIN/../../../../lib${LLVM_LIBDIR_SUFFIX}" ${extra_libdir}) + set_target_properties(liblldb

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS AND UNIX

MaskRay created this revision. MaskRay added reviewers: clayborg, JDevlieghere, jingham, labath. Herald added subscribers: lldb-commits, kristof.beyls, mgorny. Herald added a project: LLDB. For -DBUILD_SHARED_LIBS=On builds, lib/liblldb.so depends on lib/*.so .

[Lldb-commits] [lldb] 4164be7 - [Lldb/Lua] Persist Lua state across script interpreter calls.

Author: Jonas Devlieghere Date: 2019-12-21T15:00:35-08:00 New Revision: 4164be7206d740b77b5a7b4b2f859ed122d08c10 URL: https://github.com/llvm/llvm-project/commit/4164be7206d740b77b5a7b4b2f859ed122d08c10 DIFF:

[Lldb-commits] [lldb] ceb433a - [lldb] Fix windows build after getASTContext() change

Author: Raphael Isemann Date: 2019-12-21T23:27:27+01:00 New Revision: ceb433ad162bac35888303d29d34dc2609974d92 URL: https://github.com/llvm/llvm-project/commit/ceb433ad162bac35888303d29d34dc2609974d92 DIFF:

[Lldb-commits] [PATCH] D71235: [lldb/Lua] Generate Lua Bindings and Make Them Available to the Script Interpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf03e17c5701: [Lldb/Lua] Generate Lua Bindings (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D71235?vs=234799=235024#toc Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] bf03e17 - [Lldb/Lua] Generate Lua Bindings

Author: Jonas Devlieghere Date: 2019-12-21T11:28:41-08:00 New Revision: bf03e17c570171c7a52117fe63ace89d58f328d5 URL: https://github.com/llvm/llvm-project/commit/bf03e17c570171c7a52117fe63ace89d58f328d5 DIFF:

[Lldb-commits] [PATCH] D71789: [lldb] Refactor thread-step-out-ret-addr-check test to use .data instead of stack variable

mossberg abandoned this revision. mossberg added a comment. Thanks all for testing this! I had no idea it was this hard to get a non-executable section :) Superseded by D71784 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 49b206f - [lldb][NFC] Remove all ASTContext getter wrappers from ClangASTContext

Author: Raphael Isemann Date: 2019-12-21T15:41:18+01:00 New Revision: 49b206f95806f35ff8f9a715185355fc2a159760 URL: https://github.com/llvm/llvm-project/commit/49b206f95806f35ff8f9a715185355fc2a159760 DIFF:

[Lldb-commits] [lldb] 2947da9 - [lldb] disable thread-step-out-ret-addr-check on windows

Author: Pavel Labath Date: 2019-12-21T14:20:47+01:00 New Revision: 2947da9ff7d1a1c1d0356ac51405e6576d8fbf64 URL: https://github.com/llvm/llvm-project/commit/2947da9ff7d1a1c1d0356ac51405e6576d8fbf64 DIFF: https://github.com/llvm/llvm-project/commit/2947da9ff7d1a1c1d0356ac51405e6576d8fbf64.diff

[Lldb-commits] [PATCH] D71797: Fix thread-step-out-ret-addr-check.test PT_GNU_STACK compilation on Windows

jankratochvil abandoned this revision. jankratochvil added a comment. This has been already fixed by @labath: https://github.com/llvm/llvm-project/commit/ce3ce9f46404688cc2d95f794799c8f834630905 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71797: Fix thread-step-out-ret-addr-check.test PT_GNU_STACK compilation on Windows

labath added a comment. I already fixed the compilation error in rGce3ce9f , but it does not seem to be enough.. I guess the test will need to be re-disabled on windows. (My vague knowledge of windows tells me that the

[Lldb-commits] [lldb] e192cc1 - [lldb] One more attempt to fix thread-step-out-ret-addr-check on windows

Author: Pavel Labath Date: 2019-12-21T13:33:42+01:00 New Revision: e192cc1f1bf120712f7c78fcd51645db8918d083 URL: https://github.com/llvm/llvm-project/commit/e192cc1f1bf120712f7c78fcd51645db8918d083 DIFF: https://github.com/llvm/llvm-project/commit/e192cc1f1bf120712f7c78fcd51645db8918d083.diff

[Lldb-commits] [PATCH] D71797: Fix thread-step-out-ret-addr-check.test PT_GNU_STACK compilation on Windows

jankratochvil created this revision. jankratochvil added reviewers: stella.stamenova, mossberg, labath. jankratochvil added a project: LLDB. Herald added a subscriber: krytarowski. jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at:

[Lldb-commits] [PATCH] D71797: Fix thread-step-out-ret-addr-check.test PT_GNU_STACK compilation on Windows

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/test/Shell/Unwind/Inputs/thread-step-out-ret-addr-check.s:22 -#ifdef __linux__ .section .note.GNU-stack,"",@progbits That was apparently a comment

[Lldb-commits] [lldb] ce3ce9f - [lldb] Force the preprocessor to run in thread-step-out-ret-addr-check.test

Author: Pavel Labath Date: 2019-12-21T12:25:02+01:00 New Revision: ce3ce9f46404688cc2d95f794799c8f834630905 URL: https://github.com/llvm/llvm-project/commit/ce3ce9f46404688cc2d95f794799c8f834630905 DIFF: https://github.com/llvm/llvm-project/commit/ce3ce9f46404688cc2d95f794799c8f834630905.diff

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Expression/IRMemoryMap.cpp:577-586 if (lldb_private::Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_EXPRESSIONS)) { LLDB_LOGF(log,

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil updated this revision to Diff 234935. jankratochvil marked an inline comment as done. Herald added a subscriber: emaste. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71498/new/ https://reviews.llvm.org/D71498 Files:

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil marked 6 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Core/PluginManager.cpp:89 template static FPtrTy CastToFPtr(void *VPtr) { - return reinterpret_cast(reinterpret_cast(VPtr)); + return reinterpret_cast(VPtr); }

[Lldb-commits] [PATCH] D71722: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot

This revision was automatically updated to reflect the committed changes. Closed by commit rG44b4b833ad76: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot (authored by aprantl). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rGdf6879ec0227: [lldb] Fix ARM32 inferior calls (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Host/common/HostInfoBase.cpp:250 + reinterpret_cast( + HostInfoBase::ComputeSharedLibraryDirectory))); labath wrote: > jankratochvil

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil added a comment. In D71498#1785458 , @labath wrote: > In other places you're replacing a reinterpret_cast with two c casts. `reinterpret_cast` and a `(c cast)` have the same behavior and as `c cast` is shorter I did prefer it. But I see

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for tracking these down! Comment at: lldb/source/Expression/IRMemoryMap.cpp:577-586 if (lldb_private::Log *log =

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

This revision was automatically updated to reflect the committed changes. Closed by commit rG4706a60e8a07: [lldb] [testsuite] Fix Linux fail: Unwind/thread-step-out-ret-addr-check.test (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1805d1f - [lldb] Fix -Wstringop-truncation in PythonReadline.cpp

Author: Pavel Labath Date: 2019-12-21T11:35:26+01:00 New Revision: 1805d1f87d7835b237f85bfb0595d1f411ebf1bf URL: https://github.com/llvm/llvm-project/commit/1805d1f87d7835b237f85bfb0595d1f411ebf1bf DIFF: https://github.com/llvm/llvm-project/commit/1805d1f87d7835b237f85bfb0595d1f411ebf1bf.diff

[Lldb-commits] [lldb] 4706a60 - [lldb] [testsuite] Fix Linux fail: Unwind/thread-step-out-ret-addr-check.test

Author: Jan Kratochvil Date: 2019-12-21T11:27:54+01:00 New Revision: 4706a60e8a071f0c6a686c45ed08c7bab0bb8446 URL: https://github.com/llvm/llvm-project/commit/4706a60e8a071f0c6a686c45ed08c7bab0bb8446 DIFF:

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

labath added a comment. I didn't check this patch exactly, but I tried something very similar investigating this patch yesterday, so I think this should be fine. You should be able to see any darwin failures here: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/ Repository: rG LLVM

[Lldb-commits] [PATCH] D71235: [lldb/Lua] Generate Lua Bindings and Make Them Available to the Script Interpreter

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine. Things will start to get interesting once you start wanting to access the current session from inside the lua script (not just creating a new one),, CHANGES SINCE LAST

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

jankratochvil added a comment. Thanks for the review but is it tested on Darwin? I do not have any. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71784/new/ https://reviews.llvm.org/D71784 ___

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath added a comment. In D71770#1793334 , @aprantl wrote: > Does the mean these mappings will show up in the settings command? No, these won't show up in the target.source-map setting because this is setting the "per-module" mapping list, and not the

[Lldb-commits] [PATCH] D71789: [lldb] Refactor thread-step-out-ret-addr-check test to use .data instead of stack variable

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. My testing matches the @labath's one. I have updated D71784 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

jankratochvil updated this revision to Diff 235009. jankratochvil added a comment. Herald added a subscriber: krytarowski. Addressed the review and D71789 and enabled it for Linux again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

labath added a comment. As I said on the other patch, this is probably a simpler approach (assuming we can't find a way to make the data section non-executable in a generic way). You'll need to add an `#ifdef` for the section directive though... Comment at:

[Lldb-commits] [PATCH] D71789: [lldb] Refactor thread-step-out-ret-addr-check test to use .data instead of stack variable

labath added subscribers: MaskRay, krytarowski. labath added a comment. I don't really understand what's going on, but it seems that the lack of the `.note.GNU-stack` section causes the data section to be executable too (at least on my machine, anyway). Which means that using the data address

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

labath added a comment. A bunch more comments from me. :) A higher level question I have is whether there's something suitable within llvm for parsing wasm object files that could be reused. I know this can be tricky with files loaded from memory etc., so it's fine if it isn't possible to do

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

labath added a comment. Thank you very much Omair. This is very useful information, and it does explain a few thing (while raising other questions). The thing that would help now is seeing the difference in the symbols and their properties in the area around the mmap function. Comparing the