[Lldb-commits] [lldb] 4b0563f - test: correct flags for Windows

Author: Saleem Abdulrasool Date: 2019-12-23T20:21:26-08:00 New Revision: 4b0563f89f939f2160002298d5491a8fc8ee1137 URL: https://github.com/llvm/llvm-project/commit/4b0563f89f939f2160002298d5491a8fc8ee1137 DIFF:

Re: [Lldb-commits] [lldb] 3cfb667 - [lldb] Don't process symlinks deep inside DWARFUnit

Hi Pavel, I've temporarily reverted this in ebcb36d4a1387e771fb49d1f6379cb5774373a5a because it broke TestCompDirSymLink.py on macOS. Jonas On Mon, Dec 23, 2019 at 2:24 AM Pavel Labath via lldb-commits wrote: > > > Author: Pavel Labath > Date: 2019-12-23T11:24:04+01:00 > New Revision:

[Lldb-commits] [lldb] ebcb36d - Revert "[lldb] Don't process symlinks deep inside DWARFUnit"

Author: Jonas Devlieghere Date: 2019-12-23T18:04:29-08:00 New Revision: ebcb36d4a1387e771fb49d1f6379cb5774373a5a URL: https://github.com/llvm/llvm-project/commit/ebcb36d4a1387e771fb49d1f6379cb5774373a5a DIFF:

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere updated this revision to Diff 235178. JDevlieghere added a comment. - Keep one set of convenience variables per lua state/script interpreter - Add test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71801/new/ https://reviews.llvm.org/D71801 Files:

[Lldb-commits] [lldb] 187f66b - [lldb/CMake] Always set a value for find_package when finding optional dependencies

Author: Alex Langford Date: 2019-12-23T13:37:58-08:00 New Revision: 187f66bcac668dd2ea25244ed7d7711551275f9d URL: https://github.com/llvm/llvm-project/commit/187f66bcac668dd2ea25244ed7d7711551275f9d DIFF: https://github.com/llvm/llvm-project/commit/187f66bcac668dd2ea25244ed7d7711551275f9d.diff

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

omjavaid added a comment. Some new observations: With this approach of not setting size of a non-last zero-sized symbol we somehow mange to zero out size of init (_init symbol) and .text (_start symbol). To build and evaluate a.out echo -e '#include \nint main(void){\nsync();return

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS or LLVM_LINK_LLVM_DYLIB on *nix

MaskRay updated this revision to Diff 235170. MaskRay marked 3 inline comments as done. MaskRay retitled this revision from "[CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS AND UNIX" to "[CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS or LLVM_LINK_LLVM_DYLIB

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS or LLVM_LINK_LLVM_DYLIB on *nix

MaskRay added inline comments. Comment at: lldb/source/API/CMakeLists.txt:117 +# loaded from Python. +if(LLDB_ENABLE_PYTHON AND BUILD_SHARED_LIBS AND UNIX) + if(LLVM_INSTALL_PREFIX AND NOT (LLVM_INSTALL_PREFIX STREQUAL CMAKE_INSTALL_PREFIX)) labath wrote: > I

[Lldb-commits] [lldb] e7d5131 - [lldb/Test] Disable TestSynchronous.test on Windows.

Author: Jonas Devlieghere Date: 2019-12-23T09:49:22-08:00 New Revision: e7d5131d3b122cdae5442b02f60e8527423c40c3 URL: https://github.com/llvm/llvm-project/commit/e7d5131d3b122cdae5442b02f60e8527423c40c3 DIFF:

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere planned changes to this revision. JDevlieghere added a comment. Thanks Pavel, I must admit I gave this little thought and just mirrored the Python approach. I *think* it should easy to implement things the way you describe (famous last words). CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e40ac74 - [lldb] Remove DWARFUnit::AppendDIEsWithTag

Author: Pavel Labath Date: 2019-12-23T15:50:30+01:00 New Revision: e40ac74dacda99ff6330945f0f105252b7c28c9c URL: https://github.com/llvm/llvm-project/commit/e40ac74dacda99ff6330945f0f105252b7c28c9c DIFF: https://github.com/llvm/llvm-project/commit/e40ac74dacda99ff6330945f0f105252b7c28c9c.diff

[Lldb-commits] [lldb] 46f02fc - [lldb/DWARF] Fix hostname-stripping logic

Author: Pavel Labath Date: 2019-12-23T14:54:22+01:00 New Revision: 46f02fc922e053006e34d860e9efaf29c88d8ba3 URL: https://github.com/llvm/llvm-project/commit/46f02fc922e053006e34d860e9efaf29c88d8ba3 DIFF: https://github.com/llvm/llvm-project/commit/46f02fc922e053006e34d860e9efaf29c88d8ba3.diff

[Lldb-commits] [lldb] 982a9e3 - [lldb][NFC] Remove unused callback functionality from ClangASTContext

Author: Raphael Isemann Date: 2019-12-23T13:50:01+01:00 New Revision: 982a9e3d46bbecc9407c9d5df06634f03d21c6cd URL: https://github.com/llvm/llvm-project/commit/982a9e3d46bbecc9407c9d5df06634f03d21c6cd DIFF:

[Lldb-commits] [lldb] 40bd809 - [lldb][NFC] Simplify ClangExternalASTSourceCallbacks

Author: Raphael Isemann Date: 2019-12-23T13:22:29+01:00 New Revision: 40bd809b6d5cfe69ffcb567245bc521b971a80eb URL: https://github.com/llvm/llvm-project/commit/40bd809b6d5cfe69ffcb567245bc521b971a80eb DIFF:

[Lldb-commits] [lldb] b6c29d9 - [lldb][NFC] Remove unused 'type' parameter in ClangExpressionDeclMap::FindGlobalVariable

Author: Raphael Isemann Date: 2019-12-23T12:43:47+01:00 New Revision: b6c29d9de027692cfe93a4f701cf49f1d5f99574 URL: https://github.com/llvm/llvm-project/commit/b6c29d9de027692cfe93a4f701cf49f1d5f99574 DIFF:

[Lldb-commits] [lldb] a175c6a - [lldb][NFC] Remove wrong and unused ClangASTContext::CopyDecl method

Author: Raphael Isemann Date: 2019-12-23T12:11:26+01:00 New Revision: a175c6a6f6bd98a5afc3bb90b41362e812134309 URL: https://github.com/llvm/llvm-project/commit/a175c6a6f6bd98a5afc3bb90b41362e812134309 DIFF:

[Lldb-commits] [lldb] 76d294c - [lldb][NFC] Delete all 'else return ...' in CompilerDeclContext.cpp

Author: Raphael Isemann Date: 2019-12-23T11:49:35+01:00 New Revision: 76d294cb8744b8b15a72d5adb2d435d2265ea9d7 URL: https://github.com/llvm/llvm-project/commit/76d294cb8744b8b15a72d5adb2d435d2265ea9d7 DIFF:

[Lldb-commits] [lldb] 73951a1 - [lldb] Add sanity check to CreateDeclContext and fixed illformed CompilerContext in ClangExpressionDeclMap.

Author: Raphael Isemann Date: 2019-12-23T11:48:02+01:00 New Revision: 73951a11c64b4e748bbd1291d5021aef6aa400a5 URL: https://github.com/llvm/llvm-project/commit/73951a11c64b4e748bbd1291d5021aef6aa400a5 DIFF:

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS AND UNIX

labath added a comment. BTW, isn't a LLVM_LINK_LLVM_DYLIB build suffering from the same problem? Should that be included here too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71800/new/ https://reviews.llvm.org/D71800

[Lldb-commits] [lldb] 3cfb667 - [lldb] Don't process symlinks deep inside DWARFUnit

Author: Pavel Labath Date: 2019-12-23T11:24:04+01:00 New Revision: 3cfb6677b2aa20f782d9bb0f7958e61f5a976c16 URL: https://github.com/llvm/llvm-project/commit/3cfb6677b2aa20f782d9bb0f7958e61f5a976c16 DIFF: https://github.com/llvm/llvm-project/commit/3cfb6677b2aa20f782d9bb0f7958e61f5a976c16.diff

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cfb6677b2aa: [lldb] Dont process symlinks deep inside DWARFUnit (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71770/new/

[Lldb-commits] [lldb] 12a3d97 - [lldb/lua] Fix bindings.test for lua-5.1

Author: Pavel Labath Date: 2019-12-23T11:07:35+01:00 New Revision: 12a3d97cf68389a025b8a75b8ea660b11401a3c8 URL: https://github.com/llvm/llvm-project/commit/12a3d97cf68389a025b8a75b8ea660b11401a3c8 DIFF: https://github.com/llvm/llvm-project/commit/12a3d97cf68389a025b8a75b8ea660b11401a3c8.diff

[Lldb-commits] [lldb] fbccef6 - [lldb] Fix a -Wreturn-type gcc warning in ScriptInterpreter.cpp

Author: Pavel Labath Date: 2019-12-23T11:07:35+01:00 New Revision: fbccef6b2553a3e6a7183e259f5a911885d0ddea URL: https://github.com/llvm/llvm-project/commit/fbccef6b2553a3e6a7183e259f5a911885d0ddea DIFF: https://github.com/llvm/llvm-project/commit/fbccef6b2553a3e6a7183e259f5a911885d0ddea.diff

[Lldb-commits] [lldb] fecb122 - [lldb][NFC] Simplify ClangASTContext::GetTranslationUnitDecl

Author: Raphael Isemann Date: 2019-12-23T11:02:21+01:00 New Revision: fecb122cca254f565050559b349c8ff309194554 URL: https://github.com/llvm/llvm-project/commit/fecb122cca254f565050559b349c8ff309194554 DIFF:

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS AND UNIX

labath added a comment. Yeah, not requiring LD_LIBRARY_PATH in the BUILD_SHARED_LIBS build would be nice. The fix isn't particularly pretty, but I don't know if there is a better way to do that (besides the improvements in inline comments). Comment at:

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dca0596a959: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 5dca059 - [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

Author: Raphael Isemann Date: 2019-12-23T10:38:25+01:00 New Revision: 5dca0596a959217a1c18858a62ed35245a4c42b4 URL: https://github.com/llvm/llvm-project/commit/5dca0596a959217a1c18858a62ed35245a4c42b4 DIFF:

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

labath added a reviewer: jingham. labath added a comment. +Jim, for his thoughts on debugger+interpreter relationship I think this is the time to step back and discuss the relationship between debugger and script interpreter contexts... So, the way I understand the python code, our intention

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor updated this revision to Diff 235109. teemperor added a comment. - Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71630/new/ https://reviews.llvm.org/D71630 Files: lldb/unittests/Core/MangledTest.cpp lldb/unittests/Editline/EditlineTest.cpp

[Lldb-commits] [lldb] 6df6edf - [lldb][NFC] Document CompilerDeclContext constructors

Author: Raphael Isemann Date: 2019-12-23T09:59:58+01:00 New Revision: 6df6edfd0a0b50195d56124b9e43bb7c29843b7f URL: https://github.com/llvm/llvm-project/commit/6df6edfd0a0b50195d56124b9e43bb7c29843b7f DIFF:

[Lldb-commits] [lldb] 42ec584 - [lldb][NFC] Make CompilerDeclContext construction type safe

Author: Raphael Isemann Date: 2019-12-23T09:56:54+01:00 New Revision: 42ec584a8b4e604360b7a4d45a65c570d58b1bf9 URL: https://github.com/llvm/llvm-project/commit/42ec584a8b4e604360b7a4d45a65c570d58b1bf9 DIFF:

[Lldb-commits] [PATCH] D71824: Add the 'start' and 'length' to the completions response.

labath added a reviewer: clayborg. labath added a comment. This needs a test case, but I am also not sure that the implementation is correct even. What will this do with multiword commands "frame variable foo.b" ? Or even single-word commands that have multiple arguments ("vo foo bar foo.b")?