[Lldb-commits] [PATCH] D72195: [lldb] [Process/NetBSD] Remove unused orig_*ax use

mgorny created this revision. mgorny added reviewers: krytarowski, labath. `orig_*ax` logic is Linux-specific, and was never used on NetBSD. In fact, its support seems to be a dead code entirely. https://reviews.llvm.org/D72195 Files:

[Lldb-commits] [PATCH] D72096: [lldb/Command] Add --force option for `watchpoint delete` command

This revision was automatically updated to reflect the committed changes. mib marked an inline comment as done. Closed by commit rGdf71f92fbb7c: [lldb/Command] Add --force option for `watchpoint delete` command (authored by mib). Changed prior to commit:

[Lldb-commits] [lldb] df71f92 - [lldb/Command] Add --force option for `watchpoint delete` command

Author: Med Ismail Bennani Date: 2020-01-04T03:11:15+01:00 New Revision: df71f92fbb7c96cfd36d247ae6fb6929cb9bce35 URL: https://github.com/llvm/llvm-project/commit/df71f92fbb7c96cfd36d247ae6fb6929cb9bce35 DIFF:

[Lldb-commits] [lldb] 6c87623 - [UserExpression] Clean up `return` after `else`.

Author: Davide Italiano Date: 2020-01-03T16:52:10-08:00 New Revision: 6c87623615b3befdf62e3a5cd6c408a698f1c2d9 URL: https://github.com/llvm/llvm-project/commit/6c87623615b3befdf62e3a5cd6c408a698f1c2d9 DIFF:

[Lldb-commits] [PATCH] D72190: Removing C-style casts in favor of explict C++ style casts

shafik created this revision. shafik added reviewers: teemperor, JDevlieghere, labath. C-style casts hide intent and when code changes they can also hide logic errors. This change converts most of the C-style cast into `static_cast` and the icky ones are converted to `reinterpret_cast` and we

[Lldb-commits] [lldb] d2b19d4 - [lldb/Utility] YAML validation should be orthogonal to packet semantics.

Author: Jonas Devlieghere Date: 2020-01-03T14:23:42-08:00 New Revision: d2b19d455de22fe3c8aa192320e1ff9a4eb1a365 URL: https://github.com/llvm/llvm-project/commit/d2b19d455de22fe3c8aa192320e1ff9a4eb1a365 DIFF:

[Lldb-commits] [lldb] 320b43c - [lldb/Docs] Include the man page on the website

Author: Jonas Devlieghere Date: 2020-01-03T13:59:19-08:00 New Revision: 320b43c39f0eb636c84815ce463893b21befdc8f URL: https://github.com/llvm/llvm-project/commit/320b43c39f0eb636c84815ce463893b21befdc8f DIFF:

[Lldb-commits] [lldb] 6e6b6a5 - [lldb/Docs] Include how to generate the man page

Author: Jonas Devlieghere Date: 2020-01-03T13:34:35-08:00 New Revision: 6e6b6a5754514a137729ce1a5e389db5f516c964 URL: https://github.com/llvm/llvm-project/commit/6e6b6a5754514a137729ce1a5e389db5f516c964 DIFF:

[Lldb-commits] [PATCH] D72161: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

shafik added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1745 + "0x%8.8llx, length = %llu) => %p", + (uint64_t)addr, (uint64_t)length, static_cast(bp)); return bp;

[Lldb-commits] [PATCH] D72161: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

shafik added a comment. This is a great change! Moving to stricter casts clarifies intent and reduces the chance that later changes can introduce bugs accidentally. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72161/new/ https://reviews.llvm.org/D72161

[Lldb-commits] [PATCH] D71909: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

shafik added inline comments. Comment at: lldb/source/Symbol/ClangASTContext.cpp:1347 + if (decl_ctx->isRecord()) +func_tmpl_decl->setAccess(clang::AccessSpecifier::AS_public); teemperor wrote: > shafik wrote: > > Where is the method being added and why

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

paolosev marked 10 inline comments as done. paolosev added a comment. In D71575#1793791 , @labath wrote: > A bunch more comments from me. :) > > A higher level question I have is whether there's something suitable within > llvm for parsing wasm object

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS or LLVM_LINK_LLVM_DYLIB on *nix

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71800/new/ https://reviews.llvm.org/D71800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

jarin added a comment. Actually, there is something unusually flaky in my current checkout, so you might be right that not canonicalizing is harmless. It still makes more sense to land that separately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72133/new/

[Lldb-commits] [PATCH] D72161: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

teemperor created this revision. teemperor added reviewers: shafik, JDevlieghere, labath. Herald added subscribers: lldb-commits, usaxena95, arphaman. Herald added a project: LLDB. There are a few places in LLDB where we do a `reinterpret_cast` for conversions that we could also do with

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

teemperor added a comment. Interesting, I actually can't reproduce those failures on any of my machines. Can you post the error output you get? But I agree that we can figure this out in a separate patch, so I'll give this another test run and then land it. Thanks for the patch! CHANGES

[Lldb-commits] [PATCH] D72152: Support Launching in External Console in lldb-vscode

puremourning created this revision. puremourning added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When testing terminal-mode applications using lldb-vscode on macOS, it's currently required to set LLDB_LAUNCH_FLAG_LAUNCH_IN_TTY when starting

[Lldb-commits] [PATCH] D72096: [lldb/Command] Add --force option for `watchpoint delete` command

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/TestWatchpointCommands.py:194-196 +# Delete the watchpoint immediately using the force option. +

[Lldb-commits] [PATCH] D72096: [lldb/Command] Add --force option for `watchpoint delete` command

mib updated this revision to Diff 236029. mib marked an inline comment as done. mib added a comment. Merged `--force` flag and `auto-confirm` setting test. Refactored implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72096/new/

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

jarin marked an inline comment as not done. jarin added a comment. In D72133#1802727 , @teemperor wrote: > Also do you need someone to commit this for you? Yes, please (once we agree what to do with SBType.cpp). CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

jarin marked 7 inline comments as done. jarin added a comment. I have addressed the comments, thanks for the quick review. Comment at: lldb/source/API/SBType.cpp:218 + return LLDB_RECORD_RESULT( + SBType(TypeImplSP(new TypeImpl(canonical_type.GetArrayElementType();

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

teemperor added a comment. Just FYI, I meant that `lldb/source/API/SBType.cpp` shouldn't be changed with this patch. I think it's fine that this patch will change the behavior (as the old behavior seems broken). Also do you need someone to commit this for you? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71909: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Symbol/ClangASTContext.cpp:1347 + if (decl_ctx->isRecord()) +func_tmpl_decl->setAccess(clang::AccessSpecifier::AS_public); shafik wrote: > Where is the

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

jarin updated this revision to Diff 236021. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72133/new/ https://reviews.llvm.org/D72133 Files: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/array_typedef/Makefile

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I have some comments but otherwise this patch looks good to me. Thanks! Comment at:

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

jarin created this revision. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. Motivation: When formatting an array of typedefed chars, we would like to display the array as a string. The string formatter currently does not trigger because the formatter lookup does not

[Lldb-commits] [lldb] 2e03324 - [lldb][NFC] Remove forward declaration for non-existent type clang::Action and delete references to it

Author: Raphael Isemann Date: 2020-01-03T11:24:16+01:00 New Revision: 2e033244417c1b9947ee28795568bc33a1efe781 URL: https://github.com/llvm/llvm-project/commit/2e033244417c1b9947ee28795568bc33a1efe781 DIFF:

[Lldb-commits] [lldb] 1711f88 - [lldb][NFC] Document TypeSystem and related Compiler* classes

Author: Raphael Isemann Date: 2020-01-03T10:38:38+01:00 New Revision: 1711f886fd801581b6b5505cc165c977294d311a URL: https://github.com/llvm/llvm-project/commit/1711f886fd801581b6b5505cc165c977294d311a DIFF:

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

We could use clang::Decl* etc. in these classes but that would defeat the whole concept that they are supposed to implement. CompilerType, CompilerDecl, etc.. are all classes that represent their respective equivalent in a language plugin. For Clang that is indeed clang::Type* and clang::Decl*,