[Lldb-commits] [lldb] 9890cc2 - [lldb] Fix LLDB build after API change to printInst (D72172)

Author: Raphael Isemann Date: 2020-01-07T08:33:35+01:00 New Revision: 9890cc2ef08576cc16e32aff4288e7a7821a25f7 URL: https://github.com/llvm/llvm-project/commit/9890cc2ef08576cc16e32aff4288e7a7821a25f7 DIFF:

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

jingham added a comment. In D71801#1794758 , @labath wrote: > +Jim, for his thoughts on debugger+interpreter relationship > > I think this is the time to step back and discuss the relationship between > debugger and script interpreter contexts... I

[Lldb-commits] [lldb] 450073c - Change the patterns to include the prefix '= ' so we don't pass errantly.

Author: Jason Molenda Date: 2020-01-06T15:20:13-08:00 New Revision: 450073c639d7f182e48ec8b1b588212194089a52 URL: https://github.com/llvm/llvm-project/commit/450073c639d7f182e48ec8b1b588212194089a52 DIFF: https://github.com/llvm/llvm-project/commit/450073c639d7f182e48ec8b1b588212194089a52.diff

[Lldb-commits] [lldb] 59fadc1 - [NSArray] Remove a very old and deprecated formatter.

Author: Davide Italiano Date: 2020-01-06T14:58:37-08:00 New Revision: 59fadc14eeb1d63177b76147b26348a106ac1f9b URL: https://github.com/llvm/llvm-project/commit/59fadc14eeb1d63177b76147b26348a106ac1f9b DIFF:

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

Raphael is correct that the idea behind all of the "Compiler" classes is to abstract us from the TypeSystem that is being used, so they should stay "void *". I would rather not have each Compiler class make a union of pointers. CompilerType looks like: class CompilerType { ...

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

clayborg added a comment. So as long as the following are true from this patch I am ok: - if I ask for the array element type of "str" in the test that was added, it should return "MCHAR". We shouldn't be removing any typedefs from the type. The user can call SBType::GetCanonicalType() if they

[Lldb-commits] [lldb] 317cbda - [lldb/Docs] Describe optional dependencies on build page.

Author: Jonas Devlieghere Date: 2020-01-06T13:59:24-08:00 New Revision: 317cbdad4d1b9ea7ec703072aba34eeb62c9d3af URL: https://github.com/llvm/llvm-project/commit/317cbdad4d1b9ea7ec703072aba34eeb62c9d3af DIFF:

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/API/SBType.cpp:215-218 + CompilerType canonical_type = + m_opaque_sp->GetCompilerType(true).GetCanonicalType(); + return

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

clayborg added inline comments. Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:34 +/// Checks whether the data buffer starts with a valid Wasm module header. +static bool ValidateModuleHeader(const DataBufferSP _sp) { + if (!data_sp || data_sp->GetByteSize()

[Lldb-commits] [PATCH] D68679: [CMake] Add a cache for iOS.

davide abandoned this revision. davide added a comment. We don't need this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68679/new/ https://reviews.llvm.org/D68679 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

clayborg added a comment. I would suggest removing GetVaruint7 and GetVaruint32 and adding "llvm::Optional DataExtractor::GetULEB128(uint64_t *offset_ptr, uint64_t max_value);" as mentioned in inlined comments. Comment at:

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

clayborg added a comment. lgtm. Pavel? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71825/new/ https://reviews.llvm.org/D71825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D72286: installation: Accept separate install prefix for LLDB.framework

vsk abandoned this revision. vsk added a comment. This is still not right. build-script does not include the arch-specific destdir in the install prefix to begin with. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72286/new/ https://reviews.llvm.org/D72286

[Lldb-commits] [PATCH] D71379: lldbutil: Forward ASan launch info to test inferiors

davide accepted this revision. davide added a comment. This looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71379/new/ https://reviews.llvm.org/D71379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] Optional Dependencies in LLDB

(This was meant for lldb-dev) On Mon, Jan 6, 2020 at 11:15 AM Jonas Devlieghere wrote: > > Hey everyone, > > I just wanted to let you know that most of the work is complete for > auto-detecting optional dependencies in LLDB. Unless explicitly > specified, optional dependencies like editline will

[Lldb-commits] Optional Dependencies in LLDB

Hey everyone, I just wanted to let you know that most of the work is complete for auto-detecting optional dependencies in LLDB. Unless explicitly specified, optional dependencies like editline will be enabled when available and disabled otherwise. This is different from the old behavior, where

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

JDevlieghere added a comment. friendly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71825/new/ https://reviews.llvm.org/D71825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

JDevlieghere added inline comments. Comment at: packages/Python/lldbsuite/test/test_result.py:119 +categories = set() while folder != '/': categories_file_name = os.path.join(folder, ".categories") labath wrote: > I don't think this

Re: [Lldb-commits] [lldb] b3757f3 - [lldb/CMake] Autodetect Python dependency

Should be fixed by 8c8ffd461d16681cb1fc764bedfa8b09fde260aa On Mon, Jan 6, 2020 at 10:17 AM Davidino Italiano wrote: > > > > > On Jan 6, 2020, at 9:07 AM, Jonas Devlieghere via lldb-commits > > wrote: > > > > > > Author: Jonas Devlieghere > > Date: 2020-01-06T09:05:05-08:00 > > New Revision:

Re: [Lldb-commits] [lldb] b3757f3 - [lldb/CMake] Autodetect Python dependency

> On Jan 6, 2020, at 9:07 AM, Jonas Devlieghere via lldb-commits > wrote: > > > Author: Jonas Devlieghere > Date: 2020-01-06T09:05:05-08:00 > New Revision: b3757f3091d1c718a91f5b06b7364b2af28339fa > > URL: >

[Lldb-commits] [PATCH] D71906: [lldb][tests] Make it possible to expect failure for a whole category

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71906/new/ https://reviews.llvm.org/D71906

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath, compnerd. Herald added a subscriber: mgorny. Herald added a project: LLDB. Libxml2 is already an optional dependency. It should use the same infrastructure as the other dependencies. Repository: rLLDB LLDB

[Lldb-commits] [lldb] 0239526 - [lldb/Docs] Fix capitalization typo.

Author: Jonas Devlieghere Date: 2020-01-06T10:08:05-08:00 New Revision: 0239526cccf8aa708e29eeb7e49de8f6dc6c1a5f URL: https://github.com/llvm/llvm-project/commit/0239526cccf8aa708e29eeb7e49de8f6dc6c1a5f DIFF:

[Lldb-commits] [PATCH] D72286: installation: Accept separate install prefix for LLDB.framework

vsk updated this revision to Diff 236402. vsk added a comment. It looks like a framework-specific install prefix is required, as the install prefix for the framework is not always the same as the install prefix for the rest of the project. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8c8ffd4 - [lldb/CMake] Only set PYTHON_HOME on Windows

Author: Jonas Devlieghere Date: 2020-01-06T10:07:46-08:00 New Revision: 8c8ffd461d16681cb1fc764bedfa8b09fde260aa URL: https://github.com/llvm/llvm-project/commit/8c8ffd461d16681cb1fc764bedfa8b09fde260aa DIFF:

[Lldb-commits] [PATCH] D71379: lldbutil: Forward ASan launch info to test inferiors

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. We already have something like this for the sanitized bot. I think this will cause the variable to bet set twice in the launch info twice? If not this LGTM. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D72190: Removing C-style casts in favor of explict C++ style casts

JDevlieghere added a comment. In D72190#1805861 , @labath wrote: > This is fine, though, since you're already touching these lines, I'd consider > converting them from LLDB_LOGF to LLDB_LOG at the same time (getting rid of > most of the

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS or LLVM_LINK_LLVM_DYLIB on *nix

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbfebd7b8a67: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS or… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] bbfebd7 - [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS or LLVM_LINK_LLVM_DYLIB on *nix

Author: Fangrui Song Date: 2020-01-06T10:01:55-08:00 New Revision: bbfebd7b8a671c9649305b8a5f72e93dd1ef60e1 URL: https://github.com/llvm/llvm-project/commit/bbfebd7b8a671c9649305b8a5f72e93dd1ef60e1 DIFF: https://github.com/llvm/llvm-project/commit/bbfebd7b8a671c9649305b8a5f72e93dd1ef60e1.diff

[Lldb-commits] [PATCH] D72286: installation: Accept separate install prefix for LLDB.framework

vsk planned changes to this revision. vsk added a comment. Hm, the new framework install prefix seems redundant with CMAKE_INSTALL_PREFIX. Let me see if they can be shared. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72286/new/ https://reviews.llvm.org/D72286

[Lldb-commits] [lldb] 3abc292 - [lldb/Test] Move @skipIfAsan from test class to test methods.

Author: Jonas Devlieghere Date: 2020-01-06T09:53:06-08:00 New Revision: 3abc2927cb2372349fbbc0b62382c85d7d000f2c URL: https://github.com/llvm/llvm-project/commit/3abc2927cb2372349fbbc0b62382c85d7d000f2c DIFF:

[Lldb-commits] [PATCH] D71379: lldbutil: Forward ASan launch info to test inferiors

vsk added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71379/new/ https://reviews.llvm.org/D71379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D72286: installation: Accept separate install prefix for LLDB.framework

vsk created this revision. vsk added reviewers: davide, teemperor, friss. Herald added a subscriber: mgorny. To support multi-arch (fat) builds of swift-lldb, the build script sets up separate per-arch install directories, runs each arch-specific build, and then lipo's together the contents.

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3757f3091d1: [lldb/CMake] Autodetect Python dependency (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D72107?vs=235942=236393#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 8eba3fb - [lldb/Test] Temporarily skip TestFoundationDisassembly on the ASan bot.

Author: Jonas Devlieghere Date: 2020-01-06T09:06:09-08:00 New Revision: 8eba3fbb12fc179959f709aa93f9af8d902fb6d7 URL: https://github.com/llvm/llvm-project/commit/8eba3fbb12fc179959f709aa93f9af8d902fb6d7 DIFF:

[Lldb-commits] [lldb] b3757f3 - [lldb/CMake] Autodetect Python dependency

Author: Jonas Devlieghere Date: 2020-01-06T09:05:05-08:00 New Revision: b3757f3091d1c718a91f5b06b7364b2af28339fa URL: https://github.com/llvm/llvm-project/commit/b3757f3091d1c718a91f5b06b7364b2af28339fa DIFF:

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil planned changes to this revision. jankratochvil added a comment. In D63540#1805967 , @labath wrote: > Passing different sort objects to different sort invocations could cause > changes done by one Sort call to be undone by further Symtab

[Lldb-commits] [PATCH] D71906: [lldb][tests] Make it possible to expect failure for a whole category

tatyana-krasnukha updated this revision to Diff 236374. tatyana-krasnukha added a comment. Increased number of lines of context. Jonas, yes, it is. Pavel, names are consistent (if I understand your comment correctly). The "--xfail-category" is singular like the "--skip-category". Repository:

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

labath added a comment. Thanks Jan and Omair for the investigation. It does seem like there is some more work to be done on arm/thumb in elf code in lldb, as it seems to me that things are working now more-or-less accidentally. The good news is that this should not require any fundamental

[Lldb-commits] [PATCH] D72195: [lldb] [Process/NetBSD] Remove unused orig_*ax use

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc763c42bbcf: [lldb] [Process/NetBSD] Remove unused orig_*ax use (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72195: [lldb] [Process/NetBSD] Remove unused orig_*ax use

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems fine, though it may be worth checking what happens when running expressions while the process is stopped in a syscall (does the expression run correctly, does the syscall resume

[Lldb-commits] [PATCH] D72190: Removing C-style casts in favor of explict C++ style casts

labath added a comment. This is fine, though, since you're already touching these lines, I'd consider converting them from LLDB_LOGF to LLDB_LOG at the same time (getting rid of most of the static_casts...). However, I don't think we should be changing `(void)` to `static_cast`. There is also

[Lldb-commits] [PATCH] D72161: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72161/new/ https://reviews.llvm.org/D72161 ___

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS or LLVM_LINK_LLVM_DYLIB on *nix

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. I think this is fine now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71800/new/ https://reviews.llvm.org/D71800

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine to me. Thanks for tackling this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72107/new/ https://reviews.llvm.org/D72107

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

labath added a reviewer: jingham. labath added a comment. Would it be possible to fix this problem in the swig bindings instead? (i.e. move the `std::min` stuff into the swig code). That way, the behavior of this function will at least match that of snprintf, which will hopefully be less

[Lldb-commits] [PATCH] D71906: [lldb][tests] Make it possible to expect failure for a whole category

labath added a comment. Seems reasonable, just make the option name consistent. Comment at: packages/Python/lldbsuite/test/dotest_args.py:85-88 dest='skip_categories', help=textwrap.dedent('''Specify categories of test cases to skip. Takes precedence over

[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. The idea seems fine, but I think that the implementation needs more refinement, per the inline comments... Comment at:

[Lldb-commits] [PATCH] D72251: [RFC] Support SVE registers access on AArch64 Linux

omjavaid created this revision. omjavaid added reviewers: labath, clayborg, jankratochvil, jasonmolenda. omjavaid added a project: LLDB. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. This is an RFC patch for the on going effort to support SVE registers

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

MaskRay added a comment. In D71857#1804307 , @Mordante wrote: > In D71857#1800663 , @MaskRay wrote: > > > I think there is a false positive. > > > >

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante added a comment. In D71857#1800663 , @MaskRay wrote: > I think there is a false positive. > > https://github.com/llvm/llvm-project/tree/master/lld/ELF/Relocations.cpp#L1622 > > for (const std::pair ts : isd->thunkSections) > Removing the

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

raj.khem added a comment. this is now in master, and I am seeing build failures in cross-building clang, e.g. when building clang for arm on a x86_64 host. its resorting to finding, libz from buildhost instead of target sysroot ( using --sysroot) and failing in link step. e.g. FAILED: