[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

jankratochvil added a comment. I have reverted this change as it fixed the testsuite but real world usage was broken: (lldb) run assert.test.tmp.out: /home/jkratoch/redhat/llvm-monorepo/lldb/test/Shell/Recognizer/Inputs/assert.c:7: int main(): Assertion `a == 42' failed. Process 12062

[Lldb-commits] [lldb] 6ef4786 - Revert "[lldb] Fix+re-enable Assert StackFrame Recognizer on Linux"

Author: Jan Kratochvil Date: 2020-02-08T05:08:48+01:00 New Revision: 6ef4786dbcd47cfe346ee8679ba0b4d320da797d URL: https://github.com/llvm/llvm-project/commit/6ef4786dbcd47cfe346ee8679ba0b4d320da797d DIFF:

[Lldb-commits] [lldb] 3e70a91 - [lldb/Plugin] Use LLDB_PLUGIN_DECLARE to forward declare plugin initializers

Author: Jonas Devlieghere Date: 2020-02-07T18:02:21-08:00 New Revision: 3e70a9196387437abb794b294d47fde37684337d URL: https://github.com/llvm/llvm-project/commit/3e70a9196387437abb794b294d47fde37684337d DIFF:

[Lldb-commits] [lldb] d62a343 - Add a test for adding and removing Listeners from a BroadcasterManager.

Author: Jim Ingham Date: 2020-02-07T17:54:25-08:00 New Revision: d62a343db23b7e8c3b5f2a0284bcacc10141a49e URL: https://github.com/llvm/llvm-project/commit/d62a343db23b7e8c3b5f2a0284bcacc10141a49e DIFF: https://github.com/llvm/llvm-project/commit/d62a343db23b7e8c3b5f2a0284bcacc10141a49e.diff

[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

friss added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98 + bool IsMangledName(llvm::StringRef name) const override { +return false; + } shafik wrote: > xiaobai wrote: > > friss wrote: > > > The original code was

[Lldb-commits] [PATCH] D74266: [lldb-vscode] remove deprecated trace option

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd62c9cecf34: [lldb-vscode] remove deprecated trace option (authored by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc832e82cd9d8: [lldb-vscode] disable completions (authored by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74264/new/

[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

shafik added subscribers: mib, shafik. shafik added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98 + bool IsMangledName(llvm::StringRef name) const override { +return false; + } xiaobai wrote: > friss wrote: > > The

[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

wallace added a comment. > These completion requests are also expected to be asynchronous right? Do we > have any support for this right now? Currently we will deadlock in > lldb-vscode handling the current completion until it completes right? To > properly handle completion, we will need to

[Lldb-commits] [lldb] c832e82 - [lldb-vscode] disable completions

Author: Walter Erquinigo Date: 2020-02-07T16:54:42-08:00 New Revision: c832e82cd9d8f53ed8af9ec86d9d06fedda9b23b URL: https://github.com/llvm/llvm-project/commit/c832e82cd9d8f53ed8af9ec86d9d06fedda9b23b DIFF:

[Lldb-commits] [lldb] bd62c9c - [lldb-vscode] remove deprecated trace option

Author: Walter Erquinigo Date: 2020-02-07T16:54:42-08:00 New Revision: bd62c9cecf34cc3cea52ad83b278cd7cb62812b4 URL: https://github.com/llvm/llvm-project/commit/bd62c9cecf34cc3cea52ad83b278cd7cb62812b4 DIFF:

[Lldb-commits] [lldb] d7082e0 - [lldb/Plugin] Don't define initializers inside lldb_private

Author: Jonas Devlieghere Date: 2020-02-07T16:50:59-08:00 New Revision: d7082e03373ca6e58d2d187a6890157c4ca9ec47 URL: https://github.com/llvm/llvm-project/commit/d7082e03373ca6e58d2d187a6890157c4ca9ec47 DIFF:

[Lldb-commits] [PATCH] D74266: [lldb-vscode] remove deprecated trace option

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Originally this was going to enable logging to "/tmp/vscode.txt", but it is hard to log something when many packets have already gone by before sending the "launch" or "attach" requests.

[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

clayborg added a comment. These completion requests are also expected to be asynchronous right? Do we have any support for this right now? Currently we will deadlock in lldb-vscode handling the current completion until it completes right? To properly handle completion, we will need to be able

[Lldb-commits] [PATCH] D74266: [lldb-vscode] remove deprecated trace option

wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This option is not used anymore and has been replaced by the env var LLDBVSCODE_LOG. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74266

[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Completion requests are causing some problems in the debugger, which is explained in the comment in the code. I'm disabling it for now until we have time to

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

rupprecht added a comment. In D71151#1813772 , @labath wrote: > Judging by the direction of the lua patches, it doesn't look like we will > have lua "dotest" tests, so I think it's fine to just put this into API > directly (without the extra "test"

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG25675d4eaab6: [lldb][test][NFC] Create a separate LLDB_TEST_SRC var to allow moving tests. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D71150?vs=232656=243301#toc

[Lldb-commits] [lldb] fbb4d1e - [lldb/Plugins] Use external functions to (de)initialize plugins

Author: Jonas Devlieghere Date: 2020-02-07T15:28:27-08:00 New Revision: fbb4d1e43d0db9f8d1514a0209bb01f56e49d75f URL: https://github.com/llvm/llvm-project/commit/fbb4d1e43d0db9f8d1514a0209bb01f56e49d75f DIFF:

[Lldb-commits] [lldb] 25675d4 - [lldb][test][NFC] Create a separate LLDB_TEST_SRC var to allow moving tests.

Author: Jordan Rupprecht Date: 2020-02-07T15:18:36-08:00 New Revision: 25675d4eaab6ed8e97528d4886131ec85f1c8c7c URL: https://github.com/llvm/llvm-project/commit/25675d4eaab6ed8e97528d4886131ec85f1c8c7c DIFF:

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/__init__.py:32 +# TODO(rupprecht): update the above definition after moving test cases: +# lldb_test_root = os.path.join(lldb_root, "test", "API", "test")

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

jingham added a comment. Might also be good to fix the crash. If you don't support software breakpoints, you shouldn't get asked what your breakpoint opcode is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74255/new/

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

labath added a comment. We have infrastructure to "mock" a gdb-remote server (see packages/Python/lldbsuite/test/functionalities/gdb_remote_client/) to test lldb's interaction with it. For a simple patch like this, I don't think a test is really required (especially as they are not the

[Lldb-commits] [lldb] 5858c9d - Revert "[TestConvienceVariable] Clean the directory before running the test."

Author: Davide Italiano Date: 2020-02-07T14:32:30-08:00 New Revision: 5858c9d69f5efa94b721e3d37edadae21cbb77f3 URL: https://github.com/llvm/llvm-project/commit/5858c9d69f5efa94b721e3d37edadae21cbb77f3 DIFF:

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

aykevl created this revision. aykevl added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, Jim, dylanmckay. Herald added a project: LLDB. I believe the actual opcode does not matter because the AVR architecture is a Harvard architecture that does not support writing to

[Lldb-commits] [lldb] 9bce9d2 - [TestConvienceVariable] Clean the directory before running the test.

Author: Davide Italiano Date: 2020-02-07T13:52:40-08:00 New Revision: 9bce9d2d65e2462140597f71a8247750b837094c URL: https://github.com/llvm/llvm-project/commit/9bce9d2d65e2462140597f71a8247750b837094c DIFF:

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

mib added a comment. I used an apt installed lldb so it was probably a build older than Jan 13th. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74252/new/ https://reviews.llvm.org/D74252 ___

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1046c716b3: [lldb] Fix+re-enable Assert StackFrame Recognizer on Linux (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D74252?vs=243266=243274#toc Repository: rG

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. In D74252#1864879 , @mib wrote: > Originally, when I implemented the patch and tested it on linux, the symbol > on the abort frame was (__GI___assert_fail) on my machine.

[Lldb-commits] [lldb] cf1046c - [lldb] Fix+re-enable Assert StackFrame Recognizer on Linux

Author: Jan Kratochvil Date: 2020-02-07T22:24:56+01:00 New Revision: cf1046c716b33ed449aa8fc26376864917c63c25 URL: https://github.com/llvm/llvm-project/commit/cf1046c716b33ed449aa8fc26376864917c63c25 DIFF:

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Originally, when I implemented the patch and tested it on linux, the symbol on the abort frame was (__GI___assert_fail) on my machine. In D73303#1846281 ,

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

jankratochvil created this revision. jankratochvil added reviewers: mib, JDevlieghere, labath. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. D73303 was failing on Fedora Linux and so it was

[Lldb-commits] [PATCH] D74245: [lldb/Plugins] Use external functions to (de)initialize plugins

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine to me. I have one possible simplification idea in an inline comment you can consider... Comment at: lldb/include/lldb/Core/PluginManager.h:34-35 +// FIXME:

[Lldb-commits] [PATCH] D74245: [lldb/Plugins] Use external functions to (de)initialize plugins

JDevlieghere created this revision. JDevlieghere added reviewers: labath, xiaobai. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. This is a step towards making the initialize and terminate calls be generated by CMake, which in turn is towards making it possible to

[Lldb-commits] [PATCH] D74243: [lldb] Introduce "RegInfoBasedABI"

labath created this revision. labath added reviewers: JDevlieghere, jasonmolenda. Herald added subscribers: jsji, atanasyan, jrtc27, kbarton, nemanjai, sdardis. Herald added a project: LLDB. This patch creates a new subclass of the ABI class in order to abstract away the mechanism in which we

[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()

jingham added inline comments. Comment at: lldb/source/Target/Thread.cpp:601 raw_stop_description = stop_info_sp->GetDescription(); +assert(!raw_stop_description.empty() && + "StopInfo returned an empty description."); It is possible to have a

[Lldb-commits] [PATCH] D74244: [lldb] Delete register info definitions in the x86_64 ABI classes

labath created this revision. labath added reviewers: JDevlieghere, jasonmolenda. Herald added a subscriber: mgorny. Herald added a project: LLDB. These definitions are used to "augment" information received from the remote target with eh/debug frame and "generic" register numbers. Besides being

[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()

friss added a comment. I think we're on the same page then. In D74157#1864543 , @jingham wrote: > Since StopInfo::GetStopDescription is a virtual method, there's no guarantee > that a child of StopInfo will always return a non-empty description, when it

[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()

friss updated this revision to Diff 243239. friss added a comment. Remove the fallback code and assert that StopInfo returns a non-empty string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74157/new/ https://reviews.llvm.org/D74157 Files:

[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()

jingham added a comment. In D74157#1863126 , @friss wrote: > In D74157#1863069 , @jingham wrote: > > > In D74157#1862537 , @labath wrote: > > > > > Looks better. TBH, I'm

[Lldb-commits] [lldb] e21b39a - [lldb] Group ABI plugins

Author: Pavel Labath Date: 2020-02-07T09:51:38-08:00 New Revision: e21b39a86dd6e8d1a5a5fe7e0286f8570732834d URL: https://github.com/llvm/llvm-project/commit/e21b39a86dd6e8d1a5a5fe7e0286f8570732834d DIFF: https://github.com/llvm/llvm-project/commit/e21b39a86dd6e8d1a5a5fe7e0286f8570732834d.diff

[Lldb-commits] [PATCH] D74138: [lldb] Group ABI plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rGe21b39a86dd6: [lldb] Group ABI plugins (authored by labath). Changed prior to commit: https://reviews.llvm.org/D74138?vs=242921=243208#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

mib added a comment. The test seems to fail on certain linux distros (fedora and archlinux) ... Since it's not a breaking change, I sent a patch to skip it on linux, until I can reproduce it on those platform and fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 2e005c6 - [lldb/test] Skip the AssertFrameRecognizer test for Linux

Author: Med Ismail Bennani Date: 2020-02-07T18:49:35+01:00 New Revision: 2e005c64f3019aada8df29a24dcfe56f044e2e59 URL: https://github.com/llvm/llvm-project/commit/2e005c64f3019aada8df29a24dcfe56f044e2e59 DIFF:

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

labath added a comment. Yeah, we should fill in the other attributes too. As that will probably noticeably increase the amount of code, it would be good to put this stuff into a separate function (or two..). For a test, you could create some kind of a lldb-server test

[Lldb-commits] [lldb] 8033161 - [lldb] Delete ValueObjectRegisterContext class

Author: Pavel Labath Date: 2020-02-07T09:20:22-08:00 New Revision: 80331610729137db55d29c902e5e464fbf9bd931 URL: https://github.com/llvm/llvm-project/commit/80331610729137db55d29c902e5e464fbf9bd931 DIFF: https://github.com/llvm/llvm-project/commit/80331610729137db55d29c902e5e464fbf9bd931.diff

[Lldb-commits] [PATCH] D73974: [lldb] Improve debugging 32-bit programs on NetBSD/amd64

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ff411295f92: [lldb] Improve debugging 32-bit programs on NetBSD/amd64 (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, let's give this one more try. I have a couple of inline comments for the further simplification of the test case. Comment at:

[Lldb-commits] [PATCH] D74212: [lldb/Target] Fix `frame recognizer list` crash when registered with nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit rG047c4b0369f0: [lldb/Target] Fix `frame recognizer list` crash when registered with nullptr (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 047c4b0 - [lldb/Target] Fix `frame recognizer list` crash when registered with nullptr

Author: Med Ismail Bennani Date: 2020-02-07T17:35:29+01:00 New Revision: 047c4b0369f05ba2f96c79151641f07035bec954 URL: https://github.com/llvm/llvm-project/commit/047c4b0369f05ba2f96c79151641f07035bec954 DIFF:

[Lldb-commits] [lldb] 96054a1 - [lldb/test] Prevent TestFrameRecognizer.py to fail because of internal recognizers (NFC)

Author: Med Ismail Bennani Date: 2020-02-07T17:35:29+01:00 New Revision: 96054a1857e597ec15c36b935ea076a550047f02 URL: https://github.com/llvm/llvm-project/commit/96054a1857e597ec15c36b935ea076a550047f02 DIFF:

[Lldb-commits] [PATCH] D74212: [lldb/Target] Fix `frame recognizer list` crash when registered with nullptr

mib updated this revision to Diff 243177. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74212/new/ https://reviews.llvm.org/D74212 Files: lldb/source/Target/StackFrameRecognizer.cpp lldb/unittests/Target/CMakeLists.txt

[Lldb-commits] [PATCH] D74212: [lldb/Target] Fix `frame recognizer list` crash when registered with nullptr

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/unittests/Target/StackFrameRecognizerTest.cpp:83-87 +if (name == "") + name = "(internal)"; +stream_sp->Printf("%d: %s, module

[Lldb-commits] [PATCH] D74212: [lldb/Target] Fix `frame recognizer list` crash when registered with nullptr

mib updated this revision to Diff 243161. mib added a comment. Removed used class member Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74212/new/ https://reviews.llvm.org/D74212 Files: lldb/source/Target/StackFrameRecognizer.cpp

[Lldb-commits] [PATCH] D74212: [lldb/Target] Fix `frame recognizer list` crash when registered with nullptr

mib updated this revision to Diff 243160. mib retitled this revision from "[lldb/Target] Fix `recognizer list` crash when registered with nullptre" to "[lldb/Target] Fix `frame recognizer list` crash when registered with nullptr". mib edited the summary of this revision. mib added a comment.

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

jarin added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2819 +response.Printf(""); +const int registersCount = 128; +for (int reg_index = 0; reg_index < registersCount; reg_index++) { As

[Lldb-commits] [lldb] 0082f1e - [lldb] Improve error message when running static initializers in an expression fails

Author: Raphael Isemann Date: 2020-02-07T13:46:28+01:00 New Revision: 0082f1e0ccb215592d187b0a343608ad7813db30 URL: https://github.com/llvm/llvm-project/commit/0082f1e0ccb215592d187b0a343608ad7813db30 DIFF:

[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

kschwarz added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") Hi @JDevlieghere, we've noticed that with this patch check-llvm isn't added to check-all anymore by default.

[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fe839ef3a51: [CMake] Rename EXCLUDE_FROM_ALL and make it an argument to add_lit_testsuite (authored by JDevlieghere). Herald added projects: clang, Sanitizers, OpenMP. Herald added subscribers:

[Lldb-commits] [PATCH] D73847: `Debug` (but not `Release`): error: undefined reference to `ThreadPlanCallFunctionUsingABI` ctor && `ThreadPlanCallUserExpression` ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rG88cd49e941b9: [lldb] Increase LINK_INTERFACE_MULTIPLICITY for Debug builds (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74212: [lldb/Target] Fix `recognizer list` crash when registered with nullptre

mib created this revision. mib added reviewers: teemperor, friss. mib added a project: LLDB. Herald added a subscriber: lldb-commits. One way to register a recognizer is to use RegularExpressionSP for the module and symbol. In order to match a symbol regardless of the module, the recognizer can

[Lldb-commits] [PATCH] D74126: [lldb] Remove all 'clean' targets from test Makefiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG68cc9f80a6bf: [lldb] Remove all clean targets from test Makefiles (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74126/new/

[Lldb-commits] [PATCH] D74126: [lldb] Remove all 'clean' targets from test Makefiles

teemperor updated this revision to Diff 243106. teemperor added a comment. - Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74126/new/ https://reviews.llvm.org/D74126 Files: lldb/packages/Python/lldbsuite/test/api/multithreaded/Makefile

[Lldb-commits] [lldb] 68cc9f8 - [lldb] Remove all 'clean' targets from test Makefiles

Author: Raphael Isemann Date: 2020-02-07T11:24:52+01:00 New Revision: 68cc9f80a6bfd7b88a761d29c757d0ec6544e126 URL: https://github.com/llvm/llvm-project/commit/68cc9f80a6bfd7b88a761d29c757d0ec6544e126 DIFF:

[Lldb-commits] [PATCH] D74160: [lldb] removed no longer needed CMakeDependentOption

This revision was automatically updated to reflect the committed changes. Closed by commit rGb89131cdda58: [lldb] removed no longer needed CMakeDependentOption (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74160/new/

[Lldb-commits] [lldb] b89131c - [lldb] removed no longer needed CMakeDependentOption

Author: Konrad Kleine Date: 2020-02-07T09:23:35+01:00 New Revision: b89131cdda5871731a9139664aef2b70c6d72bbd URL: https://github.com/llvm/llvm-project/commit/b89131cdda5871731a9139664aef2b70c6d72bbd DIFF: https://github.com/llvm/llvm-project/commit/b89131cdda5871731a9139664aef2b70c6d72bbd.diff