[Lldb-commits] [PATCH] D74917: [lldb/cmake] Enable more verbose find_package output.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74917/new/ https://reviews.llvm.org/D74917 ___ lldb-commits

[Lldb-commits] [PATCH] D74917: [lldb/cmake] Enable more verbose find_package output.

mattd updated this revision to Diff 245771. mattd retitled this revision from "[lldb/cmake] Fail configuration if a required swig dependency is not met." to "[lldb/cmake] Enable more verbose find_package output.". mattd edited the summary of this revision. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74917: [lldb/cmake] Fail configuration if a required swig dependency is not met.

mattd added a comment. In D74917#1885621 , @JDevlieghere wrote: > In D74917#1885615 , @mattd wrote: > > > In D74917#1885590 , @JDevlieghere > > wrote: > > > > > It should

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245770. hhb added a comment. The code should check on LLDB_EMBED_PYTHON_HOME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D74917: [lldb/cmake] Fail configuration if a required swig dependency is not met.

JDevlieghere added a comment. In D74917#1885615 , @mattd wrote: > In D74917#1885590 , @JDevlieghere > wrote: > > > It should never be possible for `LLDB_ENABLE_PYTHON` to be true but > > `SWIG_FOUND` to be false.

[Lldb-commits] [PATCH] D74917: [lldb/cmake] Fail configuration if a required swig dependency is not met.

mattd updated this revision to Diff 245763. mattd retitled this revision from "[lldb/bindings] Fail configuration when a required dependency is not met." to "[lldb/cmake] Fail configuration if a required swig dependency is not met.". CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74917: [lldb/bindings] Fail configuration when a required dependency is not met.

mattd added a comment. In D74917#1885590 , @JDevlieghere wrote: > It should never be possible for `LLDB_ENABLE_PYTHON` to be true but > `SWIG_FOUND` to be false. The modules `FindPythonInterpAndLibs.cmake` and > `FindLuaAndSwig.cmake` should fail early

[Lldb-commits] [PATCH] D74917: [lldb/bindings] Fail configuration when a required dependency is not met.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. It should never be possible for `LLDB_ENABLE_PYTHON` to be true but `SWIG_FOUND` to be false. The modules `FindPythonInterpAndLibs.cmake` and `FindLuaAndSwig.cmake`

[Lldb-commits] [lldb] 0d19b01 - [lldb/Test] Remove stale README in test/API

Author: Jonas Devlieghere Date: 2020-02-20T14:52:39-08:00 New Revision: 0d19b016226dc2c442a34abfe9b9c06ab4d7ea1e URL: https://github.com/llvm/llvm-project/commit/0d19b016226dc2c442a34abfe9b9c06ab4d7ea1e DIFF:

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245750. hhb added a comment. Move option() into if Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [lldb] 3ee2810 - [lldb/Plugin] Don't mark ProcessNetBSD as a plugin

Author: Jonas Devlieghere Date: 2020-02-20T14:35:49-08:00 New Revision: 3ee281082737d18585abff3b482a7ab86af73b5a URL: https://github.com/llvm/llvm-project/commit/3ee281082737d18585abff3b482a7ab86af73b5a DIFF:

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes

JDevlieghere accepted this revision. JDevlieghere added a comment. A few small nits inline, but this LGTM if Pavel is on board. Comment at: lldb/source/Commands/CommandObjectProcess.cpp:1260 +if (command.GetArgumentCount()) { + result.AppendError("`process status`

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes

mib updated this revision to Diff 245721. mib retitled this revision from "[lldb/Plugins] Add `platform process crash-info` command" to "[lldb/Plugins] Add ability to fetch crash information on crashed processes". mib edited the summary of this revision. mib added a comment. Moved invocation to

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add `platform process crash-info` command

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1574-1577 +interpreter, "platform process", +"Commands to query, launch and attach to " +"processes on the current

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Reverted again with rG2f215cf36adc . The investigation is needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

ostannard added a comment. Reproducer for that crash: P8198 P8199 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ lldb-commits

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

krytarowski added a comment. Autogeneration of the code puts extra burden on us for tracking what is defined where and for repackaging LLDB with custom build rules (we need plain Makefile in the distribution). I presume the same problem is for gn users, for FreeBSD etc. The NetBSD buildbot is

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Nice! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D74917: [lldb/bindings] Fail configuration when a required dependency is not met.

mattd created this revision. mattd added reviewers: aadsm, hhb. mattd added a project: LLDB. Herald added a subscriber: mgorny. If the SWIG dependency is required {LLDB_ENABLE_PYTHON, LLDB_ENABLE_LUA} and SWIG is not available, fail the configuration step. Terminate the configure early rather

[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper functions to manage settings in test-suite

teemperor added a comment. I'm kinda curious how much we actually support this? I know we do a lot of random fiddling with settings and what not, but I feel if we anyway say that each test needs to have a clean setup, can't we just create like a new SBDebugger instance or something like that

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf64b31959f6: Add target.xml support for qXfer request. (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D74217?vs=245167=245686#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D74859: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ffa6e1a7e1c: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0ffa6e1 - [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY

Author: Jordan Rupprecht Date: 2020-02-20T10:07:50-08:00 New Revision: 0ffa6e1a7e1c5de36276375486f49277c6f95d0e URL: https://github.com/llvm/llvm-project/commit/0ffa6e1a7e1c5de36276375486f49277c6f95d0e DIFF:

[Lldb-commits] [lldb] af64b31 - Add target.xml support for qXfer request.

Author: Muhammad Omair Javaid Date: 2020-02-20T23:03:54+05:00 New Revision: af64b31959f634031e5ddbcf8df1fab69689bfee URL: https://github.com/llvm/llvm-project/commit/af64b31959f634031e5ddbcf8df1fab69689bfee DIFF:

[Lldb-commits] [PATCH] D74859: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY

JDevlieghere accepted this revision. JDevlieghere added a comment. In D74859#1884159 , @labath wrote: > > Aside: I'm not sure we really need all the different versions since we've > > moved to the monorepo layout -- I don't think anyone is using

[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper-functions to manage settings in test-suite

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, labath. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. Some tests set settings and don't clean them up, this leads to side effects in other tests. The patch

[Lldb-commits] [lldb] 2f215cf - Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""

Author: Djordje Todorovic Date: 2020-02-20T14:41:39+01:00 New Revision: 2f215cf36adced6bf1abda4bdbbc6422c1369353 URL: https://github.com/llvm/llvm-project/commit/2f215cf36adced6bf1abda4bdbbc6422c1369353 DIFF:

[Lldb-commits] [PATCH] D74895: [lldb]: fix typo in lldb-gdb-remote.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7b7f76ae6ae: [lldb]: fix typo in lldb-gdb-remote.txt (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74895/new/

[Lldb-commits] [lldb] c7b7f76 - [lldb]: fix typo in lldb-gdb-remote.txt

Author: Konrad Kleine Date: 2020-02-20T14:30:12+01:00 New Revision: c7b7f76ae6ae2a5f3d9753b37ef811da15386cd4 URL: https://github.com/llvm/llvm-project/commit/c7b7f76ae6ae2a5f3d9753b37ef811da15386cd4 DIFF: https://github.com/llvm/llvm-project/commit/c7b7f76ae6ae2a5f3d9753b37ef811da15386cd4.diff

[Lldb-commits] [PATCH] D74895: [lldb]: fix typo in lldb-gdb-remote.txt

labath accepted this revision. labath added a comment. yep Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74895/new/ https://reviews.llvm.org/D74895 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D74895: [lldb]: fix typo in lldb-gdb-remote.txt

kwk created this revision. kwk added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The logic of the sentence made more sense when "with" is replaced with "without". Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74895 Files:

[Lldb-commits] [lldb] 7b59ff2 - [lldb] Add boilerplate to recognize the .debug_tu_index section

Author: Pavel Labath Date: 2020-02-20T13:44:21+01:00 New Revision: 7b59ff2fa0a56a0158f3f21aaed217118da669a3 URL: https://github.com/llvm/llvm-project/commit/7b59ff2fa0a56a0158f3f21aaed217118da669a3 DIFF: https://github.com/llvm/llvm-project/commit/7b59ff2fa0a56a0158f3f21aaed217118da669a3.diff

[Lldb-commits] [PATCH] D74891: [lldb] Never compile the debugserver with Clang module flags

teemperor created this revision. Herald added subscribers: lldb-commits, JDevlieghere, mgorny. Herald added a project: LLDB. Compiling ObjC++ with Clang modules is usually not working well and compiling the small debugserver with modules is not worth the trouble. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. @ostannard Thanks for reporting that! Please share the case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. In D73534#1883048 , @djtodoro wrote: > I’ve already pushed this. Please rebase on the latest commits. Ah faff707db82d7db12fcd9f7826b8741261230e63 .

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

ostannard added a comment. There's a failure on an ARM 2-stage buildbot which looks related to this: http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh/builds/3920/steps/build%20stage%202/logs/stdio I can reproduce the crash on the buildbot machine, so hopefully I'll have a

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1883022 , @nickdesaulniers wrote: > In D73534#1882136 , @djtodoro wrote: > > > - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've > > reduced the test

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. In D73534#1882136 , @djtodoro wrote: > - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've > reduced the test > `llvm/test/DebugInfo/MIR/ARM/dbgcallsite-noreg-is-imm-check.mir`) I'd like to help

[Lldb-commits] [lldb] ddf60ba - [lldb/DWARF] Always construct a DWARFDebugInfo object

Author: Pavel Labath Date: 2020-02-20T10:51:40+01:00 New Revision: ddf60ba09f2cf31851ea165c7c5fcfc4c2ad546e URL: https://github.com/llvm/llvm-project/commit/ddf60ba09f2cf31851ea165c7c5fcfc4c2ad546e DIFF: https://github.com/llvm/llvm-project/commit/ddf60ba09f2cf31851ea165c7c5fcfc4c2ad546e.diff

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good to me. Comment at: lldb/cmake/modules/LLDBConfig.cmake:68-70 +option(LLDB_EMBED_PYTHON_HOME + "Embed PYTHONHOME in the binary. If set to OFF,

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add `platform process crash-info` command

labath added a comment. This looks a bit better, but my the purpose of my previous command was not to move the location of the cli command itself -- I think it was ok just where it was. The fact that the part of the functionality is implemented in the Platform class does not mean the cli