[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

jingham updated this revision to Diff 249257. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75880/new/ https://reviews.llvm.org/D75880 Files: lldb/include/lldb/Target/Process.h lldb/include/lldb/Target/Thread.h

[Lldb-commits] [PATCH] D75761: Fix to get the AST we generate for function templates to be closer to what clang generates and expects

shafik updated this revision to Diff 249247. shafik marked 11 inline comments as done. shafik added a comment. Moving to using `ItaniumPartialDemangler` for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75761/new/ https://reviews.llvm.org/D75761 Files:

[Lldb-commits] [PATCH] D75761: Fix to get the AST we generate for function templates to be closer to what clang generates and expects

shafik added a comment. In D75761#1912038 , @labath wrote: > It's a pity that the clang's DW_AT_name value is so ambiguous. For example, > gcc would output the name in the commit message as `operator< `, which > is a lot more parsable (for computers and

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

jingham created this revision. jingham added reviewers: friss, clayborg, labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. jingham added parent revisions: D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread, D75720: Make

[Lldb-commits] [PATCH] D75761: Fix to get the AST we generate for function templates to be closer to what clang generates and expects

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Small nit pick: Use `expect_expr(` over `expect("expr ...` if you do a Python test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75761/new/

[Lldb-commits] [lldb] 9d389f7 - [AppleObjCRuntimeV2] Fix a typo. Evalulate -> evaluate.

Author: Davide Italiano Date: 2020-03-09T15:40:09-07:00 New Revision: 9d389f78589d71adf822c97c329baa62da70b34c URL: https://github.com/llvm/llvm-project/commit/9d389f78589d71adf822c97c329baa62da70b34c DIFF:

[Lldb-commits] [PATCH] D75715: Switch TypeSystemClang over to CreateDeserialized() (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. The changes that remove the non-existent module parameter slipped in by mistake I think and the rest LGTM. I didn't verify if all the `setX` calls are 100% identical to what the

[Lldb-commits] [PATCH] D75864: Add a decorator option to skip tests based on a default setting

JDevlieghere added inline comments. Comment at: lldb/test/API/sanity/TestSettingSkipping.py:28 + def testNotExisting(self): +self.assertTrue(True, "This test should run!") + This won't trip if the tests doesn't run. If you make the assert trip and XFAIL

[Lldb-commits] [lldb] a3c4e6b - [AppleObjC2RuntimeV2] Remove dead code. NFC.

Author: Davide Italiano Date: 2020-03-09T15:37:12-07:00 New Revision: a3c4e6b44a18ffafec022d6ab76dc4f58c4ef129 URL: https://github.com/llvm/llvm-project/commit/a3c4e6b44a18ffafec022d6ab76dc4f58c4ef129 DIFF:

[Lldb-commits] [lldb] 3cabd17 - [ObjC] Dynamic type resolution logging should go to the types log.

Author: Davide Italiano Date: 2020-03-09T15:35:51-07:00 New Revision: 3cabd173a1e34febbf0351599b760a5516e64ec4 URL: https://github.com/llvm/llvm-project/commit/3cabd173a1e34febbf0351599b760a5516e64ec4 DIFF:

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jasonmolenda. Herald added a subscriber: teemperor. Herald added a project: LLDB. Support replaying debug sessions that attach to an existing process instead of lldb launching the inferior. Bypass the logic that looks for

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

labath added a comment. > Everything that holds onto its state using an ExecutionContextRef already > holds onto the m_tid as the real entity, and the Thread is only a cache (see > ExecutionContextRef::GetThreadSP). I'm sorry I missed that part. (I saw the ThreadWP, but didn't look further

[Lldb-commits] [PATCH] D75810: [lldb] Add .clang-tidy with customization to disable readability-identifier-naming

This revision was automatically updated to reflect the committed changes. Closed by commit rG71269a1f172c: [lldb] Add .clang-tidy with customization to disable readability-identifier… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 71269a1 - [lldb] Add .clang-tidy with customization to disable readability-identifier-naming

Author: Fangrui Song Date: 2020-03-09T12:50:28-07:00 New Revision: 71269a1f172cdad1cc0d7e2e6c94a7ece11ddb27 URL: https://github.com/llvm/llvm-project/commit/71269a1f172cdad1cc0d7e2e6c94a7ece11ddb27 DIFF: https://github.com/llvm/llvm-project/commit/71269a1f172cdad1cc0d7e2e6c94a7ece11ddb27.diff

[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

jasonmolenda accepted this revision. jasonmolenda added a comment. Thanks for doing this, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75848/new/ https://reviews.llvm.org/D75848 ___

[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for doing this. LGTM, might want to wait for Jason's approval like Jonas said though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75864: Add a decorator option to skip tests based on a default setting

aprantl created this revision. aprantl added reviewers: labath, JDevlieghere, jingham. This patch allows skipping a test based on a default setting, which is useful when running the testsuite in different "modes" based on a default setting. This is a feature I need for the Swift testsuite, but

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

jingham added a comment. In D75711#1912230 , @labath wrote: > Thanks for the detailed response. I'll try to be equally understandable. > > In D75711#1910155 , @jingham wrote: > > > In D75711#1909055

[Lldb-commits] [PATCH] D75810: [lldb] Add .clang-tidy with customization to disable readability-identifier-naming

MaskRay updated this revision to Diff 249139. MaskRay retitled this revision from "[lldb] Add .clang-tidy with customization to readability-identifier-naming.{Function,Member,Parameter,Variable}Case" to "[lldb] Add .clang-tidy with customization to disable readability-identifier-naming".

[Lldb-commits] [lldb] 12ba989 - [lldb/Process] Update ThreadKDP for API change

Author: Jonas Devlieghere Date: 2020-03-09T10:01:53-07:00 New Revision: 12ba989eeffbca12b501b9fde0a697c833fdfb1a URL: https://github.com/llvm/llvm-project/commit/12ba989eeffbca12b501b9fde0a697c833fdfb1a DIFF:

[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

JDevlieghere added a comment. Jason should make the call but looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75848/new/ https://reviews.llvm.org/D75848 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D75810: [lldb] Add .clang-tidy with customization to readability-identifier-naming.{Function, Member, Parameter, Variable}Case

JDevlieghere added a comment. In D75810#1912248 , @labath wrote: > Yeah, naming conventions in lldb have always been a controversial topic. Most > of the code uses the lldb convention, but some of the new code (particularly > if it interfaces with llvm

[Lldb-commits] [lldb] 2b6ad82 - [lldb/test] Fix arch arm for 32-bit armv7l/armv8l

Author: Muhammad Omair Javaid Date: 2020-03-09T20:32:18+05:00 New Revision: 2b6ad82f8d0b20c6733217fcc6b3a07333287875 URL: https://github.com/llvm/llvm-project/commit/2b6ad82f8d0b20c6733217fcc6b3a07333287875 DIFF:

[Lldb-commits] [lldb] 34d7143 - [lldb] Fix windows build, second attempt

Author: Pavel Labath Date: 2020-03-09T16:24:34+01:00 New Revision: 34d7143b035b3db64077968a09185834c1e7e9a7 URL: https://github.com/llvm/llvm-project/commit/34d7143b035b3db64077968a09185834c1e7e9a7 DIFF: https://github.com/llvm/llvm-project/commit/34d7143b035b3db64077968a09185834c1e7e9a7.diff

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 249096. kwk added a comment. - Fix include ordering based on clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindDebuginfod.cmake

[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

labath created this revision. labath added reviewers: jasonmolenda, JDevlieghere, xiaobai. Herald added a subscriber: mgorny. Herald added a project: LLDB. This is the only real unwinder, and things have been this way for quite a long time. At this point, the class has accumulated so many

[Lldb-commits] [lldb] 24b1831 - [lldb] Fix windows builds for c0b1af68

Author: Pavel Labath Date: 2020-03-09T14:55:43+01:00 New Revision: 24b1831ebfb50a2ded01506049d6c1c2f34c4a27 URL: https://github.com/llvm/llvm-project/commit/24b1831ebfb50a2ded01506049d6c1c2f34c4a27 DIFF: https://github.com/llvm/llvm-project/commit/24b1831ebfb50a2ded01506049d6c1c2f34c4a27.diff

[Lldb-commits] [lldb] c0b1af6 - [lldb] Return Unwinder& from Thread::GetUnwinder

Author: Pavel Labath Date: 2020-03-09T14:13:22+01:00 New Revision: c0b1af6878444f075a17d87f523bc6be3343db35 URL: https://github.com/llvm/llvm-project/commit/c0b1af6878444f075a17d87f523bc6be3343db35 DIFF: https://github.com/llvm/llvm-project/commit/c0b1af6878444f075a17d87f523bc6be3343db35.diff

[Lldb-commits] [PATCH] D75730: [lldb] Reduce duplication in the Disassembler class

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf3db4e9aa8f: [lldb] Reduce duplication in the Disassembler class (authored by labath). Changed prior to commit: https://reviews.llvm.org/D75730?vs=248676=249072#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectSettings.cpp:1119-1122 +if (m_options.m_clear_all) { + GetDebugger().GetValueProperties()->Clear(); + return result.Succeeded(); +} What will happen if I pass both

[Lldb-commits] [lldb] af3db4e - [lldb] Reduce duplication in the Disassembler class

Author: Pavel Labath Date: 2020-03-09T13:41:43+01:00 New Revision: af3db4e9aa8fbe7e43f89cdde780c6acc35368be URL: https://github.com/llvm/llvm-project/commit/af3db4e9aa8fbe7e43f89cdde780c6acc35368be DIFF: https://github.com/llvm/llvm-project/commit/af3db4e9aa8fbe7e43f89cdde780c6acc35368be.diff

[Lldb-commits] [PATCH] D75810: [lldb] Add .clang-tidy with customization to readability-identifier-naming.{Function, Member, Parameter, Variable}Case

labath added a comment. Yeah, naming conventions in lldb have always been a controversial topic. Most of the code uses the lldb convention, but some of the new code (particularly if it interfaces with llvm a lot) uses more llvm-like conventions. I think we used to have a description of the

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

labath added a comment. Thanks for the detailed response. I'll try to be equally understandable. In D75711#1910155 , @jingham wrote: > In D75711#1909055 , @labath wrote: > > > I am somewhat worried about the

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk marked an inline comment as done. kwk added a comment. @labath thank you for your early feedback. It was helpful even though this is still a work in progress. Comment at: lldb/source/Host/common/DebugInfoD.cpp:43-67 +UUID getBuildIDFromModule(const ModuleSP ) { + UUID

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 249047. kwk marked 3 inline comments as done. kwk added a comment. Changes suggested by elfutils maintainers: - Silently ignore error when no DEBUGINFOD_URLS was given as an environment variable (ENOSYS). - Silently ignore error when the build ID could not be

[Lldb-commits] [PATCH] D75761: Fix to get the AST we generate for function templates to be closer to what clang generates and expects

labath added a comment. It's a pity that the clang's DW_AT_name value is so ambiguous. For example, gcc would output the name in the commit message as `operator< `, which is a lot more parsable (for computers and people). Have you looked at changing clang's output to make it more like gcc's ?

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

omjavaid added a comment. In D7#1909194 , @labath wrote: > Yep, that test really shouldn't be doing that. Historically, lldb has been > avoiding architecture specific artifacts (like assembly) in its tests, but > that didn't really work out here.

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

labath added inline comments. Comment at: lldb/include/lldb/Host/DebugInfoD.h:26 + +llvm::Error findSource(UUID buildID, const std::string , + std::string _path); Expected ? Comment at:

[Lldb-commits] [lldb] ee4dc98 - [lldb/test] Remove skip arm/aarch64 decorator from instruction counting tests

Author: Muhammad Omair Javaid Date: 2020-03-09T12:54:42+05:00 New Revision: ee4dc980c031d00ba729dfd731808b214e01ee58 URL: https://github.com/llvm/llvm-project/commit/ee4dc980c031d00ba729dfd731808b214e01ee58 DIFF: