[Lldb-commits] [PATCH] D80793: [lldb][NFC] Make ClangExpressionSourceCode's wrapping logic more consistent

shafik added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h:41 +/// Note that this is also used for static member functions of a C++ class. +Function + }; I would actually feel better have a separate

[Lldb-commits] [PATCH] D80793: [lldb][NFC] Make ClangExpressionSourceCode's wrapping logic more consistent

shafik added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h:33-40 +/// Wrapped in a member function of a C++ class. +CppMemberFunction, +/// Wrapped in a instance Objective-C method. +ObjCInstanceMethod, +

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa0b674fd7f06: Fix UB in EmulateInstructionARM64.cpp (authored by aprantl). Herald added a subscriber: mgorny. Herald

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

aprantl added a comment. > This is great Adrian. I feel like there are several other instances of > additions that should use llvm::checkAdd here instead of +. Is this the only > UB triggered in the testsuite? It's the only UB caught by the green dragon / ci.swift.org bots. CHANGES SINCE

[Lldb-commits] [lldb] a0b674f - Fix UB in EmulateInstructionARM64.cpp

Author: Adrian Prantl Date: 2020-06-01T18:11:50-07:00 New Revision: a0b674fd7f06b86241cf19387313b508248a3868 URL: https://github.com/llvm/llvm-project/commit/a0b674fd7f06b86241cf19387313b508248a3868 DIFF: https://github.com/llvm/llvm-project/commit/a0b674fd7f06b86241cf19387313b508248a3868.diff

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp:99 + if (!overflow) +overflow |= !llvm::checkedAdd(*signed_sum, SInt(carry_in)); uint64_t result = unsigned_sum;

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

davide added a comment. This is great Adrian. I feel like there are several other instances of additions that should use `llvm::checkAdd` here instead of `+`. Is this the only UB triggered in the testsuite? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80955/new/

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

davide added inline comments. Comment at: lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp:25 +#include + shafik wrote: > Why? also should be `cstdlib` in C++. It's just something shuffled around, probably a side effect of clang-format.

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

jarin updated this revision to Diff 267754. jarin added a comment. Added a test for missing nibble in UUID. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80755/new/ https://reviews.llvm.org/D80755 Files: lldb/include/lldb/Utility/UUID.h lldb/source/Interpreter/OptionValueUUID.cpp

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

shafik added inline comments. Comment at: lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp:25 +#include + Why? also should be `cstdlib` in C++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80955/new/

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

jasonmolenda added a comment. Nice cleanup of a long standing undefined behavior warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80955/new/ https://reviews.llvm.org/D80955 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

vsk added a comment. I should add: otherwise, this looks good! Comment at: lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp:99 + if (!overflow) +overflow |= !llvm::checkedAdd(*signed_sum, SInt(carry_in)); uint64_t result = unsigned_sum;

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

vsk added a comment. Any chance we can export AddWithCarry via EmulateInstructionARM64.h, then add a unit test in TestArm64InstEmulation.cpp? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80955/new/ https://reviews.llvm.org/D80955 ___

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

jarin updated this revision to Diff 267739. jarin edited the summary of this revision. jarin added a comment. Removed size restrictions on UUIDs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80755/new/ https://reviews.llvm.org/D80755 Files: lldb/include/lldb/Utility/UUID.h

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

jarin marked an inline comment as done. jarin added inline comments. Comment at: lldb/source/Utility/UUID.cpp:109 *this = fromData(bytes); -return str.size() - rest.size(); +return str.size(); } jankratochvil wrote: > Now the return type could be

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

aprantl created this revision. aprantl added reviewers: jasonmolenda, vsk. Herald added subscribers: danielkiss, kristof.beyls. This fixes an unhandled signed integer overflow in AddWithCarry() by using the llvm::checkedAdd() function. Thats to @vsk for the suggestion!

[Lldb-commits] [lldb] 382f6d3 - [lldb/Test] Add test for man page and lldb --help output

Author: Jonas Devlieghere Date: 2020-06-01T13:04:45-07:00 New Revision: 382f6d37a1f2ec472a1f869be2d33078fe6ea8da URL: https://github.com/llvm/llvm-project/commit/382f6d37a1f2ec472a1f869be2d33078fe6ea8da DIFF:

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

dblaikie added a subscriber: aprantl. dblaikie added inline comments. Comment at: lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/main.cpp:8 + // FROM-FUNC1-NEXT: func1 + // FROM-FUNC1-SAME: [artificial] + // FROM-FUNC1-NEXT: main

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm! Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3740 + if (tail_call) +call_inst_pc = low_pc; + else labath

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

rmaz added a comment. In D80659#2062304 , @labath wrote: > Btw, given that Richard has found some vscode code which already tries to > send stderr to the console window >

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3740 + if (tail_call) +call_inst_pc = low_pc; + else vsk wrote: > labath wrote: > > vsk wrote: > > > I

[Lldb-commits] [lldb] 54422d2 - Revert "[lldb] Pass -fPIC flag even when DYLIB_ONLY is set"

Author: Raphael Isemann Date: 2020-06-01T14:41:08+02:00 New Revision: 54422d21700cfb532c80b22662f7b79d741b21ba URL: https://github.com/llvm/llvm-project/commit/54422d21700cfb532c80b22662f7b79d741b21ba DIFF:

[Lldb-commits] [PATCH] D80793: [lldb][NFC] Make ClangExpressionSourceCode's wrapping logic more consistent

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b37c5b56058: [lldb][NFC] Make ClangExpressionSourceCodes wrapping logic more consistent (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] 2b37c5b - [lldb][NFC] Make ClangExpressionSourceCode's wrapping logic more consistent

Author: Raphael Isemann Date: 2020-06-01T13:24:30+02:00 New Revision: 2b37c5b560584f05edf5d375d4ca86fe9c5b0173 URL: https://github.com/llvm/llvm-project/commit/2b37c5b560584f05edf5d375d4ca86fe9c5b0173 DIFF:

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 267564. fallkrum added a comment. Added changes made to Thread.cpp itself to the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 Files:

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 267561. fallkrum added a comment. Herald added subscribers: dexonsmith, mgorny. Unit tests added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 Files:

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

labath added a reviewer: friss. labath added inline comments. Comment at: lldb/source/Utility/UUID.cpp:93-94 +bool UUID::SetFromStringRef(llvm::StringRef str) { + const size_t max_uuid_size = 20; + const size_t min_uuid_size = 4; + I don't think we should be

[Lldb-commits] [PATCH] D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D80807#2063196 , @friss wrote: > I would have committed this right away if it weren't for the slight change in > behavior I wanted to point out.