[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik updated this revision to Diff 285233. shafik marked 4 inline comments as done. shafik added a comment. Updated test using more compact code from Fred. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85376/new/ https://reviews.llvm.org/D85376 Files:

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

wallace added a comment. Thanks for doing this. There are some basic bits to make this that I was unaware of, so this saves a lot of time for me :) I'll take over this patch next week and fill it with intel-pt stuff, I already have a good amount of code that is quite mergeable with this patch.

[Lldb-commits] [PATCH] D85859: [lldb] Fix relative imports and set the appropriate include dirs

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbfd831ddac2: [lldb] Fix relative imports and set the appropriate include dirs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] fbfd831 - [lldb] Fix relative imports and set the appropriate include dirs

Author: Jonas Devlieghere Date: 2020-08-12T16:28:46-07:00 New Revision: fbfd831ddac2a9dd2e7bcdf179c88de7c9c5f5ae URL: https://github.com/llvm/llvm-project/commit/fbfd831ddac2a9dd2e7bcdf179c88de7c9c5f5ae DIFF:

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

aprantl added a comment. I only added a few non-substantial inline comments. Comment at: lldb/include/lldb/Target/Trace.h:39 +public: + ~Trace() override = default; + I'm just curious: What's the purpose of this? Is the destructor = 0 in the base class and

[Lldb-commits] [PATCH] D85859: [lldb] Fix relative imports and set the appropriate include dirs

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Looks plausible! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85859/new/ https://reviews.llvm.org/D85859 ___

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

friss added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/valueobject-pass-by-reg.s:14-40 +# typedef union +# { +# unsigned raw; +# struct +# { +# unsigned a : 8; +# unsigned b : 8; This gives a much more compact debug info section:

[Lldb-commits] [PATCH] D85859: [lldb] Fix relative imports and set the appropriate include dirs

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, aprantl. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. After moving python.swig and lua.swig into their respective subdirectories, the relative paths in these files were out of date. This

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

teemperor added a comment. I'll leave the test review to Pavel who knows that much better, but I have two last nits about the test. Comment at: lldb/test/Shell/SymbolFile/DWARF/valueobject-pass-by-reg.s:59 +# +# 86dea1f39bd127776b999e10dff212003068d30a +# I

[Lldb-commits] [lldb] 7ddfb95 - [lldb] Fix unit test parsing to handle CR+LF as well as LF

Author: Adrian McCarthy Date: 2020-08-12T13:56:16-07:00 New Revision: 7ddfb956e1a5ee91d0d30f33ca0c84faeb471db4 URL: https://github.com/llvm/llvm-project/commit/7ddfb956e1a5ee91d0d30f33ca0c84faeb471db4 DIFF:

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

clayborg updated this revision to Diff 285177. clayborg added a comment. Fix inline comment issues from vsk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85705/new/ https://reviews.llvm.org/D85705 Files: lldb/include/lldb/Core/PluginManager.h

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik updated this revision to Diff 285176. shafik added a comment. Replacing python test with Shell test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85376/new/ https://reviews.llvm.org/D85376 Files: lldb/source/Core/ValueObjectChild.cpp

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGd49aedd315e3: Build a flat LLDB.framework for embedded Darwin targets (authored by vsk). Changed prior to commit: https://reviews.llvm.org/D85770?vs=284849=285174#toc Repository: rG LLVM Github

[Lldb-commits] [lldb] d49aedd - Build a flat LLDB.framework for embedded Darwin targets

Author: Vedant Kumar Date: 2020-08-12T13:34:29-07:00 New Revision: d49aedd315e35180b1df19476353ebe2558a318b URL: https://github.com/llvm/llvm-project/commit/d49aedd315e35180b1df19476353ebe2558a318b DIFF: https://github.com/llvm/llvm-project/commit/d49aedd315e35180b1df19476353ebe2558a318b.diff

[Lldb-commits] [PATCH] D85836: [lldb/Utility] Simplify and generalize Scalar class

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/Scalar.h:258 + static Type PromoteToMaxType(const Scalar , const Scalar , + Scalar _value, I really hate this signature. How do you feel about having this

[Lldb-commits] [PATCH] D85836: [lldb/Utility] Simplify and generalize Scalar class

labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added a project: LLDB. labath requested review of this revision. The class contains an enum listing all host integer types as well as some non-host types. This setup is a remnant of a time when this class was

[Lldb-commits] [lldb] cff880b - Revert "[lldb] Display autosuggestion part in gray if there is one possible suggestion"

Author: Raphael Isemann Date: 2020-08-12T13:52:03+02:00 New Revision: cff880b0c9a07ff8275e91982c0d6e2293b537e7 URL: https://github.com/llvm/llvm-project/commit/cff880b0c9a07ff8275e91982c0d6e2293b537e7 DIFF:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

This revision was automatically updated to reflect the committed changes. Closed by commit rG246afe0cd17f: [lldb] Display autosuggestion part in gray if there is one possible suggestion (authored by gedatsu217, committed by teemperor). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 246afe0 - [lldb] Display autosuggestion part in gray if there is one possible suggestion

Author: Shu Anzai Date: 2020-08-12T13:11:20+02:00 New Revision: 246afe0cd17fce935a01171f3cca548e02523e5c URL: https://github.com/llvm/llvm-project/commit/246afe0cd17fce935a01171f3cca548e02523e5c DIFF: https://github.com/llvm/llvm-project/commit/246afe0cd17fce935a01171f3cca548e02523e5c.diff

[Lldb-commits] [lldb] dd0fdf8 - [lldb] Add support for checking children in expect_expr

Author: Raphael Isemann Date: 2020-08-12T12:11:24+02:00 New Revision: dd0fdf80301e0b875d1898e01542c43b991e1b1c URL: https://github.com/llvm/llvm-project/commit/dd0fdf80301e0b875d1898e01542c43b991e1b1c DIFF:

[Lldb-commits] [PATCH] D83792: [lldb] Add support for checking children in expect_expr

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd0fdf80301e: [lldb] Add support for checking children in expect_expr (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

haampie added a comment. Great, one benefit of this is that zlib can now be detected in non-system libs. Maybe we should handle ncurses / TERMINFO in a similar manner? It currently has similar logic as finding zlib had Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG31e5f7120bdd: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2203887 , @lxfind wrote: > In D79219#2201415 , @phosek wrote: > >> This is correct. That target is provided by `find_package(ZLIB)`. In >> LLVMConfig.cmake, we invoke

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. @phosek sorry for the late reply, the builds on master are still green, so your changes are working on Windows as well. Thank you for the extra work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/