[Lldb-commits] [PATCH] D85942: [lldb] Remove Python 2 fallback and make Python 3 the only supported configuration.

mgorny added a comment. I wonder if we can remove the helper variables such as `PYTHON_LIBRARIES` now. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85942/new/ https://reviews.llvm.org/D85942 ___ lldb-commits

[Lldb-commits] [PATCH] D85951: Add Python iterator & getitem for SBTypeEnumMemberList

jingham created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jingham requested review of this revision. Herald added a subscriber: JDevlieghere. This class represents the members of an enum type, but wasn't terribly convenient to use because it only had

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

amccarth closed this revision. amccarth added a comment. Landed on Tuesday. I must have messed up the `Differential Revision:` line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84815/new/ https://reviews.llvm.org/D84815 ___ lldb-commits

[Lldb-commits] [PATCH] D85942: [lldb] Remove Python 2 fallback and make Python 3 the only supported configuration.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. This removes the fallback to Python 2 and makes Python 3 the only supported configuration. This is the first step as proposed on the

[Lldb-commits] [lldb] 3da9396 - [lldb] Improve diagnostics in lldb-repro when replay fails

Author: Jonas Devlieghere Date: 2020-08-13T14:38:34-07:00 New Revision: 3da939686c216f8d16a6aaae7831f4bb18c83483 URL: https://github.com/llvm/llvm-project/commit/3da939686c216f8d16a6aaae7831f4bb18c83483 DIFF:

[Lldb-commits] [PATCH] D85904: [lldb] Check Decl kind when completing -flimit-debug-info types

shafik accepted this revision. shafik added a comment. Minor comment but LGTM, nice fix! Comment at: lldb/test/API/functionalities/limit-debug-info/main.cpp:34 + int member = 47; +} shadowed_one; + Just to clarify we `func_shadow::One` is being shadowed here.

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG25bbceb047a3: [LLDB] Fix how ValueObjectChild handles bit-fields stored in a Scalar in… (authored by shafik). Herald

[Lldb-commits] [lldb] 25bbceb - [LLDB] Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

Author: shafik Date: 2020-08-13T11:53:14-07:00 New Revision: 25bbceb047a3ce85394d510a16bd3fcfd69b8c75 URL: https://github.com/llvm/llvm-project/commit/25bbceb047a3ce85394d510a16bd3fcfd69b8c75 DIFF: https://github.com/llvm/llvm-project/commit/25bbceb047a3ce85394d510a16bd3fcfd69b8c75.diff LOG:

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

JDevlieghere added a comment. In D85539#2215387 , @labath wrote: > The part which bugs me about this is that the first thing that Makefile.rules > will do with the triple we've painstakingly constructed here is it will > decompose it into individual

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik updated this revision to Diff 285423. shafik marked an inline comment as done. shafik added a comment. Update test name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85376/new/ https://reviews.llvm.org/D85376 Files: lldb/source/Core/ValueObjectChild.cpp

[Lldb-commits] [lldb] 2ddba09 - [lldb] Set the launch flags to GetLaunchInfo().GetLaunchFlags()

Author: Jonas Devlieghere Date: 2020-08-13T10:24:35-07:00 New Revision: 2ddba09e067add1910cc0f39ce9e1e4e0e43bb28 URL: https://github.com/llvm/llvm-project/commit/2ddba09e067add1910cc0f39ce9e1e4e0e43bb28 DIFF:

[Lldb-commits] [PATCH] D85915: [lldb] Use file to synchronize TestDeepBundle and TestBundleWithDotInFilename

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, teemperor. JDevlieghere requested review of this revision. Currently these two tests use an arbitrary wait of 5 seconds for the inferior to finish setting up. When the test machine is under heavy load this sometimes is

[Lldb-commits] [lldb] 180d6ed - [lldb] Skip TestStepScripted with reproducers

Author: Jonas Devlieghere Date: 2020-08-13T09:46:52-07:00 New Revision: 180d6ed66778ec5b7ee68878005ca1f0498b6d6d URL: https://github.com/llvm/llvm-project/commit/180d6ed66778ec5b7ee68878005ca1f0498b6d6d DIFF:

[Lldb-commits] [PATCH] D85836: [lldb/Utility] Simplify and generalize Scalar class

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I guess you'll have to rebase this, but LGTM Comment at: lldb/include/lldb/Utility/Scalar.h:258 + static Type PromoteToMaxType(const Scalar , const Scalar , +

[Lldb-commits] [PATCH] D85906: [lldb/Utility] Simplify Scalar::PromoteToMaxType

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Yeah, I think this is worth the overhead of making a few copies. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85906/new/

[Lldb-commits] [PATCH] D85904: [lldb] Check Decl kind when completing -flimit-debug-info types

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Is it too late to claim that I did this on purpose to see if anyone noticed the bug? It probably is :/ Comment at:

[Lldb-commits] [PATCH] D85906: [lldb/Utility] Simplify Scalar::PromoteToMaxType

labath added inline comments. Comment at: lldb/include/lldb/Utility/Scalar.h:268-275 friend const Scalar operator+(const Scalar , const Scalar ); - friend const Scalar operator-(const Scalar , const Scalar ); - friend const Scalar operator/(const Scalar , const Scalar ); -

[Lldb-commits] [PATCH] D85836: [lldb/Utility] Simplify and generalize Scalar class

labath added inline comments. Comment at: lldb/include/lldb/Utility/Scalar.h:258 + static Type PromoteToMaxType(const Scalar , const Scalar , + Scalar _value, JDevlieghere wrote: > I really hate this signature. How do you feel

[Lldb-commits] [PATCH] D85906: [lldb/Utility] Simplify Scalar::PromoteToMaxType

labath created this revision. labath added reviewers: JDevlieghere, teemperor. Herald added a project: LLDB. labath requested review of this revision. The function had very complicated signature, because it was trying to avoid making unnecessary copies of the Scalar object. However, this class is

[Lldb-commits] [PATCH] D85904: [lldb] Check Decl kind when completing -flimit-debug-info types

labath created this revision. labath added a reviewer: teemperor. Herald added a reviewer: shafik. Herald added a project: LLDB. labath requested review of this revision. Herald added a subscriber: JDevlieghere. The search for the complete class definition can also produce entries which are not

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

labath accepted this revision. labath added a comment. This looks good to me. I appreciate the efforts taken to reduce the test size. The trick for controlling the debug info order is neat, and I may end up using it some time. FWIW, the way I usually handle these things is by first replacing

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

labath added a comment. The part which bugs me about this is that the first thing that Makefile.rules will do with the triple we've painstakingly constructed here is it will decompose it into individual components, and then do some more matching on them, including running some xcrun commands,

[Lldb-commits] [lldb] 8af160b - [lldb][NFC] Use llvm::is_contained instead of std::find in a few places

Author: Raphael Isemann Date: 2020-08-13T14:11:28+02:00 New Revision: 8af160b0b8ca8102b9490a287244af75727872f5 URL: https://github.com/llvm/llvm-project/commit/8af160b0b8ca8102b9490a287244af75727872f5 DIFF:

[Lldb-commits] [lldb] ac2b7f8 - [lldb][NFC] Fix indentation in TCPSocket::CloseListenSockets

Author: Raphael Isemann Date: 2020-08-13T12:29:24+02:00 New Revision: ac2b7f8ac1649afbc6d0b8e2abf324278441dc7b URL: https://github.com/llvm/llvm-project/commit/ac2b7f8ac1649afbc6d0b8e2abf324278441dc7b DIFF:

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid added a comment. @labath Any further action needed on this change? I have updated test main.c for doing asm write to SVE regs and then reading them back during testing. Also i have removed NativeProcessLinux_arm64 dependence on LinuxPTraceDefines_arm64sve.h. We are using sys root's