[Lldb-commits] [PATCH] D86174: [lldb] Convert builders to classes so we can use inheritance to override platform specific methods (NFC)

JDevlieghere updated this revision to Diff 286454. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86174/new/ https://reviews.llvm.org/D86174 Files: lldb/packages/Python/lldbsuite/builders/__init__.py lldb/packages/Python/lldbsuite/builders/builder.py

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

JDevlieghere updated this revision to Diff 286455. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85539/new/ https://reviews.llvm.org/D85539 Files: lldb/packages/Python/lldbsuite/builders/builder.py lldb/packages/Python/lldbsuite/builders/darwin.py

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/builders/builder.py:224 "MAKE_DSYM=NO", "MAKE_DWO=YES", -getArchSpec(architecture), -getCCSpec(compiler), -getDsymutilSpec(), -

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

JDevlieghere updated this revision to Diff 286431. JDevlieghere added a comment. Reimplement based on passing the ARCH_CFLAGS to Make Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85539/new/ https://reviews.llvm.org/D85539 Files:

[Lldb-commits] [lldb] 514bcb3 - [lldb] Remove unused function getArchFlag (NFC)

Author: Jonas Devlieghere Date: 2020-08-18T15:20:57-07:00 New Revision: 514bcb325dc9584f378be982ce102d8d5a531d5c URL: https://github.com/llvm/llvm-project/commit/514bcb325dc9584f378be982ce102d8d5a531d5c DIFF:

[Lldb-commits] [PATCH] D86174: [lldb] Convert builders to classes so we can use inheritance to override platform specific methods

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath. Herald added subscribers: teemperor, emaste. JDevlieghere requested review of this revision. Use inheritance and a factory method to hand out builders instead of importing the desired module. This has the advantage

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:410 + +VSCode::PacketStatus VSCode::SendReverseRequest(llvm::json::Object , +llvm::json::Object ) { clayborg wrote: > clayborg wrote: >

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:410 + +VSCode::PacketStatus VSCode::SendReverseRequest(llvm::json::Object , +llvm::json::Object ) { clayborg wrote: > add "const" to

[Lldb-commits] [PATCH] D86122: Fix a check that was attempting to see if an object file was in memory.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08748d15b8d6: Fix a check that was attempting to see if an object file was in memory. (authored by clayborg). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 08748d1 - Fix a check that was attempting to see if an object file was in memory.

Author: Greg Clayton Date: 2020-08-18T13:24:22-07:00 New Revision: 08748d15b8d696db9f894db38d74a212b8ab43e6 URL: https://github.com/llvm/llvm-project/commit/08748d15b8d696db9f894db38d74a212b8ab43e6 DIFF: https://github.com/llvm/llvm-project/commit/08748d15b8d696db9f894db38d74a212b8ab43e6.diff

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:173 + + void RegisterRequestCallback(std::string request, RequestCallback callback); }; I thought this was the contents of a "lldb::SBTarget CreateTargetFromArguments(const

[Lldb-commits] [PATCH] D86110: [WIP][DebugInfo] Lazily parse debug_loclist offsets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a49d2aa691: [WIP][DebugInfo] Lazily parse debug_loclist offsets (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] f7a49d2 - [WIP][DebugInfo] Lazily parse debug_loclist offsets

Author: David Blaikie Date: 2020-08-18T10:49:39-07:00 New Revision: f7a49d2aa691266497c4baa35f29ba0167b39d23 URL: https://github.com/llvm/llvm-project/commit/f7a49d2aa691266497c4baa35f29ba0167b39d23 DIFF: https://github.com/llvm/llvm-project/commit/f7a49d2aa691266497c4baa35f29ba0167b39d23.diff

[Lldb-commits] [PATCH] D86110: [WIP][DebugInfo] Lazily parse debug_loclist offsets

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D86110#2223905 , @labath wrote: > This sounds perfectly reasonable to me. The offsets are present in memory > already so there's no point in

[Lldb-commits] [PATCH] D86140: [lldb] Add typedefs to the DeclContext they are created in

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. This is nice catch! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86140/new/ https://reviews.llvm.org/D86140

[Lldb-commits] [PATCH] D85968: [lldb] Forcefully complete a type when adding nested classes

MaskRay added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_declaration-with-children.s:7 -# RUN: llvm-mc --triple x86_64-pc-linux %s --filetype=obj > %t -# RUN: %lldb %t -o "expr a" -o exit 2>&1 | FileCheck %s --check-prefix=EXPR -# RUN: %lldb %t -o

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, just the cpuinfo detection function could use a bit of improvement. Thanks for your patience. Comment at:

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

JDevlieghere added a comment. I didn't look at the scripts in detail but I have a few general (high level) comments: - I also feel this should go under `lldb/scripts`. - Can we put the documentations as RST under `lldb/docs` so it's rendered on the website? We already have bunch of developer

[Lldb-commits] [PATCH] D86144: [lldb] [testsuite] Add split-file for check-lldb dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7baed769c7ea: [lldb] [testsuite] Add split-file for check-lldb dependencies (authored by jankratochvil). Changed prior to commit:

[Lldb-commits] [lldb] 7baed76 - [lldb] [testsuite] Add split-file for check-lldb dependencies

Author: Jan Kratochvil Date: 2020-08-18T18:10:55+02:00 New Revision: 7baed769c7ea8de27a1c077c7ff30f4e19988ade URL: https://github.com/llvm/llvm-project/commit/7baed769c7ea8de27a1c077c7ff30f4e19988ade DIFF:

[Lldb-commits] [PATCH] D86144: [lldb] [testsuite] Add split-file for check-lldb dependencies

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for catching that. Comment at: lldb/test/CMakeLists.txt:81 yaml2obj +split-file ) Please keep this list sorted. Repository: rG LLVM

[Lldb-commits] [PATCH] D86110: [WIP][DebugInfo] Lazily parse debug_loclist offsets

labath added a comment. This sounds perfectly reasonable to me. The offsets are present in memory already so there's no point in storing them in a vector as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86110/new/

[Lldb-commits] [PATCH] D86144: [lldb] [testsuite] Add split-file for check-lldb dependencies

jankratochvil created this revision. jankratochvil added reviewers: labath, MaskRay. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, aprantl, mgorny. jankratochvil requested review of this revision. D85968 started to use `split-file`

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

labath added a comment. I like this. Apart from the inline comments (which are mostly about removing excessive mentions of arm(64) -- I want to make that text feel generic, since the file is in a generic place), I have one high-level comment. Given the current layout of the repo, it seems like

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

labath added a comment. This seems fairly straight-forward to me, though I didn't dive into all the details. Given the amount of changed tests, it may be nice to separate the format change from the linking patch (so in the interim state, one could generate multiple abbrev tables, but there

[Lldb-commits] [PATCH] D86140: [lldb] Add typedefs to the DeclContext they are created in

labath created this revision. labath added reviewers: teemperor, shafik. Herald added a project: LLDB. labath requested review of this revision. Herald added a subscriber: JDevlieghere. TypeSystemClang::CreateTypedef was creating a typedef in the right DeclContext, but it was not actually adding

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

This revision was automatically updated to reflect the committed changes. Closed by commit rGa52173a3e565: Use find_library for ncurses (authored by haampie, committed by JDevlieghere). Herald added projects: Sanitizers, LLDB. Herald added subscribers: lldb-commits, Sanitizers. Repository: rG

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

RKSimon added a comment. @haampie @JDevlieghere This is failing on several buildbots please can you take a look : http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/13553 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85290: [lldb][gui] use left/right in the source view to scroll

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcd4589a0d68: [lldb][gui] use left/right in the source view to scroll (authored by llunak). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D85290?vs=283192=286246#toc

[Lldb-commits] [lldb] dcd4589 - [lldb][gui] use left/right in the source view to scroll

Author: Luboš Luňák Date: 2020-08-18T13:25:01+02:00 New Revision: dcd4589a0d68032076f6951190ab170fef9c3cf5 URL: https://github.com/llvm/llvm-project/commit/dcd4589a0d68032076f6951190ab170fef9c3cf5 DIFF: https://github.com/llvm/llvm-project/commit/dcd4589a0d68032076f6951190ab170fef9c3cf5.diff

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

jhenderson added inline comments. Comment at: llvm/include/llvm/ObjectYAML/DWARFEmitter.h:34 +private: + Data + std::map AbbrevID2Index; Would it make any sense to merge the `DWARFYAML::Data` class and `DWARFYAML::DWARFState` class at all?

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

tschuett added a comment. You can buy a PRIMEHPC FX700 from Fujitsu. It has a A64FX CPU with SVE. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82064/new/ https://reviews.llvm.org/D82064 ___ lldb-commits mailing list