[Lldb-commits] [PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

shafik marked an inline comment as done. shafik added a subscriber: rsmith. shafik added a comment. @martong I have been experimenting w/ how we pass around `ImportDefinitionKind` and pushing it through to more places does not help. I also tried defaulting most locations to `IDK_Everything` to

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide closed this revision. davide added a comment. Somebody will pick this up, probably in a different form. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82813/new/ https://reviews.llvm.org/D82813 ___ lldb-commits mailing list

[Lldb-commits] [lldb] f369d51 - [lldb] avoid assert in threadsanitizer tests on linux

Author: Luboš Luňák Date: 2020-09-03T21:18:17+02:00 New Revision: f369d51896e1c0f61df253b116c42771479549df URL: https://github.com/llvm/llvm-project/commit/f369d51896e1c0f61df253b116c42771479549df DIFF: https://github.com/llvm/llvm-project/commit/f369d51896e1c0f61df253b116c42771479549df.diff

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

llunak added a comment. Ping. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86416/new/ https://reviews.llvm.org/D86416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added a comment. > Given the `expr` status quo, I'd stick with that. I want to give a +1 to //not// copying `expr`. I think the tradeoff is not not worth it. My user perspective is that lldb could be improved by making more decisions with the user in mind, not lldb's engineers (to

[Lldb-commits] [lldb] ddcc7ce - [lldb-vscode] Fix TestVSCode_module

Author: Walter Erquinigo Date: 2020-09-03T09:01:56-07:00 New Revision: ddcc7ce59150c9ebc6b0b2d61e7ef4f2525c11f4 URL: https://github.com/llvm/llvm-project/commit/ddcc7ce59150c9ebc6b0b2d61e7ef4f2525c11f4 DIFF:

[Lldb-commits] [PATCH] D86670: [intel-pt] Add a basic implementation of the dump command

labath added a comment. In D86670#2244876 , @clayborg wrote: > In D86670#2244092 , @labath wrote: > >> I think it would be appropriate to discuss the design of this feature on >> lldb-dev before going over the

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

labath added a subscriber: sammccall. labath added a comment. I'm pretty sure the json changes should get a separate review. The json owner (let's call him @sammccall) might have a different idea on how to do this thing... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a reviewer: jasonmolenda. labath added a comment. I'd like to also pull in Jason for this, since this is really the trickiest part of the whole patchset. What this patch essentially does is bake in the knowledge of the arm sve registers and their various configurations into the

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

DavidSpickett added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86792/new/ https://reviews.llvm.org/D86792 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f18f3c858d5: [lldb] Improve test failure reporting for expect() (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86792/new/

[Lldb-commits] [lldb] 9f18f3c - [lldb] Improve test failure reporting for expect()

Author: David Spickett Date: 2020-09-03T13:35:05+01:00 New Revision: 9f18f3c858d5ff8154701a50c2be6f7b19667a1d URL: https://github.com/llvm/llvm-project/commit/9f18f3c858d5ff8154701a50c2be6f7b19667a1d DIFF:

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

labath added a comment. There are things I'd want to change here, but I think this is patch is fundamentally ok. Before going into that, I think we should first sort out the dependant patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

DavidSpickett updated this revision to Diff 289663. DavidSpickett added a comment. - Use settings command so we don't have to substr help's output - Move list and dedent calls into assert function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D87076: [lldb/Interpreter] Fix language detection for the REPL InitFile

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf8f6e89c8d6: [lldb/Interpreter] Fix language detection for the REPL InitFile (authored by mib). Changed prior to commit:

[Lldb-commits] [lldb] bf8f6e8 - [lldb/Interpreter] Fix language detection for the REPL InitFile

Author: Med Ismail Bennani Date: 2020-09-03T10:57:56+02:00 New Revision: bf8f6e89c8d6fbac3e91ab37de7431d8e7c8aab4 URL: https://github.com/llvm/llvm-project/commit/bf8f6e89c8d6fbac3e91ab37de7431d8e7c8aab4 DIFF:

[Lldb-commits] [PATCH] D87076: [lldb/Interpreter] Fix language detection for the REPL InitFile

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This patch sparks joy, but the fact that this all is dead code without Swift doesn't spark joy. But as it's up to me to revive this code and the downstream Swift test looks fine, I'll

[Lldb-commits] [PATCH] D87076: [lldb/Interpreter] Fix language detection for the REPL InitFile

mib created this revision. mib added a reviewer: teemperor. mib added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. mib requested review of this revision. Previously, before loading the REPL language-specific init file, lldb checked the selected target language in which

[Lldb-commits] [PATCH] D87036: [lldb] Make symbol list output from `image dump symtab` not depend on internal ordering of DenseMap

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b354d204d09: [lldb] Make symbol list output from `image dump symtab` not depend on internal… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] 5b354d2 - [lldb] Make symbol list output from `image dump symtab` not depend on internal ordering of DenseMap

Author: Raphael Isemann Date: 2020-09-03T10:27:19+02:00 New Revision: 5b354d204d0952a6dd39e41fb41b51414bff5f0b URL: https://github.com/llvm/llvm-project/commit/5b354d204d0952a6dd39e41fb41b51414bff5f0b DIFF:

Re: [Lldb-commits] [lldb] 0e86f39 - [lldb/test] Fix TestPlatform*.py Windows failures (NFC)

On 02/09/2020 21:42, Med Ismail Bennani via lldb-commits wrote: > +#if defined(_WIN32) || defined(_WIN64) BTW, _WIN32 is also defined for 64 bit windows systems -- the macro really means "_not_ win16" rather than what the name would imply. pl ___

[Lldb-commits] [lldb] 13cde67 - [lldb] Remove a stray semicolon, fixing pedantic GCC warnings. NFC.

Author: Martin Storsjö Date: 2020-09-03T11:19:40+03:00 New Revision: 13cde6733b5fec9eff5e9652686c3b02055e6169 URL: https://github.com/llvm/llvm-project/commit/13cde6733b5fec9eff5e9652686c3b02055e6169 DIFF:

[Lldb-commits] [lldb] e123959 - [lldb] Remove debugserver specific string from TestAbortExitCode check

Author: Raphael Isemann Date: 2020-09-03T10:03:02+02:00 New Revision: e123959e94716ef6b5942060ac5934f696eaa3d3 URL: https://github.com/llvm/llvm-project/commit/e123959e94716ef6b5942060ac5934f696eaa3d3 DIFF:

[Lldb-commits] [PATCH] D86336: [debugserver] Fix that debugserver's stop reply packets always return signal code 0

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0699d910914: [debugserver] Fix that debugservers stop reply packets always return signal… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] f0699d9 - [debugserver] Fix that debugserver's stop reply packets always return signal code 0

Author: Raphael Isemann Date: 2020-09-03T09:47:03+02:00 New Revision: f0699d9109143754088c26604c58f5ab3e9d4678 URL: https://github.com/llvm/llvm-project/commit/f0699d9109143754088c26604c58f5ab3e9d4678 DIFF:

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. In D86996#2252561 , @JDevlieghere wrote: > In D86996#2252520 , @JDevlieghere > wrote: > >> In

[Lldb-commits] [PATCH] D86821: [lldb] Make the majority of the lit configuration values optional for the API tests

labath added inline comments. Comment at: lldb/test/API/lit.cfg.py:88-91 +def is_configured(attr): + """Return the configuration attribute if it exists and None otherwise. + + This allows us to check if the attribute exists before trying to access it."""

[Lldb-commits] [PATCH] D85993: [lldb] Set the access property on member function decls

teemperor added a comment. In D85993#2253465 , @amccarth wrote: > In D85993#2220724 , @labath wrote: > >> Dwarf parser uses `TypeSystemClang::AddMethodToCXXRecordType` instead of >> this function to create methods