[Lldb-commits] [lldb] 757ac4c - [lldb] Reword CompilerType docstring to not say "generic type"

Author: Dave Lee Date: 2020-09-15T22:14:57-07:00 New Revision: 757ac4ccfb8b024454b4f445a2b5c8985da5dc8a URL: https://github.com/llvm/llvm-project/commit/757ac4ccfb8b024454b4f445a2b5c8985da5dc8a DIFF: https://github.com/llvm/llvm-project/commit/757ac4ccfb8b024454b4f445a2b5c8985da5dc8a.diff

[Lldb-commits] [PATCH] D87633: [lldb] Reword CompilerType docstring to not say "generic type"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG757ac4ccfb8b: [lldb] Reword CompilerType docstring to not say generic type (authored by kastiglione). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D87626: Fix .debug_aranges parsing.

aprantl added a comment. Wow :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87626/new/ https://reviews.llvm.org/D87626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D87730: [intel-pt] Pretty print the instruction list

wallace updated this revision to Diff 292060. wallace added a comment. remove whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87730/new/ https://reviews.llvm.org/D87730 Files: lldb/include/lldb/Target/Trace.h

[Lldb-commits] [PATCH] D87730: [intel-pt] Pretty print the instruction list

wallace created this revision. wallace added a reviewer: clayborg. Herald added subscribers: lldb-commits, dang. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. wallace requested review of this revision. Depends on D87589 . In D87589

[Lldb-commits] [lldb] 79f22b1 - Fix .debug_aranges parsing.

Author: Greg Clayton Date: 2020-09-15T11:50:57-07:00 New Revision: 79f22b1f99fd72db9a45c387258d289791f2b9c0 URL: https://github.com/llvm/llvm-project/commit/79f22b1f99fd72db9a45c387258d289791f2b9c0 DIFF: https://github.com/llvm/llvm-project/commit/79f22b1f99fd72db9a45c387258d289791f2b9c0.diff

[Lldb-commits] [PATCH] D87626: Fix .debug_aranges parsing.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79f22b1f99fd: Fix .debug_aranges parsing. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

MaskRay added inline comments. Comment at: llvm/lib/Support/MemoryBuffer.cpp:460 - if (shouldUseMmap(FD, FileSize, MapSize, Offset, RequiresNullTerminator, -PageSize, IsVolatile)) { + if (false) { std::error_code EC; I guess this was

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

This revision was automatically updated to reflect the committed changes. Closed by commit rG127faae7529a: [lldb] Add -l/--language option to script command (authored by JDevlieghere). Herald added subscribers: llvm-commits, hiraditya. Herald added projects: LLDB, LLVM. Changed prior to commit:

[Lldb-commits] [lldb] 127faae - [lldb] Add -l/--language option to script command

Author: Jonas Devlieghere Date: 2020-09-15T09:40:17-07:00 New Revision: 127faae7529aee7e8508abebbc19212ce30bbf27 URL: https://github.com/llvm/llvm-project/commit/127faae7529aee7e8508abebbc19212ce30bbf27 DIFF:

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht added a comment. In D87333#2273506 , @labath wrote: > (Sorry about the delay.) Given the current requirements, I think this patch > is fine (excellent even). > > That said, I'm not sure whether the original motivation for this requirement >

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht updated this revision to Diff 291956. rupprecht marked an inline comment as done. rupprecht added a comment. - Compare directly against the error code instead of hopping through `std::make_error_code()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

JDevlieghere added a comment. In D86996#2273445 , @labath wrote: > This looks fine (sorry about the delay, I've been OOO). I hope you had a good time. Glad to have you back! :-) Comment at:

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

DavidSpickett created this revision. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Previously when in "memory region " didn't parse correctly, we'd print an error then also ask

[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

dmantipov updated this revision to Diff 291894. dmantipov added a comment. OK let's reduce it to minimum minimorum. As for the profiling, l can see possible improvement around DWARFAttributes::Append() - inlining even at -O2 and eliminating extra constructor call makes 10.61% intern-state

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

labath added a comment. This is fixing the same issue that I tried to fix with D84402 , but then failed to get back to it when the discussion about the best approach started getting long. While I do have some reservations about this approach, it is definitive

[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

labath added a comment. In D87675#2273831 , @dmantipov wrote: > Use std::pair rather than an ad-hoc two-member trivial structures. Since > std::pair provides the default constructor to initialize both members, no > extra C++ glue is required for

[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

dmantipov updated this revision to Diff 291870. dmantipov added a comment. Use std::pair rather than an ad-hoc two-member trivial structures. Since std::pair provides the default constructor to initialize both members, no extra C++ glue is required for emplace_back()'ing the pairs into

[Lldb-commits] [lldb] af3789a - [lldb] Improve qemu interop for aarch64

Author: Pavel Labath Date: 2020-09-15T13:32:08+02:00 New Revision: af3789a188116e400dd021bae54d91dc543aca7d URL: https://github.com/llvm/llvm-project/commit/af3789a188116e400dd021bae54d91dc543aca7d DIFF: https://github.com/llvm/llvm-project/commit/af3789a188116e400dd021bae54d91dc543aca7d.diff

[Lldb-commits] [lldb] 0a2213c - [lldb/cmake] Fix testing support library dependencies

Author: Pavel Labath Date: 2020-09-15T13:32:08+02:00 New Revision: 0a2213c6eb24c9deec738e30509815e5bddd860c URL: https://github.com/llvm/llvm-project/commit/0a2213c6eb24c9deec738e30509815e5bddd860c DIFF: https://github.com/llvm/llvm-project/commit/0a2213c6eb24c9deec738e30509815e5bddd860c.diff

[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

labath added a comment. Using emplacement instead of construction is a good idea, where it makes sense. However, I am not convinced that adding constructors to otherwise-trivial structures is worth it. These structures are usually trivially copyable and/or movable and so an emplacement does

[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

dmantipov updated this revision to Diff 291838. dmantipov added a comment. Minor style adjustments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87675/new/ https://reviews.llvm.org/D87675 Files: lldb/include/lldb/Symbol/Function.h

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett marked 3 inline comments as done. DavidSpickett added a comment. In D87442#2273064 , @omjavaid wrote: > This seems fine to me with some minor nits. Also do you plan on writing a > Linux API test for this which test memory regions on Linux?

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

labath added a comment. Herald added a reviewer: JDevlieghere. (Sorry about the delay.) Given the current requirements, I think this patch is fine (excellent even). That said, I'm not sure whether the original motivation for this requirement (avoiding dns lookups) is still relevant. These

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 291835. DavidSpickett added a comment. - clang-format Minidump file - Remove HasFlags from API, return True/False from GetFlags instead - Rename MapKind to MapsKind and make it an enum class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

dmantipov abandoned this revision. dmantipov added a comment. Superseded with https://reviews.llvm.org/D87675. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87441/new/ https://reviews.llvm.org/D87441

[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

dmantipov created this revision. dmantipov added reviewers: labath, jankratochvil, teemperor. dmantipov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a reviewer: shafik. dmantipov requested review of this revision. Prefer emplace_back() over push_back()

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine (sorry about the delay, I've been OOO). Comment at: lldb/test/Shell/ScriptInterpreter/Lua/lua.test:2 # REQUIRES: lua -# RUN: %lldb --script-language lua -o

[Lldb-commits] [PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

bcardiff created this revision. bcardiff added reviewers: JDevlieghere, phosek, smeenai. Herald added subscribers: llvm-commits, lldb-commits, Sanitizers, cfe-commits, hiraditya, mgorny. Herald added projects: clang, Sanitizers, LLDB, LLVM. bcardiff requested review of this revision. Changes