[Lldb-commits] [PATCH] D88158: [lldb/examples] Add missing declaration in heap.py

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Based on the signature of the call below this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88158/new/

[Lldb-commits] [lldb] 92d42b3 - Utility: ignore OS version on non-Darwin targets in `ArchSpec`

Author: Saleem Abdulrasool Date: 2020-09-23T18:21:34-07:00 New Revision: 92d42b32a9b7a085fd200a56022724a77cf12a2d URL: https://github.com/llvm/llvm-project/commit/92d42b32a9b7a085fd200a56022724a77cf12a2d DIFF:

[Lldb-commits] [PATCH] D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92d42b32a9b7: Utility: ignore OS version on non-Darwin targets in `ArchSpec` (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

jingham marked 9 inline comments as done. jingham added a comment. Addressed review comments. Comment at: lldb/docs/use/python-reference.rst:843 +|| | **target** is the SBTarget to which the stop hook is added.

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

jingham updated this revision to Diff 293902. jingham marked 3 inline comments as done. jingham added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88123/new/ https://reviews.llvm.org/D88123 Files:

[Lldb-commits] [lldb] 751f5c8 - Fix LLDB tweak in 62a47e994fcf5b73e29547d26cd9676b30cb69a3

Author: Sam McCall Date: 2020-09-24T01:30:42+02:00 New Revision: 751f5c81468966d921ad54827d27ff19aa43af8e URL: https://github.com/llvm/llvm-project/commit/751f5c81468966d921ad54827d27ff19aa43af8e DIFF: https://github.com/llvm/llvm-project/commit/751f5c81468966d921ad54827d27ff19aa43af8e.diff

[Lldb-commits] [PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

sammccall updated this revision to Diff 293892. sammccall added a comment. This was landed as 4 commits, this diff is all 4 as committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88103/new/ https://reviews.llvm.org/D88103 Files:

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

wallace added a comment. @luismarques , what's the recommended gdb-server implementation you recommend for me to try this on a riscv machine? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2288013 , @JDevlieghere wrote: > Sounds reasonable to me. Maybe it's still to early for that but have you > tried running (part of) the test suite under QEMU yet? It should give you a > pretty good idea of the

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

JDevlieghere added a comment. In D62732#2254440 , @luismarques wrote: > @labath @jrtc27 @clayborg Now that we have at least 3 open-source debug > servers that we can use to test this with (OpenOCD, QEMU gdbstub, gdbserver) > perhaps this can be merged?

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2286332 , @wallace wrote: > @luismarques , what's the recommended gdb-server implementation you recommend > for me to try this on a riscv machine? I compiled mine from the mainline binutils-gdb git repository

[Lldb-commits] [lldb] fa69b60 - [JSON] Add error reporting to fromJSON and ObjectMapper

Author: Sam McCall Date: 2020-09-24T01:20:09+02:00 New Revision: fa69b608063eecba76fb35d167b063cbfe532c28 URL: https://github.com/llvm/llvm-project/commit/fa69b608063eecba76fb35d167b063cbfe532c28 DIFF: https://github.com/llvm/llvm-project/commit/fa69b608063eecba76fb35d167b063cbfe532c28.diff

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

jingham added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; }

[Lldb-commits] [PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa69b608063e: [JSON] Add error reporting to fromJSON and ObjectMapper (authored by sammccall). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht added a comment. In D87333#2274572 , @rupprecht wrote: > In D87333#2273506 , @labath wrote: > >> (Sorry about the delay.) Given the current requirements, I think this patch >> is fine (excellent even).

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht updated this revision to Diff 293887. rupprecht added a comment. - Switch back to using localhost for non-socket uses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llvm.org/D87333 Files:

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; }

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

JDevlieghere added a comment. I'm very excited about this feature. Great job on the documentation, both in the help output as for the website. Do you have a potential use case in mind that we could add to the examples? Comment at: lldb/docs/use/python-reference.rst:843 +|

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

jingham added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; }

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; }

[Lldb-commits] [PATCH] D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`

kastiglione accepted this revision. kastiglione added a comment. sgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88181/new/ https://reviews.llvm.org/D88181 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`

compnerd added a comment. Correct, this is just upstreaming the original ArchSpec change that we found on Swift. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88181/new/ https://reviews.llvm.org/D88181

[Lldb-commits] [PATCH] D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This is the same change as we did on Github, right? If so this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88181/new/

[Lldb-commits] [PATCH] D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`

compnerd created this revision. compnerd added reviewers: JDevlieghere, kastiglione. compnerd added a project: LLDB. compnerd requested review of this revision. The OS version field is generally not very helpful for non-Darwin targets. On Linux, it identifies the kernel version which moves

[Lldb-commits] [lldb] 4a55c98 - [lldb] Normalize paths in new test

Author: Joseph Tremoulet Date: 2020-09-23T12:41:47-07:00 New Revision: 4a55c98fa7bee1e5ab1504db20ca4d7c8a083111 URL: https://github.com/llvm/llvm-project/commit/4a55c98fa7bee1e5ab1504db20ca4d7c8a083111 DIFF:

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

jingham added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; }

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; }

[Lldb-commits] [lldb] 3726ac4 - Add `breakpoint delete --disabled`: deletes all disabled breakpoints.

Author: Jim Ingham Date: 2020-09-23T11:35:11-07:00 New Revision: 3726ac41e9e00d2f6f87779b68f91ea264223c8a URL: https://github.com/llvm/llvm-project/commit/3726ac41e9e00d2f6f87779b68f91ea264223c8a DIFF: https://github.com/llvm/llvm-project/commit/3726ac41e9e00d2f6f87779b68f91ea264223c8a.diff

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jingham marked an inline comment as done. Closed by commit rG3726ac41e9e0: Add `breakpoint delete --disabled`: deletes all disabled breakpoints. (authored by jingham).

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

jingham marked an inline comment as done. jingham added a comment. I agree that having --disable flip the meaning of the listed breakpoints, but I think its the most useful meaning by far. Comment at: lldb/source/Commands/CommandObjectBreakpoint.cpp:1475 Target =

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. Nice improvement! I think it's strange that `break delete DeleteMeNot` and `break delete --disabled DeleteMeNot ` behave differently. For the case that it supports, I would suggest

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

jingham updated this revision to Diff 293796. jingham added a comment. In the original version of the patch you couldn't supply any breakpoints along with the --disabled flag. But it makes sense to be able to have some breakpoints that don't get deleted by this operation, which you can achieve

[Lldb-commits] [lldb] 6835808 - Add optimal thread strategy

Author: Dmitry Antipov Date: 2020-09-23T19:44:22+03:00 New Revision: 68358081585b160c38443425935457235a4b9d1a URL: https://github.com/llvm/llvm-project/commit/68358081585b160c38443425935457235a4b9d1a DIFF:

[Lldb-commits] [PATCH] D87765: [llvm][lldb] Add optimal ThreadPool concurrency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68358081585b: Add optimal thread strategy (authored by dmantipov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88158: [lldb/examples] Add missing declaration in heap.py

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor, aprantl. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Add missing declaration for `malloc_get_all_zones` in heap.py. Repository: rG

[Lldb-commits] [PATCH] D88119: [lldb] Remove lldb-perf remenant

This revision was automatically updated to reflect the committed changes. Closed by commit rG9abd1e8f4e5d: [lldb] Remove lldb-perf remenant (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88119/new/

[Lldb-commits] [lldb] 9abd1e8 - [lldb] Remove lldb-perf remenant

Author: Dave Lee Date: 2020-09-23T08:23:50-07:00 New Revision: 9abd1e8f4e5ddd6e5e592306432fb32dd68f4c14 URL: https://github.com/llvm/llvm-project/commit/9abd1e8f4e5ddd6e5e592306432fb32dd68f4c14 DIFF: https://github.com/llvm/llvm-project/commit/9abd1e8f4e5ddd6e5e592306432fb32dd68f4c14.diff

[Lldb-commits] [lldb] 20f8425 - [lldb] Fix GetRemoteSharedModule fallback logic

Author: Joseph Tremoulet Date: 2020-09-23T06:00:50-07:00 New Revision: 20f84257ac4ac54ceb5f581a6081fac6eff2a5a1 URL: https://github.com/llvm/llvm-project/commit/20f84257ac4ac54ceb5f581a6081fac6eff2a5a1 DIFF:

[Lldb-commits] [PATCH] D88099: [lldb] Fix GetRemoteSharedModule fallback logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20f84257ac4a: [lldb] Fix GetRemoteSharedModule fallback logic (authored by JosephTremoulet). Repository: rG LLVM Github Monorepo CHANGES SINCE