[Lldb-commits] [lldb] 3d27a99 - [LLDB] Remove AArch64/Linux xfail decorator from TestGuiBasicDebug

Author: Muhammad Omair Javaid Date: 2020-10-01T10:20:22+05:00 New Revision: 3d27a99b2ed24e1951483cf13357ec188ad44bb0 URL: https://github.com/llvm/llvm-project/commit/3d27a99b2ed24e1951483cf13357ec188ad44bb0 DIFF:

[Lldb-commits] [PATCH] D88632: A handful of fixes to lldb's "scan the local filesystem for kexts & kernels" feature

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. jasonmolenda requested review of this revision. This started out with one small idea I had and then got a bit of PatchCreep while I was digging into a subsystem I

[Lldb-commits] [PATCH] D86670: [intel-pt] Add a basic implementation of the dump command

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: lldb/include/lldb/Target/Target.h:32 #include "lldb/Target/ThreadSpec.h" +#include "lldb/Target/Trace.h" #include

[Lldb-commits] [lldb] d689570 - [lldb] Make TestGuiBasicDebug more lenient

Author: Jonas Devlieghere Date: 2020-09-30T17:06:47-07:00 New Revision: d689570d7dcb16ee241676e22324dc456837eb23 URL: https://github.com/llvm/llvm-project/commit/d689570d7dcb16ee241676e22324dc456837eb23 DIFF:

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

clayborg added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:369 + EXPECT_EQ(section_sp->GetType(), eSectionTypeCode); +} labath wrote: > clayborg wrote: > > I would rather deal with an C++ unit test any day. Trying to

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

clayborg added a comment. In D87868#2303398 , @labath wrote: > A completely different approach would be to avoid the mmap function > completely, and go for the mmap syscall instead. > > That is, instead of setting up registers to fake call to mmap and

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

clayborg added a comment. Agreed, must call weak_ptr.lock(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88266/new/ https://reviews.llvm.org/D88266 ___ lldb-commits mailing list

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

On 30/09/2020 20:45, Jim Ingham wrote: > I also used to get e-mails when a test failed and I was on the changes list. > But I haven’t gotten any failure e-mails. Does that only happen for some of > the bots (or has that stopped working) or should I look to my filters? > > Jim > You didn't

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafaeb6af79a4: Fix crash in SBStructuredData::GetDescription() when theres no… (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] afaeb6a - Fix crash in SBStructuredData::GetDescription() when there's no StructuredDataPlugin.

Author: Jim Ingham Date: 2020-09-30T11:48:54-07:00 New Revision: afaeb6af79a4278249ef9114755e5685d0b35984 URL: https://github.com/llvm/llvm-project/commit/afaeb6af79a4278249ef9114755e5685d0b35984 DIFF: https://github.com/llvm/llvm-project/commit/afaeb6af79a4278249ef9114755e5685d0b35984.diff

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

I also used to get e-mails when a test failed and I was on the changes list. But I haven’t gotten any failure e-mails. Does that only happen for some of the bots (or has that stopped working) or should I look to my filters? Jim > On Sep 30, 2020, at 10:40 AM, Jim Ingham via lldb-commits >

[Lldb-commits] [PATCH] D88513: [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. rupprecht marked an inline comment as done. Closed by commit rGad865d9d10b8: [lldb-vscode] Allow an empty breakpoints field to clear breakpoints. (authored by

[Lldb-commits] [lldb] ad865d9 - [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints.

Author: Jordan Rupprecht Date: 2020-09-30T11:32:06-07:00 New Revision: ad865d9d10b8cf93738470175aae1be7a4a3eb6b URL: https://github.com/llvm/llvm-project/commit/ad865d9d10b8cf93738470175aae1be7a4a3eb6b DIFF:

[Lldb-commits] [lldb] c3193e4 - [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

Author: Jordan Rupprecht Date: 2020-09-30T11:08:41-07:00 New Revision: c3193e464cbd5e8b7cade103032c222bf8bc0e27 URL: https://github.com/llvm/llvm-project/commit/c3193e464cbd5e8b7cade103032c222bf8bc0e27 DIFF:

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3193e464cbd: [lldb/ipv6] Support running lldb tests in an ipv6-only environment. (authored by rupprecht). Repository: rG LLVM Github Monorepo

Re: [Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

We should probably outlaw the shared pointer from weak pointer constructor in lldb. It looks like the only safe way to use it is in a try/catch block (or by preflighting the weak pointer with lock which renders it pretty much pointless.) Jim > On Sep 30, 2020, at 6:02 AM, Pavel Labath via

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

It looks like all the failing builds are incremental builds. Can you kick off a clean build and see if that also gets a failure? I’m worried that all the SWIG bits aren’t getting rebuilt. The code that is failing here is not at all time dependent, or particularly platform specific, so it

[Lldb-commits] [PATCH] D88583: [lldb] [test/Register] Add partial read/write tests for x87 regs

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Herald added a project: LLDB. mgorny requested review of this revision. Herald added a subscriber: JDevlieghere. Add a partial read/write tests for x87 FPU registers. This includes reading and writing ST registers,

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

labath added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:369 + EXPECT_EQ(section_sp->GetType(), eSectionTypeCode); +} clayborg wrote: > I would rather deal with an C++ unit test any day. Trying to track down what >

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

labath added a comment. A completely different approach would be to avoid the mmap function completely, and go for the mmap syscall instead. That is, instead of setting up registers to fake call to mmap and doing a run-to entry point breakpoint, we could set them up to fake a syscall, and then

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sorry about the delay. In D87333#2293266 , @clayborg wrote: > I am fine with trying "localhost" and seeing if we run into any issues. > Hopefully

[Lldb-commits] [lldb] 762e8f9 - [lldb] [Process/NetBSD] Fix operating on ftag register

Author: Michał Górny Date: 2020-09-30T15:39:31+02:00 New Revision: 762e8f9bbdaf43300dbc75637a8bce1ce643cc06 URL: https://github.com/llvm/llvm-project/commit/762e8f9bbdaf43300dbc75637a8bce1ce643cc06 DIFF: https://github.com/llvm/llvm-project/commit/762e8f9bbdaf43300dbc75637a8bce1ce643cc06.diff

[Lldb-commits] [PATCH] D88453: [lldb] Fix FreeBSD Arm Process Plugin build.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf794160c6cb7: [lldb] Fix FreeBSD Arm Process Plugin build (authored by emaste). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f794160 - [lldb] Fix FreeBSD Arm Process Plugin build

Author: Ed Maste Date: 2020-09-30T09:25:27-04:00 New Revision: f794160c6cb7da4b5ef354a91fe498341f651d36 URL: https://github.com/llvm/llvm-project/commit/f794160c6cb7da4b5ef354a91fe498341f651d36 DIFF: https://github.com/llvm/llvm-project/commit/f794160c6cb7da4b5ef354a91fe498341f651d36.diff

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

labath added a comment. In D88266#2302245 , @jingham wrote: > Use std::weak_ptr::lock to make the shared pointer, rather than > std::shared_ptr::shared_ptr(std::weak_ptr) (sort of), as the latter throws. Yep, `wp.lock()` behaves differently from the

Re: [Lldb-commits] [lldb] 92e1ebe - [trace] Fix destructor declaration

On 29/09/2020 22:09, Walter Erquinigo via lldb-commits wrote: > The destructor must be defined in the implementation class so that it > can be called That doesn't sound right. Each class automatically gets a destructor if it does not declare one itself. "~Foo() override = default" is completely

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

It looks like the new test (TestStopHookScripted.py) is flaky: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/18360/steps/test/logs/stdio http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/9484/steps/test/logs/stdio