[Lldb-commits] [PATCH] D88870: [lldb][NFC] remove unused local variable uuid

zequanwu created this revision. zequanwu added reviewers: amccarth, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. zequanwu requested review of this revision. Herald added a subscriber: JDevlieghere. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

JDevlieghere added a comment. In D88866#2313371 , @aprantl wrote: > So this is adding a fallback that ignores DEVELOPER_DIR if it is set, but > doesn't exist? Is that really desirable, or am I misunderstanding the patch? > I would expect LLDB to fail

[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

aprantl added a comment. So this is adding a fallback that ignores DEVELOPER_DIR if it is set, but doesn't exist? Is that really desirable, or am I misunderstanding the patch? I would expect LLDB to fail hard if the DEVELOPER_DIR in the environment is wrong and not silently ignore it...

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

kastiglione added a comment. About `-P`, the man page for `lldb` and the driver's `Options.td` say it: > Prints out the path to the lldb.py file for this version of lldb. Should it do just that? If so this can be simplified further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGf22496a9f4ca: [dotest] Simplify logic to find the Python path (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] f22496a - [dotest] Simplify logic to find the Python path

Author: Jonas Devlieghere Date: 2020-10-05T19:04:33-07:00 New Revision: f22496a9f4cabb97e735314b62731fedb2e01e50 URL: https://github.com/llvm/llvm-project/commit/f22496a9f4cabb97e735314b62731fedb2e01e50 DIFF:

[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. JDevlieghere requested review of this revision. If we tried getting the SDK from `xcrun` with the developer dir set and it failed, try without the developer dir. https://reviews.llvm.org/D88866 Files:

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:550-551 +# If our lldb supports the -P option, use it to find the python path: +with open(os.devnull, 'w') as DEVNULL: +

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

rupprecht accepted this revision. rupprecht added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:550-551 +# If our lldb supports the -P option, use it to find the python path: +with

[Lldb-commits] [lldb] be66987 - Fix raciness in the StopHook check for "has the target run".

Author: Jim Ingham Date: 2020-10-05T15:44:28-07:00 New Revision: be66987e2047636d9ed9d2a4d88b762d59ae88f2 URL: https://github.com/llvm/llvm-project/commit/be66987e2047636d9ed9d2a4d88b762d59ae88f2 DIFF: https://github.com/llvm/llvm-project/commit/be66987e2047636d9ed9d2a4d88b762d59ae88f2.diff

[Lldb-commits] [PATCH] D88753: Fix raciness in the check for whether a stop hook has run the target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe66987e2047: Fix raciness in the StopHook check for has the target run. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

clayborg added a comment. Glad the other mmap was not marked external, that makes this much easier. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:54 +if (sc_list.GetContextAtIndex(i, sc) && +(sc.symbol->IsExternal() || sc.symbol->IsWeak()))

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Commands/CommandObjectThread.cpp:2231-2240 + CommandObjectTraceDumpInstructions(CommandInterpreter ) + :

[Lldb-commits] [PATCH] D88841: [intel pt] Refactor parsing

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Target/Trace.h:77 /// - /// \param[in] settings - /// JSON object describing a trace. + /// \param[in]

[Lldb-commits] [PATCH] D88852: [lldb] [Platform] Move common ::DebugProcess() to PlatformPOSIX

mgorny added a comment. @labath, I've tested it on Linux so far. I'm currently building on NetBSD. @JDevlieghere, could you test this on Darwin? Alternatively, it's quite simple so I can wait for buildbots to complain after pushing ;-). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D88852: [lldb] [Platform] Move common ::DebugProcess() to PlatformPOSIX

mgorny created this revision. mgorny added reviewers: labath, JDevlieghere. Herald added a subscriber: arichardson. Herald added a project: LLDB. mgorny requested review of this revision. Move common ::DebugProcess() implementation shared by Linux and NetBSD (and to be shared by FreeBSD shortly)

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

This revision was automatically updated to reflect the committed changes. Closed by commit rG010d7a388b14: [lldb/test] Catch invalid calls to expect() (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/

[Lldb-commits] [lldb] 010d7a3 - [lldb/test] Catch invalid calls to expect()

Author: Dave Lee Date: 2020-10-05T12:41:52-07:00 New Revision: 010d7a388b146cafaf4bc0b28b952d5852d62b6a URL: https://github.com/llvm/llvm-project/commit/010d7a388b146cafaf4bc0b28b952d5852d62b6a DIFF: https://github.com/llvm/llvm-project/commit/010d7a388b146cafaf4bc0b28b952d5852d62b6a.diff

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

wallace updated this revision to Diff 296254. wallace added a comment. Rebased on top of https://reviews.llvm.org/D88841 - Comments on the architecture of classes are in that diff - I was able to get rid of cross-plug-in dependencies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D88841: [intel pt] Refactor parsing

wallace created this revision. wallace added reviewers: clayborg, labath. Herald added subscribers: lldb-commits, mgorny. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. wallace requested review of this revision. With the feedback I was getting in different diffs, I realized

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere updated this revision to Diff 296239. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88840/new/ https://reviews.llvm.org/D88840 Files: lldb/packages/Python/lldbsuite/test/dotest.py Index: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny updated this revision to Diff 296238. mgorny marked 2 inline comments as done. mgorny added a comment. For a start, removed leftover printf and len increment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88796/new/ https://reviews.llvm.org/D88796 Files:

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere updated this revision to Diff 296229. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88840/new/ https://reviews.llvm.org/D88840 Files: lldb/packages/Python/lldbsuite/test/dotest.py Index: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere created this revision. JDevlieghere added reviewers: rupprecht, labath, mgorny, teemperor. JDevlieghere requested review of this revision. Simplify the logic of parsing the `lldb -P` output to find the python path. This removes the special handling for the LLDB.framework and instead

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm updated this revision to Diff 296220. aadsm added a comment. I explored Greg's suggestion of checking if the functions were external symbols. As suspected the overriden mmap is not external, so we can use this check to avoid calling it! It does look to me that Pavel's suggestion is the

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione updated this revision to Diff 296217. kastiglione added a comment. "missing a matcher" -> "missing a matcher argument" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 Files:

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione added inline comments. Comment at: lldb/test/API/types/TestRecursiveTypes.py:54 +self.expect("print tpi") +self.expect("print *tpi") aprantl wrote: > I'm not not sure I understand this change? The second parameter, `msg`, is only

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2440-2441 +assert "patterns must be a collection of strings" and False +if isinstance(substrs, six.string_types): +assert "substrs must be a collection

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione updated this revision to Diff 296215. kastiglione added a comment. Resyntax the isinstance asserts; Add expect() tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 Files:

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

aprantl added inline comments. Comment at: lldb/test/API/types/TestRecursiveTypes.py:54 +self.expect("print tpi") +self.expect("print *tpi") I'm not not sure I understand this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

aprantl added a comment. Oh wow — that paid off! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

krytarowski added inline comments. Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:269-375 + Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_PLATFORM)); + LLDB_LOG(log, "target {0}", target); + + // If we're a remote host, use standard behavior from parent

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett added a comment. > The thing I'm not so sure about is the verbatim passing of the os-specific > flags. That's nice for the purpose of displaying them to the user, but it can > make things messy for programatic use, particularly if multiple platforms > start using these. What's do

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

labath added a comment. BTW, are you running the lldb-server test suite on this? How's it shaping up? In D88796#2311594 , @mgorny wrote: > Also a potentially interesting concept would be to unify reg constants > between platforms. Which constants do

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

labath added a comment. Before going into the code details, could you give a high-level overview of the intended interactions between the Trace and ProcessTrace classes? I am thinking about how to organize this so that we don't have too many criss-cross dependencies. My main question is

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny added a comment. Also a potentially interesting concept would be to unify reg constants between platforms. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88796/new/ https://reviews.llvm.org/D88796 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny marked an inline comment as done. mgorny added a comment. Indeed I've been wondering how we could dedupe this. At least large part of hw watchpoint handling should be reusable. Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:274 + if (!IsHost()) {

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

labath added inline comments. Comment at: lldb/source/Host/common/PseudoTerminal.cpp:149 + int r = ptsname_r(m_primary_fd, buf, sizeof(buf)); + assert(r == 0); + return buf; MaskRay wrote: > MaskRay wrote: > > labath wrote: > > > mgorny wrote: > > > > labath

[Lldb-commits] [PATCH] D88753: Fix raciness in the check for whether a stop hook has run the target

labath accepted this revision. labath added a comment. This explains the things I saw in the log file. Thanks for fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88753/new/ https://reviews.llvm.org/D88753

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

DavidSpickett added a comment. Does it make sense to add a few tests for this to `lldb/test/API/assert_messages_test/TestAssertMessages.py`? (this is only checking expect() messages, despite the generic name) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71cf97e95b8c: Reland [lldb] Dont send invalid region addresses to lldb server (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

labath added a comment. Looks pretty straigh-forward. I'm getting a lot of deja-vu when looking at this code, though it's not clear to me whether its identical of just similar. Have you investigated the possibility of factoring some parts of this && the netbsd code (and maybe linux too) into

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks for fixing all of this! Beside the assertion this LGTM. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2440-2441 +assert "patterns must

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine to me. Please wait a bit to give Jonas the opportunity to comment. (FWIW, I think these are fine as shell scripts right now, but that may change if windows comes into play.)

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath I am just back from holiday and was hoping for Jason to give his advice in this. I am wondering how we can move forward on this. I have added a some information from GDB inline. In D82863#2254423 , @labath wrote: > I'd

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

wallace updated this revision to Diff 296106. wallace added a comment. Herald added a subscriber: dexonsmith. Address comments: - Created a basic ThreadTrace class instead of using HistoryThread. I'll modify this class later when I add the decoding functionality and refactor the json file

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid added a comment. Ping! LGTM or any further comments or suggestions? PS: I have been on holidays so apologies for late responses in past few week. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82064/new/ https://reviews.llvm.org/D82064

[Lldb-commits] [PATCH] D88795: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin

labath added a subscriber: jasonmolenda. labath added a comment. BTW, what's the reason for darwin using the name `stmm`? It would be nice if the register names were consistent across a single architecture. We could keep the "stmm" variants as the "alternate" names on darwin for a while, to

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2440-2441 +assert "patterns must be a collection of strings" and False +if isinstance(substrs, six.string_types): +assert "substrs must be a collection of

[Lldb-commits] [PATCH] D88795: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin

mgorny added a comment. No problem. If you could send me logs for other tests xfailing on Darwin (particularly mm-related), I'd also be happy to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88795/new/ https://reviews.llvm.org/D88795

[Lldb-commits] [PATCH] D88795: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin

JDevlieghere added a comment. In D88795#2311096 , @mgorny wrote: > Thanks. I won't be at a computer for the next 8 hours, so feel free to push > it for me. Done. Thanks a lot for following up on this so quickly! Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] e8beb69 - [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin

Author: Michał Górny Date: 2020-10-04T23:04:40-07:00 New Revision: e8beb6988bab71ee4917288f07674b4982736109 URL: https://github.com/llvm/llvm-project/commit/e8beb6988bab71ee4917288f07674b4982736109 DIFF: https://github.com/llvm/llvm-project/commit/e8beb6988bab71ee4917288f07674b4982736109.diff

[Lldb-commits] [PATCH] D88795: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8beb6988bab: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin (authored by mgorny, committed by JDevlieghere). Herald added a project: LLDB. Herald added a subscriber: lldb-commits.