[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

mib requested changes to this revision. mib added a comment. This revision now requires changes to proceed. Could please follow PEP8 style guide regarding variable names : Function names should be lowercase, with words

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

MaskRay added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:369 + + If no target is selected a startup, the lldb-server can be directed to launch + or attach a process by the LLDB client. `a startup` -> `at startup` Repository: rG

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

MaskRay added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:404 + unsigned MissingArgCount; + opt::InputArgList Args = Opts.ParseArgs(makeArrayRef(argv + 2, argc - 2), + MissingArgIndex, MissingArgCount);

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 298495. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 Files: lldb/include/lldb/Target/Trace.h

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

wallace updated this revision to Diff 298493. wallace added a comment. Herald added a reviewer: JDevlieghere. Addressed the issues that @labath pointed out regarding the TraceProcess and TraceThread: - These classes were not together - TraceProcess was an optional plug-in, which would break the

[Lldb-commits] [PATCH] D89428: Add support for more OS types to AddClangModuleCompilationOptionsForSDKType()

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1525 + // If the SDK type is for the host OS, use its version number. + auto get_host_os = []() { return HostInfo::GetTargetTriple().getOS(); }; switch (sdk_type) {

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

MaskRay added inline comments. Comment at: lldb/tools/lldb-server/CMakeLists.txt:61 LINK_COMPONENTS Support ) Otherwise it fails in a BUILD_SHARED_LIBS=on build because the -Wl,-z,defs linker option requires a module to have fully specified

[Lldb-commits] [PATCH] D89358: Add an API to get an SBBreakpoint's owning SBTarget

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6754caa9bf21: Add an SB API to get the SBTarget from an SBBreakpoint (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 6754caa - Add an SB API to get the SBTarget from an SBBreakpoint

Author: Jim Ingham Date: 2020-10-15T14:28:44-07:00 New Revision: 6754caa9bf21a759c4080a797f23e2b7a77a71e1 URL: https://github.com/llvm/llvm-project/commit/6754caa9bf21a759c4080a797f23e2b7a77a71e1 DIFF: https://github.com/llvm/llvm-project/commit/6754caa9bf21a759c4080a797f23e2b7a77a71e1.diff

[Lldb-commits] [PATCH] D89428: Add support for more OS types to AddClangModuleCompilationOptionsForSDKType()

aprantl updated this revision to Diff 298453. aprantl added a comment. Address review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89428/new/ https://reviews.llvm.org/D89428 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp Index:

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 298445. fallkrum added a comment. API test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files: lldb/bindings/interface/SBType.i lldb/include/lldb/API/SBModule.h

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:54 +if (sc_list.GetContextAtIndex(i, sc) && +(sc.symbol->IsExternal() || sc.symbol->IsWeak())) { const uint32_t range_scope = labath wrote: >

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

JDevlieghere added inline comments. Comment at: lldb/source/Utility/Args.cpp:178 +Args::Args(llvm::ArrayRef args) : Args() { + for (llvm::StringRef arg : args) Maybe StringList should have a ctor that takes an `ArrayRef`, but probably not worth the extra

[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That's nicer, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89315/new/ https://reviews.llvm.org/D89315 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support

This revision was automatically updated to reflect the committed changes. Closed by commit rG87d38831d909: [lldb] [Process/FreeBSDRemote] Initial multithreading support (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 87d3883 - [lldb] [Process/FreeBSDRemote] Initial multithreading support

Author: Michał Górny Date: 2020-10-15T17:37:37+02:00 New Revision: 87d38831d909bf937039a97aa63220929d498047 URL: https://github.com/llvm/llvm-project/commit/87d38831d909bf937039a97aa63220929d498047 DIFF: https://github.com/llvm/llvm-project/commit/87d38831d909bf937039a97aa63220929d498047.diff

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere added a comment. In D89334#2331903 , @labath wrote: > In D89334#2330287 , @JDevlieghere > wrote: > >> In D89334#2329667 , @labath wrote: >> >>> The main

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett added a comment. If you wondering, the average number of flags for a hello world's memory regions is 8 so 8 lines of output. Here's an example I had that does madvise. (lldb) memory region addr [0x77ed5000-0x77fd5000) rw- /dev/zero (deleted) flags: readable

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 298371. DavidSpickett added a comment. - Move to llvm::Expected for callbacks - Use flag names based on Linux names but for all platforms - Show generic names/descriptions in memory region output - Add minidump cases for error handling Repository:

[Lldb-commits] [PATCH] D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support

emaste added a comment. Looks fine to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89413/new/ https://reviews.llvm.org/D89413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

labath added a comment. In D89334#2330287 , @JDevlieghere wrote: > In D89334#2329667 , @labath wrote: > >> The main question on my mind is should we be adding the directory of the >> python file to the path

[Lldb-commits] [lldb] 82ed186 - [lldb] Explicitly test the template argument SB API

Author: Raphael Isemann Date: 2020-10-15T11:17:43+02:00 New Revision: 82ed18601dbc816e1f64407a926602f95bbeda32 URL: https://github.com/llvm/llvm-project/commit/82ed18601dbc816e1f64407a926602f95bbeda32 DIFF:

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

labath added a comment. Making this a separate patch is a good idea, but it does not materially address my objections to having ProcessTrace and ThreadTrace live in two different places. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89408/new/

[Lldb-commits] [PATCH] D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support

labath added a comment. Seems pretty straight forward. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89413/new/ https://reviews.llvm.org/D89413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D89428: Add support for more OS types to AddClangModuleCompilationOptionsForSDKType()

teemperor added a comment. Thanks for refactoring this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89428/new/ https://reviews.llvm.org/D89428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D89428: Add support for more OS types to AddClangModuleCompilationOptionsForSDKType()

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1525 + // If the SDK type is for the host OS, use its version number. + auto

[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

aarzilli updated this revision to Diff 298319. aarzilli added a comment. Like this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89315/new/ https://reviews.llvm.org/D89315 Files: lldb/tools/debugserver/source/DNB.cpp lldb/tools/debugserver/source/DNB.h

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 298311. wallace added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 Files: lldb/include/lldb/Target/Trace.h

[Lldb-commits] [lldb] b198568 - Fix typeo in attach failed error message.

Author: Jason Molenda Date: 2020-10-14T23:31:24-07:00 New Revision: b19856881c1624df8b667d672193be52dfa23846 URL: https://github.com/llvm/llvm-project/commit/b19856881c1624df8b667d672193be52dfa23846 DIFF: https://github.com/llvm/llvm-project/commit/b19856881c1624df8b667d672193be52dfa23846.diff