[Lldb-commits] [lldb] 30e7df0 - [lldb] XFAIL TestTypeGetModule.py (temporarily)

Author: Jonas Devlieghere Date: 2020-10-29T18:37:46-07:00 New Revision: 30e7df0d58542ad35d517eace70a4cea40e6fa7a URL: https://github.com/llvm/llvm-project/commit/30e7df0d58542ad35d517eace70a4cea40e6fa7a DIFF:

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

JDevlieghere added a comment. It was still failing so I've temporarily XFAIL'ed it in 30e7df0d58542ad35d517eace70a4cea40e6fa7a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

JDevlieghere added a comment. In D88483#2363529 , @fallkrum wrote: > make types extern. > @jingham please commit this patch to check if it will fix DWO issue, the > rest of your recommendations will add later. Jim asked me to follow up on this so I've

[Lldb-commits] [lldb] 56282cf - [lldb] Update TestTypeGetModule.py

Author: Ilya Bukonkin Date: 2020-10-29T18:28:57-07:00 New Revision: 56282cf7e271092a81aced9cb1e8998f2d395f70 URL: https://github.com/llvm/llvm-project/commit/56282cf7e271092a81aced9cb1e8998f2d395f70 DIFF: https://github.com/llvm/llvm-project/commit/56282cf7e271092a81aced9cb1e8998f2d395f70.diff

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56282cf7e271: [lldb] Update TestTypeGetModule.py (authored by fallkrum, committed by JDevlieghere). Changed prior to commit:

[Lldb-commits] [PATCH] D89842: [lldb/DWARF] Add support for DW_OP_implicit_value

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89842/new/ https://reviews.llvm.org/D89842

[Lldb-commits] [PATCH] D89842: [lldb/DWARF] Add support for DW_OP_implicit_value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGefe62b637d51: [lldb/DWARF] Add support for DW_OP_implicit_value (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 301796. fallkrum added a comment. make types extern. @jingham please commit this patch to check if it will fix DWO issue, the rest of your recommendations will add later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

jingham added a comment. The test failed in the new form at line 77. So we got the CU for compile_unit1.c and it was valid. But it didn't contain an SBType for compile_unit1_type. Probably the same thing is true in compile_unit2.c you just didn't get there. Maybe your executable is too

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

jingham added a comment. Sorry to be picky, but you can compress this by putting the IsValid checks into your find_* routines. And the: self.assertEqual(cu_type.GetName(), type2_name) calls aren't necessary, since you already found the type by matching the name. So I think you can

[Lldb-commits] [lldb] 32a85b2 - This is a preliminary version of the test for https://reviews.llvm.org/D88483.

Author: Jim Ingham Date: 2020-10-29T16:39:35-07:00 New Revision: 32a85b268a010035e81646541ac1c9675da6cb2e URL: https://github.com/llvm/llvm-project/commit/32a85b268a010035e81646541ac1c9675da6cb2e DIFF: https://github.com/llvm/llvm-project/commit/32a85b268a010035e81646541ac1c9675da6cb2e.diff

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2363277 , @jingham wrote: > This test is still assuming (1) that main.c is CompUnit(0), etc. You don't > know that's true. And that there is only one type in each CU (and type 0 is > the one you want). Neither of

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 301783. fallkrum added a comment. Api test fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files:

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

jingham added a comment. This test is still assuming (1) that main.c is CompUnit(0), etc. You don't know that's true. And that there is only one type in each CU (and type 0 is the one you want). Neither of these is guaranteed. Can you check all these things, I'd rather not have to go a

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2363075 , @fallkrum wrote: > @JDevlieghere @jingham api test failed after my commit: > http://lab.llvm.org:8011/#/builders/68/builds/1040 > Had no such an error on my computer, please help to figure out what went >

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 301768. fallkrum added a comment. Api test improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files:

[Lldb-commits] [lldb] fa5a132 - Provide a reasonable value for PATH_MAX if the lldb headers don't provide it.

Author: Jim Ingham Date: 2020-10-29T15:02:51-07:00 New Revision: fa5a13276764a2657b3571fa3c57b07ee5d2d661 URL: https://github.com/llvm/llvm-project/commit/fa5a13276764a2657b3571fa3c57b07ee5d2d661 DIFF: https://github.com/llvm/llvm-project/commit/fa5a13276764a2657b3571fa3c57b07ee5d2d661.diff

[Lldb-commits] [lldb] c8c07b7 - Use !hasLocalLinkage instead of listing the symbol types

Author: Jim Ingham Date: 2020-10-29T14:44:06-07:00 New Revision: c8c07b76b2cf2ada8e7ec132f7f57b97d76743cf URL: https://github.com/llvm/llvm-project/commit/c8c07b76b2cf2ada8e7ec132f7f57b97d76743cf DIFF: https://github.com/llvm/llvm-project/commit/c8c07b76b2cf2ada8e7ec132f7f57b97d76743cf.diff

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8c07b76b2cf: Use !hasLocalLinkage instead of listing the symbol

[Lldb-commits] [PATCH] D90332: Mark the execution of commands in stop hooks as non-interactive

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa37672e2db73: Mark the execution of stop-hooks as

[Lldb-commits] [lldb] a37672e - Mark the execution of stop-hooks as non-interactive.

Author: Jim Ingham Date: 2020-10-29T14:41:53-07:00 New Revision: a37672e2db7377681d996834a0c3073c9838a549 URL: https://github.com/llvm/llvm-project/commit/a37672e2db7377681d996834a0c3073c9838a549 DIFF: https://github.com/llvm/llvm-project/commit/a37672e2db7377681d996834a0c3073c9838a549.diff

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. Could you explain how to commit that Differential revision is closed by commit? Commited like described in here https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator git pull --rebase https://github.com/llvm/llvm-project.git master

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

jingham added a comment. In D88483#2363075 , @fallkrum wrote: > @JDevlieghere @jingham api test failed after my commit: > http://lab.llvm.org:8011/#/builders/68/builds/1040 > Had no such an error on my computer, please help to figure out what went >

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

jingham added a comment. In D78972#2353643 , @labath wrote: > Right -- I can understand that. I'm not sure whether this is a real issue -- > I'd expect that these compiler-internal symbols would normally have private > (not "internal") linkage (and

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

jingham updated this revision to Diff 301752. jingham added a comment. Switched to !hasLocalLinkage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78972/new/ https://reviews.llvm.org/D78972 Files: lldb/source/Expression/IRExecutionUnit.cpp

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. @JDevlieghere @jingham api test failed after my commit: http://lab.llvm.org:8011/#/builders/68/builds/1040 Had no such an error on my computer, please help to figure out what went wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 2c0cbc4 - GetModule, GetExeModule methods added

Author: Ilya Bukonkin Date: 2020-10-29T23:44:51+03:00 New Revision: 2c0cbc47cae4e69195a883771664ef3d5a54c7d2 URL: https://github.com/llvm/llvm-project/commit/2c0cbc47cae4e69195a883771664ef3d5a54c7d2 DIFF: https://github.com/llvm/llvm-project/commit/2c0cbc47cae4e69195a883771664ef3d5a54c7d2.diff

[Lldb-commits] [lldb] 9bb9b73 - Remove HAVE_VCS_VERSION_INC, not needed

Author: Marcel Hlopko Date: 2020-10-29T13:09:05-07:00 New Revision: 9bb9b737c5573cf3850230bc4db8dac7be0e1e85 URL: https://github.com/llvm/llvm-project/commit/9bb9b737c5573cf3850230bc4db8dac7be0e1e85 DIFF: https://github.com/llvm/llvm-project/commit/9bb9b737c5573cf3850230bc4db8dac7be0e1e85.diff

[Lldb-commits] [PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bb9b737c557: Remove HAVE_VCS_VERSION_INC, not needed (authored by hlopko, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

MaskRay accepted this revision. MaskRay added a comment. Herald added a subscriber: dexonsmith. Thanks! Assuming you don't have a commit bit, I'll commit on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84623/new/

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

JDevlieghere updated this revision to Diff 301716. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90414/new/ https://reviews.llvm.org/D90414 Files: lldb/examples/python/crashlog.py Index: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

JDevlieghere updated this revision to Diff 301714. JDevlieghere added a comment. Fix indentation that got screwed up when staging only non-whitespace changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90414/new/ https://reviews.llvm.org/D90414 Files:

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

jingham added a comment. In D89157#2362697 , @JosephTremoulet wrote: >> But then you get to a point where you shouldn't really have multiple modules >> replacing a single one so you aren't really sure what to do about it. That >> part makes me a little

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda. Herald added a project: LLDB. JDevlieghere requested review of this revision. Skip the instruction stream section in the crashlog section. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

JosephTremoulet added a comment. > But then you get to a point where you shouldn't really have multiple modules > replacing a single one so you aren't really sure what to do about it. That > part makes me a little uneasy. Yeah, I wouldn't claim that the handling of the multiple-old-module case

[Lldb-commits] [PATCH] D90413: [nfc] [lldb] Align `user_id_t` format to the current `DIERef` format

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. Current `user_id_t` format is: `63{isDebugTypes} 62..32{dwo || 7fff} 31..0 {die_offset}`

[Lldb-commits] [PATCH] D90325: [lldb][NFC] Refactor getUUID functionality

zequanwu updated this revision to Diff 301694. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90325/new/ https://reviews.llvm.org/D90325 Files:

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

jingham added a comment. All the parts of D89156 that are just being consistent about always passing old_modules as a vector seem okay. But then you get to a point where you shouldn't really have multiple modules replacing a single one so you aren't really

[Lldb-commits] [lldb] 41f2bb2 - [nfc] [lldb] Remove excessive parentheses in SymbolFileDWARF::GetUID

Author: Jan Kratochvil Date: 2020-10-29T18:01:37+01:00 New Revision: 41f2bb232cc064c0289de877552cbd6a077a7ba5 URL: https://github.com/llvm/llvm-project/commit/41f2bb232cc064c0289de877552cbd6a077a7ba5 DIFF:

[Lldb-commits] [PATCH] D90318: Return actual type from SBType::GetArrayElementType

werat added a comment. Btw, I don't have commit access, so would be great if someone could land this for me :) (if everything is OK with this patch). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90318/new/ https://reviews.llvm.org/D90318

[Lldb-commits] [PATCH] D90393: [lldb/test] Simplify/generalize YAMLModuleTester

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90393/new/ https://reviews.llvm.org/D90393

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

JosephTremoulet added a comment. Thanks for the review! I'm still unsure how to proceed w.r.t. D89156 -- did you intend to include that when you approved this change, or do you have a sense when you'll have time to look at it, or should I change this to not

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

labath added a comment. echo `` is funny and creative, but I doubt it will work on windows. :) The way that other tests deal with that is they put the commands to run into a file, and then run %lldb -o 'settings set interpreter.stop-command-source-on-error false' -s commands For the

[Lldb-commits] [PATCH] D90393: [lldb/test] Simplify/generalize YAMLModuleTester

labath created this revision. labath added reviewers: aprantl, JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: LLDB. labath requested review of this revision. The class only supports a single DWARF unit (needed for my new test), and it reimplements chunks of object and

[Lldb-commits] [PATCH] D90325: [lldb][NFC] Refactor getUUID functionality

labath added a comment. Thanks for cleaning this up. A couple of comments inline. Comment at: lldb/include/lldb/Utility/UUID.h:41 + /// Create a UUID from CvRecordPdb70. + static UUID fromData(const CvRecordPdb70 *debug_info, + bool swapByteOrder =

[Lldb-commits] [lldb] 8cc49be - [lldb] Use reverse connection method for lldb-server tests

Author: Pavel Labath Date: 2020-10-29T13:49:51+01:00 New Revision: 8cc49bec2e067808e4b4d091a351fd66616d7b18 URL: https://github.com/llvm/llvm-project/commit/8cc49bec2e067808e4b4d091a351fd66616d7b18 DIFF: https://github.com/llvm/llvm-project/commit/8cc49bec2e067808e4b4d091a351fd66616d7b18.diff

[Lldb-commits] [PATCH] D90313: [lldb] Use reverse connection method for lldb-server tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc49bec2e06: [lldb] Use reverse connection method for lldb-server tests (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt

labath abandoned this revision. labath added a comment. Just abandoning. I believe I've removed the most egregious parts of the Scalar class now. There's still room for improvement, but that requires a fresh start anyway... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 075f661 - [lldb] Unbreak the build after a recent PowerPC change

Author: David Zarzycki Date: 2020-10-29T05:56:38-04:00 New Revision: 075f661d01f856192c236b6256f18bc697e28e1b URL: https://github.com/llvm/llvm-project/commit/075f661d01f856192c236b6256f18bc697e28e1b DIFF:

[Lldb-commits] [lldb] 749f13e - [lldb] Correct --help output for qemu rootfs script

Author: David Spickett Date: 2020-10-29T09:57:32Z New Revision: 749f13e7635aebcda978ee2e42f5569ab7f0fafc URL: https://github.com/llvm/llvm-project/commit/749f13e7635aebcda978ee2e42f5569ab7f0fafc DIFF: https://github.com/llvm/llvm-project/commit/749f13e7635aebcda978ee2e42f5569ab7f0fafc.diff

[Lldb-commits] [PATCH] D90225: [lldb] Correct --help output for qemu rootfs script

This revision was automatically updated to reflect the committed changes. Closed by commit rG749f13e7635a: [lldb] Correct --help output for qemu rootfs script (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90225/new/

[Lldb-commits] [PATCH] D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. This patch no longer applies, it needs a rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82864/new/

[Lldb-commits] [PATCH] D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt

jankratochvil added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:467 bool ret; - ret = scalar_value.ULongLong(1) != 0; + ret = scalar_value != 0; error.Clear(); mib wrote: > Any reason why this is not inlined in the definition ? IMO this

[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

teemperor resigned from this revision. teemperor added a comment. Herald added a reviewer: JDevlieghere. D90151 landed and addressed/tested this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83180/new/

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

jasonmolenda updated this revision to Diff 301531. jasonmolenda added a comment. Update to address previous review comments. (1) Update SBMemoryRegionInfo API to provide access to the dirty page information. (2) Update the 'memory region' command output to print the dirty page list. (3)