[Lldb-commits] [PATCH] D91130: [crashlog] Implement parser for JSON encoded crashlogs

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D91130#2387390 , @clayborg wrote: > JSON crash logs are almost here??? I remember asking for those back when I > was at Apple! Great news. Yep! 拾 > It would be nice to have

[Lldb-commits] [PATCH] D91220: [ThreadPlan] Add a test for `thread step-in -r`, NFC

stella.stamenova added a comment. This test is failing on the Windows bot: http://lab.llvm.org:8011/#/builders/83/builds/678 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91220/new/ https://reviews.llvm.org/D91220

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace planned changes to this revision. wallace added a comment. - After taking a second look I realized I don't need caching. For some reason I thought that autocompletion would be triggered with every keystroke, and that's why caching would be useful. But I was wrong all along! These

[Lldb-commits] [PATCH] D91220: [ThreadPlan] Add a test for `thread step-in -r`, NFC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae3640e386cc: [ThreadPlan] Add a test for `thread step-in -r`,

[Lldb-commits] [lldb] 9922dde - [test] Delete redundant lldbutil import, NFC

Author: Vedant Kumar Date: 2020-11-10T16:37:47-08:00 New Revision: 9922dded4737ff640f046f62f83bf1d05f26d97d URL: https://github.com/llvm/llvm-project/commit/9922dded4737ff640f046f62f83bf1d05f26d97d DIFF: https://github.com/llvm/llvm-project/commit/9922dded4737ff640f046f62f83bf1d05f26d97d.diff

[Lldb-commits] [lldb] ae3640e - [ThreadPlan] Add a test for `thread step-in -r`, NFC

Author: Vedant Kumar Date: 2020-11-10T16:37:47-08:00 New Revision: ae3640e386ccfbe0e984cc8c4b0399006ed835c7 URL: https://github.com/llvm/llvm-project/commit/ae3640e386ccfbe0e984cc8c4b0399006ed835c7 DIFF: https://github.com/llvm/llvm-project/commit/ae3640e386ccfbe0e984cc8c4b0399006ed835c7.diff

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM with the error string stuff included so we can get a nice string error message. Pavel, do you have anything? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

clayborg added a comment. Still wondering if we need to do caching in TracePluginCommandDelegate. How many times do we fetch the command object if we type "thread trace start"? I don't know how much performance is truly needed here at the expense of maintaining the caching code.

[Lldb-commits] [PATCH] D91118: Fix handling of bit-fields in a union

shafik updated this revision to Diff 304354. shafik added a comment. Add a check to make sure the bit offset is zero for fields in a union. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91118/new/ https://reviews.llvm.org/D91118 Files:

[Lldb-commits] [PATCH] D91220: [ThreadPlan] Add a test for `thread step-in -r`, NFC

jingham added a comment. It's easier to read these tests if you use "lldbutil.run_to_source_breakpoint" to remove all that boilerplate. Other than that LGTM. Thanks for adding the test! Comment at: lldb/test/API/lang/c/stepping/TestThreadStepInAvoidRegexp.py:27-45 +

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

JDevlieghere updated this revision to Diff 304352. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77153/new/ https://reviews.llvm.org/D77153 Files: lldb/include/lldb/Target/Language.h lldb/source/DataFormatters/ValueObjectPrinter.cpp

[Lldb-commits] [lldb] 34d56b0 - [ThreadPlan] Reflow docs to fit the 80 column limit, NFC

Author: Vedant Kumar Date: 2020-11-10T16:14:52-08:00 New Revision: 34d56b05fd78f0d3043f7f02badf7067cecadb30 URL: https://github.com/llvm/llvm-project/commit/34d56b05fd78f0d3043f7f02badf7067cecadb30 DIFF: https://github.com/llvm/llvm-project/commit/34d56b05fd78f0d3043f7f02badf7067cecadb30.diff

[Lldb-commits] [lldb] ba21376 - [Command] Fix accidental word concatenation in Options.td

Author: Vedant Kumar Date: 2020-11-10T16:13:39-08:00 New Revision: ba21376883d4527204ab6716597ca179e0b76157 URL: https://github.com/llvm/llvm-project/commit/ba21376883d4527204ab6716597ca179e0b76157 DIFF: https://github.com/llvm/llvm-project/commit/ba21376883d4527204ab6716597ca179e0b76157.diff

[Lldb-commits] [lldb] 04cd6c6 - [ThreadPlan] Delete unused ThreadPlanStepInRange code, NFC

Author: Vedant Kumar Date: 2020-11-10T16:15:03-08:00 New Revision: 04cd6c62176ce027af2d343044b84ce5d317aee7 URL: https://github.com/llvm/llvm-project/commit/04cd6c62176ce027af2d343044b84ce5d317aee7 DIFF: https://github.com/llvm/llvm-project/commit/04cd6c62176ce027af2d343044b84ce5d317aee7.diff

[Lldb-commits] [PATCH] D91220: [ThreadPlan] Add a test for `thread step-in -r`, NFC

vsk created this revision. vsk added a reviewer: jingham. Herald added a project: LLDB. vsk requested review of this revision. Herald added a subscriber: JDevlieghere. Adds test coverage for ThreadPlanStepInRange::SetAvoidRegexp. See:

[Lldb-commits] [PATCH] D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Read and write registers from m_gpr using offsets from RegisterInfo rather than explicit switch-case. This eliminates a lot of

[Lldb-commits] [PATCH] D91206: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Following discussion in D91193

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 304317. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90729/new/ https://reviews.llvm.org/D90729 Files: lldb/include/lldb/Core/PluginManager.h

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. That's much better. I'll change those callers can be changed to `runCmd`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

teemperor added a comment. In D91193#2386832 , @kastiglione wrote: > @teemperor maybe? Do you mean validation should go in `runCmd`? Or do you > mean something else? I meant that to my knowledge command execution where the only expectation is that they

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

JDevlieghere added a comment. In D77153#2386740 , @shafik wrote: > So this work for primitive types like `int*` etc? No, Jim probably know the details, but this only applies to composite types. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. @teemperor maybe? Do you mean validation should go in `runCmd`? Or do you mean something else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

shafik added a comment. So this work for primitive types like `int*` etc? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77153/new/ https://reviews.llvm.org/D77153 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

teemperor added a comment. Isn't that what we use `runCmd` for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

JDevlieghere updated this revision to Diff 304282. JDevlieghere added a comment. - Add fallback for finding the language - Fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77153/new/ https://reviews.llvm.org/D77153 Files: lldb/include/lldb/Target/Language.h

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione created this revision. kastiglione added reviewers: jingham, teemperor, aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Restore ability to call `expect()` with a message and no matcher. After

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 304267. wallace added a comment. Address comments - I didn't move the caching to Process.h, as creating the start command requires an Interpreter, which I don't know if I can assume as unique. Btw, I'm using weak pointers instead. - I added an

[Lldb-commits] [PATCH] D91167: [lldb] [Process/NetBSD] Copy the recent improvements from FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGf21e704d4a2c: [lldb] [Process/NetBSD] Copy the recent improvements from FreeBSD (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f21e704 - [lldb] [Process/NetBSD] Copy the recent improvements from FreeBSD

Author: Michał Górny Date: 2020-11-10T20:20:44+01:00 New Revision: f21e704d4a2cc992faff46665b31daad290cc8b8 URL: https://github.com/llvm/llvm-project/commit/f21e704d4a2cc992faff46665b31daad290cc8b8 DIFF: https://github.com/llvm/llvm-project/commit/f21e704d4a2cc992faff46665b31daad290cc8b8.diff

[Lldb-commits] [PATCH] D91155: [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitution

teemperor closed this revision. teemperor added a comment. Added the disallow in rG7211604220ae Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91155/new/

[Lldb-commits] [lldb] 7211604 - [lldb][NFC] Add lldb-server to the shell tests disallow list

Author: Raphael Isemann Date: 2020-11-10T18:48:28+01:00 New Revision: 7211604220ae7de9d96abb3385248dc2fecc9777 URL: https://github.com/llvm/llvm-project/commit/7211604220ae7de9d96abb3385248dc2fecc9777 DIFF:

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

wallace updated this revision to Diff 304232. wallace added a comment. Added a test that accounts for a custom error message from the gdb-server. I decided to follow @labath's approach of using the existing error code format (;AAA). It works well and the GDBClient classes already have good

[Lldb-commits] [PATCH] D91118: Fix handling of bit-fields in a union

teemperor added a comment. Should we maybe check that the offset is 0 instead of skipping the sanity check? Otherwise this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91118/new/ https://reviews.llvm.org/D91118 ___ lldb-commits

[Lldb-commits] [PATCH] D91155: [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitution

JDevlieghere reopened this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Please add a `_disallow` to avoid accidental use of `lldb-server` without the `%`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8da14fb - [lldb] Propagate llvm::Error to report_fatal_error

Author: Jonas Devlieghere Date: 2020-11-10T08:19:47-08:00 New Revision: 8da14fb76c77471479a12e5c5e1acd7b57117062 URL: https://github.com/llvm/llvm-project/commit/8da14fb76c77471479a12e5c5e1acd7b57117062 DIFF:

[Lldb-commits] [PATCH] D91167: [lldb] [Process/NetBSD] Copy the recent improvements from FreeBSD

mgorny created this revision. mgorny added reviewers: krytarowski, labath. Herald added subscribers: arichardson, emaste. mgorny requested review of this revision. Copy the recent improvements from the FreeBSDRemote plugin, notably: - moving event reporting setup into SetupTrace() helper -

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304198. njames93 added a comment. Herald added subscribers: usaxena95, kadircet, arphaman. Teach clangd to ignore these fix-its. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/

[Lldb-commits] [PATCH] D90987: [lldb] Avoid confusing crashes during reproducer replay when initialization failed

JDevlieghere added inline comments. Comment at: lldb/source/API/SystemInitializerFull.cpp:46 +if (repro::Reproducer::Instance().IsReplaying()) + std::_Exit(EXIT_FAILURE); +return error; labath wrote: > labath wrote: > > Print the error that has

[Lldb-commits] [lldb] 4edb7e3 - [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

Author: Pavel Labath Date: 2020-11-10T16:10:08+01:00 New Revision: 4edb7e34f824ca4adaa55d3668e050166bae2ad4 URL: https://github.com/llvm/llvm-project/commit/4edb7e34f824ca4adaa55d3668e050166bae2ad4 DIFF: https://github.com/llvm/llvm-project/commit/4edb7e34f824ca4adaa55d3668e050166bae2ad4.diff

[Lldb-commits] [PATCH] D90840: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4edb7e34f824: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results (authored by labath). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. In D82863#2375525 , @omjavaid wrote: > GDB does not have pseudo registers as part of xml register description. GDB > is managing pseudo registers on client side and independent of rest of the > register set. In case of SVE Z

[Lldb-commits] [PATCH] D91155: [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitution

teemperor added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/test/Shell/helper/toolchain.py:65-68 ToolSubst('%platformserver', command=FindTool('lldb-server'), extra_args=['platform'],

[Lldb-commits] [lldb] 9b0578d - [lldb] Reinstate TestGdbserverPort.test

Author: Raphael Isemann Date: 2020-11-10T15:51:15+01:00 New Revision: 9b0578d54631b763a3af26bb3a94cad3b0fc220e URL: https://github.com/llvm/llvm-project/commit/9b0578d54631b763a3af26bb3a94cad3b0fc220e DIFF:

[Lldb-commits] [PATCH] D91155: [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitution

This revision was automatically updated to reflect the committed changes. Closed by commit rGc50faf5c9d7c: [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] c50faf5 - [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitution

Author: Raphael Isemann Date: 2020-11-10T15:26:19+01:00 New Revision: c50faf5c9d7ca7a62cd59516c7de305b73f2455c URL: https://github.com/llvm/llvm-project/commit/c50faf5c9d7ca7a62cd59516c7de305b73f2455c DIFF:

[Lldb-commits] [PATCH] D90987: [lldb] Avoid confusing crashes during reproducer replay when initialization failed

labath added a comment. In D90987#2383141 , @JDevlieghere wrote: > In D90987#2381853 , @labath wrote: > >> I wonder if there's a way to add some consistency checks into the (active) >> replay machinery. Like,

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

labath added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:262 +send packet: jLLDBTraceSupportedType +read packet: {"name": , "description", }/E + clayborg wrote: > I know the deprecated trace packets allows an error code to be returned, but >

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

mgorny added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:214 + llvm::Error error = t.CopyWatchpointsFrom( + static_cast(*GetCurrentThread())); + if (error) {

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c54399b7eaa: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 194c5ac - [lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes

Author: Michał Górny Date: 2020-11-10T14:18:03+01:00 New Revision: 194c5accb2be0dab75085f8f5c9c488d1cee7606 URL: https://github.com/llvm/llvm-project/commit/194c5accb2be0dab75085f8f5c9c488d1cee7606 DIFF: https://github.com/llvm/llvm-project/commit/194c5accb2be0dab75085f8f5c9c488d1cee7606.diff

[Lldb-commits] [PATCH] D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

This revision was automatically updated to reflect the committed changes. Closed by commit rGe637602e7ac9: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4c54399 - [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

Author: Michał Górny Date: 2020-11-10T14:18:03+01:00 New Revision: 4c54399b7eaa487e91c32a0d9c2537611c25aee7 URL: https://github.com/llvm/llvm-project/commit/4c54399b7eaa487e91c32a0d9c2537611c25aee7 DIFF: https://github.com/llvm/llvm-project/commit/4c54399b7eaa487e91c32a0d9c2537611c25aee7.diff

[Lldb-commits] [lldb] e637602 - [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

Author: Michał Górny Date: 2020-11-10T14:18:03+01:00 New Revision: e637602e7ac9bb5721dbe079fa783cee891139b4 URL: https://github.com/llvm/llvm-project/commit/e637602e7ac9bb5721dbe079fa783cee891139b4 DIFF: https://github.com/llvm/llvm-project/commit/e637602e7ac9bb5721dbe079fa783cee891139b4.diff

[Lldb-commits] [PATCH] D91076: [lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes

This revision was automatically updated to reflect the committed changes. Closed by commit rG194c5accb2be: [lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:214 + llvm::Error error = t.CopyWatchpointsFrom( + static_cast(*GetCurrentThread())); + if (error) { labath wrote: > maybe this cast

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:214 + llvm::Error error = t.CopyWatchpointsFrom( + static_cast(*GetCurrentThread())); + if (error) {

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

mgorny updated this revision to Diff 304138. mgorny added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91032/new/ https://reviews.llvm.org/D91032 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 added a comment. An example of this in action is D91149 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.org/D91103 ___

[Lldb-commits] [PATCH] D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

mgorny updated this revision to Diff 304135. mgorny added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91007/new/ https://reviews.llvm.org/D91007 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304126. njames93 added a comment. Add `isReformatFixit` method to `FixItHint` to better express intent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.org/D91103 Files:

[Lldb-commits] [lldb] a852cf6 - [lldb] [test] Skip ObjC-based tests via 'objc' category

Author: Michał Górny Date: 2020-11-10T12:02:38+01:00 New Revision: a852cf66ea5d130a09cd796b97b15c18059e95cd URL: https://github.com/llvm/llvm-project/commit/a852cf66ea5d130a09cd796b97b15c18059e95cd DIFF: https://github.com/llvm/llvm-project/commit/a852cf66ea5d130a09cd796b97b15c18059e95cd.diff

[Lldb-commits] [lldb] 311cca8 - [lldb] [test] Rename '.categories' to 'categories'

Author: Michał Górny Date: 2020-11-10T12:02:38+01:00 New Revision: 311cca8bbf882cd93124d5ee9f40ee47f5e1f57d URL: https://github.com/llvm/llvm-project/commit/311cca8bbf882cd93124d5ee9f40ee47f5e1f57d DIFF: https://github.com/llvm/llvm-project/commit/311cca8bbf882cd93124d5ee9f40ee47f5e1f57d.diff

[Lldb-commits] [PATCH] D91065: [lldb] [test] Rename '.categories' to 'categories'

This revision was automatically updated to reflect the committed changes. Closed by commit rG311cca8bbf88: [lldb] [test] Rename .categories to categories (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91056: [lldb] [test] Skip ObjC-based tests via 'objc' category

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rGa852cf66ea5d: [lldb] [test] Skip ObjC-based tests via objc category (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG203b4774b883: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via… (authored by sgraenitz). Repository: rG LLVM Github

[Lldb-commits] [lldb] 203b477 - [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

Author: Stefan Gränitz Date: 2020-11-10T11:37:53+01:00 New Revision: 203b4774b88322de22c99881a3e1e4c78a9d5a0e URL: https://github.com/llvm/llvm-project/commit/203b4774b88322de22c99881a3e1e4c78a9d5a0e DIFF:

[Lldb-commits] [PATCH] D91056: [lldb] [test] Skip ObjC-based tests via 'objc' category

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:839 +def checkObjcSupport(): +from . import lldbplatformutil +if not lldbplatformutil.platformIsDarwin(): teemperor wrote: >

[Lldb-commits] [PATCH] D91056: [lldb] [test] Skip ObjC-based tests via 'objc' category

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Thanks for cleaning this up, it's really appreciated! Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:839 +def checkObjcSupport(): +from . import