[Lldb-commits] [lldb] a4d1e60 - [crashlog] Improve patch-crashlog.py script

Author: Jonas Devlieghere Date: 2020-11-16T23:27:40-08:00 New Revision: a4d1e60910ede9456f5720bcd40b17279e3b9331 URL: https://github.com/llvm/llvm-project/commit/a4d1e60910ede9456f5720bcd40b17279e3b9331 DIFF:

[Lldb-commits] [PATCH] D91578: [lldb] [test] Pass -mmmx to x86-gp-write test explicitly

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Pass -mmmx explicitly to fix build failure with FreeBSD's clang on i386. https://reviews.llvm.org/D91578 Files:

[Lldb-commits] [PATCH] D91130: [crashlog] Implement parser for JSON encoded crashlogs

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7cbf32f5770: [crashlog] Implement parser for JSON encoded crashlogs (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] c7cbf32 - [crashlog] Implement parser for JSON encoded crashlogs

Author: Jonas Devlieghere Date: 2020-11-16T13:50:37-08:00 New Revision: c7cbf32f5770c5eec2a2dd6eb7cf3153e654ed08 URL: https://github.com/llvm/llvm-project/commit/c7cbf32f5770c5eec2a2dd6eb7cf3153e654ed08 DIFF:

[Lldb-commits] [lldb] fa72ce3 - Another speculative fix for lldb related to ConstexprSpecKind

Author: Aaron Ballman Date: 2020-11-16T14:39:34-05:00 New Revision: fa72ce346c5f81ef96901fce0b6b23fa4faaa33e URL: https://github.com/llvm/llvm-project/commit/fa72ce346c5f81ef96901fce0b6b23fa4faaa33e DIFF: https://github.com/llvm/llvm-project/commit/fa72ce346c5f81ef96901fce0b6b23fa4faaa33e.diff

[Lldb-commits] [lldb] 1941d96 - Speculatively fix the lldb build

Author: Aaron Ballman Date: 2020-11-16T14:23:04-05:00 New Revision: 1941d9651cc90948fa442584eec09bdb0cf01a33 URL: https://github.com/llvm/llvm-project/commit/1941d9651cc90948fa442584eec09bdb0cf01a33 DIFF: https://github.com/llvm/llvm-project/commit/1941d9651cc90948fa442584eec09bdb0cf01a33.diff

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

rupprecht added a comment. In D87637#2395603 , @teemperor wrote: > Yeah I don't think this revision is to blame as just disabling the code here > doesn't bring back the backtraces. Doesn't explain what happened to them, but > that's probably on me to

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny updated this revision to Diff 305545. mgorny added a comment. Port NetBSD plugin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp

[Lldb-commits] [lldb] 618f11b - [lldb] Skip TestCppKeywordsAsCIdentifiers on Windows

Author: Raphael Isemann Date: 2020-11-16T18:41:04+01:00 New Revision: 618f11ba0bf96107074e8c3f16753bbfd24b7062 URL: https://github.com/llvm/llvm-project/commit/618f11ba0bf96107074e8c3f16753bbfd24b7062 DIFF:

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny updated this revision to Diff 305536. mgorny added a comment. Move the functions into a new file, add comment, use `llvm::ArrayRef`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 Files:

Re: [Lldb-commits] [lldb] 875be9f - [lldb] Mark command-process-connect as unsupported on Windows

On Fri, 13 Nov 2020 at 23:02, Jonas Devlieghere via lldb-commits wrote: > > > Author: Jonas Devlieghere > Date: 2020-11-13T20:02:05-08:00 > New Revision: 875be9f454c31c94701bdf4e28f8bea07a8c9c79 > > URL: > https://github.com/llvm/llvm-project/commit/875be9f454c31c94701bdf4e28f8bea07a8c9c79 >

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t abridged_tw = *(uint8_t *)src; labath wrote: >

[Lldb-commits] [PATCH] D82770: [lldb] Add support for using variables with C++ keywords names in non-C++ expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8350ce79d16: [lldb] Add support for using variables with C++ keywords names in non-C++… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] a8350ce - [lldb] Add support for using variables with C++ keywords names in non-C++ expressions

Author: Raphael Isemann Date: 2020-11-16T16:04:44+01:00 New Revision: a8350ce79d167643b53d06e2167535d24fe68dc3 URL: https://github.com/llvm/llvm-project/commit/a8350ce79d167643b53d06e2167535d24fe68dc3 DIFF:

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

mgorny updated this revision to Diff 305498. mgorny added a comment. Fix wrong output num (`$2` instead of `$1`) in x86-fp-read.test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91497/new/ https://reviews.llvm.org/D91497 Files:

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. One issue with the `orc-lazy` JIT will be symbol renaming for lazy reexports: Upfront we only emit stubs for our function symbols and they trigger compilation of the actual code in a separate logical unit once they are called. The debug object we hand over to LLDB

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

anarazel added a comment. It's not really the fault of this change, but the gdb support isn't really restricted to mcjit. `registerJITEventListener()` works with RTDyld based Orc too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90789/new/

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. Thanks for having a look. That's right and it's on my wishlist. However, the example doesn't actually work with `--jit-kind=orc-lazy` (yet). On Linux it should use RTDyldObjectLinkingLayer and so it should notify LLDB when new code is loaded, but somehow it doesn't:

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

labath added a comment. Looks reasonable to me. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t abridged_tw = *(uint8_t *)src;

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

mgorny updated this revision to Diff 305472. mgorny marked an inline comment as done. mgorny added a comment. Implemented requested changes. Clang-formatted. Extended fp-write tests to cover both writing fioff/fooff and fip/fdp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91497/new/

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

labath added a comment. I disagree, and my main reason for that is that this approach requires hardcoding the "supported architectures" for which we do this fixup in the DynamicRegisterInfo class. Besides being wrong as a matter of priniciple, I suspect this will also be a problem in practice

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64.h:262 DEFINE_FPR(fioff, ptr.i386_.fioff, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM), +

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

This revision was automatically updated to reflect the committed changes. Closed by commit rG68ca01eb50af: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b9734c6 - [lldb] [Process/FreeBSDRemote] Optimize regset pointer logic

Author: Michał Górny Date: 2020-11-16T13:03:02+01:00 New Revision: b9734c6b44e52fd94f9fe19f8ce60f55c4d3819c URL: https://github.com/llvm/llvm-project/commit/b9734c6b44e52fd94f9fe19f8ce60f55c4d3819c DIFF: https://github.com/llvm/llvm-project/commit/b9734c6b44e52fd94f9fe19f8ce60f55c4d3819c.diff

[Lldb-commits] [PATCH] D91411: [lldb] [Process/FreeBSDRemote] Optimize regset pointer logic

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9734c6b44e5: [lldb] [Process/FreeBSDRemote] Optimize regset pointer logic (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91268: [lldb] [Process/FreeBSDRemote] Access debug registers via offsets

This revision was automatically updated to reflect the committed changes. Closed by commit rG6adb55877c4b: [lldb] [Process/FreeBSDRemote] Access debug registers via offsets (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D91248: [lldb] [Process/FreeBSDRemote] Access FPR via RegisterInfo offsets

This revision was automatically updated to reflect the committed changes. Closed by commit rGe520487bf4bf: [lldb] [Process/FreeBSDRemote] Access FPR via RegisterInfo offsets (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 68ca01e - [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

Author: Michał Górny Date: 2020-11-16T13:03:01+01:00 New Revision: 68ca01eb50af0a4aca06c90a4ce1eb78029603f6 URL: https://github.com/llvm/llvm-project/commit/68ca01eb50af0a4aca06c90a4ce1eb78029603f6 DIFF: https://github.com/llvm/llvm-project/commit/68ca01eb50af0a4aca06c90a4ce1eb78029603f6.diff

[Lldb-commits] [lldb] e520487 - [lldb] [Process/FreeBSDRemote] Access FPR via RegisterInfo offsets

Author: Michał Górny Date: 2020-11-16T13:03:01+01:00 New Revision: e520487bf4bf1efc83e1f8175c6fd8356495bb5d URL: https://github.com/llvm/llvm-project/commit/e520487bf4bf1efc83e1f8175c6fd8356495bb5d DIFF: https://github.com/llvm/llvm-project/commit/e520487bf4bf1efc83e1f8175c6fd8356495bb5d.diff

[Lldb-commits] [lldb] 6adb558 - [lldb] [Process/FreeBSDRemote] Access debug registers via offsets

Author: Michał Górny Date: 2020-11-16T13:03:01+01:00 New Revision: 6adb55877c4bae6c75ab0d2c0374fab6787bff2d URL: https://github.com/llvm/llvm-project/commit/6adb55877c4bae6c75ab0d2c0374fab6787bff2d DIFF: https://github.com/llvm/llvm-project/commit/6adb55877c4bae6c75ab0d2c0374fab6787bff2d.diff

[Lldb-commits] [PATCH] D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets

This revision was automatically updated to reflect the committed changes. Closed by commit rG58abbf821ce8: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 58abbf8 - [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets

Author: Michał Górny Date: 2020-11-16T12:19:37+01:00 New Revision: 58abbf821ce88f4d35cdfa36cdb486e2d56a04e2 URL: https://github.com/llvm/llvm-project/commit/58abbf821ce88f4d35cdfa36cdb486e2d56a04e2 DIFF: https://github.com/llvm/llvm-project/commit/58abbf821ce88f4d35cdfa36cdb486e2d56a04e2.diff

[Lldb-commits] [PATCH] D91268: [lldb] [Process/FreeBSDRemote] Access debug registers via offsets

labath added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:699-711 + uint32_t regno; + switch (GetRegisterInfoInterface().GetTargetArchitecture().GetMachine()) { + case llvm::Triple::x86: +regno =

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:60-78 +static int runCallback(lua_State *L) { + LuaCallback *callback = static_cast(lua_touserdata(L, -1)); + return (*callback)(L); +} + +llvm::Error Lua::Run(LuaCallback ) { +

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

labath added a comment. I like where this is going. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64.h:262 DEFINE_FPR(fioff, ptr.i386_.fioff, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM), +DEFINE_FPR(fip,

[Lldb-commits] [PATCH] D91268: [lldb] [Process/FreeBSDRemote] Access debug registers via offsets

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:699-711 + uint32_t regno; + switch (GetRegisterInfoInterface().GetTargetArchitecture().GetMachine()) { + case llvm::Triple::x86: +regno =

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 305427. tammela added a comment. Clean up includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 Files: lldb/bindings/lua/lua-swigsafecast.swig

[Lldb-commits] [PATCH] D91268: [lldb] [Process/FreeBSDRemote] Access debug registers via offsets

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:699-711 + uint32_t regno; + switch (GetRegisterInfoInterface().GetTargetArchitecture().GetMachine()) { + case

[Lldb-commits] [PATCH] D91422: [lldb] [Process/FreeBSDRemote] Check for regset support early [WIP]

labath added a subscriber: omjavaid. labath added a comment. My guess is that this is because of the extra debug registers that you're exposing. You'll notice that Get(User)RegisterSetCount returns just a number, and this means that it is not really possible to selectively disable register