[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

labath added a comment. Looks like a nice cleanup. The only part I am not sure of is the part about removing `$(RM) $(ARCHIVE_OBJECTS)`. Is that necessary? I'm not sure why is that line there, but if I had to guess, I would say it's to ensure that lldb (on macos) reads debug info from the

[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Utility/OptionDefinition.h:52 +// Must not have any bits set outside of unsigned char range +return !(short_option & ~((1 <<

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing

[Lldb-commits] [lldb] 4b57400 - [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

Author: Richard Smith Date: 2021-01-18T21:05:01-08:00 New Revision: 4b574008aef5a7235c1f894ab065fe300d26e786 URL: https://github.com/llvm/llvm-project/commit/4b574008aef5a7235c1f894ab065fe300d26e786 DIFF: https://github.com/llvm/llvm-project/commit/4b574008aef5a7235c1f894ab065fe300d26e786.diff

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Thu, Jan 14, 2021 at 2:56 PM Jim Ingham wrote: > > How were you setting the breakpoint in the case where it was failing from the > command line? The breakpoint you are examining in the test in your patches > is a "source regular expression" breakpoint. That would be "break set -p". > If

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

dblaikie added a comment. (Works for me, FWIW - takes my local run down from 42 failures in check-lldb-api to 1 (a timeout)) Out of curiousity did you find a way to get lldb-test to print out the stdout/stderr of the underlying lldb process to see what error messages it was producing that

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela added a comment. In D94937#2505676 , @JDevlieghere wrote: > We guarantee that the SB API is ABI stable so you cannot change the signature > of existing functions. Would an overload do the trick? Hmmm, that's tricky. I will see if I can come up

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela updated this revision to Diff 317439. tammela added a comment. Removing spurious line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94937/new/ https://reviews.llvm.org/D94937 Files: lldb/bindings/interface/SBStructuredData.i

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We guarantee that the SB API is ABI stable so you cannot change the signature of existing functions. Would an overload do the trick? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela created this revision. tammela requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch changes the GetStringValue method on the SBStructuredData class to return a `const char *`. This change allows the use of the method on the

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

tammela added inline comments. Comment at: lldb/bindings/lua/lua-wrapper.swig:25-29 + auto extra_args = [&]() -> llvm::Optional { + if (extra_args_impl == nullptr) + return {}; + return lldb::SBStructuredData(extra_args_impl); + } ();

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

tammela updated this revision to Diff 317395. tammela added a comment. Addressing comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93649/new/ https://reviews.llvm.org/D93649 Files: lldb/bindings/lua/lua-swigsafecast.swig

[Lldb-commits] [PATCH] D94899: [lldb][docs] Use 'any' as the default role in LLDB's sphinx project

This revision was automatically updated to reflect the committed changes. Closed by commit rGa58aceffad61: [lldb][docs] Use any as the default role in LLDBs sphinx project (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [lldb] a58acef - [lldb][docs] Use 'any' as the default role in LLDB's sphinx project

Author: Raphael Isemann Date: 2021-01-18T19:08:19+01:00 New Revision: a58aceffad61ebffb1a860763299b3307041efa6 URL: https://github.com/llvm/llvm-project/commit/a58aceffad61ebffb1a860763299b3307041efa6 DIFF:

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay updated this revision to Diff 317382. MaskRay edited the summary of this revision. MaskRay added a comment. Don't use double-colon. https://lists.gnu.org/archive/html/help-make/2021-01/msg00016.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. UBSAN might have caught this if we had a test that took this path but I need to confirm that. If so I could add some more as a smoke test of sorts, or just call help on every command if that's not going to take an age. See

[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When a command option does not have a short version (e.g. -f for --file), we use an arbitrary value in the short_option field to mark it as

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

djtodoro added a comment. (@labath Sorry for late response, I've been away from keyboard for some time.) > Have you by any chance learned why are we zero-filling this buffer in the > first place? Seems like an odd thing to do... Maybe we should just stop > zero-filling completely? Hmm... not

[Lldb-commits] [lldb] 6e75ee6 - [lldb][docs] Use inline literals for code/paths instead of rendering it with the default role

Author: Raphael Isemann Date: 2021-01-18T11:10:19+01:00 New Revision: 6e75ee6b65c1c9924c0c9c10b1cbd57f10fe127b URL: https://github.com/llvm/llvm-project/commit/6e75ee6b65c1c9924c0c9c10b1cbd57f10fe127b DIFF:

[Lldb-commits] [lldb] f446fc5 - [lldb][docs] Resolve the remaining sphinx formatter warnings in the SB API docs

Author: Raphael Isemann Date: 2021-01-18T10:47:19+01:00 New Revision: f446fc5acf88fda676b5df1c04838f7244201d20 URL: https://github.com/llvm/llvm-project/commit/f446fc5acf88fda676b5df1c04838f7244201d20 DIFF: