[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

MaskRay updated this revision to Diff 318414. MaskRay marked an inline comment as done. MaskRay added a comment. Adopt rupprecht's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94888/new/ https://reviews.llvm.org/D94888 Files:

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

The ThreadPlanStack always has one base thread plan. You can't get rid of that one, the system relies on its always being there. Despite it's name, DiscardThreadPlans doesn't actually discard all the thread plans, just all but the base thread plan... So I think that's neither here nor

[Lldb-commits] [PATCH] D95185: lldb: repair the standalone build for Windows

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM but I'd like @teemperor to have a look too as he authored the original change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95185: lldb: repair the standalone build for Windows

compnerd created this revision. compnerd added a reviewer: JDevlieghere. compnerd added a project: LLDB. Herald added a subscriber: mgorny. compnerd requested review of this revision. Herald added a subscriber: lldb-commits. The previous code path only happened to work incidentally. The

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

I've tried to find a way to move the calls the way you mentioned, but it doesn't seem trivial. Some more information: - The invocation to the thread plan is done by Thread::ShouldStop, where it does ``` // We're starting from the base plan, so just let it decide; if

[Lldb-commits] [PATCH] D95164: Make SBDebugger::CreateTargetWithFileAndArch accept lldb.LLDB_DEFAULT_ARCH

jingham added a comment. In D95164#2513644 , @clayborg wrote: > I think the only difference is the triple is supposed to be a complete triple > and the arch can be just "arm64" and like you added, we let the currently > selected platform help fill it

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

> On Jan 21, 2021, at 2:33 PM, Jim Ingham wrote: > > > >> On Jan 21, 2021, at 12:51 PM, walter erquinigo via Phabricator >> wrote: >> >> wallace added a comment. >> >> Sorry for returning late to this diff, but I have some additional >> information. This is what's happening: >> >> -

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

> On Jan 21, 2021, at 12:51 PM, walter erquinigo via Phabricator > wrote: > > wallace added a comment. > > Sorry for returning late to this diff, but I have some additional > information. This is what's happening: > > - Before the exec, the base thread plan holds a reference to the thread

[Lldb-commits] [PATCH] D95164: Make SBDebugger::CreateTargetWithFileAndArch accept lldb.LLDB_DEFAULT_ARCH

clayborg added a comment. Herald added a subscriber: JDevlieghere. I think the only difference is the triple is supposed to be a complete triple and the arch can be just "arm64" and like you added, we let the currently selected platform help fill it out? I don't remember why this was added.

[Lldb-commits] [PATCH] D94937: [lldb/Lua] add initial Lua typemaps

tammela updated this revision to Diff 318300. tammela added a comment. Typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94937/new/ https://reviews.llvm.org/D94937 Files: lldb/bindings/lua/lua-typemaps.swig Index:

[Lldb-commits] [PATCH] D94033: [lldb-vscode] improve modules request

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39239f9b5666: [lldb-vscode] improve modules request (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 39239f9 - [lldb-vscode] improve modules request

Author: Walter Erquinigo Date: 2021-01-21T13:18:50-08:00 New Revision: 39239f9b5666bebb059fa562badeffb9f1c3afab URL: https://github.com/llvm/llvm-project/commit/39239f9b5666bebb059fa562badeffb9f1c3afab DIFF:

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela updated this revision to Diff 318298. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94937/new/ https://reviews.llvm.org/D94937 Files: lldb/bindings/lua/lua-typemaps.swig Index:

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

augusto2112 added a comment. Herald added a subscriber: JDevlieghere. This issue was found on the Swift REPL. However, I tested @teemperor's C REPL patch (https://reviews.llvm.org/D87281) and the same problem shows up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

augusto2112 created this revision. augusto2112 added reviewers: teemperor, aprantl, jingham, mib. Herald added a subscriber: krytarowski. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On some Linux distributions, after

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added a comment. Sorry for returning late to this diff, but I have some additional information. This is what's happening: - Before the exec, the base thread plan holds a reference to the thread pointer - During the exec, the original thread is destroyed in

[Lldb-commits] [PATCH] D95164: Make SBDebugger::CreateTargetWithFileAndArch accept lldb.LLDB_DEFAULT_ARCH

jingham created this revision. jingham added reviewers: clayborg, jasonmolenda, labath. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The header docs in SBDebugger.i suggest: target = debugger.CreateTargetWithFileAndArch (exe,

[Lldb-commits] [lldb] 37510f6 - [lldb][NFC] Fix build with GCC<6

Author: Raphael Isemann Date: 2021-01-21T15:04:41+01:00 New Revision: 37510f69b4cb8d76064f108d57bebe95984a23ae URL: https://github.com/llvm/llvm-project/commit/37510f69b4cb8d76064f108d57bebe95984a23ae DIFF:

[Lldb-commits] [lldb] ed2853d - Reland [lldb] Fix TestThreadStepOut.py after "Flush local value map on every instruction"

Author: Raphael Isemann Date: 2021-01-21T13:35:13+01:00 New Revision: ed2853d2c82d7286ba510c8f65049d6f649017f0 URL: https://github.com/llvm/llvm-project/commit/ed2853d2c82d7286ba510c8f65049d6f649017f0 DIFF:

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

teemperor added a comment. Not sure why we even run the DSYM variant if the test disables building DSYM. I just made this a no-debug-info-test in 060b51e0524aed6b6cc452baa8eb6d663a580eee which gets it running again on the

[Lldb-commits] [lldb] 060b51e - [lldb] Make TestBSDArchives a no-debug-info-test

Author: Raphael Isemann Date: 2021-01-21T13:06:48+01:00 New Revision: 060b51e0524aed6b6cc452baa8eb6d663a580eee URL: https://github.com/llvm/llvm-project/commit/060b51e0524aed6b6cc452baa8eb6d663a580eee DIFF:

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

teemperor added a comment. This is breaking the ` functionalities/archives/TestBSDArchives.py` test on macOS. It seems the MAKE_DSYM flag somehow looses its effect when the dsym version of the test is running (and then we fail generating a dsym without input files):

[Lldb-commits] [PATCH] D95096: [lldb][import-std-module] Do some basic file checks before trying to import a module

This revision was automatically updated to reflect the committed changes. Closed by commit rG99b7b41edf4f: [lldb][import-std-module] Do some basic file checks before trying to import a… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [lldb] 99b7b41 - [lldb][import-std-module] Do some basic file checks before trying to import a module

Author: Raphael Isemann Date: 2021-01-21T12:32:51+01:00 New Revision: 99b7b41edf4fbc2d6e52bc4524c956e8f69042d9 URL: https://github.com/llvm/llvm-project/commit/99b7b41edf4fbc2d6e52bc4524c956e8f69042d9 DIFF: