[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg added a comment. See my inlined comments, but it would be great to be able to just trace a few threads if any "tids" are specified in the "jLLDBTraceStart" packet, and all threads using a per thread buffer and call that "process". We would still use a per thread buffer for "process"

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Oops, didn't mean to accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D95119#2525925 , @MaskRay wrote: > `#!/usr/bin/env perl -w` (2 arguments) unfortunately does not work on Linux > and many other

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

MaskRay added a comment. `#!/usr/bin/env perl -w` (2 arguments) unfortunately does not work on Linux and many other systems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

MaskRay added a comment. Several `llvm/utils/` scripts can probably just be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 register contexts

mgorny added a comment. Herald added a subscriber: omjavaid. Is there a specific reason you've only covered x0..x7 in the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67954/new/ https://reviews.llvm.org/D67954

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. @JDevlieghere, would you care to review? This is another instance of moving away from system binaries to whatever the user / package manager wants the build to use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie created this revision. haampie added a reviewer: JDevlieghere. Herald added a reviewer: bollu. haampie requested review of this revision. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, Sanitizers,

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

This revision was automatically updated to reflect the committed changes. Closed by commit rG480643a95cd1: [CMake] Remove dead code setting policies to NEW (authored by tambre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre marked an inline comment as done. tambre added a comment. ldionne: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. Thanks! Eventually, I closed https://llvm.org/PR36209 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90789/new/ https://reviews.llvm.org/D90789 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG332e220ef42b: [docs] Update DebuggingJITedCode page after fix in LLDB (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] ab5591e - Fix runInTerminal failures on Windows

Author: Walter Erquinigo Date: 2021-01-27T13:17:23-08:00 New Revision: ab5591e1d8f5abcfa9e75193d3e8a29087b61425 URL: https://github.com/llvm/llvm-project/commit/ab5591e1d8f5abcfa9e75193d3e8a29087b61425 DIFF:

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace added a comment. @stella.stamenova , I've just pushed a fix. Let me know if it actually works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 ___

[Lldb-commits] [lldb] ab5591e - Fix runInTerminal failures on Windows

Author: Walter Erquinigo Date: 2021-01-27T13:17:23-08:00 New Revision: ab5591e1d8f5abcfa9e75193d3e8a29087b61425 URL: https://github.com/llvm/llvm-project/commit/ab5591e1d8f5abcfa9e75193d3e8a29087b61425 DIFF:

Re: [Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

Good to know. I'll work on that right now. Thanks! Il giorno mer 27 gen 2021 alle ore 11:41 Stella Stamenova via Phabricator < revi...@reviews.llvm.org> ha scritto: > stella.stamenova added inline comments. > > > > Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:9 > + > +#if

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

stella.stamenova added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:9 + +#if !defined(WIN32) +#include Also, this is no good. It works if you are targeting windows on windows, but not if you are targeting something else and building on

[Lldb-commits] [PATCH] D95297: [lldb] [Process/FreeBSDRemote] Introduce arm64 support

mgorny updated this revision to Diff 319562. mgorny added a comment. Remove unused copy-pasted class method declarations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95297/new/ https://reviews.llvm.org/D95297 Files: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

djtodoro added a comment. > Regarding the test, would it be possible to reuse one of the existing core > files? (The reason we have so few core tests is because we used to not allow > checked in core files at all -- now we kinda do, but it's still not ideal.) > I'm guessing you don't even need