ldionne accepted this revision as: libc++, libc++abi.
ldionne added a comment.
LGTM for libcxx and libcxxabi.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99484/new/
https://reviews.llvm.org/D99484
___
Ericson2314 updated this revision to Diff 335685.
Ericson2314 added a comment.
Fix error, remove more CMAKE_INSTALL_LIBDIR
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99484/new/
https://reviews.llvm.org/D99484
Files:
Ericson2314 added a comment.
I think with this last revision this diff might finally be ready!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99484/new/
https://reviews.llvm.org/D99484
___
lldb-commits
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG79ac5bbb96c4: [LLDB] Clarifying the documentation for
variable formatting wrt to qualifiers… (authored by shafik).
Herald added a project: LLDB.
Author: Shafik Yaghmour
Date: 2021-04-07T14:29:12-07:00
New Revision: 79ac5bbb96c46e3c6c3568a441c13aa10c087b25
URL:
https://github.com/llvm/llvm-project/commit/79ac5bbb96c46e3c6c3568a441c13aa10c087b25
DIFF:
shafik updated this revision to Diff 335929.
shafik added a comment.
Updating test to use frame var test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99827/new/
https://reviews.llvm.org/D99827
Files:
lldb/docs/use/variable.rst
xgupta added a comment.
Thanks @sushmaunnibhavi for the patch. Please update the revision as per the
comment of @JDevlieghere. I assume you don't have commit access to commit this
patch so please share your email address someone else with the commit access
will commit it on you behalf.
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM with a few nits.
Comment at: lldb/docs/use/tutorial.rst:31
with a "-" then you have to tell lldb that you're done with options for the
-current
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:455
+if (::strstr(response_cstr, "fork-events+"))
+ m_supports_fork_events = eLazyBoolYes;
Kamil noticed that this will also catch
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf49a4440d38a: [lldb][Editline] Fix crash when navigating
through empty command history. (authored by rupprecht).
Repository:
rG LLVM Github
Author: Jordan Rupprecht
Date: 2021-04-07T10:48:47-07:00
New Revision: f49a4440d38a4123b01ded6493a02b4cbf038928
URL:
https://github.com/llvm/llvm-project/commit/f49a4440d38a4123b01ded6493a02b4cbf038928
DIFF:
sushmaunnibhavi created this revision.
sushmaunnibhavi added reviewers: JDevlieghere, Shivamgupta1234.
sushmaunnibhavi requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Typo fix: lldb tutorial
Fixed typo 1, change "For instance" to
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100048/new/
https://reviews.llvm.org/D100048
rupprecht created this revision.
rupprecht added a reviewer: JDevlieghere.
rupprecht requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
An empty history entry can happen by entering the expression evaluator an
immediately hitting enter:
$
cmtice added a comment.
It has taken a bit of time to get through the GDB reviews, but the change to
GDB was accepted and committed:
https://sourceware.org/pipermail/gdb-cvs/2021-April/050267.html
May I commit this change to LLDB now?
CHANGES SINCE LAST ACTION
DavidSpickett added a comment.
@omjavaid Any more comments on this?
Comment at: lldb/include/lldb/Core/Architecture.h:110
+ virtual const MemoryTagManager *GetMemoryTagManager() const {
+return nullptr;
+ }
I also had the thought that we could just
DavidSpickett added a comment.
@labath Could you comment on the overall strategy that I'm going for?
I'll summarise my intention, the rest of the review stack here implements that
if you have time/want to dig into the details.
- Tag managers provide utilities to handle tags without knowing the
DavidSpickett added inline comments.
Comment at: lldb/source/Target/Process.cpp:6024
+llvm::Expected
+Process::GetMemoryTagManager(lldb::addr_t addr, lldb::addr_t end_addr) {
+ Architecture *arch = GetTarget().GetArchitecturePlugin();
While writing "memory tag
DavidSpickett added a comment.
@omjavaid Current status is that a partial read of memory tags is converted
into an error by lldb-server. I think this is justifiable given that the GDB
protocol as it stands doesn't describe how to really communicate a partial read
(though we could make a
mgorny updated this revision to Diff 335765.
mgorny added a comment.
Added breakpoint cleanup via gdb-remote protocol. Only minimal code coverage so
far. If this approach is okay, I guess I'll add subprocess guards to all server
commands.
CHANGES SINCE LAST ACTION
20 matches
Mail list logo
