[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

cmtice updated this revision to Diff 336276. cmtice added a comment. Herald added a reviewer: alexshap. Add a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

mgorny updated this revision to Diff 336263. mgorny added a comment. Add to `_KNOWN_QSUPPORTED_STUB_FEATURES` and clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100153/new/ https://reviews.llvm.org/D100153 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

mgorny added a comment. Note that I've included full `fork-events+` and `vfork-events+` as demo of the API. I can split them further and/or move to more relevant commits as I progress with the split. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100153/new/

[Lldb-commits] [PATCH] D99864: [lldb] Fork/vfork support via gdb-remote protocol [WIP]

mgorny added a comment. And now moved Extension API to D100153 . I've added an API to query features supported by platform plugin, so now server doesn't report them unless they're actually going to be used. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Introduce a NativeProcessProtocol API for indicating support for protocol extensions and enabling them. LLGS calls GetSupportedExtensions() method on the process factory

[Lldb-commits] [PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

gandhi21299 added a comment. @arsenm Yea, I am sorry about that. Looks like I am still not using arc properly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99812/new/ https://reviews.llvm.org/D99812 ___

[Lldb-commits] [PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

arsenm added a comment. Attached wrong diff? There are a lot of unrelated files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99812/new/ https://reviews.llvm.org/D99812 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny added a comment. In D98822#2677961 , @JDevlieghere wrote: > `test/Shell/Subprocess/vfork-follow-parent-wp.test` is failing on GreenDragon: > >

[Lldb-commits] [PATCH] D99864: [lldb] Fork/vfork support via gdb-remote protocol [WIP]

mgorny marked an inline comment as done. mgorny added a comment. Client-side qSupported processing is now refactored in D100146 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99864/new/ https://reviews.llvm.org/D99864

[Lldb-commits] [PATCH] D100146: [lldb] [gdb-remote client] Refactor handling qSupported

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Refactor the qSupported handler to split the reply into an array, and identify features within the array rather than searching the string for partial matches. While at it,

[Lldb-commits] [lldb] e761b6b - [lldb] (Temporarily) disable vfork-follow-parent-wp.test on Darwin

Author: Jonas Devlieghere Date: 2021-04-08T15:05:27-07:00 New Revision: e761b6b4c58d4f7ae1073d925d7cb321d68ee93a URL: https://github.com/llvm/llvm-project/commit/e761b6b4c58d4f7ae1073d925d7cb321d68ee93a DIFF:

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

JDevlieghere added a comment. `test/Shell/Subprocess/vfork-follow-parent-wp.test` is failing on GreenDragon: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31016/testReport/junit/lldb-shell/Subprocess/vfork_follow_parent_wp_test/ I'm going to temporarily disable the test on Darwin.

[Lldb-commits] [PATCH] D99864: [lldb] Fork/vfork support via gdb-remote protocol [WIP]

mgorny marked 2 inline comments as done. mgorny added a comment. The server-side `qSupported` handling is now split into D100140 , and all relevant remarks were addressed there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99864/new/

[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

mgorny added a comment. This is split from D99864 as a minimal independent change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100140/new/ https://reviews.llvm.org/D100140 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Refactor handling qSupported to use a virtual HandleFeatures() method. The client-provided features are split into an array and passed to the method. The method returns an

[Lldb-commits] [PATCH] D99828: Create setting to disable LanguageRuntime provided UnwindPlans

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd453a1389b6: Add setting to disable LanguageRuntime UnwindPlans (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] dd453a1 - Add setting to disable LanguageRuntime UnwindPlans

Author: Jason Molenda Date: 2021-04-08T13:28:59-07:00 New Revision: dd453a1389b6a7e6d9214b449d3c54981b1a89b6 URL: https://github.com/llvm/llvm-project/commit/dd453a1389b6a7e6d9214b449d3c54981b1a89b6 DIFF: https://github.com/llvm/llvm-project/commit/dd453a1389b6a7e6d9214b449d3c54981b1a89b6.diff

[Lldb-commits] [lldb] d01bff8 - [lldb] [test] Skip clone() tests on Linux/aarch64

Author: Michał Górny Date: 2021-04-08T20:03:45+02:00 New Revision: d01bff8cbdc98fb8751f7bf10af19b47ae5c445d URL: https://github.com/llvm/llvm-project/commit/d01bff8cbdc98fb8751f7bf10af19b47ae5c445d DIFF: https://github.com/llvm/llvm-project/commit/d01bff8cbdc98fb8751f7bf10af19b47ae5c445d.diff

[Lldb-commits] [PATCH] D100053: Fixed bug issue #42017

This revision was automatically updated to reflect the committed changes. Closed by commit rGb68545acf977: [lldb] Improve the documentation (#42017) (authored by sushmaunnibhavi, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b68545a - [lldb] Improve the documentation (#42017)

Author: Sushma Unnibhavi Date: 2021-04-08T10:58:02-07:00 New Revision: b68545acf9771b6b205647b8028d9e042ede8838 URL: https://github.com/llvm/llvm-project/commit/b68545acf9771b6b205647b8028d9e042ede8838 DIFF:

[Lldb-commits] [PATCH] D99864: [lldb] Fork/vfork support via gdb-remote protocol [WIP]

mgorny added a comment. In D99864#2676389 , @labath wrote: > I'm going to have more questions, but let me start with this: What should the > (v)fork-events extension actually mean? In the client, I guess it > demonstrates its willingness to receive the

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa345419ee030: [lldb] [Process] Watch for fork/vfork notifications (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [lldb] a345419 - [lldb] [Process] Watch for fork/vfork notifications

Author: Michał Górny Date: 2021-04-08T18:49:50+02:00 New Revision: a345419ee03095c8cdfbe1c2728467c4da8fa0a4 URL: https://github.com/llvm/llvm-project/commit/a345419ee03095c8cdfbe1c2728467c4da8fa0a4 DIFF: https://github.com/llvm/llvm-project/commit/a345419ee03095c8cdfbe1c2728467c4da8fa0a4.diff

[Lldb-commits] [PATCH] D100053: Fixed bug issue #42017

sushmaunnibhavi updated this revision to Diff 336124. sushmaunnibhavi edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100053/new/ https://reviews.llvm.org/D100053 Files: lldb/docs/use/tutorial.rst Index: lldb/docs/use/tutorial.rst

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny updated this revision to Diff 336107. mgorny added a comment. Implemented @labath's requests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 Files: lldb/include/lldb/Host/linux/Host.h lldb/source/Host/linux/Host.cpp

[Lldb-commits] [lldb] 2ecf928 - [lldb/DWARF] Fix a crash parsing invalid dwarf (pr49678)

Author: Pavel Labath Date: 2021-04-08T16:48:02+02:00 New Revision: 2ecf928153fc56dcb6bb0bd910584eac86bc23bd URL: https://github.com/llvm/llvm-project/commit/2ecf928153fc56dcb6bb0bd910584eac86bc23bd DIFF: https://github.com/llvm/llvm-project/commit/2ecf928153fc56dcb6bb0bd910584eac86bc23bd.diff

[Lldb-commits] [lldb] 1e511bb - [lldb] Re-skip TestVSCode_launch

Author: Pavel Labath Date: 2021-04-08T16:31:18+02:00 New Revision: 1e511bb1be718657a5584ccb792723d9ddac481f URL: https://github.com/llvm/llvm-project/commit/1e511bb1be718657a5584ccb792723d9ddac481f DIFF: https://github.com/llvm/llvm-project/commit/1e511bb1be718657a5584ccb792723d9ddac481f.diff

[Lldb-commits] [PATCH] D99497: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

labath added a comment. Herald added a subscriber: JDevlieghere. The test is still flaky (http://lab.llvm.org:8011/#/builders/68/builds/10124, http://lab.llvm.org:8011/#/builders/68/builds/10118, http://lab.llvm.org:8011/#/builders/68/builds/10113, ...) In fact, I think it has gotten flakier

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

labath added a comment. Setting the address size from the register context is a bit awkward. We have one register context per thread, and they all will be competing to set the value (it should always be the same value under normal circumstances, but it still makes for a strange relationship).

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny marked 10 inline comments as done. mgorny added a comment. Ok, I think I've implemented all the requested changes. I'm going to test it on all three platforms now and attach the patch if it miraculously still works ;-). Comment at:

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp:981-987 + switch (event) { + case PL_FLAG_FORKED: + case PL_FLAG_FORKED | PL_FLAG_VFORKED: +break; + default: +assert(false && "unknown clone_info.event"); + }

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

labath added a comment. Seems reasonable to me. I'm happy if @DavidSpickett is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99941/new/ https://reviews.llvm.org/D99941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D99864: [lldb] Fork/vfork support via gdb-remote protocol [WIP]

labath added a comment. This is going to be pretty big, so I'd say we start splitting this up. The client & server bits can go into separate patches, and it would make things simpler if the qSupported emission and parsing also got its own patches, as that is going to be a lot less

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb601c6719226: [lldb] [client] Support for multiprocess extension (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [lldb] b601c67 - [lldb] [client] Support for multiprocess extension

Author: Michał Górny Date: 2021-04-08T13:45:07+02:00 New Revision: b601c6719226fb83c43dae62a581e5ee08bfb169 URL: https://github.com/llvm/llvm-project/commit/b601c6719226fb83c43dae62a581e5ee08bfb169 DIFF: https://github.com/llvm/llvm-project/commit/b601c6719226fb83c43dae62a581e5ee08bfb169.diff

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

labath added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp:723 // Process all pending waitpid notifications. - int status; - ::pid_t wait_pid = - llvm::sys::RetryAfterSignal(-1, waitpid, GetID(), , WNOHANG); + while (true) {

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny marked 3 inline comments as done. mgorny added a comment. Answered where answer was due, will update the rest once I finish retesting the multiprocess patch. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp:723 // Process all pending waitpid

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yea, I think it should be fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603 ___ lldb-commits

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

labath added a comment. In D98822#2666257 , @mgorny wrote: > @labath, I think I've made all the requested changes. This looks pretty good now. Just some small nits inline... Comment at: lldb/include/lldb/Host/linux/Host.h:13 +#include

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny added a comment. @labath, any further comments or is this good to go then? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny updated this revision to Diff 336052. mgorny added a comment. Removed the hanging test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

labath added a comment. Yeah, that's tricky. For a inconsistent/unsupported response like this, probably the only reasonable thing we can do print some error message, terminate the connection and put the inferior into some terminal state. However, I don't think we have anything like that (and

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

labath added a comment. If gdb does it, then I don't have any issues with this functionality. It could use a test case though. You can try rewriting that gdb test case for lldb -- we don't have fancy dwarf assemblers (cool stuff, btw), we just use asm (you could look at

[Lldb-commits] [lldb] d9773c1 - Reorg firmware corefile tests; add test for OS plugin loading

Author: Jason Molenda Date: 2021-04-08T01:45:25-07:00 New Revision: d9773c1b4eb14c5f38d23323270ef67b4c528844 URL: https://github.com/llvm/llvm-project/commit/d9773c1b4eb14c5f38d23323270ef67b4c528844 DIFF: https://github.com/llvm/llvm-project/commit/d9773c1b4eb14c5f38d23323270ef67b4c528844.diff