[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

JDevlieghere added a comment. A few more comments about things I missed in the previous review. Comment at: lldb/source/Core/SourceLocationSpec.cpp:57 + +void SourceLocationSpec::Dump(llvm::raw_ostream ) const { + StreamString ss; Should this take a

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341774. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Core/SourceLocationSpec.h lldb/source/Core/CMakeLists.txt

[Lldb-commits] [PATCH] D101596: [debugserver] Use add_lldb_library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb535459d0a1d: [debugserver] Use add_lldb_library instead of add_library (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [lldb] b535459 - [debugserver] Use add_lldb_library instead of add_library

Author: Jonas Devlieghere Date: 2021-04-29T22:09:10-07:00 New Revision: b535459d0a1db37fca6688b8e15305e361debff5 URL: https://github.com/llvm/llvm-project/commit/b535459d0a1db37fca6688b8e15305e361debff5 DIFF:

[Lldb-commits] [PATCH] D101596: [debugserver] Use add_lldb_library

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101596/new/ https://reviews.llvm.org/D101596 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D101596: [debugserver] Use add_lldb_library

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Use `add_lldb_library` to ensure debugserver inherits all the defines set by llvm. https://reviews.llvm.org/D101596 Files:

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

mib updated this revision to Diff 341766. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100965/new/ https://reviews.llvm.org/D100965 Files: lldb/include/lldb/Breakpoint/BreakpointResolverFileLine.h

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/ProgressEvent.cpp:89 + m_start_event_timestamp >= + std::chrono::seconds(3); +} clayborg wrote: > The patch description says 5 seconds, here

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341763. mib marked 3 inline comments as done. mib added a comment. Address @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files:

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

mib updated this revision to Diff 341758. mib marked 2 inline comments as done. mib added a comment. Addressed @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101556/new/ https://reviews.llvm.org/D101556 Files:

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/include/lldb/Core/Declaration.h:161 + /// \b false otherwise. + bool operator!() const { return !operator bool(); } +

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

mib added a comment. The points that @teemperor brought up have been implemented in D101556 and D100962 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100965/new/

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

JDevlieghere added inline comments. Comment at: lldb/source/Core/SourceLocationSpec.cpp:48-61 + if (int result = FileSpec::Compare(a.GetFileSpec(), b.GetFileSpec(), full)) +return result; + + // If both file_spec matches, compare line numbers. + if (a.GetLine() !=

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

mib updated this revision to Diff 341755. mib added a comment. As discussed with @JDevlieghere offline, the current state of the `SearchFilter` and `Searcher` (from which many class inherit) are not designed for error handling so I removed the `SourceLocationSpec::Create` factory method and

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/unittests/Utility/CMakeLists.txt:41 TimerTest.cpp + UUIDTest.cpp UriParserTest.cpp Let's exclude the change to this

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341752. mib added a comment. Wrap `SourceLocationSpec` column argument into an `llvm::Optional` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files:

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341738. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Core/SourceLocationSpec.h lldb/source/Core/CMakeLists.txt

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341736. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Core/SourceLocationSpec.h lldb/source/Core/CMakeLists.txt

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341734. mib edited the summary of this revision. mib added a comment. Group the FileSpec, the Line and Column number into a `Declaration`. Remove factory function to use constructor and added an `IsValid` method (and boolean operator) Repository: rG LLVM

[Lldb-commits] [lldb] 1141ba6 - [lldb-vscode] Follow up of D99989 - store some strings more safely

Author: Walter Erquinigo Date: 2021-04-29T18:37:44-07:00 New Revision: 1141ba677e09156daec8ef31d3dcdae7f59f60c5 URL: https://github.com/llvm/llvm-project/commit/1141ba677e09156daec8ef31d3dcdae7f59f60c5 DIFF:

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

mib updated this revision to Diff 341727. mib added a comment. Addressed @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101556/new/ https://reviews.llvm.org/D101556 Files: lldb/include/lldb/Core/Declaration.h

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

mib added a comment. In D101556#2726434 , @teemperor wrote: > IIRC they were #ifdef's out because of memory concerns. Did you have a chance > to benchmark this quickly (e.g., trying to attach to a debug Clang and see > how much it increases memory) > >

[Lldb-commits] [PATCH] D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null

kastiglione added inline comments. Comment at: lldb/source/API/SBStructuredData.cpp:43 SBStructuredData::SBStructuredData(lldb_private::StructuredDataImpl *impl) -: m_impl_up(impl) { +: m_impl_up(impl ? impl : new StructuredDataImpl()) {

[Lldb-commits] [PATCH] D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null

kastiglione added a comment. I changed direction, to ensure the impl pointer is always non-null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101585/new/ https://reviews.llvm.org/D101585 ___

[Lldb-commits] [PATCH] D101585: [lldb] Handle missing SBStructuredData copy assignment cases

kastiglione updated this revision to Diff 341721. kastiglione added a comment. Ensure m_impl_up is always non-null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101585/new/ https://reviews.llvm.org/D101585 Files:

[Lldb-commits] [PATCH] D101585: [lldb] Handle missing SBStructuredData copy assignment cases

kastiglione added a comment. I should expand this to fix other unchecked dereferences. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101585/new/ https://reviews.llvm.org/D101585 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D101585: [lldb] Handle missing SBStructuredData copy assignment cases

shafik added a comment. Herald added a subscriber: JDevlieghere. LGTM, it seems like there a few places where we are not consistently checking `m_impl_up` is valid and other places we are using the conditional operator to check if it is set or not. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D101585: [lldb] Handle missing SBStructuredData copy assignment cases

kastiglione created this revision. kastiglione added a reviewer: augusto2112. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix cases that can crash `SBStructuredData::operator=`. This happened in a case where `rhs` had a

[Lldb-commits] [PATCH] D101250: Wrap edit line configuration calls into helper functions

JDevlieghere added a comment. In D101250#2726592 , @nealsid wrote: > Friendly ping - let me know if I misunderstood the comments or if anything > else is needed! Thanks again. Thanks for the explanation, I don't have a strong opinion on the matter and

[Lldb-commits] [PATCH] D101563: [lldb] [test] Extend aarch64-gp-read test to cover all registers

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, mstorsjo. Herald added subscribers: danielkiss, kristof.beyls. mgorny requested review of this revision. Extend the general-purpose/vector register test for AArch64 to test all regular registers rather than just

[Lldb-commits] [PATCH] D101250: Wrap edit line configuration calls into helper functions

nealsid added a comment. Friendly ping - let me know if I misunderstood the comments or if anything else is needed! Thanks again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101250/new/ https://reviews.llvm.org/D101250

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/Declaration.h:129 + + bool IsValid() const { +return m_file && (m_line != 0 || m_line != LLDB_INVALID_LINE_NUMBER); Let's also add an operator bool that just calls `IsValid()` under the

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

teemperor added a comment. IIRC they were #ifdef's out because of memory concerns. Did you have a chance to benchmark this quickly (e.g., trying to attach to a debug Clang and see how much it increases memory) Otherwise this LGTM. FWIW, we also need this for the SourceLocation in Clang Decls

[Lldb-commits] [PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

MaskRay added a comment. The `InitMCObjectFileInfo` refactoring is good, but I'll suggest `initMCObjectFileInfo(MCContext , bool PIC, bool LargeCodeModel)` (change the function name to `lowerCase`, and reorder MCContext before bool arguments). The refactoring adding `Triple` to

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

mib created this revision. mib added reviewers: teemperor, JDevlieghere. mib added a project: LLDB. Herald added a subscriber: mgorny. Herald added a reviewer: shafik. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch moves the `Declaration` class from the

[Lldb-commits] [PATCH] D101537: [lldb] Make the NSSet formatter faster and less prone to infinite recursion

jingham added a comment. GetPointerValue strips sign bits, so formally it should be used whenever you are getting a pointer that might be signed. OTOH, GetPointerValue is pretty new and since plain data pointers aren't going to be signed, there was no reason to go convert all the uses. We

[Lldb-commits] [PATCH] D101537: [lldb] Make the NSSet formatter faster and less prone to infinite recursion

aprantl added a comment. Functionally this LGTM. Would be curious to do git archeology to understand why the old code used this pattern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101537/new/ https://reviews.llvm.org/D101537

[Lldb-commits] [lldb] a76df78 - [lldb] Make the NSSet formatter faster and less prone to infinite recursion

Author: Raphael Isemann Date: 2021-04-29T19:13:43+02:00 New Revision: a76df78470d7994f73df0353225cbddc463cce63 URL: https://github.com/llvm/llvm-project/commit/a76df78470d7994f73df0353225cbddc463cce63 DIFF:

[Lldb-commits] [PATCH] D101537: [lldb] Make the NSSet formatter faster and less prone to infinite recursion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa76df78470d7: [lldb] Make the NSSet formatter faster and less prone to infinite recursion (authored by teemperor). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 marked 2 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Target/Target.cpp:1818 - if (!is_readonly && resolved_addr.IsSectionOffset()) { + if (file_cache_read_buffer.get() && file_cache_bytes_read > 0) { +// Reading from

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 updated this revision to Diff 341550. augusto2112 marked an inline comment as done. augusto2112 added a comment. Rely on `unique_ptr`'s bool operator, instead of checking the underlying pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

JDevlieghere added inline comments. Comment at: lldb/source/Target/Target.cpp:1818 - if (!is_readonly && resolved_addr.IsSectionOffset()) { + if (file_cache_read_buffer.get() && file_cache_bytes_read > 0) { +// Reading from the process failed. If we've previously

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

shafik accepted this revision as: shafik. shafik added a comment. This revision is now accepted and ready to land. I don't have any other feedback, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101153/new/ https://reviews.llvm.org/D101153

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

shafik added inline comments. Comment at: lldb/source/Target/Target.cpp:1778 +else if (file_cache_bytes_read > 0) { + file_cache_read_buffer.reset(malloc(file_cache_bytes_read)); + std::memcpy(file_cache_read_buffer.get(), dst, file_cache_bytes_read);

[Lldb-commits] [PATCH] D101453: [lldb] Add tests for DumpDataExtractor formats

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. FWIW, we do have a test for this named TestBuiltinFormats.py. It's using the SB API so it's not as a direct test as this one, so I think having this too is good. I think this looks

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 marked 2 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Target/Target.cpp:1778 +else if (file_cache_bytes_read > 0) { + file_cache_read_buffer.reset(malloc(file_cache_bytes_read)); +

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 updated this revision to Diff 341532. augusto2112 added a comment. Change buffer unique pointer from void to uint8_t, eliminating the need to call malloc/free. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101390/new/

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: polly/cmake/CMakeLists.txt:104-110 +set(tgt_prefix "${CMAKE_INSTALL_FULL_BINDIR}/") else() -set(tgt_prefix "lib/") +set(tgt_prefix "${CMAKE_INSTALL_FULL_LIBDIR}/") endif() - set(tgt_path

[Lldb-commits] [PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. Thanks for the review! I already thought that I will have to split this up, so I made the commits self contained so I'll do that. One question before I start: Where should I split this? Should I only split out the RISC-V patch and leave the changes that targets can

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques updated this revision to Diff 341471. luismarques added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 Files: lldb/include/lldb/Utility/ArchSpec.h

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added a comment. In D99484#2724435 , @Ericson2314 wrote: > I effectively replaced `${CMAKE_INSTALL_PREFIX}/lib` with > `${CMAKE_INSTALL_LIBDIR}`, which evaluates (by default) merely to `lib`. The > fix was `${CMAKE_INSTALL_FULL_LIBDIR}` which

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang-tools-extra/clang-doc/tool/CMakeLists.txt:26 install(FILES ../assets/index.js - DESTINATION share/clang + DESTINATION "${CMAKE_INSTALL_DATADIR}/clang" COMPONENT clang-doc) Ericson2314 wrote: > compnerd

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. In D99484#2724343 , @Meinersbur wrote: > In D99484#2724055 , @Ericson2314 > wrote: > >> Fix bug makeing polly path full, and rebase fixing conflicts > > What was the problem? I

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

aprantl added inline comments. Comment at: lldb/include/lldb/Utility/ArchSpec.h:101 + // RISCV specific flags + enum RISCVflags { In modern LLDB style we would format this as: ``` /// RISCV specific flags. enum class RISCVflags { arch_c = 0x0001,

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added a comment. In D99484#2724055 , @Ericson2314 wrote: > Fix bug makeing polly path full, and rebase fixing conflicts What was the problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

JDevlieghere added a comment. In D62732#2724078 , @luismarques wrote: > In D62732#2724040 , @JDevlieghere > wrote: > >> Any update on the testing strategy yet? It seems like that this is actively >> being used

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341338. Ericson2314 added a comment. Rebase, no changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341339. Ericson2314 added a comment. Resubmit now prior diff is rebased, so CI doesn't trip up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2724040 , @JDevlieghere wrote: > Any update on the testing strategy yet? It seems like that this is actively > being used and worked on, so I'm generally supportive of landing this with > some elementary coverage.

[Lldb-commits] [PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

MaskRay added a comment. The refactoring part seems useful on its own. The controversial 4-byte alignment part should be split. Doesn't GNU as use 4 for most architectures as well? Why do you want to change it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

jrtc27 added a comment. Herald added a subscriber: JDevlieghere. What's the benefit of less-aligned functions? Is that not more likely to get poor performance due to cache line straddling of the first instruction? Regardless, the functional change should be separated out from the refactoring.

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341213. Ericson2314 added a comment. Fix stray ':' typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

JDevlieghere added a comment. Any update on the testing strategy yet? It seems like that this is actively being used and worked on, so I'm generally supportive of landing this with some elementary coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341326. Ericson2314 added a comment. Fix bug makeing polly path full, and rebase fixing conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341211. Ericson2314 added a comment. Fix stray ':' typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt

[Lldb-commits] [PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

flip1995 created this revision. flip1995 added reviewers: MaskRay, rnk, asb. Herald added subscribers: frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, rupprecht, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27,

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques updated this revision to Diff 341153. luismarques added a comment. Rebase and fix the unwinding issue reported by @jade. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 Files:

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341071. Ericson2314 added a comment. Herald added subscribers: openmp-commits, lldb-commits, cfe-commits, jvesely. Herald added projects: clang, LLDB, OpenMP. Quote variable usages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341072. Ericson2314 added a comment. Quote variable usages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jade added a comment. In D62732#2707945 , @jade wrote: > In D62732#2306055 , @labath wrote: > >> ABI plugins are one of the hardest things to test in lldb, particularly >> without actual hardware. That's why we've

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This is a pretty straightforward cleanup now, which adds additional functionality by deferring work to CMake. There are a couple of minor points about inconsistent quoting but this seems

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang-tools-extra/clang-doc/tool/CMakeLists.txt:26 install(FILES ../assets/index.js - DESTINATION share/clang + DESTINATION "${CMAKE_INSTALL_DATADIR}/clang" COMPONENT clang-doc) compnerd wrote: > Why are these

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2707945 , @jade wrote: > These files are also available as a gist, which can be grabbed with: `git > clone https://gist.github.com/e2efac2f780ed820277dbaf608805f4e > lldb-riscv-repro` Thank you for the reproducer.

[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jasonmolenda, jingham. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A type system is not guaranteed to have a symbol file. This patch adds

[Lldb-commits] [PATCH] D101521: [lldb] [Process/FreeBSD] Fix arm64 build after RegisterInfoPOSIX_arm64 changes

mgorny created this revision. mgorny added reviewers: omjavaid, krytarowski, emaste, labath. Herald added subscribers: kristof.beyls, arichardson. mgorny requested review of this revision. Commit 88a5b35d63f927db69ec953ff487a7ba2504a610

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

mgorny added a comment. Herald added a subscriber: JDevlieghere. This changed the API of `RegisterInfoPOSIX_arm64` and broke the FreeBSD plugin. I'm going to try to fix it but next time it'd be nice if you checked that the class isn't used by something before making changes to its API.

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 341450. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 341449. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 341448. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 341447. DavidSpickett added a comment. `asm/hwcap.h` is not available on x86 (riscv/arm/aarch64 have it at least) so #ifdef the includes and auxval call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 341446. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h

[Lldb-commits] [PATCH] D101157: [lldb] [test] Add tests for coredumps with multiple threads

mgorny added a comment. @labath, could you give me at least a rough idea how you feel about this one? I'd like to know if I need to change the test code before I start adding coredumps for more architectures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101157/new/

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py:42 if self.process().GetState() == lldb.eStateExited: self.fail("Test program failed to run.") omjavaid

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf31e390453d2: [lldb][AArch64] Dont check for VmFlags in smaps files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] f31e390 - [lldb][AArch64] Don't check for VmFlags in smaps files

Author: David Spickett Date: 2021-04-29T09:30:14+01:00 New Revision: f31e390453d255bc6a486bbd5cb990e684b29510 URL: https://github.com/llvm/llvm-project/commit/f31e390453d255bc6a486bbd5cb990e684b29510 DIFF: