[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

JDevlieghere added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:102 +std::string *not_a_string = (std::string *) 0x0; +touch_string(*not_a_string); return 0; shafik wrote: >

[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

shafik added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:102 +std::string *not_a_string = (std::string *) 0x0; +touch_string(*not_a_string); return 0; This is undefined

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So I am trying this out. I tried the target creation form and I am not able to use arrow keys when entering the path to the main executable. Are you able to do this? It seems

[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM module formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108228/new/ https://reviews.llvm.org/D108228

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

JDevlieghere added inline comments. Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:148 + +std::string proc_fd_path = "/proc/self/fd"; +std::error_code EC; MaskRay wrote: > Can this be a StringRef? Comment at:

[Lldb-commits] [lldb] c64d185 - [lldb] Include arm64 in affected_by_radar_34562999

Author: Jonas Devlieghere Date: 2021-08-17T19:45:45-07:00 New Revision: c64d1855b9a912cd6e3d0227ecd939c93c68fd9e URL: https://github.com/llvm/llvm-project/commit/c64d1855b9a912cd6e3d0227ecd939c93c68fd9e DIFF:

[Lldb-commits] [lldb] a452ca4 - [lldb] Extend isAArch64 to arm64 and arm64e

Author: Jonas Devlieghere Date: 2021-08-17T19:45:45-07:00 New Revision: a452ca471c0e3d0bcd26d16a45b6bc43efee URL: https://github.com/llvm/llvm-project/commit/a452ca471c0e3d0bcd26d16a45b6bc43efee DIFF:

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

MaskRay added inline comments. Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:148 + +std::string proc_fd_path = "/proc/self/fd"; +std::error_code EC; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

MaskRay accepted this revision. MaskRay added a comment. LGTM. Some nits Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:161 +// stdin/stdout/stderr +if ((fd > 2) && !info.GetFileActionForFD(fd) && fd != error_fd) +

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb26e1efc424a: [LLDB][GUI] Add Breakpoints window (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] b26e1ef - [LLDB][GUI] Add Breakpoints window

Author: Omar Emara Date: 2021-08-17T17:38:16-07:00 New Revision: b26e1efc424ad840143f02a96246cc666ee99e72 URL: https://github.com/llvm/llvm-project/commit/b26e1efc424ad840143f02a96246cc666ee99e72 DIFF: https://github.com/llvm/llvm-project/commit/b26e1efc424ad840143f02a96246cc666ee99e72.diff

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

clayborg added a comment. In D108061#2950858 , @rdhindsa wrote: > Updated the test to check for the respective function name from the shared > library in the frames. > I didn't add run_to_source_breakpoint since we can't set a breakpoint on main >

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

clayborg added a comment. Herald added a subscriber: JDevlieghere. LGTM. Anyone else have any issues? Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:148 +std::string proc_fd_path = "/proc/self/fd"; +std::filesystem::path fp(proc_fd_path);

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa updated this revision to Diff 367067. rdhindsa added a comment. Herald added a project: LLDB. Updated it to use llvm's filesystem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 Files:

[Lldb-commits] [PATCH] D108257: Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. If getType() doesn't trigger type completion then this LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108257/new/ https://reviews.llvm.org/D108257

[Lldb-commits] [PATCH] D108257: Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

shafik created this revision. shafik added reviewers: teemperor, aprantl. shafik requested review of this revision. I was debugging a problem and noticed that it would have been helpful to have the type of each `FieldDecl` when looking at the output from `ClangASTSource::layoutRecordType`

[Lldb-commits] [PATCH] D107761: [LLDB][GUI] Refactor form drawing using subsurfaces

clayborg added a comment. In D107761#2947639 , @OmarEmaraDev wrote: > @clayborg Perhaps you missed this, it is essential the same as D107182 > but without the unsupported function. It > would be good to have this

[Lldb-commits] [PATCH] D107761: [LLDB][GUI] Refactor form drawing using subsurfaces

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79e950a29e00: [LLDB][GUI] Refactor form drawing using subsurfaces

[Lldb-commits] [lldb] 79e950a - [LLDB][GUI] Refactor form drawing using subsurfaces

Author: Omar Emara Date: 2021-08-17T16:54:41-07:00 New Revision: 79e950a29e004f2f0ac590f6090b61b3043503e2 URL: https://github.com/llvm/llvm-project/commit/79e950a29e004f2f0ac590f6090b61b3043503e2 DIFF: https://github.com/llvm/llvm-project/commit/79e950a29e004f2f0ac590f6090b61b3043503e2.diff

[Lldb-commits] [lldb] 0479afb - [LLDB] Fix off by one logging placeholders in ClangASTSource::layoutRecordType()

Author: Shafik Yaghmour Date: 2021-08-17T16:47:46-07:00 New Revision: 0479afb3d6a31668631464653f07154d6850e4a1 URL: https://github.com/llvm/llvm-project/commit/0479afb3d6a31668631464653f07154d6850e4a1 DIFF:

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

MaskRay added inline comments. Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:148 +std::string proc_fd_path = "/proc/self/fd"; +std::filesystem::path fp(proc_fd_path); /proc/self/fd is generally unavailable on non-Linux OSes. CHANGES

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

MaskRay added a comment. Drive-by: std::filesystem is unavailable for GCC<8. The minimum GCC version is 5, so std::filesystem isn't suitable. You may use`include/llvm/Support/FileSystem.h` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa marked an inline comment as done. rdhindsa added a comment. Updated the test to check for the respective function name from the shared library in the frames. I didn't add run_to_source_breakpoint since we can't set a breakpoint on main initially before running the program. Hence it

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 367047. rdhindsa marked an inline comment as done. rdhindsa added a comment. Updated the test to check for the respective function name from the shared library in the frames. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I like the idea of this! I have a minidump creation tool I wrote in python for making tests. ELF files support core files in their native file format, so I think the

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

aprantl added a comment. > This can't have been the intention of this commit? As far as I can see, there > *is* no plugin for plain assembler? This commit changes the warning from > This version of LLDB has no plugin for the mipsassem language. to > This version of LLDB has no plugin for the

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe21a21a977b4: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base… (authored by jankratochvil). Repository: rG LLVM

[Lldb-commits] [lldb] e21a21a - [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

Author: Jan Kratochvil Date: 2021-08-17T22:19:16+02:00 New Revision: e21a21a977b492cc7172779d080db146e3c39e06 URL: https://github.com/llvm/llvm-project/commit/e21a21a977b492cc7172779d080db146e3c39e06 DIFF:

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D106466#2950268 , @jankratochvil wrote: > In D106466#2947710 , @dblaikie > wrote: > >> I assume

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. In D106466#2947710 , @dblaikie wrote: > I assume there's already test coverage for rnglistx in debug_info.dwo/split > unit? (because in that case there's no rnglists_base, but rnglistx is usable) I admit I did not check

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK created this revision. Aj0SK added a reviewer: clayborg. Herald added subscribers: pengfei, mgorny, emaste. Aj0SK requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. This change adds save-core functionality into the ObjectFileELF

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

bulbazord created this revision. bulbazord added reviewers: clayborg, jingham, teemperor. Herald added a subscriber: mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. Module::LookupInfo's constructor currently goes over supported languages trying to figure out the

[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

jingham created this revision. jingham added a reviewer: JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The formatter tries to get the data field of the std::string, and to check whether that fails it just checks

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

tammela added a comment. I think we are getting there, just some more details Comment at: lldb/docs/use/scripting-example.rst:822 +The complete code for the Dictionary program (with case-conversion bug), the +DFS function and other Python script examples (tree_utils.py) used

[Lldb-commits] [PATCH] D108145: [lldb] Make TestAArch64AdrpAdd depend on the AArch64 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc5495c351a1: [lldb] Make TestAArch64AdrpAdd depend on the AArch64 target (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [lldb] fc5495c - [lldb] Make TestAArch64AdrpAdd depend on the AArch64 target

Author: Raphael Isemann Date: 2021-08-17T13:47:22+02:00 New Revision: fc5495c351a1f7ce28c7166a70113ce45906ff7b URL: https://github.com/llvm/llvm-project/commit/fc5495c351a1f7ce28c7166a70113ce45906ff7b DIFF:

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

dim added a comment. In D101406#2948152 , @clayborg wrote: > Everyone uses this for any assembly in their code. Should we get rid of this > warning? I find it is useless and would like to see it go. Well, for other languages it might be a helpful