[Lldb-commits] [PATCH] D108888: Improve error messaging on process connect errors

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3472ad5c5f8: Add specific error messages around gdb RSP

[Lldb-commits] [lldb] f3472ad - Add specific error messages around gdb RSP handshake failures

Author: Jason Molenda Date: 2021-09-09T17:02:42-07:00 New Revision: f3472ad5c5f88c3425fc54f40d3d5280258d8be5 URL: https://github.com/llvm/llvm-project/commit/f3472ad5c5f88c3425fc54f40d3d5280258d8be5 DIFF: https://github.com/llvm/llvm-project/commit/f3472ad5c5f88c3425fc54f40d3d5280258d8be5.diff

[Lldb-commits] [lldb] 766afbc - Don't re-define constants that are now in compact_unwind_encoding.h.

Author: Jason Molenda Date: 2021-09-09T17:01:43-07:00 New Revision: 766afbc8042bc45283d52c763d11327a34eb04a6 URL: https://github.com/llvm/llvm-project/commit/766afbc8042bc45283d52c763d11327a34eb04a6 DIFF: https://github.com/llvm/llvm-project/commit/766afbc8042bc45283d52c763d11327a34eb04a6.diff

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

mgorny updated this revision to Diff 371674. mgorny marked an inline comment as done. mgorny added a comment. Use fancy endian-magic types ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107840/new/ https://reviews.llvm.org/D107840 Files:

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young added inline comments. Comment at: lldb/bindings/lua/lua-typemaps.swig:219-221 +%typecheck(SWIG_TYPECHECK_STRING_ARRAY) char ** { + $1 = (lua_istable(L, $input) || lua_isnil(L, $input)); +} tammela wrote: > This is not being generated by SWIG for

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:776 + + std::array data; + DataEncoder encoder{data.data(), data.size(), lldb::eByteOrderBig, labath wrote: > consider: > ``` > struct

[Lldb-commits] [PATCH] D107811: [lldb] [gdb-remote] Add fallbacks for vFile:mode and vFile:exists

mgorny updated this revision to Diff 371653. mgorny added a comment. Undo extra comments. Fix wrong length of test GDB packet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107811/new/ https://reviews.llvm.org/D107811 Files:

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 371644. rdhindsa marked 6 inline comments as done. rdhindsa added a comment. Thanks Pavel for investigating and figuring out that the upstream failing test had libxml support disabled. I was able to reproduce the failure locally by adding

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:242 +""" +pass + Should `eStateStopped` be the default? Comment at:

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

mib added a comment. ping ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108953/new/ https://reviews.llvm.org/D108953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

mib added a comment. Following @JDevlieghere question in https://reviews.llvm.org/D107585#2979988, here are some explanations: In order to read memory from the ScriptedProcess, the process plugin calls the python `read_memory_at_address` method passing the address at which we should start

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

mgorny updated this revision to Diff 371618. mgorny marked 2 inline comments as done. mgorny added a comment. Use LLVM's `ubig*_t` types. Thanks for the suggestion, @labath! Also add the comment that `Stat()` is only a wrapper over open+fstat. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D109508: [lldb] Fix format string in Communication::Write

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f1c90a6d4dd: [lldb] Fix format string in Communication::Write (authored by rmansfield, committed by teemperor). Repository: rG LLVM Github

[Lldb-commits] [lldb] 4f1c90a - [lldb] Fix format string in Communication::Write

Author: Ryan Mansfield Date: 2021-09-09T17:55:38+02:00 New Revision: 4f1c90a6d4dde9e3c6d3c7d76bb187c1c19960d5 URL: https://github.com/llvm/llvm-project/commit/4f1c90a6d4dde9e3c6d3c7d76bb187c1c19960d5 DIFF:

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

craig.topper added a comment. I think I read this patch too closely. I'll leave it up to you how much of this you want to do. Comment at: llvm/include/llvm/IR/Constants.h:206 /// Determine if the value is all ones. bool isMinusOne() const { return Val.isAllOnesValue();

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner marked an inline comment as done. lattner added inline comments. Comment at: llvm/include/llvm/ADT/APInt.h:384 /// value for the APInt's bit width. bool isMaxValue() const { return isAllOnesValue(); } craig.topper wrote: > isAllOnes()? Yep, good

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. This patch has a lot of noise, the important part is APInt.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

craig.topper added inline comments. Comment at: llvm/include/llvm/ADT/APInt.h:384 /// value for the APInt's bit width. bool isMaxValue() const { return isAllOnesValue(); } isAllOnes()? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dblaikie added a comment. In D109345#2990577 , @dexonsmith wrote: > In D109345#2990527 , @dblaikie > wrote: > >> (were there other regressions I mentioned/should think about?) > > I don't have specific

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. In D109345#2990527 , @dblaikie wrote: > (were there other regressions I mentioned/should think about?) I don't have specific concerns; I was just reading between the lines of your description... >> 1. Add `using

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dblaikie added a comment. In D109345#2987565 , @dexonsmith wrote: > This seems like the right direction to me! Especially like the > look-through-the-ErrorInfo change for `FileError` -- I hit this before and > found it annoying. Thanks for taking a

[Lldb-commits] [PATCH] D109185: [gn build] Add build files for LLDB

thakis added a comment. In D109185#2988837 , @teemperor wrote: > Thanks! Out of curiosity, is there a public GN bot that is testing this? The GN bots at http://45.33.8.238/ do the compile step. They don't yet run lldb tests. Maybe I'll add that, but

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `ninja clang` on Windows works. `check-llvm-tools` has a few `REQUIRES: system-windows` tests and I am running them. Test invocation is bit slow. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D109185: [gn build] Add build files for LLDB

teemperor added a comment. Thanks! Out of curiosity, is there a public GN bot that is testing this? > LLDB has many dependency cycles, something GN doesn't allow. For that reason, I've omitted some dependency edges. Hopefully we can clean up the cycles one day. No idea about GN, but I would

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. This seems like the right direction to me! Especially like the look-through-the-ErrorInfo change for `FileError` -- I hit this before and found it annoying. IMO, it'd be valuable to split out the consequential functional changes: - Improvements/changes you made to

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dblaikie added a comment. In D109345#2986297 , @thopre wrote: > Is there no way to split this patch further? It's going to be hard finding > someone who can review something so big. If there's no way to split it in > incremental changes, you could

[Lldb-commits] [PATCH] D109508: [lldb] Fix format string in Communication::Write

rmansfield added a comment. Thanks. Could someone please apply on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109508/new/ https://reviews.llvm.org/D109508 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D109508: [lldb] Fix format string in Communication::Write

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109508/new/ https://reviews.llvm.org/D109508

[Lldb-commits] [PATCH] D109508: [lldb] Fix format string in Communication::Write

rmansfield created this revision. rmansfield added a reviewer: JDevlieghere. rmansfield added a project: LLDB. rmansfield requested review of this revision. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109508 Files:

[Lldb-commits] [PATCH] D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

krytarowski accepted this revision. krytarowski added a comment. Looks still fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96766/new/ https://reviews.llvm.org/D96766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D109495: [lldb] [test] Add synchronization fix Subprocess test flakiness

mgorny added a comment. With this version, I haven't been able to reproduce a test failure in 350 iterations, so I guess it's good now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109495/new/ https://reviews.llvm.org/D109495 ___

[Lldb-commits] [PATCH] D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

mgorny updated this revision to Diff 371579. mgorny marked 3 inline comments as done. mgorny added a comment. Rebased after Linux/MIPS removal. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96766/new/ https://reviews.llvm.org/D96766 Files:

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

labath added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:153 +cursor = info_addr = +ResolveRendezvousAddress(m_process, m_executable_interpreter); else At this point, you can just make

[Lldb-commits] [PATCH] D109495: [lldb] [test] Add synchronization fix Subprocess test flakiness

mgorny updated this revision to Diff 371571. mgorny added a comment. Force sync earlier for `fork()` and `clone()` (since we don't have to wait for exec there). Avoid depending on ordering between child output and LLDB exit. Stress-testing it now. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] cda1450 - [lldb][NFC] Add some tests for function-local classes and document some bugs

Author: Raphael Isemann Date: 2021-09-09T14:12:02+02:00 New Revision: cda1450f1c771712718ef3585315f0ecbb708d8d URL: https://github.com/llvm/llvm-project/commit/cda1450f1c771712718ef3585315f0ecbb708d8d DIFF:

[Lldb-commits] [PATCH] D109495: [lldb] [test] Add synchronization fix Subprocess test flakiness

mgorny updated this revision to Diff 371554. mgorny added a comment. Remove unnecessary `child_done` pipe, as pointed out by @labath. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109495/new/ https://reviews.llvm.org/D109495 Files: lldb/test/Shell/Subprocess/Inputs/fork.cpp

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8901f8beea3a: AArch64 SVE restore SVE registers after expression (authored by omjavaid). Changed prior to commit:

[Lldb-commits] [lldb] 8901f8b - AArch64 SVE restore SVE registers after expression

Author: Muhammad Omair Javaid Date: 2021-09-09T16:06:48+05:00 New Revision: 8901f8beea3a70f92be8c0b80313260502f03727 URL: https://github.com/llvm/llvm-project/commit/8901f8beea3a70f92be8c0b80313260502f03727 DIFF:

[Lldb-commits] [PATCH] D109495: [lldb] [test] Add synchronization fix Subprocess test flakiness

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Add synchronization routines to ensure that Subprocess tests output in a predictable order, and all test strings are output before the tests terminate.

[Lldb-commits] [PATCH] D101157: [lldb] [test] Add tests for coredumps with multiple threads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1280f6967db: [lldb] [test] Add tests for coredumps with multiple threads (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] d1280f6 - [lldb] [test] Add tests for coredumps with multiple threads

Author: Michał Górny Date: 2021-09-09T09:59:52+02:00 New Revision: d1280f6967db1ca8fa4e0c39414003e717b40feb URL: https://github.com/llvm/llvm-project/commit/d1280f6967db1ca8fa4e0c39414003e717b40feb DIFF: https://github.com/llvm/llvm-project/commit/d1280f6967db1ca8fa4e0c39414003e717b40feb.diff

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM with the clang-format warning fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108739/new/ https://reviews.llvm.org/D108739