[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".

2021-10-12 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. I have broken out the target only settings to make this patch smaller into: https://reviews.llvm.org/D111686 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110804/new/ https://reviews.llvm.org/D110804

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

2021-10-12 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: jingham, labath, aprantl, JDevlieghere, aadsm, wallace, jdoerfert. Herald added a subscriber: mgorny. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch is a

[Lldb-commits] [lldb] 1b81581 - [lldb][test] Remove Intel MPX tests

2021-10-12 Thread Fangrui Song via lldb-commits
Author: Fangrui Song Date: 2021-10-12T16:16:58-07:00 New Revision: 1b81581feec8cb6361d898dea17ed2f0ad7e5b13 URL: https://github.com/llvm/llvm-project/commit/1b81581feec8cb6361d898dea17ed2f0ad7e5b13 DIFF: https://github.com/llvm/llvm-project/commit/1b81581feec8cb6361d898dea17ed2f0ad7e5b13.diff

[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

2021-10-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectMultiword.cpp:121-129 + const char *error_str = nullptr; + if (!can_replace) +error_str = "sub-command already exists"; + if (!(*pos).second->IsUserCommand()) +error_str = "can't replace a

[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

2021-10-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham updated this revision to Diff 379145. jingham marked an inline comment as done. jingham added a comment. I changed the command name from "command multiword" to "command container". Greg noted that "multiword" is what we used for these but it's actually not a great description of what

[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".

2021-10-12 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D110804#3037504 , @JDevlieghere wrote: > Thanks Greg! Following Pavel's suggestion in D110893 > , could you split up this patch into > smaller ones? I think that will make it a lot easier

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

2021-10-12 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D110827#3042820 , @kpdev42 wrote: > In D110827#3034767 , @clayborg > wrote: > >> Should we be testing if these directories exist before trying to use them? >> Might be nice to avoid

[Lldb-commits] [PATCH] D111659: [lldb] Skip several lldb tests that are flaky on Windows

2021-10-12 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova created this revision. stella.stamenova added a reviewer: labath. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests fail every 10 or so runs on Windows causing both local failures as well as

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

2021-10-12 Thread Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG67f94e5a9745: [lldb/lua] Supplement Lua bindings for lldb module (authored by Siger Yang sigerye...@gmail.com). Changed

[Lldb-commits] [lldb] 67f94e5 - [lldb/lua] Supplement Lua bindings for lldb module

2021-10-12 Thread Siger Yang via lldb-commits
Author: Siger Yang Date: 2021-10-12T22:10:21+08:00 New Revision: 67f94e5a9745665dd62550c75cb16569fbb0059d URL: https://github.com/llvm/llvm-project/commit/67f94e5a9745665dd62550c75cb16569fbb0059d DIFF: https://github.com/llvm/llvm-project/commit/67f94e5a9745665dd62550c75cb16569fbb0059d.diff

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

2021-10-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6de63b3ba5e2: [lldb/lua] Force Lua version to be 5.3 (authored by Siger Yang sigerye...@gmail.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 6de63b3 - [lldb/lua] Force Lua version to be 5.3

2021-10-12 Thread Siger Yang via lldb-commits
Author: Siger Yang Date: 2021-10-12T21:34:15+08:00 New Revision: 6de63b3ba5e2dbb5994d329623fbf933e319ea7a URL: https://github.com/llvm/llvm-project/commit/6de63b3ba5e2dbb5994d329623fbf933e319ea7a DIFF: https://github.com/llvm/llvm-project/commit/6de63b3ba5e2dbb5994d329623fbf933e319ea7a.diff

[Lldb-commits] [PATCH] D108468: [lldb] [gdb-remote] Fix displaying i387_ext & vec regs with gdbserver

2021-10-12 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbda5fe8f0c04: [lldb] [gdb-remote] Fix displaying i387_ext vec regs with gdbserver (authored by mgorny). Herald added a project: LLDB. Changed

[Lldb-commits] [lldb] bda5fe8 - [lldb] [gdb-remote] Fix displaying i387_ext & vec regs with gdbserver

2021-10-12 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-12T15:16:06+02:00 New Revision: bda5fe8f0c049f8c805572ba9eb92ce6044e7999 URL: https://github.com/llvm/llvm-project/commit/bda5fe8f0c049f8c805572ba9eb92ce6044e7999 DIFF: https://github.com/llvm/llvm-project/commit/bda5fe8f0c049f8c805572ba9eb92ce6044e7999.diff

[Lldb-commits] [PATCH] D111634: [lldb] Print embedded nuls in char arrays (PR44649)

2021-10-12 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: teemperor, jingham. labath requested review of this revision. Herald added a project: LLDB. When we know the bounds of the array, print any embedded nuls instead of treating them as terminators. An exception to this rule is made for the nul

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

2021-10-12 Thread Siger Young via Phabricator via lldb-commits
siger-young updated this revision to Diff 378971. siger-young added a comment. Pull and merge conflicts, will soon be merged into main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108090/new/ https://reviews.llvm.org/D108090 Files: