[Lldb-commits] [PATCH] D116982: Fix clang-tidy bugprone-argument-comment that was mixed up

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Good catch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116982/new/ https://reviews.llvm.org/D116982 ___ lldb-commits

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

JDevlieghere updated this revision to Diff 398837. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116972/new/ https://reviews.llvm.org/D116972 Files: zorg/buildbot/builders/LLDBBuilder.py Index: zorg/buildbot/builders/LLDBBuilder.py

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

ljmf00 added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:50 install_cmd = ['ninja','install'] -test_cmd = ['ninja','check-lldb'] +test_cmd = ['ninja','check-lldb', '-v'] ljmf00 wrote: > I don't know if ninja verbosity

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

ljmf00 added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:50 install_cmd = ['ninja','install'] -test_cmd = ['ninja','check-lldb'] +test_cmd = ['ninja','check-lldb', '-v'] I don't know if ninja verbosity propagates to

Re: [Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

I agree that if we are going to start putting in errors for not finding listed arguments to “frame var” we should do it consistently, and Greg’s list seems good - along with the error “No debug info” when “frame var” is run in a frame w/o debug info or recognizers. The one thing that bothers

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione added a comment. > Let me know your thoughts as mine are just my initial thoughts after thinking > about things a bit more. For most of what you said, I was thinking the same. The only place where I wasn't as sure about (regex), I was on the fence. Your cases and arguments all

[Lldb-commits] [PATCH] D116982: Fix clang-tidy bugprone-argument-comment that was mixed up

shafik created this revision. shafik added reviewers: wallace, JDevlieghere. shafik requested review of this revision. Several of the comments were annotating the wrong argument. I caught this while reviewing this clean-up:

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

clayborg added a comment. In D116788#3232105 , @kastiglione wrote: > In D116788#3231612 , @clayborg > wrote: > >> I would vote that if any argument or option is specified, and results in >> something not being

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

zequanwu added a comment. > The one part that bothers me is the "two-phased" setting of line tables. > IIUC, the problem is that the inline line info is in the block descriptor, so > you need to parse block info in order to create a line table, but in order to > actually create an

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

zequanwu updated this revision to Diff 398772. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Store "temporary" line table in `CompileUnitIndex`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116845/new/

[Lldb-commits] [lldb] 1267506 - [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

Author: Lirong Yuan Date: 2022-01-10T14:33:09-08:00 New Revision: 1267506ea54a62e0c728215c033b256ce856db30 URL: https://github.com/llvm/llvm-project/commit/1267506ea54a62e0c728215c033b256ce856db30 DIFF: https://github.com/llvm/llvm-project/commit/1267506ea54a62e0c728215c033b256ce856db30.diff

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1267506ea54a: [lldb] fix memory leak in GetGDBServerRegisterInfoXMLAndProcess (authored by yuanzi, committed by

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116972/new/ https://reviews.llvm.org/D116972 ___ lldb-commits

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

JDevlieghere created this revision. JDevlieghere added reviewers: labath, stella.stamenova, omjavaid. JDevlieghere requested review of this revision. Run `check-lldb` in verbose mode so that the bot shows which tests are unsupported. https://llvm.discourse.group/t/lldb-buildbots-verbosity/5253

[Lldb-commits] [lldb] da4b743 - [lldb] Remove LLDB_RECORD_DUMMY_* macros

Author: Jonas Devlieghere Date: 2022-01-10T12:05:54-08:00 New Revision: da4b7437f932570227b9debecc031a40875445fa URL: https://github.com/llvm/llvm-project/commit/da4b7437f932570227b9debecc031a40875445fa DIFF:

[Lldb-commits] [lldb] 69c55d6 - [lldb] Remove LLDB_RECORD_CHAR_PTR_* macros

Author: Jonas Devlieghere Date: 2022-01-10T11:57:20-08:00 New Revision: 69c55d63620066dfd6714b0b666f7cac5a3407eb URL: https://github.com/llvm/llvm-project/commit/69c55d63620066dfd6714b0b666f7cac5a3407eb DIFF:

[Lldb-commits] [lldb] 4609e30 - [lldb] Remove lldb-instr

Author: Jonas Devlieghere Date: 2022-01-10T11:48:16-08:00 New Revision: 4609e30f5001cfcba59d1f2f90ce72ebfda6e61f URL: https://github.com/llvm/llvm-project/commit/4609e30f5001cfcba59d1f2f90ce72ebfda6e61f DIFF:

[Lldb-commits] [PATCH] D116896: [lldb] [gdb-remote] Support client fallback for servers without reg defs

mgorny updated this revision to Diff 398701. mgorny retitled this revision from "[lldb] [gdb-remote] Support client fallback for servers without reg defs (WIP)" to "[lldb] [gdb-remote] Support client fallback for servers without reg defs". mgorny edited the summary of this revision. mgorny added

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

yuanzi added a comment. Thanks for the reviews! Yeah I do not have commit access. It would be great if someone could help with the commit! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116707/new/ https://reviews.llvm.org/D116707

[Lldb-commits] [lldb] 9b5cf72 - [lldb] Disable several lldb tests that are flaky on Windows

Author: Stella Stamenova Date: 2022-01-10T10:21:12-08:00 New Revision: 9b5cf7267beb1e9c6f16402795890f0d02eb5145 URL: https://github.com/llvm/llvm-project/commit/9b5cf7267beb1e9c6f16402795890f0d02eb5145 DIFF:

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione added a comment. In D116788#3231612 , @clayborg wrote: > I would vote that if any argument or option is specified, and results in > something not being found, that an error be returned. Is this in response to my question about regexes? It

[Lldb-commits] [PATCH] D116419: [lldb] Display MachO seg, sec of memory region

kastiglione added inline comments. Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:76 + +self.runCmd("run", RUN_SUCCEEDED) + aprantl wrote: > Doesn't `lldbutil.run_break_set_by_symbol()` do the "file" and "run" already > and

[Lldb-commits] [PATCH] D116419: [lldb] Display MachO seg, sec of memory region

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1695 + section_sp = section_sp->GetParent(); +section_name = section_sp->GetName(); + } aprantl wrote: > Why did

[Lldb-commits] [PATCH] D116896: [lldb] [gdb-remote] Support client fallback for servers without reg defs (WIP)

mgorny updated this revision to Diff 398654. mgorny added a comment. Add aarch64. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116896/new/ https://reviews.llvm.org/D116896 Files: lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 398366. Ericson2314 added a comment. Make sure possibly exposed modules have their own `include(GNUInstallDirs)`s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 398318. Ericson2314 added a comment. Rebase on top of fixed polly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

This revision was automatically updated to reflect the committed changes. Closed by commit rGfeeff8a37c35: [llvm] Use `GNUInstallDirs` to support custom installation dirs (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 added inline comments. Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:1 include(GNUInstallDirs) N.B. this already had it from an earlier revision of mine, so didn't need to add it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 added a comment. OK, at long last, I this is the attempt that's gonna make it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 ___ lldb-commits

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 398219. Ericson2314 marked 4 inline comments as done. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files:

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

rupprecht updated this revision to Diff 398652. rupprecht added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114722/new/ https://reviews.llvm.org/D114722 Files:

[Lldb-commits] [PATCH] D116896: [lldb] [gdb-remote] Support client fallback for servers without reg defs (WIP)

mgorny updated this revision to Diff 398644. mgorny added a comment. Split the new code into a separate file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116896/new/ https://reviews.llvm.org/D116896 Files: lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

clayborg added a comment. I would vote that if any argument or option is specified, and results in something not being found, that an error be returned. The error state doesn't do anything for the user on the command line, but it is nice to know that something failed to produce a result due to

[Lldb-commits] [PATCH] D116539: [lldb/platform-gdb] Clear cached protocol state upon disconnection

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ccfcab34ffb: [lldb/platform-gdb] Clear cached protocol state upon disconnection (authored by labath). Changed prior to commit: https://reviews.llvm.org/D116539?vs=397067=398636#toc Repository: rG

[Lldb-commits] [lldb] 8ccfcab - [lldb/platform-gdb] Clear cached protocol state upon disconnection

Author: Pavel Labath Date: 2022-01-10T16:27:30+01:00 New Revision: 8ccfcab34ffb068f127e88be9fb1f42bb46f3af4 URL: https://github.com/llvm/llvm-project/commit/8ccfcab34ffb068f127e88be9fb1f42bb46f3af4 DIFF: https://github.com/llvm/llvm-project/commit/8ccfcab34ffb068f127e88be9fb1f42bb46f3af4.diff

[Lldb-commits] [PATCH] D116539: [lldb/platform-gdb] Clear cached protocol state upon disconnection

labath added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:84 bool PlatformAndroidRemoteGDBServer::LaunchGDBServer(lldb::pid_t , std::string _url) { uint16_t

[Lldb-commits] [PATCH] D116896: [lldb] [gdb-remote] Support client fallback for servers without reg defs (WIP)

mgorny updated this revision to Diff 398595. mgorny added a comment. Inline FileCheck input in the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116896/new/ https://reviews.llvm.org/D116896 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

[Lldb-commits] [PATCH] D116896: [lldb] [gdb-remote] Support client fallback for servers without reg defs (WIP)

mgorny added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/amd64-fallback-regs.FileCheck:1 +CHECK-DAG: rax = 0x0807060504030201 +CHECK-DAG: rbx = 0x1817161514131211 labath wrote: > I actually think it would be better if this was

[Lldb-commits] [PATCH] D116853: [CMake][LLDB] Resolve install conflict when `LLDB_BUILD_FRAMEWORK=ON`

paperchalice updated this revision to Diff 398569. paperchalice edited the summary of this revision. paperchalice added a comment. Install python scripts into canonical resource path. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116853/new/ https://reviews.llvm.org/D116853 Files:

[Lldb-commits] [PATCH] D116896: [lldb] [gdb-remote] Support client fallback for servers without reg defs (WIP)

labath added a reviewer: jasonmolenda. labath added a comment. This looks pretty okay I'd say. I might consider putting the actual definitions into a separate cpp file, simply because it's easy, and ProcessGDBRemote.cpp is already too big. Comment at:

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

labath added a comment. I don't know much about PDBs, but the code seems ok. I particularly like the test case. The one part that bothers me is the "two-phased" setting of line tables. IIUC, the problem is that the inline line info is in the block descriptor, so you need to parse block info

[Lldb-commits] [PATCH] D116896: [lldb] [gdb-remote] Support client fallback for servers without reg defs (WIP)

mgorny updated this revision to Diff 398542. mgorny edited the summary of this revision. mgorny added a comment. Herald added a subscriber: thopre. Simplify the macros. Add a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116896/new/ https://reviews.llvm.org/D116896 Files:

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

labath accepted this revision. labath added a comment. Cool, thanks. Do you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116707/new/ https://reviews.llvm.org/D116707