[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

ilya-nozhkin updated this revision to Diff 411015. ilya-nozhkin edited the summary of this revision. ilya-nozhkin added a comment. Added a test based on core files debugging. `RegisterContextCorePOSIX_x86_64` indeed forbids writing registers. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

stephanemoore added a comment. In D113616#3341803 , @JDevlieghere wrote: > This seems trivial enough, but adding Greg as he wrote most of lldb-vscode. Thanks!  I tried looking through the commit history but wasn't sure who would be a good candidate

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e3e79a9e4c3: [lldb/test] Fix TestProgressReporting.py race issue with the event listener (authored by mib). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 3e3e79a - [lldb/test] Fix TestProgressReporting.py race issue with the event listener

Author: Med Ismail Bennani Date: 2022-02-23T16:45:28-08:00 New Revision: 3e3e79a9e4c378b59f5f393f556e6a84edcd8898 URL: https://github.com/llvm/llvm-project/commit/3e3e79a9e4c378b59f5f393f556e6a84edcd8898 DIFF:

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

mib updated this revision to Diff 410973. mib edited the summary of this revision. mib added a comment. Make the interface binding arguments `OUTPUT` only. Re-enable test on all platforms. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120284/new/ https://reviews.llvm.org/D120284

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

JDevlieghere added a comment. This seems trivial enough, but adding Greg as he wrote most of lldb-vscode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113616/new/ https://reviews.llvm.org/D113616 ___

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

mwyman accepted this revision. mwyman added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113616/new/ https://reviews.llvm.org/D113616

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

stephanemoore created this revision. stephanemoore updated this revision to Diff 410926. stephanemoore added a comment. stephanemoore added reviewers: mwyman, jingham. stephanemoore published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Updated.

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

clayborg added a comment. Code looks good. Lets see if we can test it with a core file. I am guessing we can't from my previous comment, but it would be worth checking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120319/new/

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

clayborg added a comment. In D120319#3340298 , @labath wrote: > Core files have read-only registers. Would that help? (you could just throw > in a SetValueFromCString call into one of the existing core file tests) Actually I believe we allow writing

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 410920. d-millar added a comment. Rebased on v14 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111409/new/ https://reviews.llvm.org/D111409 Files: lldb/CMakeLists.txt lldb/bindings/CMakeLists.txt

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a6dbedf5a92: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 2a6dbed - [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

Author: Jonas Devlieghere Date: 2022-02-23T12:34:14-08:00 New Revision: 2a6dbedf5a923512ba8b5c2d192b5fc8bb1210fd URL: https://github.com/llvm/llvm-project/commit/2a6dbedf5a923512ba8b5c2d192b5fc8bb1210fd DIFF:

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

JDevlieghere added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); I see an opportunity for a little RAII helper.

[Lldb-commits] [PATCH] D120425: [lldb/host] Remove monitor_signals argument from process monitoring functions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120425/new/ https://reviews.llvm.org/D120425

[Lldb-commits] [PATCH] D120425: [lldb/host] Remove monitor_signals argument from process monitoring functions

labath created this revision. labath added a reviewer: JDevlieghere. Herald added a subscriber: krytarowski. labath requested review of this revision. Herald added a project: LLDB. All current callers set the argument to false. monitor_signals=true used to be used in the Process plugins (which

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_loc.s:28-29 # CHECK: Variable{{.*}}, name = "x0", {{.*}}, scope = parameter, location = # CHECK-NEXT: [0x, 0x0001): DW_OP_reg5 RDI # CHECK-NEXT:

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 410882. zequanwu marked 3 inline comments as done. zequanwu added a comment. - Remove short option. `-show-variable-ranges` prints all ranges. If not given, only print single range. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

MaskRay added a comment. In D120195#3334697 , @serge-sans-paille wrote: > In D120195#943 , @MaskRay wrote: > >> It'd be good to test `-DLLVM_ENABLE_MODULES=on` build. > > Sure, I'll add that to my local test

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120101/new/ https://reviews.llvm.org/D120101 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

DavidSpickett added a comment. Got it, thanks for the explanation. > What's important is that the second signal gets delivered (not "handled", > because at that point we have removed the handler) to the same thread, as > that's the only one we're sure that will have it unblocked (although, in

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

labath marked 4 inline comments as done. labath added a comment. The behavior of the stop signals (SIGTTIN, SIGTTOU, SIGTSTP) is this: - if the process has a signal handler, then the kernel picks an arbitrary thread (which does not have the signal blocked) to handle it. As far as the kernel is

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

DavidSpickett added a comment. I think I mostly get it and the code looks fine, but my signal foo is weak so @mgorny should give a second look. > we use raise to send the signal, which makes sure it gets delivered to the > thread which is running the handler

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

labath added a comment. Core files have read-only registers. Would that help? (you could just throw in a SetValueFromCString call into one of the existing core file tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120319/new/

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

labath marked 4 inline comments as done. labath added inline comments. Comment at: lldb/test/API/driver/job_control/TestJobControl.py:9 +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test.lldbpexpect import PExpectTest

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

labath updated this revision to Diff 410800. labath added a comment. Add comments, delete unused code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120320/new/ https://reviews.llvm.org/D120320 Files:

[Lldb-commits] [PATCH] D120321: [lldb] Modernize ThreadLauncher

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120321/new/ https://reviews.llvm.org/D120321 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 82951cf - Fix HostProcessWindows for D120321

Author: Pavel Labath Date: 2022-02-23T14:52:34+01:00 New Revision: 82951cfb8a413aab9c4b8aeecbd7475dda8f1fb1 URL: https://github.com/llvm/llvm-project/commit/82951cfb8a413aab9c4b8aeecbd7475dda8f1fb1 DIFF: https://github.com/llvm/llvm-project/commit/82951cfb8a413aab9c4b8aeecbd7475dda8f1fb1.diff

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille added a comment. @thakis should be fixed by 57c6012213b50804ed78530b89bae30c0ee4fe82 , the new failure (seems) unrelated to this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120321: [lldb] Modernize ThreadLauncher

thakis added a comment. Looks like this breaks building on Windows: http://45.33.8.238/win/53761/step_4.txt Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120321/new/ https://reviews.llvm.org/D120321

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

DavidSpickett added inline comments. Comment at: lldb/test/API/driver/job_control/TestJobControl.py:9 +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test.lldbpexpect import PExpectTest Unused import?

[Lldb-commits] [PATCH] D120322: [lldb] Simplify HostThreadMacOSX

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf4568e12219f: [lldb] Simplify HostThreadMacOSX (authored by labath). Changed prior to commit:

[Lldb-commits] [PATCH] D120321: [lldb] Modernize ThreadLauncher

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0810779b1f3: [lldb] Modernize ThreadLauncher (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120321/new/

[Lldb-commits] [lldb] f4568e1 - [lldb] Simplify HostThreadMacOSX

Author: Pavel Labath Date: 2022-02-23T14:25:59+01:00 New Revision: f4568e12219f3a6ada20035ea40223680e274203 URL: https://github.com/llvm/llvm-project/commit/f4568e12219f3a6ada20035ea40223680e274203 DIFF: https://github.com/llvm/llvm-project/commit/f4568e12219f3a6ada20035ea40223680e274203.diff

[Lldb-commits] [lldb] d081077 - [lldb] Modernize ThreadLauncher

Author: Pavel Labath Date: 2022-02-23T14:25:59+01:00 New Revision: d0810779b1f310d99176467d5d5b5aa4e26d7eb5 URL: https://github.com/llvm/llvm-project/commit/d0810779b1f310d99176467d5d5b5aa4e26d7eb5 DIFF: https://github.com/llvm/llvm-project/commit/d0810779b1f310d99176467d5d5b5aa4e26d7eb5.diff

[Lldb-commits] [PATCH] D120321: [lldb] Modernize ThreadLauncher

labath added inline comments. Comment at: lldb/source/Host/common/HostNativeThreadBase.cpp:55-56 HostNativeThreadBase::ThreadCreateTrampoline(lldb::thread_arg_t arg) { - ThreadLauncher::HostThreadCreateInfo *info = - (ThreadLauncher::HostThreadCreateInfo *)arg; -

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

labath added a comment. I'm not sure about `ModuleLookupShowRange::Single` option. It feels like it just complicates things. Did anyone request that? FWIW, I don't think that dumping a /single/ range is particularly verbose, so I could imagine even doing that by default. I think it should be

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

thakis added a comment. Breaks building on win: http://45.33.8.238/win/53749/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120195/new/ https://reviews.llvm.org/D120195

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb4c8608115c: Cleanup llvm/DebugInfo/PDB headers (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION