[Lldb-commits] [PATCH] D122193: Reland "[lldb/test] Add events listener helper class to lldbtest"

mib updated this revision to Diff 417136. mib added a comment. Reflow docstring CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122193/new/ https://reviews.llvm.org/D122193 Files: lldb/packages/Python/lldbsuite/test/eventlistener.py

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

mib marked an inline comment as done. mib added a comment. Came up with a new approach in D122193 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121977/new/ https://reviews.llvm.org/D121977

[Lldb-commits] [PATCH] D122193: Reland "[lldb/test] Add events listener helper class to lldbtest"

mib created this revision. mib added reviewers: labath, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This reverts commit 8bf893466632cc2597188b431160effcd8cedeef

[Lldb-commits] [PATCH] D122176: [trace] clear any existing tracing sessions before relaunching the binary

This revision was automatically updated to reflect the committed changes. Closed by commit rGa80c6c7d36d2: [trace] clear any existing tracing sessions before relaunching the binary (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D122192: [trace] Use vector instead of ArrayRef when reading data

This revision was automatically updated to reflect the committed changes. Closed by commit rG31e44c01e3b5: [trace] Use vector instead of ArrayRef when reading data (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 31e44c0 - [trace] Use vector instead of ArrayRef when reading data

Author: Walter Erquinigo Date: 2022-03-21T16:03:37-07:00 New Revision: 31e44c01e3b5cc2cc7a9f1dc49806b3f050efb82 URL: https://github.com/llvm/llvm-project/commit/31e44c01e3b5cc2cc7a9f1dc49806b3f050efb82 DIFF:

[Lldb-commits] [lldb] a80c6c7 - [trace] clear any existing tracing sessions before relaunching the binary

Author: Walter Erquinigo Date: 2022-03-21T16:03:37-07:00 New Revision: a80c6c7d36d25999a28cfad32e1f461db95ba4dc URL: https://github.com/llvm/llvm-project/commit/a80c6c7d36d25999a28cfad32e1f461db95ba4dc DIFF:

[Lldb-commits] [PATCH] D122176: [trace] clear any existing tracing sessions before relaunching the binary

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. nice catch, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122176/new/ https://reviews.llvm.org/D122176

[Lldb-commits] [lldb] 15c2d9c - [simple] fix formatting in the intel-pt doc

Author: Walter Erquinigo Date: 2022-03-21T15:56:55-07:00 New Revision: 15c2d9cd790cac143fdd2a206304d245d65fb4e1 URL: https://github.com/llvm/llvm-project/commit/15c2d9cd790cac143fdd2a206304d245d65fb4e1 DIFF:

[Lldb-commits] [PATCH] D122025: [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput

jingham added a comment. I think it makes sense to require that the CommandResultObject's command output is UTF-8 string with no embedded '\0'-s. We wouldn't do smart things with rendering command output with nulls in it, and I don't see any reason to support such a thing. OTOH, this seems

[Lldb-commits] [PATCH] D122192: [trace] Use vector instead of ArrayRef when reading data

wallace created this revision. wallace added reviewers: jj10306, zrthxn. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I incorrectly returned an ArrayRef when the underlying object didn't own the

[Lldb-commits] [PATCH] D122177: [lldb] Fix log & progress report for in-memory binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG3323321f4ef0: [lldb] Fix log progress report for in-memory binaries (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 3323321 - [lldb] Fix log & progress report for in-memory binaries

Author: Jonas Devlieghere Date: 2022-03-21T15:35:21-07:00 New Revision: 3323321f4ef04308c50a3dc4ad17dfa1e13d8477 URL: https://github.com/llvm/llvm-project/commit/3323321f4ef04308c50a3dc4ad17dfa1e13d8477 DIFF:

[Lldb-commits] [lldb] 45d9aab - Fix e6c84f82b87576a57d1fa1c7e8c289d3d4fa7ab1

Author: Jakob Johnson Date: 2022-03-21T15:02:02-07:00 New Revision: 45d9aab7a5a76b7317ec5571bc557158045a34df URL: https://github.com/llvm/llvm-project/commit/45d9aab7a5a76b7317ec5571bc557158045a34df DIFF: https://github.com/llvm/llvm-project/commit/45d9aab7a5a76b7317ec5571bc557158045a34df.diff

[Lldb-commits] [lldb] d137528 - Fix e6c84f82b87576a57d1fa1c7e8c289d3d4fa7ab1

Author: Jakob Johnson Date: 2022-03-21T14:35:14-07:00 New Revision: d13752851a4e134708f365a5b238e8ff375accaa URL: https://github.com/llvm/llvm-project/commit/d13752851a4e134708f365a5b238e8ff375accaa DIFF: https://github.com/llvm/llvm-project/commit/d13752851a4e134708f365a5b238e8ff375accaa.diff

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/eventlistener.py:38-41 +# Broadcast a eBroadcastBitStopListenerThread` event so the background +# thread stops listening to events, then join the

[Lldb-commits] [lldb] e412529 - Fix e6c84f82b87576a57d1fa1c7e8c289d3d4fa7ab1

Author: Jakob Johnson Date: 2022-03-21T14:00:39-07:00 New Revision: e412529c93ae86d580b8212e07a0a2a0a8ab5cda URL: https://github.com/llvm/llvm-project/commit/e412529c93ae86d580b8212e07a0a2a0a8ab5cda DIFF: https://github.com/llvm/llvm-project/commit/e412529c93ae86d580b8212e07a0a2a0a8ab5cda.diff

[Lldb-commits] [lldb] e6c84f8 - Add thin wrapper for perf_event_open API

Author: Jakob Johnson Date: 2022-03-21T13:38:52-07:00 New Revision: e6c84f82b87576a57d1fa1c7e8c289d3d4fa7ab1 URL: https://github.com/llvm/llvm-project/commit/e6c84f82b87576a57d1fa1c7e8c289d3d4fa7ab1 DIFF: https://github.com/llvm/llvm-project/commit/e6c84f82b87576a57d1fa1c7e8c289d3d4fa7ab1.diff

[Lldb-commits] [PATCH] D121734: [trace][intelpt] Add thin wrapper for perf_event_open API

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6c84f82b875: Add thin wrapper for perf_event_open API (authored by jj10306). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D122176: [trace] clear any existing tracing sessions before relaunching the binary

wallace updated this revision to Diff 417082. wallace added a comment. improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122176/new/ https://reviews.llvm.org/D122176 Files: lldb/source/Target/Target.cpp

[Lldb-commits] [PATCH] D122177: [lldb] Fix log & progress report for in-memory binaries

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122177/new/ https://reviews.llvm.org/D122177 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D122177: [lldb] Fix log & progress report for in-memory binaries

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Fix the log and progress report message for in-memory binaries. If there's no object file, use the name from the Module. With

[Lldb-commits] [PATCH] D122176: [trace] clear any existing tracing sessions before relaunching the binary

wallace created this revision. wallace added reviewers: jj10306, zrthxn. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There's a bug caused when a process is relaunched: the target, which doesn't

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

shafik added a comment. Do we have any tests for these? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122041/new/ https://reviews.llvm.org/D122041 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 417049. yinghuitan added a comment. Remove last ondemand test flavor testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files:

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 417048. yinghuitan added a comment. Remove ondemand test category/flavor Add new testcases: - source text regex breakpoint - regex breakpoint filter by language - global variable symbol table match hydration Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG826bdf51ff31: [lldb] Fix llvm::Optional summary provider (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D122114: [tests][intelpt] Fix outdated trace load test

This revision was automatically updated to reflect the committed changes. Closed by commit rGca47011e73e6: [tests][intelpt] Fix outdated trace load test (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122114/new/

[Lldb-commits] [lldb] ca47011 - [tests][intelpt] Fix outdated trace load test

Author: Alisamar Husain Date: 2022-03-21T13:21:45+05:30 New Revision: ca47011e73e6ff0451b6a9c8de3d3f3044acec72 URL: https://github.com/llvm/llvm-project/commit/ca47011e73e6ff0451b6a9c8de3d3f3044acec72 DIFF:

[Lldb-commits] [PATCH] D122114: [tests][intelpt] Fix outdated trace load test

zrthxn created this revision. zrthxn added reviewers: wallace, jj10306. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122114 Files:

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

labath added a comment. I've reverted this patch because it introduces races in the event processing. See inline comment for details. Comment at: lldb/packages/Python/lldbsuite/test/eventlistener.py:38-41 +# Broadcast a eBroadcastBitStopListenerThread` event so the

[Lldb-commits] [lldb] 8bf8934 - Revert "[lldb/test] Add events listener helper class to lldbtest"

Author: Pavel Labath Date: 2022-03-21T08:32:16+01:00 New Revision: 8bf893466632cc2597188b431160effcd8cedeef URL: https://github.com/llvm/llvm-project/commit/8bf893466632cc2597188b431160effcd8cedeef DIFF: https://github.com/llvm/llvm-project/commit/8bf893466632cc2597188b431160effcd8cedeef.diff

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

This revision was automatically updated to reflect the committed changes. Closed by commit rG37a466dd72b0: [trace][intelpt] Added total memory usage by decoded trace (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/

[Lldb-commits] [lldb] 37a466d - [trace][intelpt] Added total memory usage by decoded trace

Author: Alisamar Husain Date: 2022-03-21T12:36:08+05:30 New Revision: 37a466dd72b0c46090198c9f1779c384809c0662 URL: https://github.com/llvm/llvm-project/commit/37a466dd72b0c46090198c9f1779c384809c0662 DIFF:

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416826. zrthxn added a comment. Ingore errored instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files:

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:123-130 + size_t non_err_instruction_count = 0; + for (const IntelPTInstruction :

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416825. zrthxn marked an inline comment as done. zrthxn added a comment. Cosmetic and minor changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files:

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn marked 4 inline comments as done. zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:119 + s.Printf(" Total approximate memory usage: %0.2lf KiB\n", + (float)mem_used / 1024); return; wallace