[Lldb-commits] [lldb] 0cf21a7 - [lldb/source/Utility/DataExtractor.cpp] Update for `llvm::MD5::MD5Result` API change

2022-04-05 Thread Argyrios Kyrtzidis via lldb-commits
Author: Argyrios Kyrtzidis Date: 2022-04-05T21:47:45-07:00 New Revision: 0cf21a7e0c820dc68628c39b2dc8115d3c2b86b2 URL: https://github.com/llvm/llvm-project/commit/0cf21a7e0c820dc68628c39b2dc8115d3c2b86b2 DIFF:

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

2022-04-05 Thread Zequan Wu via Phabricator via lldb-commits
zequanwu planned changes to this revision. zequanwu added a comment. Plan to apply similar change in D123151 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123092/new/ https://reviews.llvm.org/D123092

[Lldb-commits] [lldb] 70984dd - [lldb] Update ReadAllRegisterValues in RegisterContextWindows

2022-04-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-05T15:15:48-07:00 New Revision: 70984dd40a425927876518ff4e0bd9b6b790bec2 URL: https://github.com/llvm/llvm-project/commit/70984dd40a425927876518ff4e0bd9b6b790bec2 DIFF:

[Lldb-commits] [PATCH] D120948: Disable LLDB index cache for .o files with no UUID.

2022-04-05 Thread Greg Clayton via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb6087ba769c6: Disable LLDB index cache for .o files with no UUID. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120948/new/

[Lldb-commits] [lldb] b6087ba - Disable LLDB index cache for .o files with no UUID.

2022-04-05 Thread Greg Clayton via lldb-commits
Author: Greg Clayton Date: 2022-04-05T15:14:36-07:00 New Revision: b6087ba769c612c031b84e6673c438fe44a46c6a URL: https://github.com/llvm/llvm-project/commit/b6087ba769c612c031b84e6673c438fe44a46c6a DIFF: https://github.com/llvm/llvm-project/commit/b6087ba769c612c031b84e6673c438fe44a46c6a.diff

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

2022-04-05 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. So we added documentation on this feature explaining who will want to enable this feature and also describe exactly when and how debug info will get enabled. Does anyone else have objections or comments to make? If we need to setup a meeting to discuss, please chime

[Lldb-commits] [lldb] 470eb5c - [lldb] Add more missing consts in NativeRegisterContexts

2022-04-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-05T14:43:39-07:00 New Revision: 470eb5c29bb12c7af723301c0ea4b8969eab34ae URL: https://github.com/llvm/llvm-project/commit/470eb5c29bb12c7af723301c0ea4b8969eab34ae DIFF:

[Lldb-commits] [lldb] b7bf5a7 - [lldb] Add missing const to NativeRegisterContextLinux_arm

2022-04-05 Thread Benjamin Kramer via lldb-commits
Author: Benjamin Kramer Date: 2022-04-05T23:39:08+02:00 New Revision: b7bf5a7a7ef4181813ea682a8f9dac56f25c3141 URL: https://github.com/llvm/llvm-project/commit/b7bf5a7a7ef4181813ea682a8f9dac56f25c3141 DIFF:

[Lldb-commits] [lldb] ed9a14f - [lldb] Add missing const to NativeRegisterContextLinux_x86_64

2022-04-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-05T14:26:50-07:00 New Revision: ed9a14f912c034c6a7177d4bc8a2d41a22b3e129 URL: https://github.com/llvm/llvm-project/commit/ed9a14f912c034c6a7177d4bc8a2d41a22b3e129 DIFF:

[Lldb-commits] [lldb] c2f6460 - [lldb] Update the NativeRegisterContext to take a WritableMemoryBuffer

2022-04-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-05T14:19:01-07:00 New Revision: c2f6460145175d265cd1a7ad7906b778bb11fa3d URL: https://github.com/llvm/llvm-project/commit/c2f6460145175d265cd1a7ad7906b778bb11fa3d DIFF:

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

2022-04-05 Thread Luboš Luňák via Phabricator via lldb-commits
llunak added a comment. In D122975#3430613 , @JDevlieghere wrote: > After applying this patch I started seeing data races reported by TSan when > running the shell tests (`check-lldb-shell`). It seems to happen to different > tests on different runs

[Lldb-commits] [lldb] a722dea - [lldb] Update reinterpret_cast in linux/Host.cpp

2022-04-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-05T13:52:07-07:00 New Revision: a722dea4af7743a76701bb582ded88fe0e188c14 URL: https://github.com/llvm/llvm-project/commit/a722dea4af7743a76701bb582ded88fe0e188c14 DIFF:

[Lldb-commits] [PATCH] D123073: [lldb] Change CreateMemoryInstance to take a WritableDataBuffer

2022-04-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2ea125ea09d: [lldb] Change CreateMemoryInstance to take a WritableDataBuffer (authored by JDevlieghere). Herald added a project: LLDB. Changed

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

2022-04-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc54427e76c8: [lldb] Refactor DataBuffer so we can map files as read-only (authored by JDevlieghere). Herald added a project: LLDB. Changed prior

[Lldb-commits] [lldb] f2ea125 - [lldb] Change CreateMemoryInstance to take a WritableDataBuffer

2022-04-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-05T13:46:41-07:00 New Revision: f2ea125ea09d9e4512fa08a89eac5e0069d83738 URL: https://github.com/llvm/llvm-project/commit/f2ea125ea09d9e4512fa08a89eac5e0069d83738 DIFF:

[Lldb-commits] [lldb] fc54427 - [lldb] Refactor DataBuffer so we can map files as read-only

2022-04-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-05T13:46:37-07:00 New Revision: fc54427e76c89e567390dd4a1d64a65568f4ec26 URL: https://github.com/llvm/llvm-project/commit/fc54427e76c89e567390dd4a1d64a65568f4ec26 DIFF:

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

2022-04-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. After applying this patch I started seeing data races reported by TSan when running the shell tests (`check-lldb-shell`). It seems to happen to different tests on different runs but the backtraces are the same. WARNING: ThreadSanitizer: data race (pid=40880)

[Lldb-commits] [lldb] ee39417 - Refine memory buffer for importing shared cache objc class list

2022-04-05 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2022-04-05T12:49:40-07:00 New Revision: ee394177e6b797917e4d8e0d786d84046599d2c5 URL: https://github.com/llvm/llvm-project/commit/ee394177e6b797917e4d8e0d786d84046599d2c5 DIFF: https://github.com/llvm/llvm-project/commit/ee394177e6b797917e4d8e0d786d84046599d2c5.diff

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

2022-04-05 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thanks for your patience. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2636-2638 + assert(llvm::isa(data_buffer_sp.get())); +

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

2022-04-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Still LGTM. Apologies for the new rebase conflict introduced by e90d8f024b2b . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120810/new/

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

2022-04-05 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9bcaf6ddfe34: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 9bcaf6d - [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

2022-04-05 Thread Walter Erquinigo via lldb-commits
Author: Walter Erquinigo Date: 2022-04-05T11:54:03-07:00 New Revision: 9bcaf6ddfe34943e6ae6a319097524c117908913 URL: https://github.com/llvm/llvm-project/commit/9bcaf6ddfe34943e6ae6a319097524c117908913 DIFF:

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

2022-04-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 420589. JDevlieghere added a comment. Herald added a subscriber: mgorny. - Copy the buffer if ObjectFileELF didn't map it - Use LLVM style RTTI CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122856/new/ https://reviews.llvm.org/D122856 Files:

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

2022-04-05 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. ok! I'll commit it for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123025/new/ https://reviews.llvm.org/D123025 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

2022-04-05 Thread Michael Hept via Phabricator via lldb-commits
nidefawl added a comment. In D123025#3429896 , @wallace wrote: > Let me know if you need help upstreaming this patch. Yes I needs some help. This is my first contribution. I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D122767: [lldb] Improve documentation for some of the platform functions

2022-04-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe90d8f024b2b: [lldb] Improve documentation for some of the platform functions (authored by JDevlieghere). Herald added a

[Lldb-commits] [lldb] e90d8f0 - [lldb] Improve documentation for some of the platform functions

2022-04-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-05T09:47:32-07:00 New Revision: e90d8f024b2b6789c1a9fed3b854c45a2db36adc URL: https://github.com/llvm/llvm-project/commit/e90d8f024b2b6789c1a9fed3b854c45a2db36adc DIFF:

[Lldb-commits] [lldb] 8c3a6fe - Fix a mistyping introduced with the new container command.

2022-04-05 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2022-04-05T09:42:05-07:00 New Revision: 8c3a6fe37fc36537b939ea75a59fb2d5963246fb URL: https://github.com/llvm/llvm-project/commit/8c3a6fe37fc36537b939ea75a59fb2d5963246fb DIFF: https://github.com/llvm/llvm-project/commit/8c3a6fe37fc36537b939ea75a59fb2d5963246fb.diff

[Lldb-commits] [PATCH] D123098: [lldb] Fix undefined behavior: left shift of negative value

2022-04-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG73714a3c603c: [lldb] Fix undefined behavior: left shift of negative value (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 73714a3 - [lldb] Fix undefined behavior: left shift of negative value

2022-04-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-05T09:37:31-07:00 New Revision: 73714a3c603c1e0656f138ad8b6ef2c4740c95f3 URL: https://github.com/llvm/llvm-project/commit/73714a3c603c1e0656f138ad8b6ef2c4740c95f3 DIFF:

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

2022-04-05 Thread Alisamar Husain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd849959071c8: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread` (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d849959 - [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

2022-04-05 Thread Alisamar Husain via lldb-commits
Author: Alisamar Husain Date: 2022-04-05T22:01:36+05:30 New Revision: d849959071c8478841a9e7b1bb625e00b848f1c7 URL: https://github.com/llvm/llvm-project/commit/d849959071c8478841a9e7b1bb625e00b848f1c7 DIFF:

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

2022-04-05 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. Let me know if you need help upstreaming this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123025/new/ https://reviews.llvm.org/D123025 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

2022-04-05 Thread walter erquinigo via Phabricator via lldb-commits
wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123025/new/ https://reviews.llvm.org/D123025

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

2022-04-05 Thread walter erquinigo via Phabricator via lldb-commits
wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great job! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122991/new/ https://reviews.llvm.org/D122991

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

2022-04-05 Thread Alisamar Husain via Phabricator via lldb-commits
zrthxn updated this revision to Diff 420543. zrthxn marked an inline comment as done. zrthxn added a comment. Removed unnecessary comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122991/new/ https://reviews.llvm.org/D122991 Files:

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

2022-04-05 Thread walter erquinigo via Phabricator via lldb-commits
wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. just remove a small comment and good to go! Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:143-146 + /// \param[in] next_load_address + ///

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

2022-04-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 420540. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. I don't really like the idea of making the argument to createInstance writable. That seems like an implementation detail. Instead I added a virtual method IsWritable()

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

2022-04-05 Thread Michael Hept via Phabricator via lldb-commits
nidefawl marked 2 inline comments as done. nidefawl added inline comments. Comment at: lldb/tools/lldb-vscode/OutputRedirector.cpp:55 } - callback(StringRef(buffer, bytes_count).str()); + callback(StringRef(buffer, bytes_count)); } mstorsjo

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

2022-04-05 Thread Michael Hept via Phabricator via lldb-commits
nidefawl updated this revision to Diff 420531. nidefawl added a comment. Reorder OS check to remove negation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123025/new/ https://reviews.llvm.org/D123025 Files:

[Lldb-commits] [PATCH] D123128: don't extra notify ModulesDidLoad() from LoadModuleAtAddress()

2022-04-05 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. > Note that this patch could have been shorter if I simply changed > LoadModuleAtAddress() to always pass false for notify (all callers currently > call ModulesDidLoad() afterwards) and added a note to LoadModuleAtAddress() > docs about it, but I don't know if that's a

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

2022-04-05 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 420507. labath added a comment. Reopening, since the last attempt was quite some time ago, and the rebase was non-trivial. Functionally, there are no real changes. The one-liner in dotest.py is somewhat interesting, as it was necessary for (emu|simu)lator

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

2022-04-05 Thread Luboš Luňák via Phabricator via lldb-commits
llunak updated this revision to Diff 420492. llunak retitled this revision from "parallelize module loading in DynamicLoaderPOSIXDYLD()" to "parallelize calling of Module::PreloadSymbols()". llunak edited the summary of this revision. llunak added a reviewer: jingham. llunak added a comment.

[Lldb-commits] [PATCH] D123128: don't extra notify ModulesDidLoad() from LoadModuleAtAddress()

2022-04-05 Thread Luboš Luňák via Phabricator via lldb-commits
llunak created this revision. llunak added a reviewer: jasonmolenda. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. Places calling LoadModuleAddress() already

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

2022-04-05 Thread Luboš Luňák via Phabricator via lldb-commits
llunak added a comment. In D122975#3428876 , @labath wrote: > OK, got it. So, for this case, I think the best approach would be to extract > and paralelize the `PreloadSymbols` calls. They are not deep (=> relatively > easy to extract), optional (they

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

2022-04-05 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D122975#3426731 , @llunak wrote: > In D122975#3426575 , @labath wrote: > >> I'd like to understand what is the precise thing that you're trying to >> optimise. If there is like a

[Lldb-commits] [PATCH] D122660: [lldb] Avoid duplicate vdso modules when opening core files

2022-04-05 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe67cee09499c: [lldb] Avoid duplicate vdso modules when opening core files (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122660/new/

[Lldb-commits] [PATCH] D122716: [lldb/linux] Handle main thread exits

2022-04-05 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4384c96fe7eb: [lldb/linux] Handle main thread exits (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122716/new/

[Lldb-commits] [PATCH] D122898: [lldb] Move host platform implementations into the base class

2022-04-05 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG331150a47dd5: [lldb] Move host platform implementations into the base class (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122898/new/

[Lldb-commits] [lldb] e67cee0 - [lldb] Avoid duplicate vdso modules when opening core files

2022-04-05 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-04-05T11:22:37+02:00 New Revision: e67cee09499cbf386334115a627cd4fbe19cb01c URL: https://github.com/llvm/llvm-project/commit/e67cee09499cbf386334115a627cd4fbe19cb01c DIFF: https://github.com/llvm/llvm-project/commit/e67cee09499cbf386334115a627cd4fbe19cb01c.diff

[Lldb-commits] [lldb] 331150a - [lldb] Move host platform implementations into the base class

2022-04-05 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-04-05T11:22:37+02:00 New Revision: 331150a47dd5b26758293d73c5df3aa1b61ecad9 URL: https://github.com/llvm/llvm-project/commit/331150a47dd5b26758293d73c5df3aa1b61ecad9 DIFF: https://github.com/llvm/llvm-project/commit/331150a47dd5b26758293d73c5df3aa1b61ecad9.diff

[Lldb-commits] [lldb] 4384c96 - [lldb/linux] Handle main thread exits

2022-04-05 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-04-05T11:22:37+02:00 New Revision: 4384c96fe7eb5ceb5f2c1ece4a73c22a18bac19f URL: https://github.com/llvm/llvm-project/commit/4384c96fe7eb5ceb5f2c1ece4a73c22a18bac19f DIFF: https://github.com/llvm/llvm-project/commit/4384c96fe7eb5ceb5f2c1ece4a73c22a18bac19f.diff

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

2022-04-05 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:361 // Update the data to contain the entire file if it doesn't already if (data_sp->GetByteSize() < length) { +data_sp = MapFileDataWritable(*file, length, file_offset);

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

2022-04-05 Thread Alisamar Husain via Phabricator via lldb-commits
zrthxn updated this revision to Diff 420401. zrthxn marked 12 inline comments as done. zrthxn added a comment. Address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122991/new/ https://reviews.llvm.org/D122991 Files:

[Lldb-commits] [PATCH] D123073: [lldb] Change CreateMemoryInstance to take a WritableDataBuffer

2022-04-05 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool. thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123073/new/ https://reviews.llvm.org/D123073 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

2022-04-05 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. As unusual, I don't understand pdbs, but the resulting line table seems reasonable. I don't think we can assert this level of detail in a compilation-based test though. Could you put these checks into the non-"live" version of the test? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D123106: [trace][intel pt] Create a class for the libipt decoder wrapper

2022-04-05 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 420395. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123106/new/ https://reviews.llvm.org/D123106 Files: lldb/source/Plugins/Trace/intel-pt/CMakeLists.txt

[Lldb-commits] [PATCH] D123001: make 'step out' step out of the selected frame

2022-04-05 Thread Luboš Luňák via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG76bc77292089: [lldb][gui] make step out step out of the selected frame (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123001/new/

[Lldb-commits] [PATCH] D122998: use just '#' instead of 'frame #2' in the threads/frame view

2022-04-05 Thread Luboš Luňák via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf90fa55569fc: [lldb][gui] use just #2 instead of frame #2 in the threads/frame view (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 76bc772 - [lldb][gui] make 'step out' step out of the selected frame

2022-04-05 Thread Luboš Luňák via lldb-commits
Author: Luboš Luňák Date: 2022-04-05T08:29:13+02:00 New Revision: 76bc7729208976e6ff6bc28b08e460d97cab5bb3 URL: https://github.com/llvm/llvm-project/commit/76bc7729208976e6ff6bc28b08e460d97cab5bb3 DIFF: https://github.com/llvm/llvm-project/commit/76bc7729208976e6ff6bc28b08e460d97cab5bb3.diff

[Lldb-commits] [PATCH] D122997: do not show the help window on first gui startup

2022-04-05 Thread Luboš Luňák via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaaca2acd5f34: [lldb][gui] do not show the help window on first gui startup (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122997/new/

[Lldb-commits] [lldb] f90fa55 - [lldb][gui] use just '#2' instead of 'frame #2' in the threads/frame view

2022-04-05 Thread Luboš Luňák via lldb-commits
Author: Luboš Luňák Date: 2022-04-05T08:29:13+02:00 New Revision: f90fa55569fc8fc3b44512823ed9e2a0d1243826 URL: https://github.com/llvm/llvm-project/commit/f90fa55569fc8fc3b44512823ed9e2a0d1243826 DIFF: https://github.com/llvm/llvm-project/commit/f90fa55569fc8fc3b44512823ed9e2a0d1243826.diff

[Lldb-commits] [lldb] aaca2ac - [lldb][gui] do not show the help window on first gui startup

2022-04-05 Thread Luboš Luňák via lldb-commits
Author: Luboš Luňák Date: 2022-04-05T08:29:13+02:00 New Revision: aaca2acd5f3434ccd1d568596161628ce53d9066 URL: https://github.com/llvm/llvm-project/commit/aaca2acd5f3434ccd1d568596161628ce53d9066 DIFF: https://github.com/llvm/llvm-project/commit/aaca2acd5f3434ccd1d568596161628ce53d9066.diff

[Lldb-commits] [PATCH] D123106: [trace][intel pt] Create a class for the libipt decoder wrapper

2022-04-05 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: jj10306, zrthxn. Herald added a subscriber: mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As we soon will need to decode multiple raw